[jira] [Commented] (MASSEMBLY-907) Dependencies are not included when run with mvn install
[
https://issues.apache.org/jira/browse/MASSEMBLY-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17562298#comment-17562298
]
Daniel Fernández commented on MASSEMBLY-907:
I can confirm as of version 3.4.0 of the plugin this not only happens when
doing "{{mvn install}}" but also with "{{mvn deploy}}", which heavily affects
my build process. I don't have the involved _failing_ modules included as
dependencies in the {{pom.xml}} of the assembly module.
I would disagree that having to add all involved first level modules to the
{{pom.xml}} of the assembly project as explained in the first comment in this
ticket makes sense, for four reasons IMHO:
*First*, because in my case I'm using a {{}} with
{{true}}, so I should expect all
reactor modules to be processed with their dependencies without needing to add
all my large number of reactor modules one by one to the {{pom.xml}}. That
would turn assembly maintenance really complex (we are talking dozens of
modules at several levels).
*Second*, because all the modules are actually being processed, *but not their
dependencies*, which is IMHO unexpected anywhere in Maven unless specifically
configured to do otherwise. If the issue was with dependencies not being added
to the {{pom.xml}}, it would be more coherent not process these dependencies
(reactor modules) at all, instead of processing them, but not their
dependencies.
*Third*, because the fact that this works as expected (by me) when doing "{{mvn
package}}" but not "{{mvn deploy}}" is not a coherent behaviour.
*Fourth*, because processing of modules in the reactor *and* their transitive
dependencies worked as expected (by me) until 3.1.1, when behaviour changed. So
this broke many builds.
This is what my {{}} looks like:
{code:xml}
true
org.thymeleaf:*
/dist
false
/lib
runtime
org.thymeleaf:*
...
{code}
> Dependencies are not included when run with mvn install
> ---
>
> Key: MASSEMBLY-907
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-907
> Project: Maven Assembly Plugin
> Issue Type: Bug
>Affects Versions: 3.1.1
>Reporter: Lau Bakman
>Priority: Major
> Attachments: 310_install.log, 310_install_verbose.log,
> 311_install.log, 311_install_verbose.log, 311_package_verbose.log,
> assembly_deps.zip
>
>
> We have just updated to version 3.1.1 due to MASSEMBLY-873 and have stumbled
> upon a problem.
> Our project is structured similar to the attached project. When we build our
> project using "mvn clean package" the project is assembled correctly
> including dependencies. If we on the other hand build our project using "mvn
> clean install", only the top level jar files are assembled and all
> dependencies are missing.
> This worked in version 3.1.0.
> Is this by design? And if it is, is there a way to revert to the old behavior?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-907) Dependencies are not included when run with mvn install
[ https://issues.apache.org/jira/browse/MASSEMBLY-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911189#comment-16911189 ] Mark Symons commented on MASSEMBLY-907: --- Is there any progress on this? Our teams ran into exactly the same problem after upgrading from 3.1.0 to 3.1.1. Like [~lbakman], we also have bouncy castle dependencies that necesitate usage of 3.1.1 due to MASSEMBLY-873. > Dependencies are not included when run with mvn install > --- > > Key: MASSEMBLY-907 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-907 > Project: Maven Assembly Plugin > Issue Type: Bug >Affects Versions: 3.1.1 >Reporter: Lau Bakman >Assignee: Karl Heinz Marbaise >Priority: Major > Attachments: 310_install.log, 310_install_verbose.log, > 311_install.log, 311_install_verbose.log, 311_package_verbose.log, > assembly_deps.zip > > > We have just updated to version 3.1.1 due to MASSEMBLY-873 and have stumbled > upon a problem. > Our project is structured similar to the attached project. When we build our > project using "mvn clean package" the project is assembled correctly > including dependencies. If we on the other hand build our project using "mvn > clean install", only the top level jar files are assembled and all > dependencies are missing. > This worked in version 3.1.0. > Is this by design? And if it is, is there a way to revert to the old behavior? -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (MASSEMBLY-907) Dependencies are not included when run with mvn install
[ https://issues.apache.org/jira/browse/MASSEMBLY-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802667#comment-16802667 ] Lau Bakman commented on MASSEMBLY-907: -- Added the log for "mvn package" with version 3.1.1. > Dependencies are not included when run with mvn install > --- > > Key: MASSEMBLY-907 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-907 > Project: Maven Assembly Plugin > Issue Type: Bug >Affects Versions: 3.1.1 >Reporter: Lau Bakman >Assignee: Karl Heinz Marbaise >Priority: Major > Attachments: 310_install.log, 310_install_verbose.log, > 311_install.log, 311_install_verbose.log, 311_package_verbose.log, > assembly_deps.zip > > > We have just updated to version 3.1.1 due to MASSEMBLY-873 and have stumbled > upon a problem. > Our project is structured similar to the attached project. When we build our > project using "mvn clean package" the project is assembled correctly > including dependencies. If we on the other hand build our project using "mvn > clean install", only the top level jar files are assembled and all > dependencies are missing. > This worked in version 3.1.0. > Is this by design? And if it is, is there a way to revert to the old behavior? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-907) Dependencies are not included when run with mvn install
[ https://issues.apache.org/jira/browse/MASSEMBLY-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802646#comment-16802646 ] Lau Bakman commented on MASSEMBLY-907: -- I have added the logging output for both executions. To my untrained eyes there seem to be a difference in line 1572: * 3.1.0: Dependencies (resolve): [compile] * 3.1.1: Dependencies (resolve): [test] > Dependencies are not included when run with mvn install > --- > > Key: MASSEMBLY-907 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-907 > Project: Maven Assembly Plugin > Issue Type: Bug >Affects Versions: 3.1.1 >Reporter: Lau Bakman >Assignee: Karl Heinz Marbaise >Priority: Major > Attachments: 310_install.log, 310_install_verbose.log, > 311_install.log, 311_install_verbose.log, assembly_deps.zip > > > We have just updated to version 3.1.1 due to MASSEMBLY-873 and have stumbled > upon a problem. > Our project is structured similar to the attached project. When we build our > project using "mvn clean package" the project is assembled correctly > including dependencies. If we on the other hand build our project using "mvn > clean install", only the top level jar files are assembled and all > dependencies are missing. > This worked in version 3.1.0. > Is this by design? And if it is, is there a way to revert to the old behavior? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-907) Dependencies are not included when run with mvn install
[ https://issues.apache.org/jira/browse/MASSEMBLY-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802591#comment-16802591 ] Karl Heinz Marbaise commented on MASSEMBLY-907: --- Can you please add the logging output of the two executions you have mentioned... > Dependencies are not included when run with mvn install > --- > > Key: MASSEMBLY-907 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-907 > Project: Maven Assembly Plugin > Issue Type: Bug >Affects Versions: 3.1.1 >Reporter: Lau Bakman >Assignee: Karl Heinz Marbaise >Priority: Major > Attachments: assembly_deps.zip > > > We have just updated to version 3.1.1 due to MASSEMBLY-873 and have stumbled > upon a problem. > Our project is structured similar to the attached project. When we build our > project using "mvn clean package" the project is assembled correctly > including dependencies. If we on the other hand build our project using "mvn > clean install", only the top level jar files are assembled and all > dependencies are missing. > This worked in version 3.1.0. > Is this by design? And if it is, is there a way to revert to the old behavior? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-907) Dependencies are not included when run with mvn install
[ https://issues.apache.org/jira/browse/MASSEMBLY-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802508#comment-16802508 ] Lau Bakman commented on MASSEMBLY-907: -- I have tried with every version of maven-assembly-plugin from version 2.3. Only 3.1.1 fails to assemble the attached project correctly. > Dependencies are not included when run with mvn install > --- > > Key: MASSEMBLY-907 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-907 > Project: Maven Assembly Plugin > Issue Type: Bug >Affects Versions: 3.1.1 >Reporter: Lau Bakman >Assignee: Karl Heinz Marbaise >Priority: Major > Attachments: assembly_deps.zip > > > We have just updated to version 3.1.1 due to MASSEMBLY-873 and have stumbled > upon a problem. > Our project is structured similar to the attached project. When we build our > project using "mvn clean package" the project is assembled correctly > including dependencies. If we on the other hand build our project using "mvn > clean install", only the top level jar files are assembled and all > dependencies are missing. > This worked in version 3.1.0. > Is this by design? And if it is, is there a way to revert to the old behavior? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-907) Dependencies are not included when run with mvn install
[ https://issues.apache.org/jira/browse/MASSEMBLY-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802505#comment-16802505 ] Lau Bakman commented on MASSEMBLY-907: -- In the attached project: Change maven.assembly.plugin.version to 3.1.0 and execute "mvn install": spike.services.hello is assembled including dependencies in the lib folder. Change maven.assembly.plugin.version to 3.1.1 and execute "mvn install": spike.services.hello is assembled but without dependencies. > Dependencies are not included when run with mvn install > --- > > Key: MASSEMBLY-907 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-907 > Project: Maven Assembly Plugin > Issue Type: Bug >Affects Versions: 3.1.1 >Reporter: Lau Bakman >Assignee: Karl Heinz Marbaise >Priority: Major > Attachments: assembly_deps.zip > > > We have just updated to version 3.1.1 due to MASSEMBLY-873 and have stumbled > upon a problem. > Our project is structured similar to the attached project. When we build our > project using "mvn clean package" the project is assembled correctly > including dependencies. If we on the other hand build our project using "mvn > clean install", only the top level jar files are assembled and all > dependencies are missing. > This worked in version 3.1.0. > Is this by design? And if it is, is there a way to revert to the old behavior? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-907) Dependencies are not included when run with mvn install
[ https://issues.apache.org/jira/browse/MASSEMBLY-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802504#comment-16802504 ] Lau Bakman commented on MASSEMBLY-907: -- I still believe it is a bug and it is very much a problem for us. We cannot use 3.1.0 anymore due to MASSEMBLY-873 and we cannot upgrade to 3.1.1 because of a change in behavior. Prior to 3.1.1 our project setup which is demonstrated in the attached assembly_deps worked flawlessly, assembling all jars and their dependencies. With 3.1.1 this is no longer the case. Something has broken (for us) when the plugin is executed as part of "mvn install" My last comment yesterday concerned your question of why we use the "dir" format. We use the "dir" format to create a directory structure for building our installers. We cannot build the structure if the dependencies are not copied to the assembly output directory. The maven-resource-plugin is not relevant for this problem - it was part of my explanation for the "dir" format. > Dependencies are not included when run with mvn install > --- > > Key: MASSEMBLY-907 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-907 > Project: Maven Assembly Plugin > Issue Type: Bug >Affects Versions: 3.1.1 >Reporter: Lau Bakman >Assignee: Karl Heinz Marbaise >Priority: Major > Attachments: assembly_deps.zip > > > We have just updated to version 3.1.1 due to MASSEMBLY-873 and have stumbled > upon a problem. > Our project is structured similar to the attached project. When we build our > project using "mvn clean package" the project is assembled correctly > including dependencies. If we on the other hand build our project using "mvn > clean install", only the top level jar files are assembled and all > dependencies are missing. > This worked in version 3.1.0. > Is this by design? And if it is, is there a way to revert to the old behavior? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-907) Dependencies are not included when run with mvn install
[ https://issues.apache.org/jira/browse/MASSEMBLY-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801896#comment-16801896 ] Lau Bakman commented on MASSEMBLY-907: -- Thank you for your time on this issue. Just trying to understand what is happening. I am using a dir format because I am assembling an application that includes native libraries as well. I use the assembly plugin (and later maven-resources-plugin) to build a directory structure that I can take and use directly for my installers. For example: module-services: Root folder for my services. |- libs: Directory containing jar dependencies used by my services |- win32: Directory containing Windows 32-bit native libraries |- win64: Directory containing Windows 64-bit native libraries |- linux32: Directory containing Linux 32-bit native libraries |- linux64: Directory containing Linux 64-bit native libraries | launcher.jar: Service launcher | *-service.jar: A number of services loaded by the service launcher - these may vary on the build and these are the ones I would like to avoid specifying dependencies for. My installer step will then grab the service files, libs directory and the appropriate native directory from the module-services folder and create an installer for the appropriate architecture. I do not know if it is the right tool for the job, but maven-assembly-plugin have been doing great until now. If you have any suggestions on how to do this differently, I am open to new ideas. As for the different combinations, the only thing I changed in my project when discovering this problem was the version of maven-assembly-plugin. > Dependencies are not included when run with mvn install > --- > > Key: MASSEMBLY-907 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-907 > Project: Maven Assembly Plugin > Issue Type: Bug >Affects Versions: 3.1.1 >Reporter: Lau Bakman >Priority: Major > Attachments: assembly_deps.zip > > > We have just updated to version 3.1.1 due to MASSEMBLY-873 and have stumbled > upon a problem. > Our project is structured similar to the attached project. When we build our > project using "mvn clean package" the project is assembled correctly > including dependencies. If we on the other hand build our project using "mvn > clean install", only the top level jar files are assembled and all > dependencies are missing. > This worked in version 3.1.0. > Is this by design? And if it is, is there a way to revert to the old behavior? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-907) Dependencies are not included when run with mvn install
[ https://issues.apache.org/jira/browse/MASSEMBLY-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801872#comment-16801872 ] Karl Heinz Marbaise commented on MASSEMBLY-907: --- This can be a coincidence based on using a different version of JDK a different version of Maven or different version of the assembly-plugin etc. or simply changed the order of modules in your pom file etc. which changed the order of the reactor. Furthermore I don't know why you are using the format: dir ...in your descriptor. And yes you have to do the dependencies to be sure the reactor is in the expected order... > Dependencies are not included when run with mvn install > --- > > Key: MASSEMBLY-907 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-907 > Project: Maven Assembly Plugin > Issue Type: Bug >Affects Versions: 3.1.1 >Reporter: Lau Bakman >Priority: Major > Attachments: assembly_deps.zip > > > We have just updated to version 3.1.1 due to MASSEMBLY-873 and have stumbled > upon a problem. > Our project is structured similar to the attached project. When we build our > project using "mvn clean package" the project is assembled correctly > including dependencies. If we on the other hand build our project using "mvn > clean install", only the top level jar files are assembled and all > dependencies are missing. > This worked in version 3.1.0. > Is this by design? And if it is, is there a way to revert to the old behavior? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-907) Dependencies are not included when run with mvn install
[ https://issues.apache.org/jira/browse/MASSEMBLY-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801867#comment-16801867 ] Lau Bakman commented on MASSEMBLY-907: -- Interesting. I have tried to add the dependency to the assembly pom and that does indeed include the dependencies in the output, although the output is no longer structured as I expect it to be. But that is a different matter for me to figure out. Just a few things: * Reading the FAQ ([http://maven.apache.org/components/plugins/maven-assembly-plugin/faq.html#module-binaries]). I do not get an error when building my original project. Everything seems to work - except that the dependencies are missing from my output. * I am curious as to why this has worked for us since we started using maven-assembly-plugin in 2014 and only just stopped working with version 3.1.1 and also why only when executed using "mvn install" and not "mvn package". We have a configuration where we want to package all jar files with similar artifact id's, like the "spike.services.*" example. Having to maintain an additional dependency list is something that we would like to avoid if possible. > Dependencies are not included when run with mvn install > --- > > Key: MASSEMBLY-907 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-907 > Project: Maven Assembly Plugin > Issue Type: Bug >Affects Versions: 3.1.1 >Reporter: Lau Bakman >Priority: Major > Attachments: assembly_deps.zip > > > We have just updated to version 3.1.1 due to MASSEMBLY-873 and have stumbled > upon a problem. > Our project is structured similar to the attached project. When we build our > project using "mvn clean package" the project is assembled correctly > including dependencies. If we on the other hand build our project using "mvn > clean install", only the top level jar files are assembled and all > dependencies are missing. > This worked in version 3.1.0. > Is this by design? And if it is, is there a way to revert to the old behavior? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-907) Dependencies are not included when run with mvn install
[
https://issues.apache.org/jira/browse/MASSEMBLY-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801826#comment-16801826
]
Karl Heinz Marbaise commented on MASSEMBLY-907:
---
The simple issue is that you a relying on the defined order of modules in your
parent {{pom.xml}} which is defined as:
{code:xml}
common
services
assembly
{code}
But this is not reliable.
In your {{assembly}} you have to define dependencies to the modules you would
like have been packaged in your assembly. and that would make sure the order of
building is the one you expect..In consequence you have to add dependencies in
the {{pom.xml}} of the {{assembly}} module. The definition of the module set in
the assembly descriptor will not influence the build order of the reactor.
> Dependencies are not included when run with mvn install
> ---
>
> Key: MASSEMBLY-907
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-907
> Project: Maven Assembly Plugin
> Issue Type: Bug
>Affects Versions: 3.1.1
>Reporter: Lau Bakman
>Priority: Major
> Attachments: assembly_deps.zip
>
>
> We have just updated to version 3.1.1 due to MASSEMBLY-873 and have stumbled
> upon a problem.
> Our project is structured similar to the attached project. When we build our
> project using "mvn clean package" the project is assembled correctly
> including dependencies. If we on the other hand build our project using "mvn
> clean install", only the top level jar files are assembled and all
> dependencies are missing.
> This worked in version 3.1.0.
> Is this by design? And if it is, is there a way to revert to the old behavior?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
