[jira] [Commented] (MENFORCER-301) banDuplicatePomDependencyVersions does not check managementDependencies
[
https://issues.apache.org/jira/browse/MENFORCER-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165774#comment-17165774
]
Hudson commented on MENFORCER-301:
--
Build succeeded in Jenkins: Maven TLP » maven-enforcer » master #151
See https://builds.apache.org/job/maven-box/job/maven-enforcer/job/master/151/
> banDuplicatePomDependencyVersions does not check managementDependencies
> ---
>
> Key: MENFORCER-301
> URL: https://issues.apache.org/jira/browse/MENFORCER-301
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 3.0.0-M1
>Reporter: Alexander Kudrevatykh
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.0.0
>
>
> MENFORCER-152 added rule for ban duplicate depndencies, but
> dependencyManagement section does not checked correctly
> code {code:java} if ( model.getDependencyManagement() != null )
> {
> List managementDependencies = model.getDependencies();
> Map duplicateManagementDependencies =
> validateDependencies( managementDependencies );{code} should be written as
> {code}
> if ( model.getDependencyManagement() != null )
> {
> List managementDependencies =
> model.getDependencyManagement().getDependencies();
> Map duplicateManagementDependencies =
> validateDependencies( managementDependencies );{code}
> and same fix should be applied to {noformat}profiles{noformat} checking code
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MENFORCER-301) banDuplicatePomDependencyVersions does not check managementDependencies
[
https://issues.apache.org/jira/browse/MENFORCER-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165762#comment-17165762
]
Hudson commented on MENFORCER-301:
--
Build failed in Jenkins: Maven » Maven TLP » maven-enforcer » master #6
See
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-enforcer/job/master/6/
> banDuplicatePomDependencyVersions does not check managementDependencies
> ---
>
> Key: MENFORCER-301
> URL: https://issues.apache.org/jira/browse/MENFORCER-301
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 3.0.0-M1
>Reporter: Alexander Kudrevatykh
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.0.0
>
>
> MENFORCER-152 added rule for ban duplicate depndencies, but
> dependencyManagement section does not checked correctly
> code {code:java} if ( model.getDependencyManagement() != null )
> {
> List managementDependencies = model.getDependencies();
> Map duplicateManagementDependencies =
> validateDependencies( managementDependencies );{code} should be written as
> {code}
> if ( model.getDependencyManagement() != null )
> {
> List managementDependencies =
> model.getDependencyManagement().getDependencies();
> Map duplicateManagementDependencies =
> validateDependencies( managementDependencies );{code}
> and same fix should be applied to {noformat}profiles{noformat} checking code
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MENFORCER-301) banDuplicatePomDependencyVersions does not check managementDependencies
[
https://issues.apache.org/jira/browse/MENFORCER-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439161#comment-16439161
]
ASF GitHub Bot commented on MENFORCER-301:
--
kudrevatykh opened a new pull request #33: MENFORCER-301 check
dependencyManagement
URL: https://github.com/apache/maven-enforcer/pull/33
really check dependencyManagement section
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> banDuplicatePomDependencyVersions does not check managementDependencies
> ---
>
> Key: MENFORCER-301
> URL: https://issues.apache.org/jira/browse/MENFORCER-301
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: Standard Rules
>Affects Versions: 3.0.0-M1
>Reporter: Alexander Kudrevatykh
>Priority: Major
>
> MENFORCER-152 added rule for ban duplicate depndencies, but
> dependencyManagement section does not checked correctly
> code {code:java} if ( model.getDependencyManagement() != null )
> {
> List managementDependencies = model.getDependencies();
> Map duplicateManagementDependencies =
> validateDependencies( managementDependencies );{code} should be written as
> {code}
> if ( model.getDependencyManagement() != null )
> {
> List managementDependencies =
> model.getDependencyManagement().getDependencies();
> Map duplicateManagementDependencies =
> validateDependencies( managementDependencies );{code}
> and same fix should be applied to {noformat}profiles{noformat} checking code
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
