[jira] [Commented] (MNG-6106) Remove maven.home setter from m2.conf
[
https://issues.apache.org/jira/browse/MNG-6106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15793557#comment-15793557
]
Hervé Boutemy commented on MNG-6106:
I understand these last explanations: the default value cannot be used when
Maven is launched with mvn script, and would only be used in an unexpected
embedded situation with external launcher
but there is no real bug as stated in initial explanation, that I was not
understanding
I'm ok to integrate this cleanup
> Remove maven.home setter from m2.conf
> -
>
> Key: MNG-6106
> URL: https://issues.apache.org/jira/browse/MNG-6106
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap & Build, core
>Affects Versions: 3.3.9
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: 3.4.0
>
>
> The {{set maven.core default...}} seems to be a relic from ancient times.
> Even if it would be used, it wouldn't work because {{user.home}} never
> contains Maven's installation files.
> This line can safely be removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MNG-6106) Remove maven.home setter from m2.conf
[
https://issues.apache.org/jira/browse/MNG-6106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15793507#comment-15793507
]
Michael Osipov commented on MNG-6106:
-
We never had this in use, never promoted. Additionally, people might confuse it
with {{${user.home\}/.m2}} and it does not work because it is always set in
wrapper script, Plexus conf sets in case of absence. You cannot use it anyway.
> Remove maven.home setter from m2.conf
> -
>
> Key: MNG-6106
> URL: https://issues.apache.org/jira/browse/MNG-6106
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap & Build, core
>Affects Versions: 3.3.9
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: 3.4.0
>
>
> The {{set maven.core default...}} seems to be a relic from ancient times.
> Even if it would be used, it wouldn't work because {{user.home}} never
> contains Maven's installation files.
> This line can safely be removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MNG-6106) Remove maven.home setter from m2.conf
[
https://issues.apache.org/jira/browse/MNG-6106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15793425#comment-15793425
]
Hervé Boutemy commented on MNG-6106:
why can't {{user.home/m2}} be a valid Maven home? I don't get the reasoning
> Remove maven.home setter from m2.conf
> -
>
> Key: MNG-6106
> URL: https://issues.apache.org/jira/browse/MNG-6106
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap & Build, core
>Affects Versions: 3.3.9
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: 3.4.0
>
>
> The {{set maven.core default...}} seems to be a relic from ancient times.
> Even if it would be used, it wouldn't work because {{user.home}} never
> contains Maven's installation files.
> This line can safely be removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MNG-6106) Remove maven.home setter from m2.conf
[
https://issues.apache.org/jira/browse/MNG-6106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15793388#comment-15793388
]
Michael Osipov commented on MNG-6106:
-
You are right, the dot ({{.}}) slipped through my eyes. Still, none of them can
be a valid Maven home. Thanks for raising.
> Remove maven.home setter from m2.conf
> -
>
> Key: MNG-6106
> URL: https://issues.apache.org/jira/browse/MNG-6106
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap & Build, core
>Affects Versions: 3.3.9
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: 3.4.0
>
>
> The {{set maven.core default...}} seems to be a relic from ancient times.
> Even if it would be used, it wouldn't work because {{user.home}} never
> contains Maven's installation files.
> This line can safely be removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MNG-6106) Remove maven.home setter from m2.conf
[
https://issues.apache.org/jira/browse/MNG-6106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15793354#comment-15793354
]
Hervé Boutemy commented on MNG-6106:
IIRC your comment on dev list: "This is actually a bug because maven.home can
never be user.home/.m2"
default value is not {{user.home/.m2}} but {{user.home/m2}}: typo on dev list,
or overlooked {{.m2}} vs {{m2}} during hard review?
> Remove maven.home setter from m2.conf
> -
>
> Key: MNG-6106
> URL: https://issues.apache.org/jira/browse/MNG-6106
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap & Build, core
>Affects Versions: 3.3.9
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: 3.4.0
>
>
> The {{set maven.core default...}} seems to be a relic from ancient times.
> Even if it would be used, it wouldn't work because {{user.home}} never
> contains Maven's installation files.
> This line can safely be removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MNG-6106) Remove maven.home setter from m2.conf
[
https://issues.apache.org/jira/browse/MNG-6106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15578936#comment-15578936
]
Hudson commented on MNG-6106:
-
SUCCESS: Integrated in Jenkins build maven-3.x #1397 (See
[https://builds.apache.org/job/maven-3.x/1397/])
[MNG-6106] Remove maven.home setter from m2.conf (michaelo: rev
f7c1359cf4e3ed82b91b78688076ff684a4eb9a8)
* (edit) apache-maven/src/bin/m2.conf
> Remove maven.home setter from m2.conf
> -
>
> Key: MNG-6106
> URL: https://issues.apache.org/jira/browse/MNG-6106
> Project: Maven
> Issue Type: Task
> Components: Bootstrap & Build, core
>Affects Versions: 3.3.9
>Reporter: Michael Osipov
>Assignee: Michael Osipov
> Fix For: 3.4.0
>
>
> The {{set maven.core default...}} seems to be a relic from ancient times.
> Even if it would be used, it wouldn't work because {{user.home}} never
> contains Maven's installation files.
> This line can safely be removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
