[jira] [Commented] (MPDF-66) custom properties are not filtered in .apt.vm

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPDF-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15580613#comment-15580613
 ] 

ASF GitHub Bot commented on MPDF-66:


Github user gmcdonald closed the pull request at:

https://github.com/apache/maven-plugins/pull/29


> custom properties are not filtered in .apt.vm
> -
>
> Key: MPDF-66
> URL: https://issues.apache.org/jira/browse/MPDF-66
> Project: Maven PDF Plugin
>  Issue Type: Bug
>Affects Versions: 1.2
>Reporter: Leo Breuss
>Assignee: Karl Heinz Marbaise
> Fix For: 1.3
>
>
> The pdf-plugin does not properly filter the .apt.vm files.
> The following site docu fragment works with the site-plugin 3.3 and 3.4, but 
> fails with the pdf-plugin.
> {code:title=download.apt.vm}
> Download
> ~~ See 
> http://stackoverflow.com/questions/4836564/maven-properties-in-site-apt-files
>  {{${release-download-url}}} 
> {code}
> {code}
> [INFO] --- maven-pdf-plugin:1.2:pdf (pdf) @ commons-mail ---
> ...
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-pdf-plugin:1.2:pdf (pdf) on project 
> commons-mail: Error during document generation: Error parsing 
> C:\Users\leo\myproject\target\pdf\site.tmp\apt\download.apt.vm: missing '}' 
> -> [Help 1]
> {code}
> See also this stackoverflow question: 
> http://stackoverflow.com/questions/18142538/maven-pdf-plugin-custom-properties-are-not-filtered-in-the-generated-pdf



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MPDF-66) custom properties are not filtered in .apt.vm

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPDF-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15580612#comment-15580612
 ] 

ASF GitHub Bot commented on MPDF-66:


GitHub user lbreuss reopened a pull request:

https://github.com/apache/maven-plugins/pull/29

MPDF-66 maven-pdf-plugin puts project.properties into Velocity context.

It works. Are there any side effects to be expected by putting all 
project.properties into the renderer context?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lbreuss/maven-plugins trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-plugins/pull/29.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #29


commit 03165a8a48cb6e969318bcc08ee60f63bc198778
Author: Leo Breuss 
Date:   2014-10-14T09:05:38Z

MPDF-66 maven-pdf-plugin puts project.properties into Velocity context.




> custom properties are not filtered in .apt.vm
> -
>
> Key: MPDF-66
> URL: https://issues.apache.org/jira/browse/MPDF-66
> Project: Maven PDF Plugin
>  Issue Type: Bug
>Affects Versions: 1.2
>Reporter: Leo Breuss
>Assignee: Karl Heinz Marbaise
> Fix For: 1.3
>
>
> The pdf-plugin does not properly filter the .apt.vm files.
> The following site docu fragment works with the site-plugin 3.3 and 3.4, but 
> fails with the pdf-plugin.
> {code:title=download.apt.vm}
> Download
> ~~ See 
> http://stackoverflow.com/questions/4836564/maven-properties-in-site-apt-files
>  {{${release-download-url}}} 
> {code}
> {code}
> [INFO] --- maven-pdf-plugin:1.2:pdf (pdf) @ commons-mail ---
> ...
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-pdf-plugin:1.2:pdf (pdf) on project 
> commons-mail: Error during document generation: Error parsing 
> C:\Users\leo\myproject\target\pdf\site.tmp\apt\download.apt.vm: missing '}' 
> -> [Help 1]
> {code}
> See also this stackoverflow question: 
> http://stackoverflow.com/questions/18142538/maven-pdf-plugin-custom-properties-are-not-filtered-in-the-generated-pdf



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MPDF-66) custom properties are not filtered in .apt.vm

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPDF-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15580607#comment-15580607
 ] 

ASF GitHub Bot commented on MPDF-66:


Github user gmcdonald closed the pull request at:

https://github.com/apache/maven-plugins/pull/29


> custom properties are not filtered in .apt.vm
> -
>
> Key: MPDF-66
> URL: https://issues.apache.org/jira/browse/MPDF-66
> Project: Maven PDF Plugin
>  Issue Type: Bug
>Affects Versions: 1.2
>Reporter: Leo Breuss
>Assignee: Karl Heinz Marbaise
> Fix For: 1.3
>
>
> The pdf-plugin does not properly filter the .apt.vm files.
> The following site docu fragment works with the site-plugin 3.3 and 3.4, but 
> fails with the pdf-plugin.
> {code:title=download.apt.vm}
> Download
> ~~ See 
> http://stackoverflow.com/questions/4836564/maven-properties-in-site-apt-files
>  {{${release-download-url}}} 
> {code}
> {code}
> [INFO] --- maven-pdf-plugin:1.2:pdf (pdf) @ commons-mail ---
> ...
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-pdf-plugin:1.2:pdf (pdf) on project 
> commons-mail: Error during document generation: Error parsing 
> C:\Users\leo\myproject\target\pdf\site.tmp\apt\download.apt.vm: missing '}' 
> -> [Help 1]
> {code}
> See also this stackoverflow question: 
> http://stackoverflow.com/questions/18142538/maven-pdf-plugin-custom-properties-are-not-filtered-in-the-generated-pdf



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)