[jira] [Commented] (MSHADE-258) RemappingClassAdapter is deprecated and throws an exception with ASM 6.0 beta

2018-03-23 Thread JIRA

[ 
https://issues.apache.org/jira/browse/MSHADE-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410954#comment-16410954
 ] 

Børge N commented on MSHADE-258:


After a dependency started including module-info.class, we get
[WARNING] Discovered module-info.class. Shading will break its strong 
encapsulation.
We tried to filter out the file, but it didn't work, because this warning is 
emitted just before the file is checked for filtering:

[https://maven.apache.org/plugins/maven-shade-plugin/xref/org/apache/maven/plugins/shade/DefaultShader.html#L180]

I think it is reasonable to avoid the warning if the file has been marked for 
exclusion.

> RemappingClassAdapter is deprecated and throws an exception with ASM 6.0 beta
> -
>
> Key: MSHADE-258
> URL: https://issues.apache.org/jira/browse/MSHADE-258
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Ismael Juma
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.1.0
>
>
> While trying to use the maven shade plugin with ASM 6.0 beta (for Java 9 
> support) in the easymock project, I ran into the following exception:
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-shade-plugin:3.0.0:shade (default) on project 
> easymock: Error creating shaded jar: Error in ASM processing class 
> module-info.class: RemappingClassAdapter is deprecated, use ClassRemapper 
> instead -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-shade-plugin:3.0.0:shade (default) on 
> project easymock: Error creating shaded jar: Error in ASM processing class 
> module-info.class
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:309)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:993)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:345)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:191)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error creating 
> shaded jar: Error in ASM processing class module-info.class
>   at 
> org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:546)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
>   ... 20 more
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error in ASM 
> processing class module-info.class
>   at 
> org.apache.maven.plugins.shade.DefaultShader.addRemappedClass(DefaultShader.java:453)
>   at 
> org.apache.maven.plugins.shade.DefaultShader.shadeSingleJar(DefaultShader.java:220)
>   at 
> org.apache.maven.plugins.shade.DefaultShader.shadeJars(DefaultShader.java:181)
>   at 
> org.apache.maven.plugins.shade.DefaultShader.shade(DefaultShader.java:104)
>   at 
> org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:442)
>   ... 22 more
> Caused by: java.lang.RuntimeException: RemappingClassAdapter is deprecated, 
> use ClassRemapper instead
>   at 

[jira] [Commented] (MSHADE-258) RemappingClassAdapter is deprecated and throws an exception with ASM 6.0 beta

2017-10-08 Thread Robert Scholte (JIRA)

[ 
https://issues.apache.org/jira/browse/MSHADE-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196284#comment-16196284
 ] 

Robert Scholte commented on MSHADE-258:
---

Sounds like a bug, please create a new issue.

> RemappingClassAdapter is deprecated and throws an exception with ASM 6.0 beta
> -
>
> Key: MSHADE-258
> URL: https://issues.apache.org/jira/browse/MSHADE-258
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Ismael Juma
>Assignee: Robert Scholte
> Fix For: 3.1.0
>
>
> While trying to use the maven shade plugin with ASM 6.0 beta (for Java 9 
> support) in the easymock project, I ran into the following exception:
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-shade-plugin:3.0.0:shade (default) on project 
> easymock: Error creating shaded jar: Error in ASM processing class 
> module-info.class: RemappingClassAdapter is deprecated, use ClassRemapper 
> instead -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-shade-plugin:3.0.0:shade (default) on 
> project easymock: Error creating shaded jar: Error in ASM processing class 
> module-info.class
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:309)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:993)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:345)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:191)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error creating 
> shaded jar: Error in ASM processing class module-info.class
>   at 
> org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:546)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
>   ... 20 more
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error in ASM 
> processing class module-info.class
>   at 
> org.apache.maven.plugins.shade.DefaultShader.addRemappedClass(DefaultShader.java:453)
>   at 
> org.apache.maven.plugins.shade.DefaultShader.shadeSingleJar(DefaultShader.java:220)
>   at 
> org.apache.maven.plugins.shade.DefaultShader.shadeJars(DefaultShader.java:181)
>   at 
> org.apache.maven.plugins.shade.DefaultShader.shade(DefaultShader.java:104)
>   at 
> org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:442)
>   ... 22 more
> Caused by: java.lang.RuntimeException: RemappingClassAdapter is deprecated, 
> use ClassRemapper instead
>   at org.objectweb.asm.commons.RemappingClassAdapter.visitModule(Unknown 
> Source)
>   at org.objectweb.asm.ClassReader.a(Unknown Source)
>   at org.objectweb.asm.ClassReader.accept(Unknown Source)
>   at org.objectweb.asm.ClassReader.accept(Unknown Source)
>   at 
> org.apache.maven.plugins.shade.DefaultShader.addRemappedClass(DefaultShader.java:449)
> {code}
> Link to the exception:
> https://gitlab.ow2.org/asm/asm/blob/master/src/org/objectweb/asm/commons/RemappingClassAdapter.java#L75

[jira] [Commented] (MSHADE-258) RemappingClassAdapter is deprecated and throws an exception with ASM 6.0 beta

2017-10-05 Thread John Poth (JIRA)

[ 
https://issues.apache.org/jira/browse/MSHADE-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192790#comment-16192790
 ] 

John Poth commented on MSHADE-258:
--

Hi [~rfscholte], [~ijuma],

What is it intentional to exclude the module-info.class from the original 
artifact? Would it be possible to add an option to keep it?

Thanks!



> RemappingClassAdapter is deprecated and throws an exception with ASM 6.0 beta
> -
>
> Key: MSHADE-258
> URL: https://issues.apache.org/jira/browse/MSHADE-258
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Ismael Juma
>Assignee: Robert Scholte
> Fix For: 3.1.0
>
>
> While trying to use the maven shade plugin with ASM 6.0 beta (for Java 9 
> support) in the easymock project, I ran into the following exception:
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-shade-plugin:3.0.0:shade (default) on project 
> easymock: Error creating shaded jar: Error in ASM processing class 
> module-info.class: RemappingClassAdapter is deprecated, use ClassRemapper 
> instead -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-shade-plugin:3.0.0:shade (default) on 
> project easymock: Error creating shaded jar: Error in ASM processing class 
> module-info.class
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:309)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:993)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:345)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:191)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error creating 
> shaded jar: Error in ASM processing class module-info.class
>   at 
> org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:546)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
>   ... 20 more
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error in ASM 
> processing class module-info.class
>   at 
> org.apache.maven.plugins.shade.DefaultShader.addRemappedClass(DefaultShader.java:453)
>   at 
> org.apache.maven.plugins.shade.DefaultShader.shadeSingleJar(DefaultShader.java:220)
>   at 
> org.apache.maven.plugins.shade.DefaultShader.shadeJars(DefaultShader.java:181)
>   at 
> org.apache.maven.plugins.shade.DefaultShader.shade(DefaultShader.java:104)
>   at 
> org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:442)
>   ... 22 more
> Caused by: java.lang.RuntimeException: RemappingClassAdapter is deprecated, 
> use ClassRemapper instead
>   at org.objectweb.asm.commons.RemappingClassAdapter.visitModule(Unknown 
> Source)
>   at org.objectweb.asm.ClassReader.a(Unknown Source)
>   at org.objectweb.asm.ClassReader.accept(Unknown Source)
>   at org.objectweb.asm.ClassReader.accept(Unknown Source)
>   at 
> org.apache.maven.plugins.shade.DefaultShader.addRemappedClass(DefaultShader.java:449)
> {code}
> Link to 

[jira] [Commented] (MSHADE-258) RemappingClassAdapter is deprecated and throws an exception with ASM 6.0 beta

2017-08-19 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/MSHADE-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134119#comment-16134119
 ] 

Hudson commented on MSHADE-258:
---

SUCCESS: Integrated in Jenkins build maven-plugins #9072 (See 
[https://builds.apache.org/job/maven-plugins/9072/])
[MSHADE-258] RemappingClassAdapter is deprecated and throws an exception with 
ASM 6.0 beta
Provide IT (rfscholte: [http://svn.apache.org/viewvc/?view=rev=1805503])
* (add) maven-shade-plugin/src/it/MSHADE-258_module_relocation
* (add) maven-shade-plugin/src/it/MSHADE-258_module_relocation/pom.xml
* (add) maven-shade-plugin/src/it/MSHADE-258_module_relocation/verify.groovy


> RemappingClassAdapter is deprecated and throws an exception with ASM 6.0 beta
> -
>
> Key: MSHADE-258
> URL: https://issues.apache.org/jira/browse/MSHADE-258
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Ismael Juma
>Assignee: Robert Scholte
> Fix For: 3.1.0
>
>
> While trying to use the maven shade plugin with ASM 6.0 beta (for Java 9 
> support) in the easymock project, I ran into the following exception:
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-shade-plugin:3.0.0:shade (default) on project 
> easymock: Error creating shaded jar: Error in ASM processing class 
> module-info.class: RemappingClassAdapter is deprecated, use ClassRemapper 
> instead -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-shade-plugin:3.0.0:shade (default) on 
> project easymock: Error creating shaded jar: Error in ASM processing class 
> module-info.class
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:309)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:993)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:345)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:191)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error creating 
> shaded jar: Error in ASM processing class module-info.class
>   at 
> org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:546)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
>   ... 20 more
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error in ASM 
> processing class module-info.class
>   at 
> org.apache.maven.plugins.shade.DefaultShader.addRemappedClass(DefaultShader.java:453)
>   at 
> org.apache.maven.plugins.shade.DefaultShader.shadeSingleJar(DefaultShader.java:220)
>   at 
> org.apache.maven.plugins.shade.DefaultShader.shadeJars(DefaultShader.java:181)
>   at 
> org.apache.maven.plugins.shade.DefaultShader.shade(DefaultShader.java:104)
>   at 
> org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:442)
>   ... 22 more
> Caused by: java.lang.RuntimeException: RemappingClassAdapter is deprecated, 
> use ClassRemapper instead
>   at org.objectweb.asm.commons.RemappingClassAdapter.visitModule(Unknown 
> 

[jira] [Commented] (MSHADE-258) RemappingClassAdapter is deprecated and throws an exception with ASM 6.0 beta

2017-08-07 Thread Ismael Juma (JIRA)

[ 
https://issues.apache.org/jira/browse/MSHADE-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116320#comment-16116320
 ] 

Ismael Juma commented on MSHADE-258:


Makes sense. Interestingly that error happened after the following line:

[DEBUG] Processing JAR 
/Users/ijuma/.m2/repository/org/ow2/asm/asm/6.0_BETA/asm-6.0_BETA.jar

> RemappingClassAdapter is deprecated and throws an exception with ASM 6.0 beta
> -
>
> Key: MSHADE-258
> URL: https://issues.apache.org/jira/browse/MSHADE-258
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Ismael Juma
>
> While trying to use the maven shade plugin with ASM 6.0 beta (for Java 9 
> support) in the easymock project, I ran into the following exception:
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-shade-plugin:3.0.0:shade (default) on project 
> easymock: Error creating shaded jar: Error in ASM processing class 
> module-info.class: RemappingClassAdapter is deprecated, use ClassRemapper 
> instead -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-shade-plugin:3.0.0:shade (default) on 
> project easymock: Error creating shaded jar: Error in ASM processing class 
> module-info.class
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:309)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:993)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:345)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:191)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error creating 
> shaded jar: Error in ASM processing class module-info.class
>   at 
> org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:546)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
>   ... 20 more
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error in ASM 
> processing class module-info.class
>   at 
> org.apache.maven.plugins.shade.DefaultShader.addRemappedClass(DefaultShader.java:453)
>   at 
> org.apache.maven.plugins.shade.DefaultShader.shadeSingleJar(DefaultShader.java:220)
>   at 
> org.apache.maven.plugins.shade.DefaultShader.shadeJars(DefaultShader.java:181)
>   at 
> org.apache.maven.plugins.shade.DefaultShader.shade(DefaultShader.java:104)
>   at 
> org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:442)
>   ... 22 more
> Caused by: java.lang.RuntimeException: RemappingClassAdapter is deprecated, 
> use ClassRemapper instead
>   at org.objectweb.asm.commons.RemappingClassAdapter.visitModule(Unknown 
> Source)
>   at org.objectweb.asm.ClassReader.a(Unknown Source)
>   at org.objectweb.asm.ClassReader.accept(Unknown Source)
>   at org.objectweb.asm.ClassReader.accept(Unknown Source)
>   at 
> org.apache.maven.plugins.shade.DefaultShader.addRemappedClass(DefaultShader.java:449)
> {code}
> Link to the exception:
> 

[jira] [Commented] (MSHADE-258) RemappingClassAdapter is deprecated and throws an exception with ASM 6.0 beta

2017-08-06 Thread Robert Scholte (JIRA)

[ 
https://issues.apache.org/jira/browse/MSHADE-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115888#comment-16115888
 ] 

Robert Scholte commented on MSHADE-258:
---

MSHADE-242 is happening in case of minifying the jar, this issue happens when 
relocating classes of jars with a module descriptor. This will also mean that 
it'll break the intended strong encapsulation.
Java 9 will not provide a solution for that yet, so I guess we'll have to log a 
warning as well.

> RemappingClassAdapter is deprecated and throws an exception with ASM 6.0 beta
> -
>
> Key: MSHADE-258
> URL: https://issues.apache.org/jira/browse/MSHADE-258
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Ismael Juma
>
> While trying to use the maven shade plugin with ASM 6.0 beta (for Java 9 
> support) in the easymock project, I ran into the following exception:
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-shade-plugin:3.0.0:shade (default) on project 
> easymock: Error creating shaded jar: Error in ASM processing class 
> module-info.class: RemappingClassAdapter is deprecated, use ClassRemapper 
> instead -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-shade-plugin:3.0.0:shade (default) on 
> project easymock: Error creating shaded jar: Error in ASM processing class 
> module-info.class
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:309)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:993)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:345)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:191)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error creating 
> shaded jar: Error in ASM processing class module-info.class
>   at 
> org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:546)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
>   ... 20 more
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error in ASM 
> processing class module-info.class
>   at 
> org.apache.maven.plugins.shade.DefaultShader.addRemappedClass(DefaultShader.java:453)
>   at 
> org.apache.maven.plugins.shade.DefaultShader.shadeSingleJar(DefaultShader.java:220)
>   at 
> org.apache.maven.plugins.shade.DefaultShader.shadeJars(DefaultShader.java:181)
>   at 
> org.apache.maven.plugins.shade.DefaultShader.shade(DefaultShader.java:104)
>   at 
> org.apache.maven.plugins.shade.mojo.ShadeMojo.execute(ShadeMojo.java:442)
>   ... 22 more
> Caused by: java.lang.RuntimeException: RemappingClassAdapter is deprecated, 
> use ClassRemapper instead
>   at org.objectweb.asm.commons.RemappingClassAdapter.visitModule(Unknown 
> Source)
>   at org.objectweb.asm.ClassReader.a(Unknown Source)
>   at org.objectweb.asm.ClassReader.accept(Unknown Source)
>   at org.objectweb.asm.ClassReader.accept(Unknown Source)
>   at 
>