[jira] [Commented] (MSITE-782) Support for custom Velocity tools has disappeared

2017-04-02 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/MSITE-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952566#comment-15952566
 ] 

Hudson commented on MSITE-782:
--

SUCCESS: Integrated in Jenkins build maven-plugins #8907 (See 
[https://builds.apache.org/job/maven-plugins/8907/])
[MSITE-782] removed reportPlugins parameter: use project.reporting.plugins 
(hboutemy: [http://svn.apache.org/viewvc/?view=rev=1789855])
* (edit) maven-site-plugin/pom.xml
* (edit) maven-site-plugin/src/it/MSITE-484/parent-usage-test/pom.xml
* (edit) maven-site-plugin/src/it/MSITE-484/pom.xml
* (edit) maven-site-plugin/src/it/MSITE-627/pom.xml
* (edit) maven-site-plugin/src/it/new-configuration/verify.groovy
* (edit) 
maven-site-plugin/src/main/java/org/apache/maven/plugins/site/render/AbstractSiteRenderingMojo.java
* (edit) maven-site-plugin/src/site/apt/maven-3.apt.vm


> Support for custom Velocity tools has disappeared
> -
>
> Key: MSITE-782
> URL: https://issues.apache.org/jira/browse/MSITE-782
> Project: Maven Site Plugin
>  Issue Type: Bug
>Affects Versions: 3.5, 3.5.1
>Reporter: Bernardo
>Assignee: Michael Osipov
> Fix For: 3.6
>
>
> Since the version 3.5 any skin using custom velocity tools is no longer 
> working.
> This can be seen on the Reflow maven skin, and also on my own skin, which was 
> developed from the Reflow one.
> The Reflow skin, along its Velocity tools, can be found here:
> https://github.com/andriusvelykis/reflow-maven-skin
> My Maven skin can be found here:
> https://github.com/Bernardo-MG/docs-maven-skin
> My custom velocity tools:
> https://github.com/Bernardo-MG/maven-site-fixer
> All these projects are available through Maven central, making them easy to 
> test.
> To see this problem just use the Reflow skin, which won't print the content 
> of any page. In the case of my own skin, there will be several errors in the 
> HTML code, the most visible being the broken headers.
> It may be actually a Doxia problem, related to this issue:
> https://issues.apache.org/jira/browse/DOXIASITETOOLS-93
> Additionally, there is a related link commenting this problem:
> http://maven.40175.n5.nabble.com/New-maven-site-and-doxia-with-custom-velocity-doxia-td5865376.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (MSITE-782) Support for custom Velocity tools has disappeared

2016-10-15 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/MSITE-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15578234#comment-15578234
 ] 

Hudson commented on MSITE-782:
--

FAILURE: Integrated in Jenkins build maven-plugins #7349 (See 
[https://builds.apache.org/job/maven-plugins/7349/])
[MSITE-782] check that Velocity tools declared in 
/META-INF/maven/site-tools.xml are discovered after DOXIASITETOOLS-168 r1765053 
(hboutemy: [http://svn.apache.org/viewvc/?view=rev=1765073])
* (add) maven-site-plugin/src/it/doxia-formats/src/main/resources/META-INF
* (add) maven-site-plugin/src/it/doxia-formats/src/main/resources/META-INF/maven
* (add) 
maven-site-plugin/src/it/doxia-formats/src/main/resources/META-INF/maven/site-tools.xml
* (delete) maven-site-plugin/src/it/doxia-formats/src/main/resources/tools.xml
* (edit) 
maven-site-plugin/src/it/doxia-formats/src/site/apt/velocity-context.apt.vm
* (delete) maven-site-plugin/src/it/doxia-formats/verify.groovy.edited


> Support for custom Velocity tools has disappeared
> -
>
> Key: MSITE-782
> URL: https://issues.apache.org/jira/browse/MSITE-782
> Project: Maven Site Plugin
>  Issue Type: Bug
>Affects Versions: 3.5, 3.5.1
>Reporter: Bernardo
>Assignee: Michael Osipov
> Fix For: 3.6
>
>
> Since the version 3.5 any skin using custom velocity tools is no longer 
> working.
> This can be seen on the Reflow maven skin, and also on my own skin, which was 
> developed from the Reflow one.
> The Reflow skin, along its Velocity tools, can be found here:
> https://github.com/andriusvelykis/reflow-maven-skin
> My Maven skin can be found here:
> https://github.com/Bernardo-MG/docs-maven-skin
> My custom velocity tools:
> https://github.com/Bernardo-MG/maven-site-fixer
> All these projects are available through Maven central, making them easy to 
> test.
> To see this problem just use the Reflow skin, which won't print the content 
> of any page. In the case of my own skin, there will be several errors in the 
> HTML code, the most visible being the broken headers.
> It may be actually a Doxia problem, related to this issue:
> https://issues.apache.org/jira/browse/DOXIASITETOOLS-93
> Additionally, there is a related link commenting this problem:
> http://maven.40175.n5.nabble.com/New-maven-site-and-doxia-with-custom-velocity-doxia-td5865376.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MSITE-782) Support for custom Velocity tools has disappeared

2016-10-15 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/MSITE-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15578091#comment-15578091
 ] 

Hudson commented on MSITE-782:
--

SUCCESS: Integrated in Jenkins build doxia-all #298 (See 
[https://builds.apache.org/job/doxia-all/298/])
[MSITE-782] Support for custom Velocity tools has disappeared

Instruct Velocity to load possible custom tools from 
/META-INF/maven/site-tools.xml found in the classpath of the Maven Site Plugin. 
(michaelo: [http://svn.apache.org/viewvc/?view=rev=1765053])
* (edit) 
./doxia-sitetools/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
* (edit) ./doxia-sitetools/doxia-site-renderer/src/site/apt/index.apt.vm


> Support for custom Velocity tools has disappeared
> -
>
> Key: MSITE-782
> URL: https://issues.apache.org/jira/browse/MSITE-782
> Project: Maven Site Plugin
>  Issue Type: Bug
>Affects Versions: 3.5, 3.5.1
>Reporter: Bernardo
>Assignee: Michael Osipov
> Fix For: 3.6
>
>
> Since the version 3.5 any skin using custom velocity tools is no longer 
> working.
> This can be seen on the Reflow maven skin, and also on my own skin, which was 
> developed from the Reflow one.
> The Reflow skin, along its Velocity tools, can be found here:
> https://github.com/andriusvelykis/reflow-maven-skin
> My Maven skin can be found here:
> https://github.com/Bernardo-MG/docs-maven-skin
> My custom velocity tools:
> https://github.com/Bernardo-MG/maven-site-fixer
> All these projects are available through Maven central, making them easy to 
> test.
> To see this problem just use the Reflow skin, which won't print the content 
> of any page. In the case of my own skin, there will be several errors in the 
> HTML code, the most visible being the broken headers.
> It may be actually a Doxia problem, related to this issue:
> https://issues.apache.org/jira/browse/DOXIASITETOOLS-93
> Additionally, there is a related link commenting this problem:
> http://maven.40175.n5.nabble.com/New-maven-site-and-doxia-with-custom-velocity-doxia-td5865376.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MSITE-782) Support for custom Velocity tools has disappeared

2016-10-15 Thread Michael Osipov (JIRA)

[ 
https://issues.apache.org/jira/browse/MSITE-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15578069#comment-15578069
 ] 

Michael Osipov commented on MSITE-782:
--

Again, sorry for the huge delay though this fix way easy. I was simply to busy 
to take a serious look at it.

> Support for custom Velocity tools has disappeared
> -
>
> Key: MSITE-782
> URL: https://issues.apache.org/jira/browse/MSITE-782
> Project: Maven Site Plugin
>  Issue Type: Bug
>Affects Versions: 3.5, 3.5.1
>Reporter: Bernardo
>Assignee: Michael Osipov
> Fix For: 3.6
>
>
> Since the version 3.5 any skin using custom velocity tools is no longer 
> working.
> This can be seen on the Reflow maven skin, and also on my own skin, which was 
> developed from the Reflow one.
> The Reflow skin, along its Velocity tools, can be found here:
> https://github.com/andriusvelykis/reflow-maven-skin
> My Maven skin can be found here:
> https://github.com/Bernardo-MG/docs-maven-skin
> My custom velocity tools:
> https://github.com/Bernardo-MG/maven-site-fixer
> All these projects are available through Maven central, making them easy to 
> test.
> To see this problem just use the Reflow skin, which won't print the content 
> of any page. In the case of my own skin, there will be several errors in the 
> HTML code, the most visible being the broken headers.
> It may be actually a Doxia problem, related to this issue:
> https://issues.apache.org/jira/browse/DOXIASITETOOLS-93
> Additionally, there is a related link commenting this problem:
> http://maven.40175.n5.nabble.com/New-maven-site-and-doxia-with-custom-velocity-doxia-td5865376.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MSITE-782) Support for custom Velocity tools has disappeared

2016-10-13 Thread JIRA

[ 
https://issues.apache.org/jira/browse/MSITE-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571495#comment-15571495
 ] 

Hervé Boutemy commented on MSITE-782:
-

Hi Michael,
I added an IT in r1762932 taht eases tests, since it shows the issue in a 
simple document, without the need to test at template/skin level
But I didn't try to fix the issue since you're on it: do you need help?

> Support for custom Velocity tools has disappeared
> -
>
> Key: MSITE-782
> URL: https://issues.apache.org/jira/browse/MSITE-782
> Project: Maven Site Plugin
>  Issue Type: Bug
>Affects Versions: 3.5, 3.5.1
>Reporter: Bernardo
> Fix For: 3.6
>
>
> Since the version 3.5 any skin using custom velocity tools is no longer 
> working.
> This can be seen on the Reflow maven skin, and also on my own skin, which was 
> developed from the Reflow one.
> The Reflow skin, along its Velocity tools, can be found here:
> https://github.com/andriusvelykis/reflow-maven-skin
> My Maven skin can be found here:
> https://github.com/Bernardo-MG/docs-maven-skin
> My custom velocity tools:
> https://github.com/Bernardo-MG/maven-site-fixer
> All these projects are available through Maven central, making them easy to 
> test.
> To see this problem just use the Reflow skin, which won't print the content 
> of any page. In the case of my own skin, there will be several errors in the 
> HTML code, the most visible being the broken headers.
> It may be actually a Doxia problem, related to this issue:
> https://issues.apache.org/jira/browse/DOXIASITETOOLS-93
> Additionally, there is a related link commenting this problem:
> http://maven.40175.n5.nabble.com/New-maven-site-and-doxia-with-custom-velocity-doxia-td5865376.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MSITE-782) Support for custom Velocity tools has disappeared

2016-09-30 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/MSITE-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15536607#comment-15536607
 ] 

Hudson commented on MSITE-782:
--

SUCCESS: Integrated in Jenkins build maven-plugins #7320 (See 
[https://builds.apache.org/job/maven-plugins/7320/])
[MSITE-782] added custom Velocity tool test (failing...) (hboutemy: 
[http://svn.apache.org/viewvc/?view=rev=1762932])
* (add) maven-site-plugin/src/it/doxia-formats/invoker.properties
* (edit) maven-site-plugin/src/it/doxia-formats/pom.xml
* (add) maven-site-plugin/src/it/doxia-formats/src/main
* (add) maven-site-plugin/src/it/doxia-formats/src/main/java
* (add) maven-site-plugin/src/it/doxia-formats/src/main/java/org
* (add) maven-site-plugin/src/it/doxia-formats/src/main/java/org/apache
* (add) maven-site-plugin/src/it/doxia-formats/src/main/java/org/apache/maven
* (add) 
maven-site-plugin/src/it/doxia-formats/src/main/java/org/apache/maven/plugins
* (add) 
maven-site-plugin/src/it/doxia-formats/src/main/java/org/apache/maven/plugins/site
* (add) 
maven-site-plugin/src/it/doxia-formats/src/main/java/org/apache/maven/plugins/site/it
* (add) 
maven-site-plugin/src/it/doxia-formats/src/main/java/org/apache/maven/plugins/site/it/CustomVelocityTool.java
* (add) maven-site-plugin/src/it/doxia-formats/src/main/resources
* (add) maven-site-plugin/src/it/doxia-formats/src/main/resources/tools.xml
* (edit) 
maven-site-plugin/src/it/doxia-formats/src/site/apt/velocity-context.apt.vm
* (edit) maven-site-plugin/src/it/doxia-formats/verify.groovy
* (add) maven-site-plugin/src/it/doxia-formats/verify.groovy.edited


> Support for custom Velocity tools has disappeared
> -
>
> Key: MSITE-782
> URL: https://issues.apache.org/jira/browse/MSITE-782
> Project: Maven Site Plugin
>  Issue Type: Bug
>Affects Versions: 3.5, 3.5.1
>Reporter: Bernardo
>
> Since the version 3.5 any skin using custom velocity tools is no longer 
> working.
> This can be seen on the Reflow maven skin, and also on my own skin, which was 
> developed from the Reflow one.
> The Reflow skin, along its Velocity tools, can be found here:
> https://github.com/andriusvelykis/reflow-maven-skin
> My Maven skin can be found here:
> https://github.com/Bernardo-MG/docs-maven-skin
> My custom velocity tools:
> https://github.com/Bernardo-MG/maven-site-fixer
> All these projects are available through Maven central, making them easy to 
> test.
> To see this problem just use the Reflow skin, which won't print the content 
> of any page. In the case of my own skin, there will be several errors in the 
> HTML code, the most visible being the broken headers.
> It may be actually a Doxia problem, related to this issue:
> https://issues.apache.org/jira/browse/DOXIASITETOOLS-93
> Additionally, there is a related link commenting this problem:
> http://maven.40175.n5.nabble.com/New-maven-site-and-doxia-with-custom-velocity-doxia-td5865376.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MSITE-782) Support for custom Velocity tools has disappeared

2016-09-24 Thread Michael Osipov (JIRA)

[ 
https://issues.apache.org/jira/browse/MSITE-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15519676#comment-15519676
 ] 

Michael Osipov commented on MSITE-782:
--

Hi folks,

I did not have much time for this in the last couple of months but aready had 
some ideas, as expressed in August. I guess, I wll take on this in October.

> Support for custom Velocity tools has disappeared
> -
>
> Key: MSITE-782
> URL: https://issues.apache.org/jira/browse/MSITE-782
> Project: Maven Site Plugin
>  Issue Type: Bug
>Affects Versions: 3.5, 3.5.1
>Reporter: Bernardo
>
> Since the version 3.5 any skin using custom velocity tools is no longer 
> working.
> This can be seen on the Reflow maven skin, and also on my own skin, which was 
> developed from the Reflow one.
> The Reflow skin, along its Velocity tools, can be found here:
> https://github.com/andriusvelykis/reflow-maven-skin
> My Maven skin can be found here:
> https://github.com/Bernardo-MG/docs-maven-skin
> My custom velocity tools:
> https://github.com/Bernardo-MG/maven-site-fixer
> All these projects are available through Maven central, making them easy to 
> test.
> To see this problem just use the Reflow skin, which won't print the content 
> of any page. In the case of my own skin, there will be several errors in the 
> HTML code, the most visible being the broken headers.
> It may be actually a Doxia problem, related to this issue:
> https://issues.apache.org/jira/browse/DOXIASITETOOLS-93
> Additionally, there is a related link commenting this problem:
> http://maven.40175.n5.nabble.com/New-maven-site-and-doxia-with-custom-velocity-doxia-td5865376.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MSITE-782) Support for custom Velocity tools has disappeared

2016-09-24 Thread JIRA

[ 
https://issues.apache.org/jira/browse/MSITE-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15519654#comment-15519654
 ] 

Hervé Boutemy commented on MSITE-782:
-

thank you for these explanations: ok, now I see how each piece is suppose to 
come into play
I'll try to create an IT to ease testing of the current bug

> Support for custom Velocity tools has disappeared
> -
>
> Key: MSITE-782
> URL: https://issues.apache.org/jira/browse/MSITE-782
> Project: Maven Site Plugin
>  Issue Type: Bug
>Affects Versions: 3.5, 3.5.1
>Reporter: Bernardo
>
> Since the version 3.5 any skin using custom velocity tools is no longer 
> working.
> This can be seen on the Reflow maven skin, and also on my own skin, which was 
> developed from the Reflow one.
> The Reflow skin, along its Velocity tools, can be found here:
> https://github.com/andriusvelykis/reflow-maven-skin
> My Maven skin can be found here:
> https://github.com/Bernardo-MG/docs-maven-skin
> My custom velocity tools:
> https://github.com/Bernardo-MG/maven-site-fixer
> All these projects are available through Maven central, making them easy to 
> test.
> To see this problem just use the Reflow skin, which won't print the content 
> of any page. In the case of my own skin, there will be several errors in the 
> HTML code, the most visible being the broken headers.
> It may be actually a Doxia problem, related to this issue:
> https://issues.apache.org/jira/browse/DOXIASITETOOLS-93
> Additionally, there is a related link commenting this problem:
> http://maven.40175.n5.nabble.com/New-maven-site-and-doxia-with-custom-velocity-doxia-td5865376.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MSITE-782) Support for custom Velocity tools has disappeared

2016-09-22 Thread Bernardo (JIRA)

[ 
https://issues.apache.org/jira/browse/MSITE-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15514487#comment-15514487
 ] 

Bernardo commented on MSITE-782:


I'll try to be as detailed as possible, as there are a few projects mixed on 
that.

If you need any more info, just ask for it.

h5. Velocity Tool

First of all, the code for the Velocity tool being used can be found in this 
project:
https://github.com/Bernardo-MG/maven-site-fixer

The configuration file for the Maven Site Fixer Velocity tool can be found 
inside of it, in the path "src/main/resources/tools.xml".
https://github.com/Bernardo-MG/maven-site-fixer/blob/master/src/main/resources/tools.xml

h5. Maven Skin

This Velocity tool is loaded into the skin. The Maven skin code can be found 
here:
https://github.com/Bernardo-MG/docs-maven-skin

Inside the Docs Maven Skin POM the Velocity tool is declared as a dependency:
{code}
   
  
 
 com.wandrell.velocity
 maven-site-fixer
 ${wandrell.siteFixer.version}
  
  
 
 org.apache.velocity
 velocity
 ${velocity.version}
  
   
{code}

h5. Test project

Finally, in the test project the Maven skin is set as a dependency of the Maven 
Site plugin, in the build section:
{code}
 


org.apache.maven.plugins
maven-site-plugin

   
  
  com.wandrell.maven.skins
  docs-maven-skin
  ${site.skin.version}
   
   
  
  org.apache.velocity
  velocity
  ${plugin.site.velocity.version}
   

 
{code}

> Support for custom Velocity tools has disappeared
> -
>
> Key: MSITE-782
> URL: https://issues.apache.org/jira/browse/MSITE-782
> Project: Maven Site Plugin
>  Issue Type: Bug
>Affects Versions: 3.5, 3.5.1
>Reporter: Bernardo
>
> Since the version 3.5 any skin using custom velocity tools is no longer 
> working.
> This can be seen on the Reflow maven skin, and also on my own skin, which was 
> developed from the Reflow one.
> The Reflow skin, along its Velocity tools, can be found here:
> https://github.com/andriusvelykis/reflow-maven-skin
> My Maven skin can be found here:
> https://github.com/Bernardo-MG/docs-maven-skin
> My custom velocity tools:
> https://github.com/Bernardo-MG/maven-site-fixer
> All these projects are available through Maven central, making them easy to 
> test.
> To see this problem just use the Reflow skin, which won't print the content 
> of any page. In the case of my own skin, there will be several errors in the 
> HTML code, the most visible being the broken headers.
> It may be actually a Doxia problem, related to this issue:
> https://issues.apache.org/jira/browse/DOXIASITETOOLS-93
> Additionally, there is a related link commenting this problem:
> http://maven.40175.n5.nabble.com/New-maven-site-and-doxia-with-custom-velocity-doxia-td5865376.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MSITE-782) Support for custom Velocity tools has disappeared

2016-09-22 Thread JIRA

[ 
https://issues.apache.org/jira/browse/MSITE-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15514411#comment-15514411
 ] 

Hervé Boutemy commented on MSITE-782:
-

thanks for this test project. I'll need your help to dig into it: where is the 
custom Velocity tool, that is not loaded?

> Support for custom Velocity tools has disappeared
> -
>
> Key: MSITE-782
> URL: https://issues.apache.org/jira/browse/MSITE-782
> Project: Maven Site Plugin
>  Issue Type: Bug
>Affects Versions: 3.5, 3.5.1
>Reporter: Bernardo
>
> Since the version 3.5 any skin using custom velocity tools is no longer 
> working.
> This can be seen on the Reflow maven skin, and also on my own skin, which was 
> developed from the Reflow one.
> The Reflow skin, along its Velocity tools, can be found here:
> https://github.com/andriusvelykis/reflow-maven-skin
> My Maven skin can be found here:
> https://github.com/Bernardo-MG/docs-maven-skin
> My custom velocity tools:
> https://github.com/Bernardo-MG/maven-site-fixer
> All these projects are available through Maven central, making them easy to 
> test.
> To see this problem just use the Reflow skin, which won't print the content 
> of any page. In the case of my own skin, there will be several errors in the 
> HTML code, the most visible being the broken headers.
> It may be actually a Doxia problem, related to this issue:
> https://issues.apache.org/jira/browse/DOXIASITETOOLS-93
> Additionally, there is a related link commenting this problem:
> http://maven.40175.n5.nabble.com/New-maven-site-and-doxia-with-custom-velocity-doxia-td5865376.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MSITE-782) Support for custom Velocity tools has disappeared

2016-08-07 Thread Bernardo (JIRA)

[ 
https://issues.apache.org/jira/browse/MSITE-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411077#comment-15411077
 ] 

Bernardo commented on MSITE-782:


I've created a test project for the bug:
https://github.com/bernardo-mg/maven-site-velocity-bug

As it was created from an Archetype it may contain some unneeded files and 
configuration, still what matters is that it sets up my skin as I expect it to 
be set up.

To test it just download the code and run the "mvn site" command, it will 
create a Maven Site with an index containing the same text as the readme, which 
notes several errors which, if the appear, show that the custom Velocity 
library is not being loaded.

The project contains two branches, one set up for version 3.4 of the plugin, 
which works, and another for version 3.5.1, which breaks the skin.

> Support for custom Velocity tools has disappeared
> -
>
> Key: MSITE-782
> URL: https://issues.apache.org/jira/browse/MSITE-782
> Project: Maven Site Plugin
>  Issue Type: Bug
>Affects Versions: 3.5, 3.5.1
>Reporter: Bernardo
>
> Since the version 3.5 any skin using custom velocity tools is no longer 
> working.
> This can be seen on the Reflow maven skin, and also on my own skin, which was 
> developed from the Reflow one.
> The Reflow skin, along its Velocity tools, can be found here:
> https://github.com/andriusvelykis/reflow-maven-skin
> My Maven skin can be found here:
> https://github.com/Bernardo-MG/docs-maven-skin
> My custom velocity tools:
> https://github.com/Bernardo-MG/maven-site-fixer
> All these projects are available through Maven central, making them easy to 
> test.
> To see this problem just use the Reflow skin, which won't print the content 
> of any page. In the case of my own skin, there will be several errors in the 
> HTML code, the most visible being the broken headers.
> It may be actually a Doxia problem, related to this issue:
> https://issues.apache.org/jira/browse/DOXIASITETOOLS-93
> Additionally, there is a related link commenting this problem:
> http://maven.40175.n5.nabble.com/New-maven-site-and-doxia-with-custom-velocity-doxia-td5865376.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MSITE-782) Support for custom Velocity tools has disappeared

2016-08-03 Thread Michael Osipov (JIRA)

[ 
https://issues.apache.org/jira/browse/MSITE-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406676#comment-15406676
 ] 

Michael Osipov commented on MSITE-782:
--

This is a regression. The Velocity Toolbox configuration is is horribly 
complex, completely overdesigned and has so many defaults a regular user 
wouldn't think of. By default, the 
[{{ConfiguationUtils}}|https://github.com/apache/velocity-tools/blob/49282b4dbb0b8f460a07db8e7e56844c05b908ce/velocity-tools-generic/src/main/java/org/apache/velocity/tools/config/ConfigurationUtils.java]
 queries numerous sources for a {{tools.xml}}. Since the {{ToolManager}} is 
called with {{false, false}} all automagic has been disabled. Your config is 
ignored.

I just quickly reviewed the Velocity code and as far as I can see, one can 
chain configs. Your config would be a child, though I would not read from 
{{classpath:/tools.xml}} but rather from 
{{classpath:/META-INF/maven/site-tools.xml}} or similar.

[~hboutemy], we need to create a new ticket where we will introduce a 
skin-related custom Velocity Toolbox, document the new path and push a new 
Doxia release. This ticket would depend on it. I will take care of the new 
ticket. Additionally, I do not know wether it makes sense to configure the 
config path in {{skin.xml}}. I would like avoid too much config for this.

[~Bernardo-MG], please prepare a sample project to reproduce and to develop 
with. You may also prepare a new branch of your skin with  a 
yet-to-be-announced default path for a tools config file.

> Support for custom Velocity tools has disappeared
> -
>
> Key: MSITE-782
> URL: https://issues.apache.org/jira/browse/MSITE-782
> Project: Maven Site Plugin
>  Issue Type: Bug
>Affects Versions: 3.5, 3.5.1
>Reporter: Bernardo
>
> Since the version 3.5 any skin using custom velocity tools is no longer 
> working.
> This can be seen on the Reflow maven skin, and also on my own skin, which was 
> developed from the Reflow one.
> The Reflow skin, along its Velocity tools, can be found here:
> https://github.com/andriusvelykis/reflow-maven-skin
> My Maven skin can be found here:
> https://github.com/Bernardo-MG/docs-maven-skin
> My custom velocity tools:
> https://github.com/Bernardo-MG/maven-site-fixer
> All these projects are available through Maven central, making them easy to 
> test.
> To see this problem just use the Reflow skin, which won't print the content 
> of any page. In the case of my own skin, there will be several errors in the 
> HTML code, the most visible being the broken headers.
> It may be actually a Doxia problem, related to this issue:
> https://issues.apache.org/jira/browse/DOXIASITETOOLS-93
> Additionally, there is a related link commenting this problem:
> http://maven.40175.n5.nabble.com/New-maven-site-and-doxia-with-custom-velocity-doxia-td5865376.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (MSITE-782) Support for custom Velocity tools has disappeared

2016-08-03 Thread JIRA

[ 
https://issues.apache.org/jira/browse/MSITE-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406559#comment-15406559
 ] 

Hervé Boutemy commented on MSITE-782:
-

I'm not a Velocity expert, will need some help: [~michael-o], can you help 
here, please?
Looks like the autoconfiguration of ToolManager was getting invalid result: a 
handwritten/hardcoded configuration was done in DOXIASITETOOLS-93
but now we're missing autoconfiguration for extra tools
what's wrong?

> Support for custom Velocity tools has disappeared
> -
>
> Key: MSITE-782
> URL: https://issues.apache.org/jira/browse/MSITE-782
> Project: Maven Site Plugin
>  Issue Type: Bug
>Affects Versions: 3.5, 3.5.1
>Reporter: Bernardo
>
> Since the version 3.5 any skin using custom velocity tools is no longer 
> working.
> This can be seen on the Reflow maven skin, and also on my own skin, which was 
> developed from the Reflow one.
> The Reflow skin, along its Velocity tools, can be found here:
> https://github.com/andriusvelykis/reflow-maven-skin
> My Maven skin can be found here:
> https://github.com/Bernardo-MG/docs-maven-skin
> My custom velocity tools:
> https://github.com/Bernardo-MG/maven-site-fixer
> All these projects are available through Maven central, making them easy to 
> test.
> To see this problem just use the Reflow skin, which won't print the content 
> of any page. In the case of my own skin, there will be several errors in the 
> HTML code, the most visible being the broken headers.
> It may be actually a Doxia problem, related to this issue:
> https://issues.apache.org/jira/browse/DOXIASITETOOLS-93
> Additionally, there is a related link commenting this problem:
> http://maven.40175.n5.nabble.com/New-maven-site-and-doxia-with-custom-velocity-doxia-td5865376.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)