[jira] [Commented] (MSITE-788) Remove menu items link in the side bar to sub module that do not generate any site in the same build.
[ https://issues.apache.org/jira/browse/MSITE-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120483#comment-17120483 ] Elliotte Rusty Harold commented on MSITE-788: - Nikolas, I agree with you. Sorry if that wasn't clear. I was objecting to the addition of a configuration option to control this behavior. There should be no need to configure anything. This should just work. > Remove menu items link in the side bar to sub module that do not generate any > site in the same build. > - > > Key: MSITE-788 > URL: https://issues.apache.org/jira/browse/MSITE-788 > Project: Maven Site Plugin > Issue Type: Bug > Components: site:run >Affects Versions: 3.6 > Environment: Windows7, Maven 3.3.9 >Reporter: Nikolas Falco >Priority: Major > > We have some multi-module projects where a few modules are only for scope > distribution or for integration test. > These modules are marked with maven.site.skip=true and the site is not > generated, but in the maven site of parent project they appear in the sidebar > menu, clearly if you click on those links are broken. > Debugging the code, the mojo loop on each project in the reactor build and > add as menu item. > Is possible add a configuration element of maven-site-plugin to exclude some > modules from the modules report menu? or implement a check if a site for that > project exists? > org.example > |- module1 > |- module2 > |- module.test (skip generation) > |- distribution (skip generation) > the maven site of org.example have in the menu bar links to no available site > of distribution and module.test -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSITE-788) Remove menu items link in the side bar to sub module that do not generate any site in the same build.
[ https://issues.apache.org/jira/browse/MSITE-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120481#comment-17120481 ] Nikolas Falco commented on MSITE-788: - > Just don't include the 404 links. This mean customize the index menu file every time I add or remove a module. I was asking to do not create a link for skipped modules > Remove menu items link in the side bar to sub module that do not generate any > site in the same build. > - > > Key: MSITE-788 > URL: https://issues.apache.org/jira/browse/MSITE-788 > Project: Maven Site Plugin > Issue Type: Bug > Components: site:run >Affects Versions: 3.6 > Environment: Windows7, Maven 3.3.9 >Reporter: Nikolas Falco >Priority: Major > > We have some multi-module projects where a few modules are only for scope > distribution or for integration test. > These modules are marked with maven.site.skip=true and the site is not > generated, but in the maven site of parent project they appear in the sidebar > menu, clearly if you click on those links are broken. > Debugging the code, the mojo loop on each project in the reactor build and > add as menu item. > Is possible add a configuration element of maven-site-plugin to exclude some > modules from the modules report menu? or implement a check if a site for that > project exists? > org.example > |- module1 > |- module2 > |- module.test (skip generation) > |- distribution (skip generation) > the maven site of org.example have in the menu bar links to no available site > of distribution and module.test -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSITE-788) Remove menu items link in the side bar to sub module that do not generate any site in the same build.
[ https://issues.apache.org/jira/browse/MSITE-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117982#comment-17117982 ] Michael Osipov commented on MSITE-788: -- Agree with [~elharo]. > Remove menu items link in the side bar to sub module that do not generate any > site in the same build. > - > > Key: MSITE-788 > URL: https://issues.apache.org/jira/browse/MSITE-788 > Project: Maven Site Plugin > Issue Type: Bug > Components: site:run >Affects Versions: 3.6 > Environment: Windows7, Maven 3.3.9 >Reporter: Nikolas Falco >Priority: Major > > We have some multi-module projects where a few modules are only for scope > distribution or for integration test. > These modules are marked with maven.site.skip=true and the site is not > generated, but in the maven site of parent project they appear in the sidebar > menu, clearly if you click on those links are broken. > Debugging the code, the mojo loop on each project in the reactor build and > add as menu item. > Is possible add a configuration element of maven-site-plugin to exclude some > modules from the modules report menu? or implement a check if a site for that > project exists? > org.example > |- module1 > |- module2 > |- module.test (skip generation) > |- distribution (skip generation) > the maven site of org.example have in the menu bar links to no available site > of distribution and module.test -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSITE-788) Remove menu items link in the side bar to sub module that do not generate any site in the same build.
[ https://issues.apache.org/jira/browse/MSITE-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117969#comment-17117969 ] Elliotte Rusty Harold commented on MSITE-788: - This should absolutely not be a configuration option. We have too many of those already. Just don't include the 404 links. > Remove menu items link in the side bar to sub module that do not generate any > site in the same build. > - > > Key: MSITE-788 > URL: https://issues.apache.org/jira/browse/MSITE-788 > Project: Maven Site Plugin > Issue Type: Bug > Components: site:run >Affects Versions: 3.6 > Environment: Windows7, Maven 3.3.9 >Reporter: Nikolas Falco >Priority: Major > > We have some multi-module projects where a few modules are only for scope > distribution or for integration test. > These modules are marked with maven.site.skip=true and the site is not > generated, but in the maven site of parent project they appear in the sidebar > menu, clearly if you click on those links are broken. > Debugging the code, the mojo loop on each project in the reactor build and > add as menu item. > Is possible add a configuration element of maven-site-plugin to exclude some > modules from the modules report menu? or implement a check if a site for that > project exists? > org.example > |- module1 > |- module2 > |- module.test (skip generation) > |- distribution (skip generation) > the maven site of org.example have in the menu bar links to no available site > of distribution and module.test -- This message was sent by Atlassian Jira (v8.3.4#803005)
