[jira] [Commented] (MSKINS-137) Enable "Hamburger menu" with top-nav only
[ https://issues.apache.org/jira/browse/MSKINS-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833921#comment-16833921 ] Josh Elser commented on MSKINS-137: --- Thanks Hervé and Sylwester! > Enable "Hamburger menu" with top-nav only > - > > Key: MSKINS-137 > URL: https://issues.apache.org/jira/browse/MSKINS-137 > Project: Maven Skins > Issue Type: Improvement >Reporter: Josh Elser >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: fluido-1.8 > > Time Spent: 10m > Remaining Estimate: 0h > > Revitalizing this old PR https://github.com/apache/maven-skins/pull/4 > Still an issue for us down in HBase. Changes seem to apply and have worked in > local testing on the HBase site. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSKINS-137) Enable "Hamburger menu" with top-nav only
[ https://issues.apache.org/jira/browse/MSKINS-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833370#comment-16833370 ] Hervé Boutemy commented on MSKINS-137: -- merged in https://github.com/apache/maven-fluido-skin/commit/ec4b18a33ed4212761c05aa077a54797f25d0652 > Enable "Hamburger menu" with top-nav only > - > > Key: MSKINS-137 > URL: https://issues.apache.org/jira/browse/MSKINS-137 > Project: Maven Skins > Issue Type: Improvement >Reporter: Josh Elser >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: fluido-1.8 > > Time Spent: 10m > Remaining Estimate: 0h > > Revitalizing this old PR https://github.com/apache/maven-skins/pull/4 > Still an issue for us down in HBase. Changes seem to apply and have worked in > local testing on the HBase site. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSKINS-137) Enable "Hamburger menu" with top-nav only
[ https://issues.apache.org/jira/browse/MSKINS-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593825#comment-16593825 ] ASF GitHub Bot commented on MSKINS-137: --- joshelser commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena… URL: https://github.com/apache/maven-fluido-skin/pull/1#issuecomment-416265843 Let me try to do that today. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable "Hamburger menu" with top-nav only > - > > Key: MSKINS-137 > URL: https://issues.apache.org/jira/browse/MSKINS-137 > Project: Maven Skins > Issue Type: Improvement >Reporter: Josh Elser >Priority: Major > > Revitalizing this old PR https://github.com/apache/maven-skins/pull/4 > Still an issue for us down in HBase. Changes seem to apply and have worked in > local testing on the HBase site. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSKINS-137) Enable "Hamburger menu" with top-nav only
[ https://issues.apache.org/jira/browse/MSKINS-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592705#comment-16592705 ] ASF GitHub Bot commented on MSKINS-137: --- michael-o commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena… URL: https://github.com/apache/maven-fluido-skin/pull/1#issuecomment-415996525 Cam someone rebase this? I will review and merge then. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable "Hamburger menu" with top-nav only > - > > Key: MSKINS-137 > URL: https://issues.apache.org/jira/browse/MSKINS-137 > Project: Maven Skins > Issue Type: Improvement >Reporter: Josh Elser >Priority: Major > > Revitalizing this old PR https://github.com/apache/maven-skins/pull/4 > Still an issue for us down in HBase. Changes seem to apply and have worked in > local testing on the HBase site. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSKINS-137) Enable "Hamburger menu" with top-nav only
[ https://issues.apache.org/jira/browse/MSKINS-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573748#comment-16573748 ] ASF GitHub Bot commented on MSKINS-137: --- busbey commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena… URL: https://github.com/apache/maven-fluido-skin/pull/1#issuecomment-411526297 yes, still valid. the Apache HBase project continues to work to maintain a fork of the maven-fluido-skin project entirely due to our need for this one change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable "Hamburger menu" with top-nav only > - > > Key: MSKINS-137 > URL: https://issues.apache.org/jira/browse/MSKINS-137 > Project: Maven Skins > Issue Type: Improvement >Reporter: Josh Elser >Priority: Major > > Revitalizing this old PR https://github.com/apache/maven-skins/pull/4 > Still an issue for us down in HBase. Changes seem to apply and have worked in > local testing on the HBase site. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSKINS-137) Enable "Hamburger menu" with top-nav only
[ https://issues.apache.org/jira/browse/MSKINS-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499375#comment-16499375 ] ASF GitHub Bot commented on MSKINS-137: --- michael-o commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena… URL: https://github.com/apache/maven-fluido-skin/pull/1#issuecomment-394155597 Is this one still valid? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable "Hamburger menu" with top-nav only > - > > Key: MSKINS-137 > URL: https://issues.apache.org/jira/browse/MSKINS-137 > Project: Maven Skins > Issue Type: Improvement >Reporter: Josh Elser >Priority: Major > > Revitalizing this old PR https://github.com/apache/maven-skins/pull/4 > Still an issue for us down in HBase. Changes seem to apply and have worked in > local testing on the HBase site. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSKINS-137) Enable "Hamburger menu" with top-nav only
[ https://issues.apache.org/jira/browse/MSKINS-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244526#comment-16244526 ] ASF GitHub Bot commented on MSKINS-137: --- joshelser commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena… URL: https://github.com/apache/maven-fluido-skin/pull/1#issuecomment-342918748 > To test, I understand that any rendering of the skin with a nav bar in a little screen should be used: we already have a few when running "mvn -Prun-its verify" Great. Will take a look. > But with the patch applied, there is a space added before the topbar: to me, the patch breaks topbar positionning. Yeah, I did have to tweak some CSS down in HBase. I assumed that was something we were doing down there -- will have to circle around and see if I can make the equivalent change here instead :) > Please share a screenshot of the issue you get in hbase, then the result once the patch fixes the issue Acknowledged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable "Hamburger menu" with top-nav only > - > > Key: MSKINS-137 > URL: https://issues.apache.org/jira/browse/MSKINS-137 > Project: Maven Skins > Issue Type: Improvement >Reporter: Josh Elser > > Revitalizing this old PR https://github.com/apache/maven-skins/pull/4 > Still an issue for us down in HBase. Changes seem to apply and have worked in > local testing on the HBase site. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MSKINS-137) Enable "Hamburger menu" with top-nav only
[ https://issues.apache.org/jira/browse/MSKINS-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244496#comment-16244496 ] ASF GitHub Bot commented on MSKINS-137: --- hboutemy commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena… URL: https://github.com/apache/maven-fluido-skin/pull/1#issuecomment-342916660 thanks fo the explanation: now I know what a hamburger menu is :) To test, I understand that any rendering of the skin with a nav bar in a little screen should be used: we already have a few when running "mvn -Prun-its verify" Then I checked hbase site: the hamburger menu was perfect. But with the patch applied, there is a space added before the topbar: to me, the patch breaks topbar positionning. Please share a screenshot of the issue you get in hbase, then the result once the patch fixes the issue This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable "Hamburger menu" with top-nav only > - > > Key: MSKINS-137 > URL: https://issues.apache.org/jira/browse/MSKINS-137 > Project: Maven Skins > Issue Type: Improvement >Reporter: Josh Elser > > Revitalizing this old PR https://github.com/apache/maven-skins/pull/4 > Still an issue for us down in HBase. Changes seem to apply and have worked in > local testing on the HBase site. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MSKINS-137) Enable "Hamburger menu" with top-nav only
[ https://issues.apache.org/jira/browse/MSKINS-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244330#comment-16244330 ] ASF GitHub Bot commented on MSKINS-137: --- joshelser commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena… URL: https://github.com/apache/maven-fluido-skin/pull/1#issuecomment-342886972 Thanks, Hervé! > But I don't understand what this change does: can you describe a little bit the issue (what a "hamburger menu" is)? See https://en.wikipedia.org/wiki/Hamburger_button for starters :). If you visit https://hbase.apache.org/ on your mobile or shrink down the page in a browser, you'll see the nav-bar at the top of the page convert into a drop-down with the "stacked-lines" (hamburger) button to open/close it. > Is there one existing IT that show clearly the issue (then the fix)? Admittedly, I didn't look at all into how to test :D. Have any pointers/docs/suggestions on what kind of test would be effective? > Sidenote: this is a generic topic with Skins, ie understanding html/css changes. Any generic idea on how to describe an issue and a fix, between "designer oriented" people (who are html/css experts) and "java dev" oriented people (like Maven developpers, like me, who is not proficient at all with modern html/css, who need to judge before merging...) Ditto. CSS has changed drastically since I've done anything of consequence with it :D. I'm mostly repurposing Misty's original commit here. My general understanding is that bootstrap is doing some special logic when the "window" (or maybe screen is more appropriate) reduces to a certain size. Then it uses some CSS rules to convert the content into the dynamic drop-down instead of how it appears on screens with adequate width. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable "Hamburger menu" with top-nav only > - > > Key: MSKINS-137 > URL: https://issues.apache.org/jira/browse/MSKINS-137 > Project: Maven Skins > Issue Type: Improvement >Reporter: Josh Elser > > Revitalizing this old PR https://github.com/apache/maven-skins/pull/4 > Still an issue for us down in HBase. Changes seem to apply and have worked in > local testing on the HBase site. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MSKINS-137) Enable "Hamburger menu" with top-nav only
[ https://issues.apache.org/jira/browse/MSKINS-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243451#comment-16243451 ] ASF GitHub Bot commented on MSKINS-137: --- hboutemy commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena… URL: https://github.com/apache/maven-fluido-skin/pull/1#issuecomment-342725018 Hi Josh, Thank you for your help: I'm very interested to merge. But I don't understand what this change does: can you describe a little bit the issue (what a "hamburger menu" is)? Is there one existing IT that show clearly the issue (then the fix)? Sidenote: this is a generic topic with Skins, ie understanding html/css changes. Any generic idea on how to describe an issue and a fix, between "designer oriented" people (who are html/css experts) and "java dev" oriented people (like Maven developpers, like me, who is not proficient at all with modern html/css, who need to judge before merging...) At least, I'm happy that Git migration already has given one great result: more effective discussion on PRs Regards, Hervé This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable "Hamburger menu" with top-nav only > - > > Key: MSKINS-137 > URL: https://issues.apache.org/jira/browse/MSKINS-137 > Project: Maven Skins > Issue Type: Improvement >Reporter: Josh Elser > > Revitalizing this old PR https://github.com/apache/maven-skins/pull/4 > Still an issue for us down in HBase. Changes seem to apply and have worked in > local testing on the HBase site. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MSKINS-137) Enable "Hamburger menu" with top-nav only
[ https://issues.apache.org/jira/browse/MSKINS-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243452#comment-16243452 ] ASF GitHub Bot commented on MSKINS-137: --- hboutemy commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena… URL: https://github.com/apache/maven-fluido-skin/pull/1#issuecomment-342725018 Hi Josh, Thank you for your help: I'm very interested to merge. But I don't understand what this change does: can you describe a little bit the issue (what a "hamburger menu" is)? Is there one existing IT that show clearly the issue (then the fix)? Sidenote: this is a generic topic with Skins, ie understanding html/css changes. Any generic idea on how to describe an issue and a fix, between "designer oriented" people (who are html/css experts) and "java dev" oriented people (like Maven developpers, like me, who is not proficient at all with modern html/css, who need to judge before merging...) At least, I'm happy that Git migration already has given one great result: more effective discussion on PRs (I could easily merge the PR locally and run the ITs, but did not find where to look for improved "hamburger menus"... :) ) Regards, Hervé This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable "Hamburger menu" with top-nav only > - > > Key: MSKINS-137 > URL: https://issues.apache.org/jira/browse/MSKINS-137 > Project: Maven Skins > Issue Type: Improvement >Reporter: Josh Elser > > Revitalizing this old PR https://github.com/apache/maven-skins/pull/4 > Still an issue for us down in HBase. Changes seem to apply and have worked in > local testing on the HBase site. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MSKINS-137) Enable "Hamburger menu" with top-nav only
[ https://issues.apache.org/jira/browse/MSKINS-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243449#comment-16243449 ] ASF GitHub Bot commented on MSKINS-137: --- hboutemy commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena… URL: https://github.com/apache/maven-fluido-skin/pull/1#issuecomment-342725018 Hi Josh, Thank you for your help: I'm very interested to merge. But I don't understand what this change does: can you describe a little bit the issue (what a "hamburger menu" is)? Is there one existing IT that show clearly the issue (then the fix)? Sidenote: this is a generic topic with Skins, ie understanding html/css changes. Any generic idea on how to describe an issue and a fix, between "designer oriented" people (who are html/css experts) and "java dev" oriented people (like Maven developpers, like me, who is not proficient at all with modern html/css, who need to judge before merging...) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable "Hamburger menu" with top-nav only > - > > Key: MSKINS-137 > URL: https://issues.apache.org/jira/browse/MSKINS-137 > Project: Maven Skins > Issue Type: Improvement >Reporter: Josh Elser > > Revitalizing this old PR https://github.com/apache/maven-skins/pull/4 > Still an issue for us down in HBase. Changes seem to apply and have worked in > local testing on the HBase site. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MSKINS-137) Enable "Hamburger menu" with top-nav only
[ https://issues.apache.org/jira/browse/MSKINS-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242760#comment-16242760 ] ASF GitHub Bot commented on MSKINS-137: --- joshelser commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena… URL: https://github.com/apache/maven-fluido-skin/pull/1#issuecomment-342601761 Old (unsubmitted) PR was apache/maven-skins#4 for those interested in the lineage. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable "Hamburger menu" with top-nav only > - > > Key: MSKINS-137 > URL: https://issues.apache.org/jira/browse/MSKINS-137 > Project: Maven Skins > Issue Type: Improvement >Reporter: Josh Elser > > Revitalizing this old PR https://github.com/apache/maven-skins/pull/4 > Still an issue for us down in HBase. Changes seem to apply and have worked in > local testing on the HBase site. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MSKINS-137) Enable "Hamburger menu" with top-nav only
[ https://issues.apache.org/jira/browse/MSKINS-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242757#comment-16242757 ] ASF GitHub Bot commented on MSKINS-137: --- joshelser opened a new pull request #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena… URL: https://github.com/apache/maven-fluido-skin/pull/1 …bled and sidebar-navigation disabled Original work done in https://github.com/apache/maven-skins/pull/4/commits/f559695b03826158eb302e60b40d4924f28a8bf4 by Misty. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable "Hamburger menu" with top-nav only > - > > Key: MSKINS-137 > URL: https://issues.apache.org/jira/browse/MSKINS-137 > Project: Maven Skins > Issue Type: Improvement >Reporter: Josh Elser > > Revitalizing this old PR https://github.com/apache/maven-skins/pull/4 > Still an issue for us down in HBase. Changes seem to apply and have worked in > local testing on the HBase site. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
