[jira] [Commented] (SUREFIRE-1278) TestNG tests are run with group name that ends with specified group
[
https://issues.apache.org/jira/browse/SUREFIRE-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15503444#comment-15503444
]
ASF GitHub Bot commented on SUREFIRE-1278:
--
Github user khospodarysko closed the pull request at:
https://github.com/apache/maven-surefire/pull/121
> TestNG tests are run with group name that ends with specified group
>
>
> Key: SUREFIRE-1278
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1278
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
> Environment: OS X El Capitan 10.11.6
> TestNG 6.9.10
>Reporter: Kostya Hospodarysko
>Assignee: Tibor Digana
> Fix For: 2.19.2
>
> Attachments: testng-groups.zip
>
>
> h4.Preconditions:
> There is a simple TestNG class with two methods so that 1st method has group
> "group" and 2nd has group "apigroup".
> h4.Steps to reproduce:
> Run tests with command:
> {noformat}
> mvn clean test -Dgroups=group
> {noformat}
> {color:red}h4.Actual:{color}
> Both tests are run.
> {color:green}h4.Expected:{color}
> Only method with group "group" is run.
> Demo project could be found here:
> https://github.com/khospodarysko/testng-groups.
> Looks like the issue is in GroupMatcherMethodSelector as looking at
> includeMethod it is seen that is always returns true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1278) TestNG tests are run with group name that ends with specified group
[
https://issues.apache.org/jira/browse/SUREFIRE-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15501635#comment-15501635
]
ASF GitHub Bot commented on SUREFIRE-1278:
--
Github user khospodarysko commented on the issue:
https://github.com/apache/maven-surefire/pull/121
@Tibor17 No, I haven't. This is my first such patch. I'm happy it added
more quality to the product!
> TestNG tests are run with group name that ends with specified group
>
>
> Key: SUREFIRE-1278
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1278
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
> Environment: OS X El Capitan 10.11.6
> TestNG 6.9.10
>Reporter: Kostya Hospodarysko
>Assignee: Tibor Digana
> Fix For: 2.19.2
>
> Attachments: testng-groups.zip
>
>
> h4.Preconditions:
> There is a simple TestNG class with two methods so that 1st method has group
> "group" and 2nd has group "apigroup".
> h4.Steps to reproduce:
> Run tests with command:
> {noformat}
> mvn clean test -Dgroups=group
> {noformat}
> {color:red}h4.Actual:{color}
> Both tests are run.
> {color:green}h4.Expected:{color}
> Only method with group "group" is run.
> Demo project could be found here:
> https://github.com/khospodarysko/testng-groups.
> Looks like the issue is in GroupMatcherMethodSelector as looking at
> includeMethod it is seen that is always returns true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1278) TestNG tests are run with group name that ends with specified group
[
https://issues.apache.org/jira/browse/SUREFIRE-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15501584#comment-15501584
]
ASF GitHub Bot commented on SUREFIRE-1278:
--
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/121
@khospodarysko CI build was successful. This should be normally closed
automatically and sometimes it takes a day but you can close it as well.
Thank you for contributing.
Have you contributed to Maven in more previous pull-requests?
> TestNG tests are run with group name that ends with specified group
>
>
> Key: SUREFIRE-1278
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1278
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
> Environment: OS X El Capitan 10.11.6
> TestNG 6.9.10
>Reporter: Kostya Hospodarysko
>Assignee: Tibor Digana
> Fix For: 2.19.2
>
> Attachments: testng-groups.zip
>
>
> h4.Preconditions:
> There is a simple TestNG class with two methods so that 1st method has group
> "group" and 2nd has group "apigroup".
> h4.Steps to reproduce:
> Run tests with command:
> {noformat}
> mvn clean test -Dgroups=group
> {noformat}
> {color:red}h4.Actual:{color}
> Both tests are run.
> {color:green}h4.Expected:{color}
> Only method with group "group" is run.
> Demo project could be found here:
> https://github.com/khospodarysko/testng-groups.
> Looks like the issue is in GroupMatcherMethodSelector as looking at
> includeMethod it is seen that is always returns true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1278) TestNG tests are run with group name that ends with specified group
[
https://issues.apache.org/jira/browse/SUREFIRE-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15501548#comment-15501548
]
Hudson commented on SUREFIRE-1278:
--
SUCCESS: Integrated in Jenkins build maven-surefire #1617 (See
[https://builds.apache.org/job/maven-surefire/1617/])
Fix for SUREFIRE-1278 - TestNG tests are run with group name that ends
(tibor17: rev ae6337ea216b867e76e951e09951e475ed105d06)
* (add)
surefire-integration-tests/src/test/resources/surefire-1278-group-name-ending/pom.xml
* (edit)
surefire-grouper/src/main/java/org/apache/maven/surefire/group/match/SingleGroupMatcher.java
* (add)
surefire-integration-tests/src/test/resources/surefire-1278-group-name-ending/src/test/java/pkg/ATest.java
Fix for SUREFIRE-1278 - TestNG tests are run with group name that ends
(tibor17: rev bab3175e8388b675e1e56814d3b1a5aa25ae250a)
* (add)
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1278GroupNameEndingIT.java
> TestNG tests are run with group name that ends with specified group
>
>
> Key: SUREFIRE-1278
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1278
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
> Environment: OS X El Capitan 10.11.6
> TestNG 6.9.10
>Reporter: Kostya Hospodarysko
>Assignee: Tibor Digana
> Fix For: 2.19.2
>
> Attachments: testng-groups.zip
>
>
> h4.Preconditions:
> There is a simple TestNG class with two methods so that 1st method has group
> "group" and 2nd has group "apigroup".
> h4.Steps to reproduce:
> Run tests with command:
> {noformat}
> mvn clean test -Dgroups=group
> {noformat}
> {color:red}h4.Actual:{color}
> Both tests are run.
> {color:green}h4.Expected:{color}
> Only method with group "group" is run.
> Demo project could be found here:
> https://github.com/khospodarysko/testng-groups.
> Looks like the issue is in GroupMatcherMethodSelector as looking at
> includeMethod it is seen that is always returns true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1278) TestNG tests are run with group name that ends with specified group
[
https://issues.apache.org/jira/browse/SUREFIRE-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15501477#comment-15501477
]
ASF GitHub Bot commented on SUREFIRE-1278:
--
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/121
LGTM.
> TestNG tests are run with group name that ends with specified group
>
>
> Key: SUREFIRE-1278
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1278
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
> Environment: OS X El Capitan 10.11.6
> TestNG 6.9.10
>Reporter: Kostya Hospodarysko
>Assignee: Tibor Digana
> Fix For: 2.19.2
>
> Attachments: testng-groups.zip
>
>
> h4.Preconditions:
> There is a simple TestNG class with two methods so that 1st method has group
> "group" and 2nd has group "apigroup".
> h4.Steps to reproduce:
> Run tests with command:
> {noformat}
> mvn clean test -Dgroups=group
> {noformat}
> {color:red}h4.Actual:{color}
> Both tests are run.
> {color:green}h4.Expected:{color}
> Only method with group "group" is run.
> Demo project could be found here:
> https://github.com/khospodarysko/testng-groups.
> Looks like the issue is in GroupMatcherMethodSelector as looking at
> includeMethod it is seen that is always returns true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1278) TestNG tests are run with group name that ends with specified group
[
https://issues.apache.org/jira/browse/SUREFIRE-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15501461#comment-15501461
]
ASF GitHub Bot commented on SUREFIRE-1278:
--
Github user khospodarysko commented on the issue:
https://github.com/apache/maven-surefire/pull/121
Followed the analogy and added
org.apache.maven.surefire.its.jiras.Surefire1278GroupNameEndingIT to
src/test/java folder.
Please let me know if something else is wrong and I'll try to fix it asap.
> TestNG tests are run with group name that ends with specified group
>
>
> Key: SUREFIRE-1278
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1278
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
> Environment: OS X El Capitan 10.11.6
> TestNG 6.9.10
>Reporter: Kostya Hospodarysko
>Assignee: Tibor Digana
> Fix For: 2.19.2
>
> Attachments: testng-groups.zip
>
>
> h4.Preconditions:
> There is a simple TestNG class with two methods so that 1st method has group
> "group" and 2nd has group "apigroup".
> h4.Steps to reproduce:
> Run tests with command:
> {noformat}
> mvn clean test -Dgroups=group
> {noformat}
> {color:red}h4.Actual:{color}
> Both tests are run.
> {color:green}h4.Expected:{color}
> Only method with group "group" is run.
> Demo project could be found here:
> https://github.com/khospodarysko/testng-groups.
> Looks like the issue is in GroupMatcherMethodSelector as looking at
> includeMethod it is seen that is always returns true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1278) TestNG tests are run with group name that ends with specified group
[
https://issues.apache.org/jira/browse/SUREFIRE-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15501359#comment-15501359
]
ASF GitHub Bot commented on SUREFIRE-1278:
--
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/121
@khospodarysko Do you have it in *.bak file or in bytecode in
/target/classes?
> TestNG tests are run with group name that ends with specified group
>
>
> Key: SUREFIRE-1278
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1278
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
> Environment: OS X El Capitan 10.11.6
> TestNG 6.9.10
>Reporter: Kostya Hospodarysko
>Assignee: Tibor Digana
> Fix For: 2.19.2
>
> Attachments: testng-groups.zip
>
>
> h4.Preconditions:
> There is a simple TestNG class with two methods so that 1st method has group
> "group" and 2nd has group "apigroup".
> h4.Steps to reproduce:
> Run tests with command:
> {noformat}
> mvn clean test -Dgroups=group
> {noformat}
> {color:red}h4.Actual:{color}
> Both tests are run.
> {color:green}h4.Expected:{color}
> Only method with group "group" is run.
> Demo project could be found here:
> https://github.com/khospodarysko/testng-groups.
> Looks like the issue is in GroupMatcherMethodSelector as looking at
> includeMethod it is seen that is always returns true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1278) TestNG tests are run with group name that ends with specified group
[
https://issues.apache.org/jira/browse/SUREFIRE-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15501356#comment-15501356
]
ASF GitHub Bot commented on SUREFIRE-1278:
--
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/121
@khospodarysko Something wrong happened. The IT class is missing.
> TestNG tests are run with group name that ends with specified group
>
>
> Key: SUREFIRE-1278
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1278
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
> Environment: OS X El Capitan 10.11.6
> TestNG 6.9.10
>Reporter: Kostya Hospodarysko
>Assignee: Tibor Digana
> Fix For: 2.19.2
>
> Attachments: testng-groups.zip
>
>
> h4.Preconditions:
> There is a simple TestNG class with two methods so that 1st method has group
> "group" and 2nd has group "apigroup".
> h4.Steps to reproduce:
> Run tests with command:
> {noformat}
> mvn clean test -Dgroups=group
> {noformat}
> {color:red}h4.Actual:{color}
> Both tests are run.
> {color:green}h4.Expected:{color}
> Only method with group "group" is run.
> Demo project could be found here:
> https://github.com/khospodarysko/testng-groups.
> Looks like the issue is in GroupMatcherMethodSelector as looking at
> includeMethod it is seen that is always returns true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1278) TestNG tests are run with group name that ends with specified group
[
https://issues.apache.org/jira/browse/SUREFIRE-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15500273#comment-15500273
]
ASF GitHub Bot commented on SUREFIRE-1278:
--
Github user khospodarysko commented on the issue:
https://github.com/apache/maven-surefire/pull/121
Squashed.
> TestNG tests are run with group name that ends with specified group
>
>
> Key: SUREFIRE-1278
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1278
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
> Environment: OS X El Capitan 10.11.6
> TestNG 6.9.10
>Reporter: Kostya Hospodarysko
>Assignee: Tibor Digana
> Fix For: 2.19.2
>
> Attachments: testng-groups.zip
>
>
> h4.Preconditions:
> There is a simple TestNG class with two methods so that 1st method has group
> "group" and 2nd has group "apigroup".
> h4.Steps to reproduce:
> Run tests with command:
> {noformat}
> mvn clean test -Dgroups=group
> {noformat}
> {color:red}h4.Actual:{color}
> Both tests are run.
> {color:green}h4.Expected:{color}
> Only method with group "group" is run.
> Demo project could be found here:
> https://github.com/khospodarysko/testng-groups.
> Looks like the issue is in GroupMatcherMethodSelector as looking at
> includeMethod it is seen that is always returns true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1278) TestNG tests are run with group name that ends with specified group
[
https://issues.apache.org/jira/browse/SUREFIRE-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15497084#comment-15497084
]
ASF GitHub Bot commented on SUREFIRE-1278:
--
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/121
@khospodarysko Can you squash two commits to one single commit?
> TestNG tests are run with group name that ends with specified group
>
>
> Key: SUREFIRE-1278
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1278
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
> Environment: OS X El Capitan 10.11.6
> TestNG 6.9.10
>Reporter: Kostya Hospodarysko
>Assignee: Tibor Digana
> Attachments: testng-groups.zip
>
>
> h4.Preconditions:
> There is a simple TestNG class with two methods so that 1st method has group
> "group" and 2nd has group "apigroup".
> h4.Steps to reproduce:
> Run tests with command:
> {noformat}
> mvn clean test -Dgroups=group
> {noformat}
> {color:red}h4.Actual:{color}
> Both tests are run.
> {color:green}h4.Expected:{color}
> Only method with group "group" is run.
> Demo project could be found here:
> https://github.com/khospodarysko/testng-groups.
> Looks like the issue is in GroupMatcherMethodSelector as looking at
> includeMethod it is seen that is always returns true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1278) TestNG tests are run with group name that ends with specified group
[
https://issues.apache.org/jira/browse/SUREFIRE-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15496262#comment-15496262
]
ASF GitHub Bot commented on SUREFIRE-1278:
--
Github user khospodarysko commented on the issue:
https://github.com/apache/maven-surefire/pull/121
Btw did not receive a failures after:
mvn -Prun-its clean install
or
mvn clean install
> TestNG tests are run with group name that ends with specified group
>
>
> Key: SUREFIRE-1278
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1278
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
> Environment: OS X El Capitan 10.11.6
> TestNG 6.9.10
>Reporter: Kostya Hospodarysko
>Assignee: Tibor Digana
> Attachments: testng-groups.zip
>
>
> h4.Preconditions:
> There is a simple TestNG class with two methods so that 1st method has group
> "group" and 2nd has group "apigroup".
> h4.Steps to reproduce:
> Run tests with command:
> {noformat}
> mvn clean test -Dgroups=group
> {noformat}
> {color:red}h4.Actual:{color}
> Both tests are run.
> {color:green}h4.Expected:{color}
> Only method with group "group" is run.
> Demo project could be found here:
> https://github.com/khospodarysko/testng-groups.
> Looks like the issue is in GroupMatcherMethodSelector as looking at
> includeMethod it is seen that is always returns true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1278) TestNG tests are run with group name that ends with specified group
[
https://issues.apache.org/jira/browse/SUREFIRE-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15495779#comment-15495779
]
Kostya Hospodarysko commented on SUREFIRE-1278:
---
Create a pull request https://github.com/apache/maven-surefire/pull/121.
> TestNG tests are run with group name that ends with specified group
>
>
> Key: SUREFIRE-1278
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1278
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
> Environment: OS X El Capitan 10.11.6
> TestNG 6.9.10
>Reporter: Kostya Hospodarysko
>Assignee: Tibor Digana
> Attachments: testng-groups.zip
>
>
> h4.Preconditions:
> There is a simple TestNG class with two methods so that 1st method has group
> "group" and 2nd has group "apigroup".
> h4.Steps to reproduce:
> Run tests with command:
> {noformat}
> mvn clean test -Dgroups=group
> {noformat}
> {color:red}h4.Actual:{color}
> Both tests are run.
> {color:green}h4.Expected:{color}
> Only method with group "group" is run.
> Demo project could be found here:
> https://github.com/khospodarysko/testng-groups.
> Looks like the issue is in GroupMatcherMethodSelector as looking at
> includeMethod it is seen that is always returns true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1278) TestNG tests are run with group name that ends with specified group
[
https://issues.apache.org/jira/browse/SUREFIRE-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15495776#comment-15495776
]
ASF GitHub Bot commented on SUREFIRE-1278:
--
GitHub user khospodarysko opened a pull request:
https://github.com/apache/maven-surefire/pull/121
Fix for issue SUREFIRE-1278
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khospodarysko/maven-surefire master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-surefire/pull/121.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #121
commit bbe5dd237a2b1ba1a353bb51361d35dfa5996733
Author: Kostya Hospodarysko
Date: 2016-09-15T22:08:42Z
Fix for SUREFIRE-1278 - TestNG tests are run with group name that ends with
specified group.
commit 16bfc7c93f697b7a50ef2b041ba7e000754049c7
Author: Kostya Hospodarysko
Date: 2016-09-16T07:36:34Z
Configured pom.xml to run only group "group" in order to show the issue.
> TestNG tests are run with group name that ends with specified group
>
>
> Key: SUREFIRE-1278
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1278
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
> Environment: OS X El Capitan 10.11.6
> TestNG 6.9.10
>Reporter: Kostya Hospodarysko
>Assignee: Tibor Digana
> Attachments: testng-groups.zip
>
>
> h4.Preconditions:
> There is a simple TestNG class with two methods so that 1st method has group
> "group" and 2nd has group "apigroup".
> h4.Steps to reproduce:
> Run tests with command:
> {noformat}
> mvn clean test -Dgroups=group
> {noformat}
> {color:red}h4.Actual:{color}
> Both tests are run.
> {color:green}h4.Expected:{color}
> Only method with group "group" is run.
> Demo project could be found here:
> https://github.com/khospodarysko/testng-groups.
> Looks like the issue is in GroupMatcherMethodSelector as looking at
> includeMethod it is seen that is always returns true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1278) TestNG tests are run with group name that ends with specified group
[
https://issues.apache.org/jira/browse/SUREFIRE-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494638#comment-15494638
]
Kostya Hospodarysko commented on SUREFIRE-1278:
---
Thanks for help. Indeed it was the problem.
> TestNG tests are run with group name that ends with specified group
>
>
> Key: SUREFIRE-1278
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1278
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
> Environment: OS X El Capitan 10.11.6
> TestNG 6.9.10
>Reporter: Kostya Hospodarysko
>Assignee: Tibor Digana
> Attachments: testng-groups.zip
>
>
> h4.Preconditions:
> There is a simple TestNG class with two methods so that 1st method has group
> "group" and 2nd has group "apigroup".
> h4.Steps to reproduce:
> Run tests with command:
> {noformat}
> mvn clean test -Dgroups=group
> {noformat}
> {color:red}h4.Actual:{color}
> Both tests are run.
> {color:green}h4.Expected:{color}
> Only method with group "group" is run.
> Demo project could be found here:
> https://github.com/khospodarysko/testng-groups.
> Looks like the issue is in GroupMatcherMethodSelector as looking at
> includeMethod it is seen that is always returns true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1278) TestNG tests are run with group name that ends with specified group
[
https://issues.apache.org/jira/browse/SUREFIRE-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494146#comment-15494146
]
Guillaume Boué commented on SUREFIRE-1278:
--
It seems the issue is with the class
[{{SingleGroupMatcher}}|https://github.com/apache/maven-surefire/blob/surefire-2.19.1/surefire-grouper/src/main/java/org/apache/maven/surefire/group/match/SingleGroupMatcher.java#L117],
which determines if a given group is enabled by checking it if ends with the
configured group.
There are 2 overloads of the method, and the same "endsWith" test is done to
determine if the given category, represented as a
[{{String}}|https://github.com/apache/maven-surefire/blob/surefire-2.19.1/surefire-grouper/src/main/java/org/apache/maven/surefire/group/match/SingleGroupMatcher.java#L108]
or a
[{{Class}}|https://github.com/apache/maven-surefire/blob/surefire-2.19.1/surefire-grouper/src/main/java/org/apache/maven/surefire/group/match/SingleGroupMatcher.java#L86],
is enabled. There are test cases checking this behaviour for the {{Class...}}
overload
[here|https://github.com/apache/maven-surefire/blob/surefire-2.19.1/surefire-grouper/src/test/java/org/apache/maven/surefire/group/match/SingleGroupMatcherTest.java#L40-L44],
but not for the {{String...}} overload.
Changing this method to use {{equals}} fixes the issue and does not break any
existing test.
> TestNG tests are run with group name that ends with specified group
>
>
> Key: SUREFIRE-1278
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1278
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
> Environment: OS X El Capitan 10.11.6
> TestNG 6.9.10
>Reporter: Kostya Hospodarysko
>Assignee: Tibor Digana
> Attachments: testng-groups.zip
>
>
> h4.Preconditions:
> There is a simple TestNG class with two methods so that 1st method has group
> "group" and 2nd has group "apigroup".
> h4.Steps to reproduce:
> Run tests with command:
> {noformat}
> mvn clean test -Dgroups=group
> {noformat}
> {color:red}h4.Actual:{color}
> Both tests are run.
> {color:green}h4.Expected:{color}
> Only method with group "group" is run.
> Demo project could be found here:
> https://github.com/khospodarysko/testng-groups.
> Looks like the issue is in GroupMatcherMethodSelector as looking at
> includeMethod it is seen that is always returns true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1278) TestNG tests are run with group name that ends with specified group
[
https://issues.apache.org/jira/browse/SUREFIRE-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493601#comment-15493601
]
Kostya Hospodarysko commented on SUREFIRE-1278:
---
OK, I'll try to fix/debug in a couple of days and will make a pull request.
> TestNG tests are run with group name that ends with specified group
>
>
> Key: SUREFIRE-1278
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1278
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
> Environment: OS X El Capitan 10.11.6
> TestNG 6.9.10
>Reporter: Kostya Hospodarysko
>Assignee: Tibor Digana
> Attachments: testng-groups.zip
>
>
> h4.Preconditions:
> There is a simple TestNG class with two methods so that 1st method has group
> "group" and 2nd has group "apigroup".
> h4.Steps to reproduce:
> Run tests with command:
> {noformat}
> mvn clean test -Dgroups=group
> {noformat}
> {color:red}h4.Actual:{color}
> Both tests are run.
> {color:green}h4.Expected:{color}
> Only method with group "group" is run.
> Demo project could be found here:
> https://github.com/khospodarysko/testng-groups.
> Looks like the issue is in GroupMatcherMethodSelector as looking at
> includeMethod it is seen that is always returns true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1278) TestNG tests are run with group name that ends with specified group
[
https://issues.apache.org/jira/browse/SUREFIRE-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493560#comment-15493560
]
Tibor Digana commented on SUREFIRE-1278:
and you think the regex-based GroupMatcher is wrong?
I guess you are able to fix it in pull request in Github.
I am really preparing release. I am not sure if this is really Surefire
problem because i did not have time to dig into debugging the code.
On Thu, Sep 15, 2016 at 4:47 PM, Kostya Hospodarysko (JIRA) TestNG tests are run with group name that ends with specified group
>
>
> Key: SUREFIRE-1278
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1278
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
> Environment: OS X El Capitan 10.11.6
> TestNG 6.9.10
>Reporter: Kostya Hospodarysko
>Assignee: Tibor Digana
> Attachments: testng-groups.zip
>
>
> h4.Preconditions:
> There is a simple TestNG class with two methods so that 1st method has group
> "group" and 2nd has group "apigroup".
> h4.Steps to reproduce:
> Run tests with command:
> {noformat}
> mvn clean test -Dgroups=group
> {noformat}
> {color:red}h4.Actual:{color}
> Both tests are run.
> {color:green}h4.Expected:{color}
> Only method with group "group" is run.
> Demo project could be found here:
> https://github.com/khospodarysko/testng-groups.
> Looks like the issue is in GroupMatcherMethodSelector as looking at
> includeMethod it is seen that is always returns true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1278) TestNG tests are run with group name that ends with specified group
[
https://issues.apache.org/jira/browse/SUREFIRE-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493529#comment-15493529
]
Kostya Hospodarysko commented on SUREFIRE-1278:
---
[~tibor17] testng-groups project does not cover the case I described. There is
a method with group "abc-def". Assume that there is also a method with group
"def". So after "mvn clean test -Dgroups=def" both methods are executed but I
expect only one method with group "def" to be executed, not "abc-def".
> TestNG tests are run with group name that ends with specified group
>
>
> Key: SUREFIRE-1278
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1278
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
> Environment: OS X El Capitan 10.11.6
> TestNG 6.9.10
>Reporter: Kostya Hospodarysko
>Assignee: Tibor Digana
> Attachments: testng-groups.zip
>
>
> h4.Preconditions:
> There is a simple TestNG class with two methods so that 1st method has group
> "group" and 2nd has group "apigroup".
> h4.Steps to reproduce:
> Run tests with command:
> {noformat}
> mvn clean test -Dgroups=group
> {noformat}
> {color:red}h4.Actual:{color}
> Both tests are run.
> {color:green}h4.Expected:{color}
> Only method with group "group" is run.
> Demo project could be found here:
> https://github.com/khospodarysko/testng-groups.
> Looks like the issue is in GroupMatcherMethodSelector as looking at
> includeMethod it is seen that is always returns true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1278) TestNG tests are run with group name that ends with specified group
[
https://issues.apache.org/jira/browse/SUREFIRE-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493473#comment-15493473
]
Tibor Digana commented on SUREFIRE-1278:
For this we have integration tests
https://github.com/apache/maven-surefire/tree/master/surefire-integration-tests/src/test/resources/testng-groups
https://github.com/apache/maven-surefire/blob/master/surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/TestNgGroupsIT.java
Try to use Version 6.8.7.
> TestNG tests are run with group name that ends with specified group
>
>
> Key: SUREFIRE-1278
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1278
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
> Environment: OS X El Capitan 10.11.6
> TestNG 6.9.10
>Reporter: Kostya Hospodarysko
>Assignee: Tibor Digana
> Attachments: testng-groups.zip
>
>
> h4.Preconditions:
> There is a simple TestNG class with two methods so that 1st method has group
> "group" and 2nd has group "apigroup".
> h4.Steps to reproduce:
> Run tests with command:
> {noformat}
> mvn clean test -Dgroups=group
> {noformat}
> {color:red}h4.Actual:{color}
> Both tests are run.
> {color:green}h4.Expected:{color}
> Only method with group "group" is run.
> Demo project could be found here:
> https://github.com/khospodarysko/testng-groups.
> Looks like the issue is in GroupMatcherMethodSelector as looking at
> includeMethod it is seen that is always returns true.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
