[jira] [Commented] (WAGON-499) apache-rat complains about Eclipse .checkstyle files

2018-03-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/WAGON-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404242#comment-16404242
 ] 

ASF GitHub Bot commented on WAGON-499:
--

olamy closed pull request #43: [WAGON-499] fix apache-rat complains about 
Eclipse .checkstyle files
URL: https://github.com/apache/maven-wagon/pull/43
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.gitignore b/.gitignore
index 5eed4c10..ea247da0 100644
--- a/.gitignore
+++ b/.gitignore
@@ -7,6 +7,7 @@ target
 
 #eclipse
 .project
+.checkstyle
 .classpath
 .settings
 
diff --git a/pom.xml b/pom.xml
index 19cd18a8..6f6ded24 100644
--- a/pom.xml
+++ b/pom.xml
@@ -359,6 +359,7 @@ under the License.
   apache-rat-plugin
   
 
+  .checkstyle
   **/*.odg
   src/test/resources/**
   src/main/resources/default-server-root/**


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> apache-rat complains about Eclipse .checkstyle files
> 
>
> Key: WAGON-499
> URL: https://issues.apache.org/jira/browse/WAGON-499
> Project: Maven Wagon
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Ilya Basin
>Priority: Major
> Fix For: 3.0.1
>
>
> See RAT-246, SCM-862
> Due to my Eclipse plugins set, when I import a maven project, a .checkstyle 
> file is generated there. This breaks building maven-scm. target/rat.txt 
> mentions:
> Files with unapproved licenses:
>  .checkstyle file.
> Rat 0.13 will ignore .checkstyle by default, but it's not released yet.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (WAGON-499) apache-rat complains about Eclipse .checkstyle files

2018-02-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/WAGON-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369291#comment-16369291
 ] 

ASF GitHub Bot commented on WAGON-499:
--

GitHub user basinilya opened a pull request:

https://github.com/apache/maven-wagon/pull/43

[WAGON-499] fix apache-rat complains about Eclipse .checkstyle files



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/basinilya/maven-wagon WAGON-499

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-wagon/pull/43.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #43


commit 82023713a463c4df7c65c36c84c94b6aa30be043
Author: Ilya Basin 
Date:   2018-02-19T16:28:09Z

[WAGON-499] fix apache-rat complains about Eclipse .checkstyle files




> apache-rat complains about Eclipse .checkstyle files
> 
>
> Key: WAGON-499
> URL: https://issues.apache.org/jira/browse/WAGON-499
> Project: Maven Wagon
>  Issue Type: Bug
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Ilya Basin
>Priority: Major
>
> See RAT-246, SCM-862
> Due to my Eclipse plugins set, when I import a maven project, a .checkstyle 
> file is generated there. This breaks building maven-scm. target/rat.txt 
> mentions:
> Files with unapproved licenses:
>  .checkstyle file.
> Rat 0.13 will ignore .checkstyle by default, but it's not released yet.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)