[jira] [Commented] (WAGON-566) Add support for URI normalization
[
https://issues.apache.org/jira/browse/WAGON-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115277#comment-17115277
]
Michael Osipov commented on WAGON-566:
--
The upstream issue has been closed. Is this invalid/not needed now?
> Add support for URI normalization
> -
>
> Key: WAGON-566
> URL: https://issues.apache.org/jira/browse/WAGON-566
> Project: Maven Wagon
> Issue Type: Improvement
> Components: wagon-http
>Affects Versions: 3.3.3
>Reporter: Steve Brown
>Priority: Major
> Labels: easyfix, newbie
> Fix For: waiting-for-feedback
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> This is a simple fix for MSITE-738. I have set the priority as Major because
> that is the priority set for MSITE-738
> Some Repository Managers, e.g. JFrog's Artifactory, do not allow puts to a
> URL with relative path elements ("." or "..").
> Artifactory are addressing the issue for downloads from remote sites
> ([RTFACT-16457|https://www.jfrog.com/jira/browse/RTFACT-16457]). Artifactory
> returns this error:
> {{"status" : 500,"}}
> {{"Path element cannot end with a dot: sites/ ... redacted ... */../*"}}
> The fix is to amend
> {{org.apache.maven.wagon.shared.http.EncodeUtils.encodeURL( String url )}}
> to normalize the returned URI.
> I will create a pull request.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (WAGON-566) Add support for URI normalization
[
https://issues.apache.org/jira/browse/WAGON-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109632#comment-17109632
]
Michael Osipov commented on WAGON-566:
--
[~stvricbr...@gmail.com], do you still want to provide a PR?
> Add support for URI normalization
> -
>
> Key: WAGON-566
> URL: https://issues.apache.org/jira/browse/WAGON-566
> Project: Maven Wagon
> Issue Type: Improvement
> Components: wagon-http
>Affects Versions: 3.3.3
>Reporter: Steve Brown
>Priority: Major
> Labels: easyfix, newbie
> Fix For: waiting-for-feedback
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> This is a simple fix for MSITE-738. I have set the priority as Major because
> that is the priority set for MSITE-738
> Some Repository Managers, e.g. JFrog's Artifactory, do not allow puts to a
> URL with relative path elements ("." or "..").
> Artifactory are addressing the issue for downloads from remote sites
> ([RTFACT-16457|https://www.jfrog.com/jira/browse/RTFACT-16457]). Artifactory
> returns this error:
> {{"status" : 500,"}}
> {{"Path element cannot end with a dot: sites/ ... redacted ... */../*"}}
> The fix is to amend
> {{org.apache.maven.wagon.shared.http.EncodeUtils.encodeURL( String url )}}
> to normalize the returned URI.
> I will create a pull request.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (WAGON-566) Add support for URI normalization
[
https://issues.apache.org/jira/browse/WAGON-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015876#comment-17015876
]
Michael Osipov commented on WAGON-566:
--
[~stvricbr...@gmail.com], looking forward too.
> Add support for URI normalization
> -
>
> Key: WAGON-566
> URL: https://issues.apache.org/jira/browse/WAGON-566
> Project: Maven Wagon
> Issue Type: Improvement
> Components: wagon-http
>Affects Versions: 3.3.3
>Reporter: Steve Brown
>Priority: Major
> Labels: easyfix, newbie
> Fix For: waiting-for-feedback
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> This is a simple fix for MSITE-738. I have set the priority as Major because
> that is the priority set for MSITE-738
> Some Repository Managers, e.g. JFrog's Artifactory, do not allow puts to a
> URL with relative path elements ("." or "..").
> Artifactory are addressing the issue for downloads from remote sites
> ([RTFACT-16457|https://www.jfrog.com/jira/browse/RTFACT-16457]). Artifactory
> returns this error:
> {{"status" : 500,"}}
> {{"Path element cannot end with a dot: sites/ ... redacted ... */../*"}}
> The fix is to amend
> {{org.apache.maven.wagon.shared.http.EncodeUtils.encodeURL( String url )}}
> to normalize the returned URI.
> I will create a pull request.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (WAGON-566) Add support for URI normalization
[
https://issues.apache.org/jira/browse/WAGON-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015724#comment-17015724
]
Steve Brown commented on WAGON-566:
---
Yes, I'm willing to try a patch.
> Add support for URI normalization
> -
>
> Key: WAGON-566
> URL: https://issues.apache.org/jira/browse/WAGON-566
> Project: Maven Wagon
> Issue Type: Improvement
> Components: wagon-http
>Affects Versions: 3.3.3
>Reporter: Steve Brown
>Priority: Major
> Labels: easyfix, newbie
> Fix For: waiting-for-feedback
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> This is a simple fix for MSITE-738. I have set the priority as Major because
> that is the priority set for MSITE-738
> Some Repository Managers, e.g. JFrog's Artifactory, do not allow puts to a
> URL with relative path elements ("." or "..").
> Artifactory are addressing the issue for downloads from remote sites
> ([RTFACT-16457|https://www.jfrog.com/jira/browse/RTFACT-16457]). Artifactory
> returns this error:
> {{"status" : 500,"}}
> {{"Path element cannot end with a dot: sites/ ... redacted ... */../*"}}
> The fix is to amend
> {{org.apache.maven.wagon.shared.http.EncodeUtils.encodeURL( String url )}}
> to normalize the returned URI.
> I will create a pull request.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (WAGON-566) Add support for URI normalization
[
https://issues.apache.org/jira/browse/WAGON-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960569#comment-16960569
]
Michael Osipov commented on WAGON-566:
--
[~stvricbr...@gmail.com], are you willing to try a patch?
> Add support for URI normalization
> -
>
> Key: WAGON-566
> URL: https://issues.apache.org/jira/browse/WAGON-566
> Project: Maven Wagon
> Issue Type: Improvement
> Components: wagon-http
>Affects Versions: 3.3.3
>Reporter: Steve Brown
>Priority: Major
> Labels: easyfix, newbie
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> This is a simple fix for MSITE-738. I have set the priority as Major because
> that is the priority set for MSITE-738
> Some Repository Managers, e.g. JFrog's Artifactory, do not allow puts to a
> URL with relative path elements ("." or "..").
> Artifactory are addressing the issue for downloads from remote sites
> ([RTFACT-16457|https://www.jfrog.com/jira/browse/RTFACT-16457]). Artifactory
> returns this error:
> {{"status" : 500,"}}
> {{"Path element cannot end with a dot: sites/ ... redacted ... */../*"}}
> The fix is to amend
> {{org.apache.maven.wagon.shared.http.EncodeUtils.encodeURL( String url )}}
> to normalize the returned URI.
> I will create a pull request.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
