olamy commented on PR #104:
URL:
https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2101725049
vote started https://lists.apache.org/thread/do2dc2tpmq2zknyqnf55xpvllop94bq5
if not issues this should be available early next week
--
This is an automated
kbuntrock commented on PR #104:
URL:
https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2101600438
> I'm really looking forward to testing this out, is there a new release
planned or a place where I can track it?
Yes, Olivier mentioned on the maven dev list
hacosta commented on PR #104:
URL:
https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2100572149
I'm really looking forward to testing this out, is there a new release
planned or a place where I can track it?
--
This is an automated message from the Apache Git
kbuntrock commented on PR #104:
URL:
https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2091521362
> Thank you, @kbuntrock!
You're welcome :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
nobesio commented on PR #104:
URL:
https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2088939166
Thank you, @kbuntrock!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
martincekodhima commented on PR #104:
URL:
https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2088170053
Thanks everyone!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
olamy merged PR #104:
URL: https://github.com/apache/maven-build-cache-extension/pull/104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kbuntrock commented on PR #104:
URL:
https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2087551261
> @kbuntrock #103 has been merged. Thanks!
@olamy: rebased, ready to merge :)
--
This is an automated message from the Apache Git Service.
To respond to the
olamy commented on PR #104:
URL:
https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2087302271
@kbuntrock #103 has been merged. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
kbuntrock commented on PR #104:
URL:
https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2085055768
Just for clarity, #103 should be merged first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kbuntrock commented on PR #104:
URL:
https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2079914284
Alright, javadoc generation should be fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
kbuntrock commented on PR #104:
URL:
https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2078236378
Alright, I think I've completed my TODO list. :) (@hboutemy &
@AlexanderAshitkin)
--
This is an automated message from the Apache Git Service.
To respond to the
hboutemy commented on PR #104:
URL:
https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2074492962
notice: if you build with Maven 3, you won't have this extra file, which is
Maven 4 specific
https://cwiki.apache.org/confluence/display/MAVEN/Build+vs+Consumer+POM
kbuntrock commented on PR #104:
URL:
https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2074391072
> > some "weird" pom files
>
> oh, this is Maven 4 consumer POMs, that seem to have been generated with
random file names
>
> @gnodet do we really want
hboutemy commented on PR #104:
URL:
https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2074220142
> some "weird" pom files
oh, this is Maven 4 consumer POMs, that seem to have been generated with
random file names
@gnodet do we really want these
kbuntrock commented on PR #104:
URL:
https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2070979208
The code introduced with MBUILDCACHE-80 has partially the same purpose of
this MR. I need to adapt my code.
First version of the merge can be seen in commit :
kbuntrock commented on code in PR #104:
URL:
https://github.com/apache/maven-build-cache-extension/pull/104#discussion_r1573829035
##
src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java:
##
@@ -112,13 +114,10 @@
@SuppressWarnings("unused")
public class
kbuntrock commented on PR #104:
URL:
https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2068086415
> Hi, @kbuntrock @hboutemy. This PR looks good. How can we move it from a
draft to an open state?
Hello @AlexanderAshitkin. I guess this PR needs now a bit of
olamy commented on PR #104:
URL:
https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2067829609
> you should just search global "artefact" and fix :)
>
Both are correct it only depends if we consider speaking English from UK or
English from US
But hey
AlexanderAshitkin commented on PR #104:
URL:
https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2067786122
Hi, @kbuntrock @hboutemy. This PR looks good. How can we move it from a
draft to an open state?
--
This is an automated message from the Apache Git
hboutemy commented on code in PR #104:
URL:
https://github.com/apache/maven-build-cache-extension/pull/104#discussion_r1573334304
##
src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java:
##
@@ -92,16 +92,17 @@
import static
hboutemy commented on PR #104:
URL:
https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2067720981
@kbuntrock I see you created MBUILDCACHE-86 and renamed the PR title
can you also update the Git commit to `[MBUILDCACHE-86]` instead of
`[PR-104]` please?
--
22 matches
Mail list logo
