[jira] [Comment Edited] (MESOS-5070) Introduce more flexible subprocess interface for child options.
[ https://issues.apache.org/jira/browse/MESOS-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510435#comment-15510435 ] Joerg Schad edited comment on MESOS-5070 at 9/21/16 4:51 PM: - The current state is that they only work on linux (windows also ignores the explicit options right now and as you pointed out does not care about parentHooks). If we are are talking about adding windows support in the future childHooks have one advantage over parentHooks in my opinion: While parentHooks can be arbitrary functions, childHooks are constrained (via the factory methods) to a small set of predefined hooks to which we could add some form of id and enable windows to implement its own version of it. Maybe [~jieyu] can add more details here. was (Author: js84): The current state is that they only work on linux (windows also ignores the explicit options right now and as you pointed out does not care about parentHooks). If we are are talking about adding windows support in the future childHooks have one advantage over parentHooks in my opinion: While parentHooks can be arbitrary functions, childHooks are constrained (via the factory methods) to a small set of predefined hooks -to which we could add some form of id and enable windows to implement its own version of it-. Maybe [~jieyu] can add more details here. > Introduce more flexible subprocess interface for child options. > --- > > Key: MESOS-5070 > URL: https://issues.apache.org/jira/browse/MESOS-5070 > Project: Mesos > Issue Type: Improvement >Reporter: Joerg Schad >Assignee: Joerg Schad > Labels: tech-debt > > We introduced a number of parameters to the subprocess interface with > MESOS-5049. > Adding all options explicitly to the subprocess interface makes it > inflexible. > We should investigate a flexible options, which still prevents arbitrary code > to be executed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (MESOS-5070) Introduce more flexible subprocess interface for child options.
[
https://issues.apache.org/jira/browse/MESOS-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15481886#comment-15481886
]
Joerg Schad edited comment on MESOS-5070 at 9/11/16 5:37 PM:
-
1.
Fair, do you feel it needs to be part of this reviews?
2.
Watchdog is a different concept than a ChildHook:
A ChildHook is a function which is executed before the actual function, where
the watchdog process is running during the entire lifetime of the process.
{code}
// Creates a seperate watchdog process to monitor the child process and
// kill it in case the parent process dies.
{code}
I would be happy to rename it 'Supervisor', but in a different review :-).
was (Author: js84):
1.
Where do you want to rename Hook -> ParentHook? If you refer to
Subprocess::Hook this is used for both ParentHooks and ChildHooks, so I see no
reason to rename it.
2.
Watchdog is a different concept than a ChildHook:
A ChildHook is a function which is executed before the actual function, where
the watchdog process is running during the entire lifetime of the process.
{code}
// Creates a seperate watchdog process to monitor the child process and
// kill it in case the parent process dies.
{code}
I would be happy to rename it 'Supervisor', but in a different review :-).
> Introduce more flexible subprocess interface for child options.
> ---
>
> Key: MESOS-5070
> URL: https://issues.apache.org/jira/browse/MESOS-5070
> Project: Mesos
> Issue Type: Improvement
>Reporter: Joerg Schad
>Assignee: Joerg Schad
> Labels: tech-debt
>
> We introduced a number of parameters to the subprocess interface with
> MESOS-5049.
> Adding all options explicitly to the subprocess interface makes it
> inflexible.
> We should investigate a flexible options, which still prevents arbitrary code
> to be executed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (MESOS-5070) Introduce more flexible subprocess interface for child options.
[
https://issues.apache.org/jira/browse/MESOS-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15481886#comment-15481886
]
Joerg Schad edited comment on MESOS-5070 at 9/11/16 3:06 PM:
-
1.
Where do you want to rename Hook -> ParentHook? If you refer to
Subprocess::Hook this is used for both ParentHooks and ChildHooks, so I see no
reason to rename it.
2.
Watchdog is a different concept than a ChildHook:
A ChildHook is a function which is executed before the actual function, where
the watchdog process is running during the entire lifetime of the process.
{code}
// Creates a seperate watchdog process to monitor the child process and
// kill it in case the parent process dies.
{code}
I would be happy to rename it 'Supervisor', but in a different review :-).
was (Author: js84):
1.
Where do you want to rename Hook -> ParentHook? If you refer to
Subprocess::Hook this is used for both ParentHooks and ChildHooks, so I see no
reason to rename it.
2.
Watchdog is a different concept than a ChildHook:
A ChildHook is a function which is executed before the actual function, where
the watchdog process is running during the entire lifetime of the process.
[code]
// Creates a seperate watchdog process to monitor the child process and
// kill it in case the parent process dies.
[code]
I would be happy to rename it 'Supervisor', but in a different review :-).
> Introduce more flexible subprocess interface for child options.
> ---
>
> Key: MESOS-5070
> URL: https://issues.apache.org/jira/browse/MESOS-5070
> Project: Mesos
> Issue Type: Improvement
>Reporter: Joerg Schad
>Assignee: Joerg Schad
> Labels: tech-debt
>
> We introduced a number of parameters to the subprocess interface with
> MESOS-5049.
> Adding all options explicitly to the subprocess interface makes it
> inflexible.
> We should investigate a flexible options, which still prevents arbitrary code
> to be executed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
