[jira] [Comment Edited] (MESOS-6177) Return unregistered agents recovered from registrar in `GetAgents` and/or `/state.json`
[ https://issues.apache.org/jira/browse/MESOS-6177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1475#comment-1475 ] Zhitao Li edited comment on MESOS-6177 at 1/3/17 5:43 PM: -- https://reviews.apache.org/r/52637/ https://reviews.apache.org/r/52638/ https://reviews.apache.org/r/52639/ https://reviews.apache.org/r/54732/ https://reviews.apache.org/r/53344/ was (Author: zhitao): https://reviews.apache.org/r/52637/ https://reviews.apache.org/r/52638/ https://reviews.apache.org/r/52639/ > Return unregistered agents recovered from registrar in `GetAgents` and/or > `/state.json` > --- > > Key: MESOS-6177 > URL: https://issues.apache.org/jira/browse/MESOS-6177 > Project: Mesos > Issue Type: Improvement > Components: HTTP API >Reporter: Zhitao Li >Assignee: Zhitao Li > > Use case: > This can be used for any software which talks to Mesos master to better > understand state of an unregistered agent after a master failover. > If this information is available, the use case in MESOS-6174 can be handled > with a simpler decision of whether the corresponding agent is removed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (MESOS-6177) Return unregistered agents recovered from registrar in `GetAgents` and/or `/state.json`
[
https://issues.apache.org/jira/browse/MESOS-6177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15572997#comment-15572997
]
Zhitao Li edited comment on MESOS-6177 at 10/14/16 1:25 AM:
(edited after recalling that pid is not in SlaveInfo. We should think about
adding {{Address}} to {{SlaveInfo}} if possible but that has to be a different
ticket)
[~anandmazumdar], after some more thoughts, I'm inclined to return the full
{{AgentInfo}} instead of only {{AgentID}} for agents in {{recovered}} state.
This has the benefit to help operators to know the hostname of the agent id
which is not recovered yet without calling registry again.
-My primary intention is to have a hold of {{pid}}, so the operator/subscriber
can know the ip:port the agent is listening at. If we only return {{AgentID}},
the operator can do little additional babysitting steps to validate the state
of the agent, except for waiting for {{--agent_reregistration_timeout}} to
pass.-
-This is also pretty easy to implement IIUIC: we can simply change the
{{slaves.recovered}} from {{hashset}} to {{hashmap}}. The {{SlaveInfo}} is already available after Registrar recovers
it.-
was (Author: zhitao):
(edited)
[~anandmazumdar], after some more thoughts, I'm inclined to return the full
{{AgentInfo}} instead of only {{AgentID}} for agents in {{recovered}} state.
This has the benefit to help operators to know the hostname of the agent id
which is not recovered yet without calling registry again.
-My primary intention is to have a hold of {{pid}}, so the operator/subscriber
can know the ip:port the agent is listening at. If we only return {{AgentID}},
the operator can do little additional babysitting steps to validate the state
of the agent, except for waiting for {{--agent_reregistration_timeout}} to
pass.-
-This is also pretty easy to implement IIUIC: we can simply change the
{{slaves.recovered}} from {{hashset}} to {{hashmap}}. The {{SlaveInfo}} is already available after Registrar recovers
it.-
> Return unregistered agents recovered from registrar in `GetAgents` and/or
> `/state.json`
> ---
>
> Key: MESOS-6177
> URL: https://issues.apache.org/jira/browse/MESOS-6177
> Project: Mesos
> Issue Type: Improvement
> Components: HTTP API
>Reporter: Zhitao Li
>Assignee: Zhitao Li
>
> Use case:
> This can be used for any software which talks to Mesos master to better
> understand state of an unregistered agent after a master failover.
> If this information is available, the use case in MESOS-6174 can be handled
> with a simpler decision of whether the corresponding agent is removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (MESOS-6177) Return unregistered agents recovered from registrar in `GetAgents` and/or `/state.json`
[
https://issues.apache.org/jira/browse/MESOS-6177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15572997#comment-15572997
]
Zhitao Li edited comment on MESOS-6177 at 10/14/16 1:24 AM:
(edited)
[~anandmazumdar], after some more thoughts, I'm inclined to return the full
{{AgentInfo}} instead of only {{AgentID}} for agents in {{recovered}} state.
This has the benefit to help operators to know the hostname of the agent id
which is not recovered yet without calling registry again.
-My primary intention is to have a hold of {{pid}}, so the operator/subscriber
can know the ip:port the agent is listening at. If we only return {{AgentID}},
the operator can do little additional babysitting steps to validate the state
of the agent, except for waiting for {{--agent_reregistration_timeout}} to
pass.-
-This is also pretty easy to implement IIUIC: we can simply change the
{{slaves.recovered}} from {{hashset}} to {{hashmap}}. The {{SlaveInfo}} is already available after Registrar recovers
it.-
was (Author: zhitao):
[~anandmazumdar], after some more thoughts, I'm inclined to return the full
{{AgentInfo}} instead of only {{AgentID}} for agents in {{recovered}} state.
My primary intention is to have a hold of {{pid}}, so the operator/subscriber
can know the ip:port the agent is listening at. If we only return {{AgentID}},
the operator can do little additional babysitting steps to validate the state
of the agent, except for waiting for {{--agent_reregistration_timeout}} to pass.
This is also pretty easy to implement IIUIC: we can simply change the
{{slaves.recovered}} from {{hashset}} to {{hashmap}}. The {{SlaveInfo}} is already available after Registrar recovers
it.
> Return unregistered agents recovered from registrar in `GetAgents` and/or
> `/state.json`
> ---
>
> Key: MESOS-6177
> URL: https://issues.apache.org/jira/browse/MESOS-6177
> Project: Mesos
> Issue Type: Improvement
> Components: HTTP API
>Reporter: Zhitao Li
>Assignee: Zhitao Li
>
> Use case:
> This can be used for any software which talks to Mesos master to better
> understand state of an unregistered agent after a master failover.
> If this information is available, the use case in MESOS-6174 can be handled
> with a simpler decision of whether the corresponding agent is removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (MESOS-6177) Return unregistered agents recovered from registrar in `GetAgents` and/or `/state.json`
[
https://issues.apache.org/jira/browse/MESOS-6177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15572997#comment-15572997
]
Zhitao Li edited comment on MESOS-6177 at 10/13/16 11:07 PM:
-
[~anandmazumdar], after some more thoughts, I'm inclined to return the full
{{AgentInfo}} instead of only {{AgentID}} for agents in {{recovered}} state.
My primary intention is to have a hold of {{pid}}, so the operator/subscriber
can know the ip:port the agent is listening at. If we only return {{AgentID}},
the operator can do little additional babysitting steps to validate the state
of the agent, except for waiting for {{--agent_reregistration_timeout}} to pass.
This is also pretty easy to implement IIUIC: we can simply change the
{{slaves.recovered}} from {{hashset}} to {{hashmap}}. The {{SlaveInfo}} is already available after Registrar recovers
it.
was (Author: zhitao):
[~anandmazumdar], I'm strongly inclined to return the full {{AgentInfo}}
instead of only {{AgentID}} for agents in {{recovered}} state.
My primary intention is to have a hold of {{pid}}, so the operator/subscriber
can know the ip:port the agent is listening at. If we only return {{AgentID}},
the operator can do little additional babysitting steps to validate the state
of the agent, except for waiting for {{--agent_reregistration_timeout}} to pass.
This is also pretty easy to implement IIUIC: we can simply change the
{{slaves.recovered}} from {{hashset}} to {{hashmap}}. The {{SlaveInfo}} is already available after Registrar recovers
it.
> Return unregistered agents recovered from registrar in `GetAgents` and/or
> `/state.json`
> ---
>
> Key: MESOS-6177
> URL: https://issues.apache.org/jira/browse/MESOS-6177
> Project: Mesos
> Issue Type: Improvement
> Components: HTTP API
>Reporter: Zhitao Li
>Assignee: Zhitao Li
>
> Use case:
> This can be used for any software which talks to Mesos master to better
> understand state of an unregistered agent after a master failover.
> If this information is available, the use case in MESOS-6174 can be handled
> with a simpler decision of whether the corresponding agent is removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
