[jira] [Commented] (MESOS-9152) Close all file descriptors except whitelist_fds in posix/subprocess.

2018-11-07 Thread Qian Zhang (JIRA)


[ 
https://issues.apache.org/jira/browse/MESOS-9152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679390#comment-16679390
 ] 

Qian Zhang commented on MESOS-9152:
---

commit f539d1eba8c7b0fbc4ab040c9af357e016bfde12
Author: Qian Zhang 
Date:   Wed Aug 29 10:16:43 2018 +0800

Added `lsof()` into stout.

Review: https://reviews.apache.org/r/68642

commit 00497ab19703fb20f71eea74c2df1ff6346391f5
Author: Qian Zhang 
Date:   Wed Sep 26 16:58:48 2018 +0800

Added a test `FsTest.Lsof`.

Review: https://reviews.apache.org/r/68991

commit ebdf5106c4871875bf7c97cbec43cfe696275f0c

commit d9a02acb8c9440c29811e6f66fe2e1146a04aa52
Author: Qian Zhang 
Date:   Wed Aug 29 10:17:05 2018 +0800

Closed all file descriptors except `whitelist_fds` in posix/subprocess.

Review: https://reviews.apache.org/r/68644

commit df0a616e3555767e308a87c787d5ad5cdd4e66c1
Author: Qian Zhang 
Date:   Fri Oct 12 22:04:02 2018 +0800

Added a test `SubprocessTest.WhiteListFds`.

Review: https://reviews.apache.org/r/69016

commit bb533b784928bca1553b6ed86d10105de26bb76d
Author: Qian Zhang 
Date:   Mon Sep 3 15:09:24 2018 +0800

Updated IO switchboard to use subprocess's `whitelist_fds` parameter.

Review: https://reviews.apache.org/r/68645

commit 2455543d7534d2c1491854ff6efff1c75a1c4395
Author: Qian Zhang 
Date:   Mon Sep 3 15:11:51 2018 +0800

Updated launchers to use subprocess's `whitelist_fds` parameter.

Review: https://reviews.apache.org/r/68646

commit face988a52b0775f0c3e959d1f164212c1eba96c
Author: Qian Zhang 
Date:   Mon Oct 8 16:06:31 2018 +0800

Removed the child hook `UNSET_CLOEXEC`.

We do not need this child hook since any file descripters need
to unset the close-on-exec flag can be put in the `whitelist_fds`
parameter of the `subprocess` method.

Review: https://reviews.apache.org/r/68995

> Close all file descriptors except whitelist_fds in posix/subprocess.
> 
>
> Key: MESOS-9152
> URL: https://issues.apache.org/jira/browse/MESOS-9152
> Project: Mesos
>  Issue Type: Bug
>Reporter: Gilbert Song
>Assignee: Qian Zhang
>Priority: Major
>  Labels: containerizer, mesosphere
>
> Close all file descriptors except whitelist_fds in posix/subprocess 
> (currently whitelist_fds are not honored yet). This would avoid the fd being 
> leaked. Please follow the steps from this commit to make corresponding change:
>  
> https://issues.apache.org/jira/browse/MESOS-8917?focusedCommentId=16522629=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16522629



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MESOS-9152) Close all file descriptors except whitelist_fds in posix/subprocess.

2018-09-05 Thread Qian Zhang (JIRA)


[ 
https://issues.apache.org/jira/browse/MESOS-9152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605138#comment-16605138
 ] 

Qian Zhang commented on MESOS-9152:
---

RR: https://reviews.apache.org/r/68642/

> Close all file descriptors except whitelist_fds in posix/subprocess.
> 
>
> Key: MESOS-9152
> URL: https://issues.apache.org/jira/browse/MESOS-9152
> Project: Mesos
>  Issue Type: Bug
>Reporter: Gilbert Song
>Assignee: Qian Zhang
>Priority: Major
>  Labels: containerizer, mesosphere
>
> Close all file descriptors except whitelist_fds in posix/subprocess 
> (currently whitelist_fds are not honored yet). This would avoid the fd being 
> leaked. Please follow the steps from this commit to make corresponding change:
>  
> https://issues.apache.org/jira/browse/MESOS-8917?focusedCommentId=16522629=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16522629



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)