Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/970
It is definitely looking better. I am liking the progress. But I still
think having overly broad interfaces that do everything is causing problems;
primarily `IndexDao` and also `MetaAlertDao`.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/531
So, what is the status of this? Can we at *least* sum up?
---
[
https://issues.apache.org/jira/browse/METRON-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432293#comment-16432293
]
ASF GitHub Bot commented on METRON-854:
---
Github user ottobackwards commented on the issue:
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/670
What is the status of this?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/979
I think to test we need to try with and without the plugin
---
[
https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432348#comment-16432348
]
ASF GitHub Bot commented on METRON-1421:
Github user nickwallen commented on the issue:
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/970
> I'd like to know what specific problems we're going to solve that merit
that level of change in this PR.
The fundamental problem here is a lack of good unit tests on these search
[
https://issues.apache.org/jira/browse/METRON-1065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432296#comment-16432296
]
ASF GitHub Bot commented on METRON-1065:
Github user ottobackwards commented on the issue:
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/684
I will repeat that this should be a feature branch. What are we going to
do here? This is just sitting here getting more and more out of date.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/687
This is pretty old at this point, and there has been a lot of discussion
all over the place about it. I'm not sure I can sum up where we are.
@cestella can you sum up your current feeling on
[
https://issues.apache.org/jira/browse/METRON-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432297#comment-16432297
]
ASF GitHub Bot commented on METRON-1086:
Github user ottobackwards commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432308#comment-16432308
]
ASF GitHub Bot commented on METRON-1233:
Github user ottobackwards commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432310#comment-16432310
]
ASF GitHub Bot commented on METRON-1298:
Github user ottobackwards commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432312#comment-16432312
]
ASF GitHub Bot commented on METRON-1421:
Github user nickwallen commented on the issue:
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/970
> @justinleet Solve the code reuse problem for Solr and ES.
I am also noticing another positive side effect here. Getting rid of these
interface hierarchies (like having the
[
https://issues.apache.org/jira/browse/METRON-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432311#comment-16432311
]
ASF GitHub Bot commented on METRON-1212:
Github user ottobackwards commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432325#comment-16432325
]
ASF GitHub Bot commented on METRON-1421:
Github user justinleet commented on the issue:
Otto Fowler created METRON-1516:
---
Summary: Support for Ansible 2.5.0
Key: METRON-1516
URL: https://issues.apache.org/jira/browse/METRON-1516
Project: Metron
Issue Type: New Feature
[
https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432221#comment-16432221
]
ASF GitHub Bot commented on METRON-1421:
Github user nickwallen commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432286#comment-16432286
]
ASF GitHub Bot commented on METRON-1356:
Github user ottobackwards commented on the issue:
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/973
@merrimanr this looks great. A couple of things:
1. Can you give some steps on how to test this? I would like to keep the
FB moving
2. have you ever looked at
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/713
what is the status of this PR?
---
[
https://issues.apache.org/jira/browse/METRON-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432303#comment-16432303
]
ASF GitHub Bot commented on METRON-1130:
Github user ottobackwards commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432314#comment-16432314
]
ASF GitHub Bot commented on METRON-1507:
Github user ottobackwards commented on the issue:
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/970
@nickwallen
Right now those interfaces are basically a marker interface that requires
everything that's needed for a complete DAO set. Prior to some of the Solr
refactorings, it existed as a
[
https://issues.apache.org/jira/browse/METRON-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432305#comment-16432305
]
ASF GitHub Bot commented on METRON-1184:
Github user ottobackwards commented on the issue:
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/775
@DimDroll any update? Or can you close this?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/439
@devopsec : Tyler, can you update this or close it?
---
[
https://issues.apache.org/jira/browse/METRON-571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432291#comment-16432291
]
ASF GitHub Bot commented on METRON-571:
---
Github user ottobackwards commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432302#comment-16432302
]
ASF GitHub Bot commented on METRON-1090:
Github user ottobackwards commented on the issue:
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/754
What is the status of this? Can someone who can do EC2 deploys test it out?
---
[
https://issues.apache.org/jira/browse/METRON-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432335#comment-16432335
]
ASF GitHub Bot commented on METRON-1184:
Github user lvets commented on the issue:
Github user lvets commented on the issue:
https://github.com/apache/metron/pull/754
@ottobackwards I will try this out this week.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/970
Do you think we have enough unit tests on this functionality how it is?
---
[
https://issues.apache.org/jira/browse/METRON-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432483#comment-16432483
]
ASF GitHub Bot commented on METRON-1086:
Github user merrimanr commented on the issue:
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/970
As we are already on a feature branch, can we not iterate and refactor
this? Does it all have to go into *this* pr?
If this is landed, what is keeping @nickwallen from throwing a PR
Github user lvets commented on the issue:
https://github.com/apache/metron/pull/684
I can help out with testing wherever possible. This is a very cool
feature...
---
Nick Allen created METRON-1518:
--
Summary: Build Failure When Using Profile HDP-2.5.0.0
Key: METRON-1518
URL: https://issues.apache.org/jira/browse/METRON-1518
Project: Metron
Issue Type: Bug
[
https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432486#comment-16432486
]
ASF GitHub Bot commented on METRON-1421:
Github user ottobackwards commented on the issue:
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/684
I would be happy to help, I think I have a decent handle with the stellar
side, and could get up to speed on the ui stuff with your help.
Think about how we can go about it.
I
[
https://issues.apache.org/jira/browse/METRON-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432520#comment-16432520
]
ASF GitHub Bot commented on METRON-1086:
Github user lvets commented on the issue:
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/970
@ottobackwards Correct me if I'm misunderstanding your view, @nickwallen,
but the discussion is around what's the required level of iteration /
refactoring where this meets expectations for
[
https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432539#comment-16432539
]
ASF GitHub Bot commented on METRON-1421:
Github user justinleet commented on the issue:
Laurens Vets created METRON-1517:
Summary: GeoLite discontinuation notice
Key: METRON-1517
URL: https://issues.apache.org/jira/browse/METRON-1517
Project: Metron
Issue Type: Bug
[
https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432619#comment-16432619
]
ASF GitHub Bot commented on METRON-1421:
Github user justinleet commented on the issue:
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/970
@merrimanr I should probably hit you up too before we confirm that's what
the plan is, since you've run stuff up a couple times and been pretty involved
in the Solr work. Does the above plan for
[
https://issues.apache.org/jira/browse/METRON-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432651#comment-16432651
]
Laurens Vets commented on METRON-1517:
--
Don't we need to adapt Metron for:
h4. *Important Notice for
[
https://issues.apache.org/jira/browse/METRON-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432672#comment-16432672
]
Justin Leet commented on METRON-1517:
-
Correct, we do use GeoLite2 (although we rename some fields
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/970
@justinleet @nickwallen , sorry I didn't mean to confuse things. It seems
to me that @nickwallen is willing to do some work on this per his 'vision' and
that might be easier if this landed in
[
https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432597#comment-16432597
]
ASF GitHub Bot commented on METRON-1421:
Github user ottobackwards commented on the issue:
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/970
I agree with your plan @justinleet . I am on-board. Thanks for laying
that out.
---
[
https://issues.apache.org/jira/browse/METRON-1214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432306#comment-16432306
]
ASF GitHub Bot commented on METRON-1214:
Github user ottobackwards commented on the issue:
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/789
Still needs conflict resolution, still needs relevancy check
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/830
What is the status of this PR?
---
[
https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432370#comment-16432370
]
ASF GitHub Bot commented on METRON-1421:
Github user nickwallen commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432442#comment-16432442
]
ASF GitHub Bot commented on METRON-1421:
Github user justinleet commented on the issue:
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/970
@nickwallen
Assuming we go through with the partial refactoring, the existence of those
interfaces does not prevent us from testing the individual DAOs. A lot of the
highly specific changes
[
https://issues.apache.org/jira/browse/METRON-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Allen updated METRON-1518:
---
Description:
{code}
[
https://issues.apache.org/jira/browse/METRON-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432704#comment-16432704
]
Nick Allen commented on METRON-1518:
This is caused by my PR;
[
https://issues.apache.org/jira/browse/METRON-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432507#comment-16432507
]
ASF GitHub Bot commented on METRON-1086:
Github user ottobackwards commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432607#comment-16432607
]
Nick Allen commented on METRON-1517:
I read this as a discontinuation of GeoLite and that they are
[
https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432640#comment-16432640
]
ASF GitHub Bot commented on METRON-1421:
Github user justinleet commented on the issue:
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/684
Sorry for ignoring this for so long. This is going to be a fairly complex
module to maintain and it is VERY tightly coupled with Stellar. This means
that if we want to officially add this
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/970
Just to summarize my position, my suggested refactorings are just one of
many ways to improve the testability of all this. We don't have to take this
approach.
For this PR, I will be
[
https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432554#comment-16432554
]
ASF GitHub Bot commented on METRON-1421:
Github user nickwallen commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432634#comment-16432634
]
ASF GitHub Bot commented on METRON-1421:
Github user nickwallen commented on the issue:
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/986#discussion_r180544522
--- Diff: .travis.yml ---
@@ -33,7 +33,7 @@ before_install:
- npm config set prefix $HOME/.npm-prefix --global
install:
- - time mvn
[
https://issues.apache.org/jira/browse/METRON-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432841#comment-16432841
]
ASF GitHub Bot commented on METRON-1518:
Github user cestella commented on a diff in the pull
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/970
@mmiklavc I think that's a good insight. The original intention of
metaalerts was to basically wrap and augment the functionality of the index
alerts. I think a portion of that problem we've
[
https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432852#comment-16432852
]
ASF GitHub Bot commented on METRON-1421:
Github user justinleet commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432837#comment-16432837
]
ASF GitHub Bot commented on METRON-1518:
Github user cestella commented on a diff in the pull
[
https://issues.apache.org/jira/browse/METRON-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432869#comment-16432869
]
ASF GitHub Bot commented on METRON-1518:
Github user cestella commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432866#comment-16432866
]
ASF GitHub Bot commented on METRON-1518:
Github user nickwallen commented on a diff in the pull
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/986
+1 by inspection, thanks!
---
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/986
METRON-1518 Build Failure When Using Profile HDP-2.5.0.0
The build fails when using the 'HDP-2.5.0.0' profile.
```
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/970
@justinleet @nickwallen I agree with the proposed plan for this PR's
refactorings. That being said, I have some comments after having more or less
caught up with the thread.
Generally
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/986#discussion_r180543990
--- Diff: .travis.yml ---
@@ -33,7 +33,7 @@ before_install:
- npm config set prefix $HOME/.npm-prefix --global
install:
- - time mvn
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/986
+1 ship it
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/985
Ok, I added a unit test for this as requested.
---
[
https://issues.apache.org/jira/browse/METRON-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432763#comment-16432763
]
ASF GitHub Bot commented on METRON-1515:
Github user cestella commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432818#comment-16432818
]
ASF GitHub Bot commented on METRON-1518:
GitHub user nickwallen opened a pull request:
[
https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432821#comment-16432821
]
ASF GitHub Bot commented on METRON-1421:
Github user mmiklavc commented on the issue:
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/986#discussion_r180547851
--- Diff: .travis.yml ---
@@ -33,7 +33,7 @@ before_install:
- npm config set prefix $HOME/.npm-prefix --global
install:
- - time
[
https://issues.apache.org/jira/browse/METRON-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432881#comment-16432881
]
ASF GitHub Bot commented on METRON-1518:
Github user ottobackwards commented on the issue:
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/970
@ottobackwards You're absolutely not confusing things. It's important to
have that perspective, and I am 100% appreciative of you hopping in and
offering up your opinion. I think you're right
[
https://issues.apache.org/jira/browse/METRON-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433076#comment-16433076
]
ASF GitHub Bot commented on METRON-1515:
Github user nickwallen commented on a diff in the pull
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/985#discussion_r180583454
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/resolver/ClasspathFunctionResolver.java
---
@@ -254,18
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/987
METRON-1519 Indexing Error Topic Property Not Displayed in MPack
The user is not able to configure the Indexing Error Topic in the MPack. A
property has been defined for this in the Mpack, but
[
https://issues.apache.org/jira/browse/METRON-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433065#comment-16433065
]
ASF GitHub Bot commented on METRON-1519:
GitHub user nickwallen opened a pull request:
[
https://issues.apache.org/jira/browse/METRON-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432888#comment-16432888
]
ASF GitHub Bot commented on METRON-1515:
Github user ottobackwards commented on the issue:
Nick Allen created METRON-1519:
--
Summary: Indexing Error Topic Property Not Displayed in MPack
Key: METRON-1519
URL: https://issues.apache.org/jira/browse/METRON-1519
Project: Metron
Issue
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/985
+1 by inspection. Thanks for the contribution!
---
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/986
---
[
https://issues.apache.org/jira/browse/METRON-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432998#comment-16432998
]
ASF GitHub Bot commented on METRON-1518:
Github user nickwallen commented on the issue:
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/985#discussion_r180576221
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/resolver/ClasspathFunctionResolver.java
---
@@ -254,18
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/986
Thanks for the reviews. Just to be sure, I ran up the CentOS dev
environment, validated that alerts are being created, created a profile and
made sure that values were written.
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/985#discussion_r180578439
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/resolver/ClasspathFunctionResolver.java
---
@@ -254,18
[
https://issues.apache.org/jira/browse/METRON-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433016#comment-16433016
]
ASF GitHub Bot commented on METRON-1518:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/METRON-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433042#comment-16433042
]
ASF GitHub Bot commented on METRON-1515:
Github user cestella commented on a diff in the pull
[
https://issues.apache.org/jira/browse/METRON-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433041#comment-16433041
]
ASF GitHub Bot commented on METRON-1515:
Github user nickwallen commented on a diff in the pull
1 - 100 of 106 matches
Mail list logo
