[GitHub] metron issue #979: METRON-1507 Added support for vagrant cachier

2018-04-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/979 @simonellistonball I'm blocked by https://github.com/apache/metron/pull/989 for this hint hint ---

[GitHub] metron pull request #985: METRON-1515: Errors loading stellar functions curr...

2018-04-11 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/985#discussion_r180760561 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/resolver/ClasspathFunctionResolver.java --- @@ -254,18

[jira] [Commented] (METRON-1515) Errors loading stellar functions currently bomb the entire topology, they should be recoverable

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433938#comment-16433938 ] ASF GitHub Bot commented on METRON-1515: Github user ottobackwards commented on a diff in the

[GitHub] metron pull request #984: METRON-1499 Enable Configuration of Unified Enrich...

2018-04-11 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/984#discussion_r18074 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-enrichment-env.xml --- @@

[jira] [Commented] (METRON-1499) Enable Configuration of Unified Enrichment Topology via Ambari

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433897#comment-16433897 ] ASF GitHub Bot commented on METRON-1499: Github user cestella commented on a diff in the pull

[jira] [Commented] (METRON-1516) Support for Ansible 2.5.0

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433906#comment-16433906 ] ASF GitHub Bot commented on METRON-1516: GitHub user ottobackwards opened a pull request:

[jira] [Commented] (METRON-1515) Errors loading stellar functions currently bomb the entire topology, they should be recoverable

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433916#comment-16433916 ] ASF GitHub Bot commented on METRON-1515: Github user ottobackwards commented on a diff in the

[GitHub] metron pull request #985: METRON-1515: Errors loading stellar functions curr...

2018-04-11 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/985#discussion_r180748583 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/resolver/ClasspathFunctionResolver.java --- @@ -254,18

[jira] [Commented] (METRON-1515) Errors loading stellar functions currently bomb the entire topology, they should be recoverable

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433901#comment-16433901 ] ASF GitHub Bot commented on METRON-1515: Github user cestella commented on a diff in the pull

[GitHub] metron pull request #989: METRON-1516 Support for Ansible 2.5.0

2018-04-11 Thread ottobackwards
GitHub user ottobackwards opened a pull request: https://github.com/apache/metron/pull/989 METRON-1516 Support for Ansible 2.5.0 This PR adds support for Ansible 2.5.0. No other changes beyond allowing the check to pass where required. Tested centos and ubuntu, macOS

[GitHub] metron pull request #985: METRON-1515: Errors loading stellar functions curr...

2018-04-11 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/985#discussion_r180751165 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/resolver/ClasspathFunctionResolver.java --- @@ -254,18

[jira] [Commented] (METRON-1515) Errors loading stellar functions currently bomb the entire topology, they should be recoverable

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433907#comment-16433907 ] ASF GitHub Bot commented on METRON-1515: Github user cestella commented on a diff in the pull

[GitHub] metron pull request #985: METRON-1515: Errors loading stellar functions curr...

2018-04-11 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/985#discussion_r180755523 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/resolver/ClasspathFunctionResolver.java --- @@ -254,18

[jira] [Commented] (METRON-1515) Errors loading stellar functions currently bomb the entire topology, they should be recoverable

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433923#comment-16433923 ] ASF GitHub Bot commented on METRON-1515: Github user cestella commented on a diff in the pull

[jira] [Commented] (METRON-1515) Errors loading stellar functions currently bomb the entire topology, they should be recoverable

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433979#comment-16433979 ] ASF GitHub Bot commented on METRON-1515: Github user cestella commented on a diff in the pull

[GitHub] metron pull request #985: METRON-1515: Errors loading stellar functions curr...

2018-04-11 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/985#discussion_r180770770 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/resolver/ClasspathFunctionResolver.java --- @@ -254,18

[GitHub] metron pull request #985: METRON-1515: Errors loading stellar functions curr...

2018-04-11 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/985#discussion_r180753753 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/resolver/ClasspathFunctionResolver.java --- @@ -254,18

[jira] [Commented] (METRON-1499) Enable Configuration of Unified Enrichment Topology via Ambari

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434127#comment-16434127 ] ASF GitHub Bot commented on METRON-1499: Github user nickwallen commented on a diff in the pull

[GitHub] metron pull request #984: METRON-1499 Enable Configuration of Unified Enrich...

2018-04-11 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/984#discussion_r180814327 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-enrichment-env.xml ---

[GitHub] metron issue #975: METRON-1503: Alerts are not getting populated in alerts U...

2018-04-11 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/975 The latest commit adds unit tests for all the Solr Dao classes except SolrMetaAlertDao. Mocking some of the Solr client classes (and client libraries in general) was challenging so I opted to

[jira] [Commented] (METRON-1503) Alerts are not getting populated in alerts UI when search engine is Solr

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434138#comment-16434138 ] ASF GitHub Bot commented on METRON-1503: Github user merrimanr commented on the issue:

[jira] [Commented] (METRON-1516) Support for Ansible 2.5.0

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434058#comment-16434058 ] ASF GitHub Bot commented on METRON-1516: Github user nickwallen commented on the issue:

[GitHub] metron issue #989: METRON-1516 Support for Ansible 2.5.0

2018-04-11 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/989 +1 LGTM @ottobackwards (pending CI build) ---

[jira] [Commented] (METRON-1499) Enable Configuration of Unified Enrichment Topology via Ambari

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434126#comment-16434126 ] ASF GitHub Bot commented on METRON-1499: Github user nickwallen commented on the issue:

[GitHub] metron issue #984: METRON-1499 Enable Configuration of Unified Enrichment To...

2018-04-11 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/984 Let me know if there is anything else we need on this one guys. Thanks for the looks so far. ---

[GitHub] metron pull request #975: METRON-1503: Alerts are not getting populated in a...

2018-04-11 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/975#discussion_r180839113 --- Diff: metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrSearchDao.java --- @@ -176,19 +179,23 @@ private SolrQuery

[GitHub] metron pull request #975: METRON-1503: Alerts are not getting populated in a...

2018-04-11 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/975#discussion_r180833486 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/search/SearchResponse.java --- @@ -61,4 +61,20 @@ public void

[GitHub] metron pull request #975: METRON-1503: Alerts are not getting populated in a...

2018-04-11 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/975#discussion_r180833783 --- Diff: metron-platform/metron-solr/src/main/java/org/apache/metron/solr/dao/SolrDao.java --- @@ -72,12 +72,12 @@ public SolrDao() { @Override

[GitHub] metron issue #989: METRON-1516 Support for Ansible 2.5.0

2018-04-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/989 I'm not sure why the build is failing the zookeeper cache tests... ---

[GitHub] metron pull request #989: METRON-1516 Support for Ansible 2.5.0

2018-04-11 Thread ottobackwards
Github user ottobackwards closed the pull request at: https://github.com/apache/metron/pull/989 ---

[GitHub] metron pull request #989: METRON-1516 Support for Ansible 2.5.0

2018-04-11 Thread ottobackwards
GitHub user ottobackwards reopened a pull request: https://github.com/apache/metron/pull/989 METRON-1516 Support for Ansible 2.5.0 This PR adds support for Ansible 2.5.0. No other changes beyond allowing the check to pass where required. Tested centos and ubuntu, macOS

[jira] [Commented] (METRON-1503) Alerts are not getting populated in alerts UI when search engine is Solr

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434298#comment-16434298 ] ASF GitHub Bot commented on METRON-1503: Github user nickwallen commented on a diff in the pull

[jira] [Commented] (METRON-1503) Alerts are not getting populated in alerts UI when search engine is Solr

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434299#comment-16434299 ] ASF GitHub Bot commented on METRON-1503: Github user nickwallen commented on a diff in the pull

[jira] [Commented] (METRON-1503) Alerts are not getting populated in alerts UI when search engine is Solr

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434297#comment-16434297 ] ASF GitHub Bot commented on METRON-1503: Github user nickwallen commented on a diff in the pull

[jira] [Commented] (METRON-1503) Alerts are not getting populated in alerts UI when search engine is Solr

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434362#comment-16434362 ] ASF GitHub Bot commented on METRON-1503: Github user nickwallen commented on the issue:

[jira] [Commented] (METRON-1516) Support for Ansible 2.5.0

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434436#comment-16434436 ] ASF GitHub Bot commented on METRON-1516: GitHub user ottobackwards reopened a pull request:

[jira] [Commented] (METRON-1516) Support for Ansible 2.5.0

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434435#comment-16434435 ] ASF GitHub Bot commented on METRON-1516: Github user ottobackwards commented on the issue:

[jira] [Commented] (METRON-1503) Alerts are not getting populated in alerts UI when search engine is Solr

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434348#comment-16434348 ] ASF GitHub Bot commented on METRON-1503: Github user merrimanr commented on a diff in the pull

[GitHub] metron issue #975: METRON-1503: Alerts are not getting populated in alerts U...

2018-04-11 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/975 +1 Good stuff ---

[jira] [Commented] (METRON-1494) Profiler Emits Messages to Kafka When Not Needed

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434655#comment-16434655 ] ASF GitHub Bot commented on METRON-1494: Github user asfgit closed the pull request at:

[jira] [Created] (METRON-1520) Add caching for stellar field transformations

2018-04-11 Thread Casey Stella (JIRA)
Casey Stella created METRON-1520: Summary: Add caching for stellar field transformations Key: METRON-1520 URL: https://issues.apache.org/jira/browse/METRON-1520 Project: Metron Issue Type:

[jira] [Commented] (METRON-1520) Add caching for stellar field transformations

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434480#comment-16434480 ] ASF GitHub Bot commented on METRON-1520: GitHub user cestella opened a pull request:

[GitHub] metron pull request #990: METRON-1520: Add caching for stellar field transfo...

2018-04-11 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/metron/pull/990 METRON-1520: Add caching for stellar field transformations ## Contributor Comments Given how important caching is in the enrichment topology, we should have caching for stellar field

[GitHub] metron pull request #990: METRON-1520: Add caching for stellar field transfo...

2018-04-11 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/990#discussion_r180885231 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/json/JSONMapParser.java --- @@ -99,6 +98,7 @@ public void

[jira] [Commented] (METRON-1520) Add caching for stellar field transformations

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434529#comment-16434529 ] ASF GitHub Bot commented on METRON-1520: Github user cestella commented on the issue:

[jira] [Commented] (METRON-1521) JSONMapParser is no longer serializable

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434528#comment-16434528 ] ASF GitHub Bot commented on METRON-1521: Github user ottobackwards commented on the issue:

[jira] [Commented] (METRON-1520) Add caching for stellar field transformations

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434544#comment-16434544 ] ASF GitHub Bot commented on METRON-1520: Github user cestella commented on the issue:

[jira] [Commented] (METRON-1521) JSONMapParser is no longer serializable

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434505#comment-16434505 ] ASF GitHub Bot commented on METRON-1521: GitHub user cestella opened a pull request:

[jira] [Commented] (METRON-1520) Add caching for stellar field transformations

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434517#comment-16434517 ] ASF GitHub Bot commented on METRON-1520: Github user cestella commented on a diff in the pull

[GitHub] metron pull request #990: METRON-1520: Add caching for stellar field transfo...

2018-04-11 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/990#discussion_r180880448 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/json/JSONMapParser.java --- @@ -99,6 +98,7 @@ public void

[GitHub] metron issue #990: METRON-1520: Add caching for stellar field transformation...

2018-04-11 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/990 This PR provides an expression cache for stellar when using the stellar field transformations in parsers. Specifically, we found that without caching we were substantially stymied when performance

[GitHub] metron issue #967: METRON-1494 Profiler Emits Messages to Kafka When Not Nee...

2018-04-11 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/967 Still looks fine - tests now passing with 977, lgtm. +1 ---

[jira] [Commented] (METRON-1520) Add caching for stellar field transformations

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434534#comment-16434534 ] ASF GitHub Bot commented on METRON-1520: Github user ottobackwards commented on the issue:

[GitHub] metron issue #990: METRON-1520: Add caching for stellar field transformation...

2018-04-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/990 Does this assume, that if you have multiple transformations that all of them should be cached? Does it assume that every stellar function returns the same value with the same input? ---

[jira] [Commented] (METRON-1520) Add caching for stellar field transformations

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434561#comment-16434561 ] ASF GitHub Bot commented on METRON-1520: Github user cestella commented on the issue:

[jira] [Commented] (METRON-1520) Add caching for stellar field transformations

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434497#comment-16434497 ] ASF GitHub Bot commented on METRON-1520: Github user ottobackwards commented on a diff in the

[GitHub] metron pull request #991: METRON-1521: JSONMapParser is no longer serializab...

2018-04-11 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/metron/pull/991 METRON-1521: JSONMapParser is no longer serializable ## Contributor Comments Currently the JSONMapParser does not function because an anonymous inner class (TypeRef) is not serializable.

[GitHub] metron issue #990: METRON-1520: Add caching for stellar field transformation...

2018-04-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/990 I think that the assumptions that it makes about the ability to cache the output, and apply to every transformation or every function may be a bit optimistic. I would have it off by

[jira] [Created] (METRON-1521) JSONMapParser is no longer serializable

2018-04-11 Thread Casey Stella (JIRA)
Casey Stella created METRON-1521: Summary: JSONMapParser is no longer serializable Key: METRON-1521 URL: https://issues.apache.org/jira/browse/METRON-1521 Project: Metron Issue Type: Bug

[GitHub] metron issue #990: METRON-1520: Add caching for stellar field transformation...

2018-04-11 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/990 Yes, the caching semantics are the same as the enrichment topology; namely that we cache all stellar expressions. You can, however, turn caching off in the parsers in the case that you

[GitHub] metron pull request #988: METRON-1445: Update performance tuning guide with ...

2018-04-11 Thread mmiklavc
GitHub user mmiklavc opened a pull request: https://github.com/apache/metron/pull/988 METRON-1445: Update performance tuning guide with more explicit parameter instructions ## Contributor Comments https://issues.apache.org/jira/browse/METRON-1445 The current

[jira] [Commented] (METRON-1445) Update performance tuning guide with more explicit parameter instructions

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433494#comment-16433494 ] ASF GitHub Bot commented on METRON-1445: GitHub user mmiklavc opened a pull request:

[jira] [Commented] (METRON-1421) Create a SolrMetaAlertDao

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434877#comment-16434877 ] ASF GitHub Bot commented on METRON-1421: Github user justinleet commented on the issue:

[GitHub] metron issue #970: METRON-1421: Create a SolrMetaAlertDao

2018-04-11 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/970 @merrimanr The previous commits should also (hopefully) resolve the issues with `source.type` vs `source:type`. Given that there were issues with the tests and test schemas themselves I haven't

[GitHub] metron issue #970: METRON-1421: Create a SolrMetaAlertDao

2018-04-11 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/970 @nickwallen Refactoring should be done, barring any additional changes. The only abstract class ends up being the UpdateDao (unless we want to be consistent), because mutation is really the main

[jira] [Commented] (METRON-1421) Create a SolrMetaAlertDao

2018-04-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434837#comment-16434837 ] ASF GitHub Bot commented on METRON-1421: Github user justinleet commented on the issue: