[GitHub] metron issue #1009: 1549: Add empty object test to WriterBoltIntegrationTest...

2018-05-09 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1009 Looks like a typo on the title of the PR... "METRON-1549" ---

[GitHub] metron pull request #1001: METRON-1532: Getting started documentation improv...

2018-05-09 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/1001#discussion_r187058040 --- Diff: metron-deployment/development/centos6/README.md --- @@ -103,3 +103,8 @@ Tags are listed in the playbooks, some frequently used tags

[GitHub] metron issue #998: METRON-1530: Default proxy config settings in metron-cont...

2018-05-09 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/998 LGTM @merrimanr are you +1 on this now? ---

[GitHub] metron pull request #1004: METRON-1489: Retrofit UI tests to run reliably du...

2018-04-27 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/1004#discussion_r184743288 --- Diff: metron-interface/metron-alerts/e2e/alert-details/alert-status/alert-details-status.e2e-spec.ts --- @@ -23,64 +23,67 @@ import

[GitHub] metron pull request #1004: METRON-1489: Retrofit UI tests to run reliably du...

2018-04-27 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/1004#discussion_r184743321 --- Diff: metron-interface/metron-alerts/e2e/alert-details/alert-status/alert-details-status.e2e-spec.ts --- @@ -101,7 +104,7 @@ describe

[GitHub] metron pull request #1020: METRON-1567: Large error message can't be written...

2018-05-18 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/1020#discussion_r189398418 --- Diff: metron-platform/metron-solr/src/main/config/schema/error/schema.xml --- @@ -40,6 +39,8 @@ guid

[GitHub] metron pull request #1020: METRON-1567: Large error message can't be written...

2018-05-18 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/1020#discussion_r189402062 --- Diff: metron-platform/metron-solr/src/main/config/schema/error/schema.xml --- @@ -40,6 +39,8 @@ guid

[GitHub] metron issue #1021: METRON-1568: Stellar should have a _ special variable wh...

2018-05-22 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1021 This is a great feature from my perspective. I've seen a number of people try and build solutions that require access to the whole message for a bunch of custom functions, models, rules

[GitHub] metron pull request #1060: METRON-1615 Default endpoint locations based on A...

2018-06-12 Thread simonellistonball
GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/1060 METRON-1615 Default endpoint locations based on Ambari service locations and config ## Contributor Comments For certain values, the mpacks will now default values for the following

[GitHub] metron issue #1063: METRON-1618: Stellar boolean expressions should treat mi...

2018-06-17 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1063 Should the example target state not be: `is_alert := is_alert || geo_outlier` We should probably have a test for that, but I assume the null is falsey would apply on both

[GitHub] metron issue #1132: METRON-1695: Expose pcap properties through Ambari

2018-08-01 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1132 +1 to that, PCAP should definitely get its own service, but agreed with @anandsubbu that should probably be a follow on item. ---

[GitHub] metron pull request #1150: METRON-1707 Port Profiler to Spark [Feature Branc...

2018-08-16 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/1150#discussion_r210596217 --- Diff: metron-analytics/metron-profiler-spark/src/main/java/org/apache/metron/profiler/spark/function/ProfileBuilderFunction.java --- @@ -0,0

[GitHub] metron issue #1150: METRON-1707 Port Profiler to Spark [Feature Branch]

2018-08-13 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1150 Do we have to use groupByKey in the spark implementation, is it not possible to use reduceByKey to build the profiles, since profilers are by definition reducible. I've seen groupByKey

[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...

2018-08-28 Thread simonellistonball
Github user simonellistonball closed the pull request at: https://github.com/apache/metron/pull/ ---

[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...

2018-08-27 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/#discussion_r213124377 --- Diff: metron-interface/metron-alerts-host/src/main/scripts/metron-alerts.sh --- @@ -0,0 +1,55 @@ +#!/usr/bin/env bash

[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...

2018-08-27 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/#discussion_r213124491 --- Diff: metron-interface/metron-ui-host/pom.xml --- @@ -0,0 +1,142 @@ + + +http://maven.apache.org/POM/4.0.0; +xmlns:xsi

[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...

2018-08-28 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/#discussion_r213198753 --- Diff: metron-interface/metron-alerts-host/src/main/java/org/apache/metron/ui/AlertsApplication.java --- @@ -0,0 +1,31

[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...

2018-08-28 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/#discussion_r213198883 --- Diff: metron-interface/metron-alerts-host/pom.xml --- @@ -0,0 +1,143 @@ + --- End diff -- Done, and agreed, it should

[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...

2018-08-28 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/#discussion_r213198659 --- Diff: metron-interface/metron-ui-host/pom.xml --- @@ -0,0 +1,142 @@ + + +http://maven.apache.org/POM/4.0.0; +xmlns:xsi

[GitHub] metron pull request #1172: METRON-1724: Date/time validation missing in PCAP...

2018-08-22 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/1172#discussion_r211964997 --- Diff: metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts --- @@ -15,63 +15,116 @@ * See the License

[GitHub] metron issue #1111: METRON-1665 Host UIs on Spring Boot and add SSO authenti...

2018-08-23 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/ Thanks for the catches Ryan. My objective around metron-rest was to try and leave it as little changed as possible in this effort, since the ticket is more around the ui hosts

[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...

2018-08-23 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/#discussion_r212270804 --- Diff: metron-interface/metron-rest-client/bin/pom.xml --- @@ -0,0 +1,52 @@ + --- End diff -- Yes. Will remove. ---

[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...

2018-08-23 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/#discussion_r212225176 --- Diff: metron-interface/metron-ui-host/pom.xml --- @@ -0,0 +1,142 @@ + + +http://maven.apache.org/POM/4.0.0; +xmlns:xsi

[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...

2018-08-23 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/#discussion_r212275406 --- Diff: metron-interface/metron-alerts-host/src/main/scripts/metron-alerts.sh --- @@ -0,0 +1,55 @@ +#!/usr/bin/env bash

[GitHub] metron pull request #1127: METRON-1666 Mpack updates for LDAP, SSO config an...

2018-07-20 Thread simonellistonball
GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/1127 METRON-1666 Mpack updates for LDAP, SSO config and removal of JPA ## Contributor Comments MPack updates to go with METRON-1665. This adds settings for the SSO, LDAP

[GitHub] metron pull request #1104: METRON-1670 Stellar WEEK_OF_YEAR test is locale s...

2018-07-16 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/1104#discussion_r202600375 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/DateFunctionsTest.java --- @@ -182,7 +182,8

[GitHub] metron issue #1112: METRON-1668 Remove login services and screens from UIs

2018-07-19 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1112 And infact through form based auth if sso is off (see the backend issue METRON-1665). This PR just removes the need to process a spring login form in the Angular app to lighten the load

[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...

2018-07-19 Thread simonellistonball
GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/ METRON-1665 Host UIs on Spring Boot and add SSO authentication This is part of a move towards using KnoxSSO, and LDAP as an authentication method for Metron UIs. The current UIs

[GitHub] metron issue #1112: METRON-1668 Remove login services and screens from UIs

2018-07-19 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1112 Patience, patience :) https://issues.apache.org/jira/browse/METRON-1664 will set all this up in ambari to work on full-dev with an embedded ldap (instead of the current embedded h2

[GitHub] metron issue #1112: METRON-1668 Remove login services and screens from UIs

2018-07-19 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1112 It would also support ldap authentication, via basic auth. ---

[GitHub] metron pull request #1112: METRON-1668 Remove login services and screens fro...

2018-07-19 Thread simonellistonball
GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/1112 METRON-1668 Remove login services and screens from UIs ## Contributor Comments Removing the login screens and modules from the UIs since they are superfluous in the the SSO

[GitHub] metron pull request #1113: METRON-1667 Remove the JPA and MySQL elements

2018-07-19 Thread simonellistonball
GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/1113 METRON-1667 Remove the JPA and MySQL elements ## Contributor Comments Given that the only use of the JPA elements was for persisting a user database, these dependencies

[GitHub] metron issue #1112: METRON-1668 Remove login services and screens from UIs

2018-07-19 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1112 In the case of non-SSO ldap auth, there is a login form, it's just embedded in the spring bits instead of the angular bits. It's not as pretty, but we could add a login.jsp to make

[GitHub] metron pull request #1113: METRON-1667 Remove the JPA and MySQL elements

2018-07-19 Thread simonellistonball
Github user simonellistonball closed the pull request at: https://github.com/apache/metron/pull/1113 ---

[GitHub] metron pull request #1114: METRON-1667 Remove the JPA and MySQL elements

2018-07-19 Thread simonellistonball
GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/1114 METRON-1667 Remove the JPA and MySQL elements ## Contributor Comments Given that the only use of the JPA elements was for persisting a user database, these dependencies

[GitHub] metron issue #1113: METRON-1667 Remove the JPA and MySQL elements

2018-07-19 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1113 Apologies, re-submitting against the feature branch. ---

[GitHub] metron issue #1112: METRON-1668 Remove login services and screens from UIs

2018-09-05 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1112 @mmiklavc the knoxsso is enabled with a toggle in the mpack, to follow the pattern for NiFi, Ranger and Atlas etc. There is a kind of failover of auth methods: knoxsso, ldap, nothing

[GitHub] metron pull request #1096: METRON-1476: Update Angular in Alerts UI

2018-07-13 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/1096#discussion_r202303847 --- Diff: pom.xml --- @@ -348,6 +348,16 @@ metron-interface/metron-config README and NOTICE files

[GitHub] metron pull request #1104: METRON-1670 Stellar WEEK_OF_YEAR test is locale s...

2018-07-13 Thread simonellistonball
GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/1104 METRON-1670 Stellar WEEK_OF_YEAR test is locale sensitive ## Contributor Comments Tests were previously not local sensitive. Used a locale sensitive Calendar instance

[GitHub] metron issue #978: METRON-1507 Added support for vagrant cachier

2018-04-04 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/978 The PR includes ubuntu support, the cachier would just cache debs from apt instead of rpms from yum. TBH I've tested centos more than ubuntu. The use is still the same though, should

[GitHub] metron pull request #978: METRON-1507 Added support for vagrant cachier

2018-04-04 Thread simonellistonball
GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/978 METRON-1507 Added support for vagrant cachier ## Contributor Comments This is a Vagrant config change to enable the use of vagrant-cachier to reduce build times for the full dev

[GitHub] metron issue #978: METRON-1507 Added support for vagrant cachier

2018-04-04 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/978 The yum stuff only happens in the centos include in ansible, it's not necessary in the ubuntu version, which uses a different ansible include. An extra test for the record

[GitHub] metron issue #978: METRON-1507 Added support for vagrant cachier

2018-04-04 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/978 Ooops... wrong branch. Let me sort out the PR. ---

[GitHub] metron pull request #978: METRON-1507 Added support for vagrant cachier

2018-04-04 Thread simonellistonball
Github user simonellistonball closed the pull request at: https://github.com/apache/metron/pull/978 ---

[GitHub] metron pull request #979: METRON-1507 Added support for vagrant cachier

2018-04-04 Thread simonellistonball
GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/979 METRON-1507 Added support for vagrant cachier ## Contributor Comments This is a Vagrant config change to enable the use of vagrant-cachier to reduce build times for the full dev

[GitHub] metron pull request #979: METRON-1507 Added support for vagrant cachier

2018-04-12 Thread simonellistonball
Github user simonellistonball closed the pull request at: https://github.com/apache/metron/pull/979 ---

[GitHub] metron pull request #993: METRON-1507 Add configuration in development vagra...

2018-04-12 Thread simonellistonball
GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/993 METRON-1507 Add configuration in development vagrant files to support vagrant cac… ## Contributor Comments This is a Vagrant config change to enable the use of vagrant-cachier

[GitHub] metron issue #873: METRON-1367 Stellar should have some instrumentation of f...

2018-04-04 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/873 Did it work out for you to find bottlenecks @ottobackwards ? I would be more inclined to do multi-run micro-benchmarking (I have a bunch of multi-sample perfidix runs on all the parser

[GitHub] metron issue #873: METRON-1367 Stellar should have some instrumentation of f...

2018-04-04 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/873 Well, if it helped, cool, let’s keep it... was just curious about your use case and whether we should have a bolder scope or if there is anything like this that would help elsewhere

[GitHub] metron issue #942: METRON-1461: Modify the MIN, MAX Stellar methods to take ...

2018-04-20 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/942 Do we think we've reached consensus on this? It seems like avoiding the mixed scenarios is a good thing from a performance perspective, which is key to something like this which

[GitHub] metron issue #1001: METRON-1532: Getting started documentation improvements

2018-04-23 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1001 +1 thees are useful additions for anyone getting started. ---

[GitHub] metron issue #1233: METRON-1816: Date format Stellar function

2018-10-17 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1233 Looks like a very useful gap filler to me. +1 (non-binding) by inspection from me for sure. ---

[GitHub] metron issue #1233: METRON-1816: Date format Stellar function

2018-10-17 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1233 I would worry about having to parse the strong argument to determine whether to use a constant or custom formatter, but I guess my concern is limited because we’re caching the formatter

[GitHub] metron issue #1233: METRON-1816: Date format Stellar function

2018-10-17 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1233 @ottobackwards wouldn't ISO constant support require us to do a check on the string before passing to the DateFormat instance, which on something that is likely to be run A LOT (i.e

[GitHub] metron issue #1233: METRON-1816: Date format Stellar function

2018-10-17 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1233 Right, I hear that! I also really like the idea of a follow on function that returns the default formats as a great solution to this problem. Should we do that? ---

[GitHub] metron pull request #1203: METRON-1755 Create an architecture document for M...

2018-09-18 Thread simonellistonball
GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/1203 METRON-1755 Create an architecture document for METRON-1663 ## Contributor Comments This adds documentation on the authentication methods used in METRON-1663. ## Pull Request

[GitHub] metron issue #1186: METRON-1756: REST tests should use Embedded LDAP in metr...

2018-09-12 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1186 +1 by inspection, good call to align it with the other tests instead of leaking the in-memory auth mechanism in. ---

[GitHub] metron pull request #1114: METRON-1667 Remove the JPA and MySQL elements

2018-09-12 Thread simonellistonball
Github user simonellistonball closed the pull request at: https://github.com/apache/metron/pull/1114 ---

[GitHub] metron pull request #1114: METRON-1667 Remove the JPA and MySQL elements

2018-09-12 Thread simonellistonball
Github user simonellistonball closed the pull request at: https://github.com/apache/metron/pull/1114 ---

[GitHub] metron pull request #1193: METRON-1667 Remove the JPA and MySQL elements

2018-09-12 Thread simonellistonball
GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/1193 METRON-1667 Remove the JPA and MySQL elements ## Contributor Comments Given that the only use of the JPA elements was for persisting a user database, these dependencies

[GitHub] metron pull request #1114: METRON-1667 Remove the JPA and MySQL elements

2018-09-12 Thread simonellistonball
GitHub user simonellistonball reopened a pull request: https://github.com/apache/metron/pull/1114 METRON-1667 Remove the JPA and MySQL elements ## Contributor Comments Given that the only use of the JPA elements was for persisting a user database, these dependencies

[GitHub] metron issue #1060: METRON-1615 Default endpoint locations based on Ambari s...

2018-10-02 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1060 The fix is not necessary in pure Apache Ambari, and is only required in a non-Apache toolchain, hence from a pure Apache perspective 'works as designed' (just not very inclusively

[GitHub] metron pull request #1193: METRON-1667 Remove the JPA and MySQL elements

2018-09-28 Thread simonellistonball
Github user simonellistonball closed the pull request at: https://github.com/apache/metron/pull/1193 ---

[GitHub] metron pull request #1203: METRON-1755 Create an architecture document for M...

2018-09-28 Thread simonellistonball
Github user simonellistonball closed the pull request at: https://github.com/apache/metron/pull/1203 ---

[GitHub] metron pull request #1112: METRON-1668 Remove login services and screens fro...

2018-09-28 Thread simonellistonball
Github user simonellistonball closed the pull request at: https://github.com/apache/metron/pull/1112 ---

[GitHub] metron pull request #1127: METRON-1666 Mpack updates for LDAP, SSO config an...

2018-09-28 Thread simonellistonball
Github user simonellistonball closed the pull request at: https://github.com/apache/metron/pull/1127 ---

[GitHub] metron issue #1060: METRON-1615 Default endpoint locations based on Ambari s...

2018-10-01 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1060 Turns out this is (in theory) done by the service advisor at https://github.com/apache/metron/blob/ff1f9cf52b31ae866eb3de1cf8993af97af1790f/metron-deployment/packaging/ambari

[GitHub] metron pull request #1060: METRON-1615 Default endpoint locations based on A...

2018-10-01 Thread simonellistonball
Github user simonellistonball closed the pull request at: https://github.com/apache/metron/pull/1060 ---