[GitHub] metron issue #687: METRON-1090 Add Assignment to Stellar Language
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/687 I don't quite get what you are saying. I can't wrap my head around it. If you look at the example from the PR description under concept, that doesn't work without the resolver being updated. I have to be missing something ---
[GitHub] metron issue #687: METRON-1090 Add Assignment to Stellar Language
Github user cestella commented on the issue: https://github.com/apache/metron/pull/687 Sorry, @ottobackwards this got lost in the shuffle. What I was saying was that I think we should not adjust the VariableResolver infrastructure to update variables as the result of assignments, but rather return back the variable and the updated object. For instance, in the `BaseStellarProcessor` class we have a `parse` method that returns the output of the expression. I'd suggest we have a `parseExpression` and `parseAssignment` where the first acts as it does now and the second returns the variable name and the result. As a follow-on, I think we can adjust the variableresolver infrastructure to support variable updates. I guess ultimately, I suggest a tactical solution that leads us to the right direction rather than trying to fix it all at once. Thoughts? ---
[GitHub] metron issue #687: METRON-1090 Add Assignment to Stellar Language
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/687 Bump @cestella ---
[GitHub] metron issue #687: METRON-1090 Add Assignment to Stellar Language
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/687 This is pretty old at this point, and there has been a lot of discussion all over the place about it. I'm not sure I can sum up where we are. @cestella can you sum up your current feeling on how we can move this forward? ---
[GitHub] metron issue #687: METRON-1090 Add Assignment to Stellar Language
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/687 @nickwallen @cestella @mattf-horton , Sorry, I thought that question was more to @mattf-horton at the time. @cestella I'm not sure I understand what you are saying. Are you saying that we should not do assignment until we overhaul the current mechanisms? That this is too much a 1/2 measure? ---
[GitHub] metron issue #687: METRON-1090 Add Assignment to Stellar Language
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/687 > @cestella Should we perhaps separate parsing assignments (e.g. move StellarAssignment.from into the language like you've done here) from actually updating the variables. @ottobackwards I didn't see you respond to this. I would agree with @cestella on this. ---
[GitHub] metron issue #687: METRON-1090 Add Assignment to Stellar Language
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/687 Bump ---
