[jira] [Commented] (METRON-1499) Enable Configuration of Unified Enrichment Topology via Ambari
[ https://issues.apache.org/jira/browse/METRON-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16442525#comment-16442525 ] ASF GitHub Bot commented on METRON-1499: Github user mraliagha commented on the issue: https://github.com/apache/metron/pull/984 Great Idea to keep both for a while. Thanks. > Enable Configuration of Unified Enrichment Topology via Ambari > -- > > Key: METRON-1499 > URL: https://issues.apache.org/jira/browse/METRON-1499 > Project: Metron > Issue Type: Improvement >Reporter: Nick Allen >Assignee: Nick Allen >Priority: Major > > We recently introduced an alternative enrichment topology that is being > called the "Unified" enrichment topology. This is an alternative to the > existing "Split Join" topology. > > We need to enhance the MPack so that a user can configure, stop, and start > either the "Unified" or the "Split Join" enrichment topology. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1499) Enable Configuration of Unified Enrichment Topology via Ambari
[ https://issues.apache.org/jira/browse/METRON-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440867#comment-16440867 ] ASF GitHub Bot commented on METRON-1499: Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/984 > Enable Configuration of Unified Enrichment Topology via Ambari > -- > > Key: METRON-1499 > URL: https://issues.apache.org/jira/browse/METRON-1499 > Project: Metron > Issue Type: Improvement >Reporter: Nick Allen >Assignee: Nick Allen >Priority: Major > > We recently introduced an alternative enrichment topology that is being > called the "Unified" enrichment topology. This is an alternative to the > existing "Split Join" topology. > > We need to enhance the MPack so that a user can configure, stop, and start > either the "Unified" or the "Split Join" enrichment topology. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1499) Enable Configuration of Unified Enrichment Topology via Ambari
[ https://issues.apache.org/jira/browse/METRON-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440852#comment-16440852 ] ASF GitHub Bot commented on METRON-1499: Github user cestella commented on the issue: https://github.com/apache/metron/pull/984 This looks good to me; +1 by inspection. > Enable Configuration of Unified Enrichment Topology via Ambari > -- > > Key: METRON-1499 > URL: https://issues.apache.org/jira/browse/METRON-1499 > Project: Metron > Issue Type: Improvement >Reporter: Nick Allen >Assignee: Nick Allen >Priority: Major > > We recently introduced an alternative enrichment topology that is being > called the "Unified" enrichment topology. This is an alternative to the > existing "Split Join" topology. > > We need to enhance the MPack so that a user can configure, stop, and start > either the "Unified" or the "Split Join" enrichment topology. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1499) Enable Configuration of Unified Enrichment Topology via Ambari
[ https://issues.apache.org/jira/browse/METRON-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434127#comment-16434127 ] ASF GitHub Bot commented on METRON-1499: Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/984#discussion_r180814327 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-enrichment-env.xml --- @@ -129,70 +145,156 @@ enrichment_topology_max_spout_pending Spout Max Pending Tuples for the Enrichment Topology - -Enrichment Max Pending +500 --- End diff -- Ok, that works. It certainly deserved an explanation from me, so glad you called that out. > Enable Configuration of Unified Enrichment Topology via Ambari > -- > > Key: METRON-1499 > URL: https://issues.apache.org/jira/browse/METRON-1499 > Project: Metron > Issue Type: Improvement >Reporter: Nick Allen >Assignee: Nick Allen >Priority: Major > > We recently introduced an alternative enrichment topology that is being > called the "Unified" enrichment topology. This is an alternative to the > existing "Split Join" topology. > > We need to enhance the MPack so that a user can configure, stop, and start > either the "Unified" or the "Split Join" enrichment topology. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1499) Enable Configuration of Unified Enrichment Topology via Ambari
[ https://issues.apache.org/jira/browse/METRON-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434126#comment-16434126 ] ASF GitHub Bot commented on METRON-1499: Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/984 Let me know if there is anything else we need on this one guys. Thanks for the looks so far. > Enable Configuration of Unified Enrichment Topology via Ambari > -- > > Key: METRON-1499 > URL: https://issues.apache.org/jira/browse/METRON-1499 > Project: Metron > Issue Type: Improvement >Reporter: Nick Allen >Assignee: Nick Allen >Priority: Major > > We recently introduced an alternative enrichment topology that is being > called the "Unified" enrichment topology. This is an alternative to the > existing "Split Join" topology. > > We need to enhance the MPack so that a user can configure, stop, and start > either the "Unified" or the "Split Join" enrichment topology. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1499) Enable Configuration of Unified Enrichment Topology via Ambari
[ https://issues.apache.org/jira/browse/METRON-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433897#comment-16433897 ] ASF GitHub Bot commented on METRON-1499: Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/984#discussion_r18074 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-enrichment-env.xml --- @@ -129,70 +145,156 @@ enrichment_topology_max_spout_pending Spout Max Pending Tuples for the Enrichment Topology - -Enrichment Max Pending +500 --- End diff -- I can get behind a sane default. I retract my comment. > Enable Configuration of Unified Enrichment Topology via Ambari > -- > > Key: METRON-1499 > URL: https://issues.apache.org/jira/browse/METRON-1499 > Project: Metron > Issue Type: Improvement >Reporter: Nick Allen >Assignee: Nick Allen >Priority: Major > > We recently introduced an alternative enrichment topology that is being > called the "Unified" enrichment topology. This is an alternative to the > existing "Split Join" topology. > > We need to enhance the MPack so that a user can configure, stop, and start > either the "Unified" or the "Split Join" enrichment topology. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1499) Enable Configuration of Unified Enrichment Topology via Ambari
[ https://issues.apache.org/jira/browse/METRON-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430898#comment-16430898 ] ASF GitHub Bot commented on METRON-1499: Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/984#discussion_r180167513 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-enrichment-env.xml --- @@ -129,70 +145,156 @@ enrichment_topology_max_spout_pending Spout Max Pending Tuples for the Enrichment Topology - -Enrichment Max Pending +500 --- End diff -- +1 for a sane default > Enable Configuration of Unified Enrichment Topology via Ambari > -- > > Key: METRON-1499 > URL: https://issues.apache.org/jira/browse/METRON-1499 > Project: Metron > Issue Type: Improvement >Reporter: Nick Allen >Assignee: Nick Allen >Priority: Major > > We recently introduced an alternative enrichment topology that is being > called the "Unified" enrichment topology. This is an alternative to the > existing "Split Join" topology. > > We need to enhance the MPack so that a user can configure, stop, and start > either the "Unified" or the "Split Join" enrichment topology. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1499) Enable Configuration of Unified Enrichment Topology via Ambari
[ https://issues.apache.org/jira/browse/METRON-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430891#comment-16430891 ] ASF GitHub Bot commented on METRON-1499: Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/984#discussion_r180166554 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-enrichment-env.xml --- @@ -129,70 +145,156 @@ enrichment_topology_max_spout_pending Spout Max Pending Tuples for the Enrichment Topology - -Enrichment Max Pending +500 --- End diff -- But this is definitely not necessary for the task at hand; METRON-1499. If this is contentious, I can certainly pull this change out of this PR. I could then submit a separate PR where we can debate this point. I don't want to hang up this PR for something unrelated. I'm good with either way. > Enable Configuration of Unified Enrichment Topology via Ambari > -- > > Key: METRON-1499 > URL: https://issues.apache.org/jira/browse/METRON-1499 > Project: Metron > Issue Type: Improvement >Reporter: Nick Allen >Assignee: Nick Allen >Priority: Major > > We recently introduced an alternative enrichment topology that is being > called the "Unified" enrichment topology. This is an alternative to the > existing "Split Join" topology. > > We need to enhance the MPack so that a user can configure, stop, and start > either the "Unified" or the "Split Join" enrichment topology. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1499) Enable Configuration of Unified Enrichment Topology via Ambari
[ https://issues.apache.org/jira/browse/METRON-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430834#comment-16430834 ] ASF GitHub Bot commented on METRON-1499: Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/984#discussion_r180154515 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-enrichment-env.xml --- @@ -129,70 +145,156 @@ enrichment_topology_max_spout_pending Spout Max Pending Tuples for the Enrichment Topology - -Enrichment Max Pending +500 --- End diff -- This is about tuning the user's day 1 experience. Specifically what I have seen is on day 1 users push some telemetry into a topic, start up the topology, and the topology just blows-up. They have no idea why because they are on day 1. That is a bad experience. The topology blows-up because on day 1 the user is running with a topology that has NOT been tuned. The topology blows-up because when this value is undefined there is no back pressure. We need some back pressure here to avoid the day 1 blow-up. I'd prefer a day 1 user be able to start up the topology and see it actually work, albeit slowly, under most conditions. A user running against heavier load is more likely to be experienced and should have more knowledge to know that this value needs increased. > Enable Configuration of Unified Enrichment Topology via Ambari > -- > > Key: METRON-1499 > URL: https://issues.apache.org/jira/browse/METRON-1499 > Project: Metron > Issue Type: Improvement >Reporter: Nick Allen >Assignee: Nick Allen >Priority: Major > > We recently introduced an alternative enrichment topology that is being > called the "Unified" enrichment topology. This is an alternative to the > existing "Split Join" topology. > > We need to enhance the MPack so that a user can configure, stop, and start > either the "Unified" or the "Split Join" enrichment topology. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1499) Enable Configuration of Unified Enrichment Topology via Ambari
[ https://issues.apache.org/jira/browse/METRON-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430796#comment-16430796 ] ASF GitHub Bot commented on METRON-1499: Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/984#discussion_r180150453 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-enrichment-env.xml --- @@ -129,70 +145,156 @@ enrichment_topology_max_spout_pending Spout Max Pending Tuples for the Enrichment Topology - -Enrichment Max Pending +500 --- End diff -- This seems super low..shouldn't we leave this unspecified and default to the storm default? > Enable Configuration of Unified Enrichment Topology via Ambari > -- > > Key: METRON-1499 > URL: https://issues.apache.org/jira/browse/METRON-1499 > Project: Metron > Issue Type: Improvement >Reporter: Nick Allen >Assignee: Nick Allen >Priority: Major > > We recently introduced an alternative enrichment topology that is being > called the "Unified" enrichment topology. This is an alternative to the > existing "Split Join" topology. > > We need to enhance the MPack so that a user can configure, stop, and start > either the "Unified" or the "Split Join" enrichment topology. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1499) Enable Configuration of Unified Enrichment Topology via Ambari
[ https://issues.apache.org/jira/browse/METRON-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427705#comment-16427705 ] ASF GitHub Bot commented on METRON-1499: GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/984 METRON-1499 Enable Configuration of Unified Enrichment Topology via Ambari We recently introduced an alternative enrichment topology; the Unified enrichment topology. This is an alternative to the existing Split Join topology. This work enhances the MPack so that a user can configure, stop, and start either the Unified or the Split Join enrichment topology. * Each topology has a separate configuration section under the Metron > Enrichment settings in Ambari. * A combo box allows the user to choose which Enrichment topology should be run. * The Split Join topology remains the default Enrichment topology. * The `bin/start_enrichment_topology.sh` script was enhanced so that you can pass in the `--filter` and `--remote` args directly to launch an alternative topology. Running the script with no parameters will launch the default topology; Split Join. * The Unified topology had previously reused some of the same settings from the Split Join topology. Where it made sense, the Unified topology was updated to use its own logically named properties. * There are now separate properties file for each Enrichment topology. `$METRON_HOME/config/enrichment-splitjoin.properties` `$METRON_HOME/config/enrichment-unified.properties` * There are separate flux files for each Enrichment topology. `$METRON_HOME/flux/enrichment/remote-splitjoin.yaml` `$METRON_HOME/flux/enrichment/remote-unified.yaml` ### Manual Testing To test this change, launch a development environment. The Split Join Enrichment topology will be running by default. Switch to the Unified topology. Change some settings and make sure they are reflected in the topology. ## Pull Request Checklist - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [ ] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? You can merge this pull request into a Git repository by running: $ git pull https://github.com/nickwallen/metron METRON-1499 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/984.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #984 commit 67735e0dd2ac119d826f08e5abb820438382381c Author: Nick Allen Date: 2018-04-05T15:56:36Z METRON-1499 Enable Configuration of Unified Enrichment Topology via Ambari > Enable Configuration of Unified Enrichment Topology via Ambari > -- > > Key: METRON-1499 > URL: https://issues.apache.org/jira/browse/METRON-1499 > Project: Metron > Issue Type: Improvement >Reporter: Nick Allen >Assignee: Nick Allen >Priority: Major > > We recently introduced an alternative enrichment topology that is being > called the "Unified" enrichment topology. This is an alternative to the > existing "Split Join" topology. > > We need to enhance the MPack so that a user can configure, stop, and start > either the "Unified" or the "Split Join" enrichment topology. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
