[jira] [Commented] (METRON-1733) PCAP UI - PCAP queries don't work on Safari
[ https://issues.apache.org/jira/browse/METRON-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579625#comment-16579625 ] ASF GitHub Bot commented on METRON-1733: Github user sardell closed the pull request at: https://github.com/apache/metron/pull/1158 > PCAP UI - PCAP queries don't work on Safari > --- > > Key: METRON-1733 > URL: https://issues.apache.org/jira/browse/METRON-1733 > Project: Metron > Issue Type: Sub-task >Reporter: Shane Ardell >Assignee: Shane Ardell >Priority: Major > > On Safari, PCAP queries fail with a 500 internal server error. No issues seen > with Chrome or Firefox. After digging into the search request, it looks like > the values for the startTime and endTime are 'NaN'. It looks like Safari > cannot parse the format of the time we are passing to the getDate() funciton. > For more on this issue: > https://stackoverflow.com/questions/21883699/safari-javascript-date-nan-issue--mm-dd-hhmmss -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1733) PCAP UI - PCAP queries don't work on Safari
[ https://issues.apache.org/jira/browse/METRON-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578913#comment-16578913 ] ASF GitHub Bot commented on METRON-1733: Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1158 Can you close this @sardell? > PCAP UI - PCAP queries don't work on Safari > --- > > Key: METRON-1733 > URL: https://issues.apache.org/jira/browse/METRON-1733 > Project: Metron > Issue Type: Sub-task >Reporter: Shane Ardell >Assignee: Shane Ardell >Priority: Major > > On Safari, PCAP queries fail with a 500 internal server error. No issues seen > with Chrome or Firefox. After digging into the search request, it looks like > the values for the startTime and endTime are 'NaN'. It looks like Safari > cannot parse the format of the time we are passing to the getDate() funciton. > For more on this issue: > https://stackoverflow.com/questions/21883699/safari-javascript-date-nan-issue--mm-dd-hhmmss -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1733) PCAP UI - PCAP queries don't work on Safari
[ https://issues.apache.org/jira/browse/METRON-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578910#comment-16578910 ] ASF GitHub Bot commented on METRON-1733: Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1158 I verified this in full dev. +1 > PCAP UI - PCAP queries don't work on Safari > --- > > Key: METRON-1733 > URL: https://issues.apache.org/jira/browse/METRON-1733 > Project: Metron > Issue Type: Sub-task >Reporter: Shane Ardell >Assignee: Shane Ardell >Priority: Major > > On Safari, PCAP queries fail with a 500 internal server error. No issues seen > with Chrome or Firefox. After digging into the search request, it looks like > the values for the startTime and endTime are 'NaN'. It looks like Safari > cannot parse the format of the time we are passing to the getDate() funciton. > For more on this issue: > https://stackoverflow.com/questions/21883699/safari-javascript-date-nan-issue--mm-dd-hhmmss -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1733) PCAP UI - PCAP queries don't work on Safari
[ https://issues.apache.org/jira/browse/METRON-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578771#comment-16578771 ] ASF GitHub Bot commented on METRON-1733: Github user sardell commented on the issue: https://github.com/apache/metron/pull/1158 Closing and reopening to rerun Travis. > PCAP UI - PCAP queries don't work on Safari > --- > > Key: METRON-1733 > URL: https://issues.apache.org/jira/browse/METRON-1733 > Project: Metron > Issue Type: Sub-task >Reporter: Shane Ardell >Assignee: Shane Ardell >Priority: Major > > On Safari, PCAP queries fail with a 500 internal server error. No issues seen > with Chrome or Firefox. After digging into the search request, it looks like > the values for the startTime and endTime are 'NaN'. It looks like Safari > cannot parse the format of the time we are passing to the getDate() funciton. > For more on this issue: > https://stackoverflow.com/questions/21883699/safari-javascript-date-nan-issue--mm-dd-hhmmss -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1733) PCAP UI - PCAP queries don't work on Safari
[ https://issues.apache.org/jira/browse/METRON-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578773#comment-16578773 ] ASF GitHub Bot commented on METRON-1733: GitHub user sardell reopened a pull request: https://github.com/apache/metron/pull/1158 METRON-1733: PCAP UI - PCAP queries don't work on Safari ## Contributor Comments This PR fixes a bug where Safari cannot read the format of the date we are passing to the startTimeMs and endTimeMs parameters. To resolve this, I used moment js (which was already being used in the project) to get the numeric value of the time strings instead of new Date().getTime(). ## Testing Using Safari, run a PCAP query in the Alerts UI. If you check the request payload, it should contain the correct numeric values for the startTimeMs and endTimeMs instead of NaN, and your search results should complete the same as they would in Chrome or another browser. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - n/a ~~Have you written or updated unit tests and or integration tests to verify your changes?~~ - n/a ~~If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?~~ - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - n/a ~~Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:~~ ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sardell/metron METRON-1733 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1158.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1158 commit 348d70da6b95ecd65f434f13805f0c95b0c62161 Author: Shane Ardell Date: 2018-08-10T15:34:52Z fix safari date NaN issue commit 027520ffba1577f3c0c8216c418d469465d496e7 Author: Shane Ardell Date: 2018-08-12T05:57:29Z Merge branch 'feature/METRON-1554-pcap-query-panel' into METRON-1733 > PCAP UI - PCAP queries don't work on Safari > --- > > Key: METRON-1733 > URL: https://issues.apache.org/jira/browse/METRON-1733 > Project: Metron > Issue Type: Sub-task >Reporter: Shane Ardell >Assignee: Shane Ardell >Priority: Major > > On Safari, PCAP queries fail with a 500 internal server error. No issues seen > with Chrome or Firefox. After
[jira] [Commented] (METRON-1733) PCAP UI - PCAP queries don't work on Safari
[ https://issues.apache.org/jira/browse/METRON-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578772#comment-16578772 ] ASF GitHub Bot commented on METRON-1733: Github user sardell closed the pull request at: https://github.com/apache/metron/pull/1158 > PCAP UI - PCAP queries don't work on Safari > --- > > Key: METRON-1733 > URL: https://issues.apache.org/jira/browse/METRON-1733 > Project: Metron > Issue Type: Sub-task >Reporter: Shane Ardell >Assignee: Shane Ardell >Priority: Major > > On Safari, PCAP queries fail with a 500 internal server error. No issues seen > with Chrome or Firefox. After digging into the search request, it looks like > the values for the startTime and endTime are 'NaN'. It looks like Safari > cannot parse the format of the time we are passing to the getDate() funciton. > For more on this issue: > https://stackoverflow.com/questions/21883699/safari-javascript-date-nan-issue--mm-dd-hhmmss -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1733) PCAP UI - PCAP queries don't work on Safari
[ https://issues.apache.org/jira/browse/METRON-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578732#comment-16578732 ] ASF GitHub Bot commented on METRON-1733: Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1158 @sardell can you close and reopen this PR to trigger another travis run? > PCAP UI - PCAP queries don't work on Safari > --- > > Key: METRON-1733 > URL: https://issues.apache.org/jira/browse/METRON-1733 > Project: Metron > Issue Type: Sub-task >Reporter: Shane Ardell >Assignee: Shane Ardell >Priority: Major > > On Safari, PCAP queries fail with a 500 internal server error. No issues seen > with Chrome or Firefox. After digging into the search request, it looks like > the values for the startTime and endTime are 'NaN'. It looks like Safari > cannot parse the format of the time we are passing to the getDate() funciton. > For more on this issue: > https://stackoverflow.com/questions/21883699/safari-javascript-date-nan-issue--mm-dd-hhmmss -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1733) PCAP UI - PCAP queries don't work on Safari
[ https://issues.apache.org/jira/browse/METRON-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578499#comment-16578499 ] ASF GitHub Bot commented on METRON-1733: Github user ruffle1986 commented on the issue: https://github.com/apache/metron/pull/1158 I think it's just enough the trigger a travis rebuild to make it pass. > PCAP UI - PCAP queries don't work on Safari > --- > > Key: METRON-1733 > URL: https://issues.apache.org/jira/browse/METRON-1733 > Project: Metron > Issue Type: Sub-task >Reporter: Shane Ardell >Assignee: Shane Ardell >Priority: Major > > On Safari, PCAP queries fail with a 500 internal server error. No issues seen > with Chrome or Firefox. After digging into the search request, it looks like > the values for the startTime and endTime are 'NaN'. It looks like Safari > cannot parse the format of the time we are passing to the getDate() funciton. > For more on this issue: > https://stackoverflow.com/questions/21883699/safari-javascript-date-nan-issue--mm-dd-hhmmss -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1733) PCAP UI - PCAP queries don't work on Safari
[ https://issues.apache.org/jira/browse/METRON-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576822#comment-16576822 ] ASF GitHub Bot commented on METRON-1733: Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1158 Pending Travis, lgtm via inspection. +1. Thanks for the contribution @sardell! > PCAP UI - PCAP queries don't work on Safari > --- > > Key: METRON-1733 > URL: https://issues.apache.org/jira/browse/METRON-1733 > Project: Metron > Issue Type: Sub-task >Reporter: Shane Ardell >Assignee: Shane Ardell >Priority: Major > > On Safari, PCAP queries fail with a 500 internal server error. No issues seen > with Chrome or Firefox. After digging into the search request, it looks like > the values for the startTime and endTime are 'NaN'. It looks like Safari > cannot parse the format of the time we are passing to the getDate() funciton. > For more on this issue: > https://stackoverflow.com/questions/21883699/safari-javascript-date-nan-issue--mm-dd-hhmmss -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (METRON-1733) PCAP UI - PCAP queries don't work on Safari
[ https://issues.apache.org/jira/browse/METRON-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576806#comment-16576806 ] ASF GitHub Bot commented on METRON-1733: GitHub user sardell opened a pull request: https://github.com/apache/metron/pull/1158 METRON-1733: PCAP UI - PCAP queries don't work on Safari ## Contributor Comments This PR fixes a bug where Safari cannot read the format of the date we are passing to the startTimeMs and endTimeMs parameters. To resolve this, I used moment js (which was already being used in the project) to get the numeric value of the time strings instead of new Date().getTime(). ## Testing Using Safari, run a PCAP query in the Alerts UI. If you check the request payload, it should contain the correct numeric values for the startTimeMs and endTimeMs instead of NaN, and your search results should complete the same as they would in Chrome or another browser. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [ ] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sardell/metron METRON-1733 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1158.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1158 commit 348d70da6b95ecd65f434f13805f0c95b0c62161 Author: Shane Ardell Date: 2018-08-10T15:34:52Z fix safari date NaN issue > PCAP UI - PCAP queries don't work on Safari > --- > > Key: METRON-1733 > URL: https://issues.apache.org/jira/browse/METRON-1733 > Project: Metron > Issue Type: Sub-task >Reporter: Shane Ardell >Assignee: Shane Ardell >Priority: Major > > On Safari, PCAP queries fail with a 500 internal server error. No issues seen > with Chrome or Firefox. After digging into the search request, it looks like > the values for the startTime and endTime are 'NaN'. It looks like Safari > cannot parse the format of the time we are passing to the getDate()
