[jira] [Commented] (METRON-1877) Nested IF ELSE statements can cause parse errors in Stellar
[
https://issues.apache.org/jira/browse/METRON-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693241#comment-16693241
]
ASF GitHub Bot commented on METRON-1877:
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/1268
> Nested IF ELSE statements can cause parse errors in Stellar
> ---
>
> Key: METRON-1877
> URL: https://issues.apache.org/jira/browse/METRON-1877
> Project: Metron
> Issue Type: Improvement
>Reporter: Justin Leet
>Assignee: Justin Leet
>Priority: Major
>
> IF ELSE statements nested inside IF ELSEstatements can cause problems with
> short-circuiting. See the following example.
> {code:java}
> Stellar>>> IF true THEN IF false THEN true ELSE false ELSE is_alert
> false
> Stellar>>> IF true THEN IF true THEN true ELSE false ELSE is_alert
> ! Invalid parse, found null
> org.apache.metron.stellar.dsl.ParseException: Invalid parse, found null
> at
> org.apache.metron.stellar.common.StellarCompiler$Expression.apply(StellarCompiler.java:211)
> at
> org.apache.metron.stellar.common.BaseStellarProcessor.parse(BaseStellarProcessor.java:145)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.executeStellar(DefaultStellarShellExecutor.java:401)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.execute(DefaultStellarShellExecutor.java:257)
> at
> org.apache.metron.stellar.common.shell.cli.StellarShell.execute(StellarShell.java:357)
> at org.jboss.aesh.console.AeshProcess.run(AeshProcess.java:53)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:748){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (METRON-1877) Nested IF ELSE statements can cause parse errors in Stellar
[
https://issues.apache.org/jira/browse/METRON-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691939#comment-16691939
]
ASF GitHub Bot commented on METRON-1877:
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1268
@mmiklavc I have no idea where that comes from.
```
{11:27}~/Documents/workspace/metron:master ✓ ➭ mvn dependency:tree
-Dverbose | grep SNAPSHOT
Downloading from apache.snapshots:
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat-plugin/0.13-SNAPSHOT/maven-metadata.xml
Downloading from apache.snapshots:
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat-project/0.13-SNAPSHOT/maven-metadata.xml
[INFO] +- com.google.code.tempus-fugit:tempus-fugit:jar:1.2-SNAPSHOT:test
```
The one jar is just a test jar, and the downloading is from the rat plugin
(that's been fixed, but I haven't pulled locally yet).
> Nested IF ELSE statements can cause parse errors in Stellar
> ---
>
> Key: METRON-1877
> URL: https://issues.apache.org/jira/browse/METRON-1877
> Project: Metron
> Issue Type: Improvement
>Reporter: Justin Leet
>Assignee: Justin Leet
>Priority: Major
>
> IF ELSE statements nested inside IF ELSEstatements can cause problems with
> short-circuiting. See the following example.
> {code:java}
> Stellar>>> IF true THEN IF false THEN true ELSE false ELSE is_alert
> false
> Stellar>>> IF true THEN IF true THEN true ELSE false ELSE is_alert
> ! Invalid parse, found null
> org.apache.metron.stellar.dsl.ParseException: Invalid parse, found null
> at
> org.apache.metron.stellar.common.StellarCompiler$Expression.apply(StellarCompiler.java:211)
> at
> org.apache.metron.stellar.common.BaseStellarProcessor.parse(BaseStellarProcessor.java:145)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.executeStellar(DefaultStellarShellExecutor.java:401)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.execute(DefaultStellarShellExecutor.java:257)
> at
> org.apache.metron.stellar.common.shell.cli.StellarShell.execute(StellarShell.java:357)
> at org.jboss.aesh.console.AeshProcess.run(AeshProcess.java:53)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:748){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (METRON-1877) Nested IF ELSE statements can cause parse errors in Stellar
[
https://issues.apache.org/jira/browse/METRON-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691909#comment-16691909
]
ASF GitHub Bot commented on METRON-1877:
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/1268
Hm, this looks possibly related to, but not the same as what was of concern
in 1247. In the client migration, there was some uncertainty in the
ElasticsearchSearchIntegrationTest. But this failure appears to be in the
indexing integration test. It's actually an error, not a normal failure. And it
appears to happen before any tests can start to run. Can you open a ticket? We
should track the intermittent failure, but I think it's unrelated to this PR.
Incidentally, I caught something in the logs I never noticed before. `90399
[main] INFO o.e.n.Node - version[5.6.2-SNAPSHOT], pid[21275],
build[Unknown/Unknown], OS[Linux/4.4.0-101-generic/amd64], JVM[Oracle
Corporation/Java HotSpot(TM) 64-Bit Server VM/1.8.0_151/25.151-b12]`. This
might also be worth looking into as I'm not sure if/why we should be depending
on a SNAPSHOT version.
> Nested IF ELSE statements can cause parse errors in Stellar
> ---
>
> Key: METRON-1877
> URL: https://issues.apache.org/jira/browse/METRON-1877
> Project: Metron
> Issue Type: Improvement
>Reporter: Justin Leet
>Assignee: Justin Leet
>Priority: Major
>
> IF ELSE statements nested inside IF ELSEstatements can cause problems with
> short-circuiting. See the following example.
> {code:java}
> Stellar>>> IF true THEN IF false THEN true ELSE false ELSE is_alert
> false
> Stellar>>> IF true THEN IF true THEN true ELSE false ELSE is_alert
> ! Invalid parse, found null
> org.apache.metron.stellar.dsl.ParseException: Invalid parse, found null
> at
> org.apache.metron.stellar.common.StellarCompiler$Expression.apply(StellarCompiler.java:211)
> at
> org.apache.metron.stellar.common.BaseStellarProcessor.parse(BaseStellarProcessor.java:145)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.executeStellar(DefaultStellarShellExecutor.java:401)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.execute(DefaultStellarShellExecutor.java:257)
> at
> org.apache.metron.stellar.common.shell.cli.StellarShell.execute(StellarShell.java:357)
> at org.jboss.aesh.console.AeshProcess.run(AeshProcess.java:53)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:748){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (METRON-1877) Nested IF ELSE statements can cause parse errors in Stellar
[
https://issues.apache.org/jira/browse/METRON-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691792#comment-16691792
]
ASF GitHub Bot commented on METRON-1877:
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1268
> @justinleet: Is it possible that the tests are more stable if we get in
#1247?
I am not sure. There might be an issue with ES's Bulk Writer refresh
policy (or the way that we use it) that we are relying on in those tests. I
ended up not relying on it for #1247 which may help, but may not solve the
entire issue if that is the root cause. That being said, this is all
speculation on my part.
> Nested IF ELSE statements can cause parse errors in Stellar
> ---
>
> Key: METRON-1877
> URL: https://issues.apache.org/jira/browse/METRON-1877
> Project: Metron
> Issue Type: Improvement
>Reporter: Justin Leet
>Assignee: Justin Leet
>Priority: Major
>
> IF ELSE statements nested inside IF ELSEstatements can cause problems with
> short-circuiting. See the following example.
> {code:java}
> Stellar>>> IF true THEN IF false THEN true ELSE false ELSE is_alert
> false
> Stellar>>> IF true THEN IF true THEN true ELSE false ELSE is_alert
> ! Invalid parse, found null
> org.apache.metron.stellar.dsl.ParseException: Invalid parse, found null
> at
> org.apache.metron.stellar.common.StellarCompiler$Expression.apply(StellarCompiler.java:211)
> at
> org.apache.metron.stellar.common.BaseStellarProcessor.parse(BaseStellarProcessor.java:145)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.executeStellar(DefaultStellarShellExecutor.java:401)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.execute(DefaultStellarShellExecutor.java:257)
> at
> org.apache.metron.stellar.common.shell.cli.StellarShell.execute(StellarShell.java:357)
> at org.jboss.aesh.console.AeshProcess.run(AeshProcess.java:53)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:748){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (METRON-1877) Nested IF ELSE statements can cause parse errors in Stellar
[
https://issues.apache.org/jira/browse/METRON-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691767#comment-16691767
]
ASF GitHub Bot commented on METRON-1877:
Github user justinleet closed the pull request at:
https://github.com/apache/metron/pull/1268
> Nested IF ELSE statements can cause parse errors in Stellar
> ---
>
> Key: METRON-1877
> URL: https://issues.apache.org/jira/browse/METRON-1877
> Project: Metron
> Issue Type: Improvement
>Reporter: Justin Leet
>Assignee: Justin Leet
>Priority: Major
>
> IF ELSE statements nested inside IF ELSEstatements can cause problems with
> short-circuiting. See the following example.
> {code:java}
> Stellar>>> IF true THEN IF false THEN true ELSE false ELSE is_alert
> false
> Stellar>>> IF true THEN IF true THEN true ELSE false ELSE is_alert
> ! Invalid parse, found null
> org.apache.metron.stellar.dsl.ParseException: Invalid parse, found null
> at
> org.apache.metron.stellar.common.StellarCompiler$Expression.apply(StellarCompiler.java:211)
> at
> org.apache.metron.stellar.common.BaseStellarProcessor.parse(BaseStellarProcessor.java:145)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.executeStellar(DefaultStellarShellExecutor.java:401)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.execute(DefaultStellarShellExecutor.java:257)
> at
> org.apache.metron.stellar.common.shell.cli.StellarShell.execute(StellarShell.java:357)
> at org.jboss.aesh.console.AeshProcess.run(AeshProcess.java:53)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:748){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (METRON-1877) Nested IF ELSE statements can cause parse errors in Stellar
[
https://issues.apache.org/jira/browse/METRON-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691766#comment-16691766
]
ASF GitHub Bot commented on METRON-1877:
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1268
Kicking Travis. The test failure is in metron-elasticsearch, and my
personal Travis passed
(https://travis-ci.org/justinleet/metron/builds/456098365).
@nickwallen Is it possible that the tests are more stable if we get in
https://github.com/apache/metron/pull/1247?
> Nested IF ELSE statements can cause parse errors in Stellar
> ---
>
> Key: METRON-1877
> URL: https://issues.apache.org/jira/browse/METRON-1877
> Project: Metron
> Issue Type: Improvement
>Reporter: Justin Leet
>Assignee: Justin Leet
>Priority: Major
>
> IF ELSE statements nested inside IF ELSEstatements can cause problems with
> short-circuiting. See the following example.
> {code:java}
> Stellar>>> IF true THEN IF false THEN true ELSE false ELSE is_alert
> false
> Stellar>>> IF true THEN IF true THEN true ELSE false ELSE is_alert
> ! Invalid parse, found null
> org.apache.metron.stellar.dsl.ParseException: Invalid parse, found null
> at
> org.apache.metron.stellar.common.StellarCompiler$Expression.apply(StellarCompiler.java:211)
> at
> org.apache.metron.stellar.common.BaseStellarProcessor.parse(BaseStellarProcessor.java:145)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.executeStellar(DefaultStellarShellExecutor.java:401)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.execute(DefaultStellarShellExecutor.java:257)
> at
> org.apache.metron.stellar.common.shell.cli.StellarShell.execute(StellarShell.java:357)
> at org.jboss.aesh.console.AeshProcess.run(AeshProcess.java:53)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:748){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (METRON-1877) Nested IF ELSE statements can cause parse errors in Stellar
[
https://issues.apache.org/jira/browse/METRON-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689830#comment-16689830
]
ASF GitHub Bot commented on METRON-1877:
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1268
+1, great job
> Nested IF ELSE statements can cause parse errors in Stellar
> ---
>
> Key: METRON-1877
> URL: https://issues.apache.org/jira/browse/METRON-1877
> Project: Metron
> Issue Type: Improvement
>Reporter: Justin Leet
>Assignee: Justin Leet
>Priority: Major
>
> IF ELSE statements nested inside IF ELSEstatements can cause problems with
> short-circuiting. See the following example.
> {code:java}
> Stellar>>> IF true THEN IF false THEN true ELSE false ELSE is_alert
> false
> Stellar>>> IF true THEN IF true THEN true ELSE false ELSE is_alert
> ! Invalid parse, found null
> org.apache.metron.stellar.dsl.ParseException: Invalid parse, found null
> at
> org.apache.metron.stellar.common.StellarCompiler$Expression.apply(StellarCompiler.java:211)
> at
> org.apache.metron.stellar.common.BaseStellarProcessor.parse(BaseStellarProcessor.java:145)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.executeStellar(DefaultStellarShellExecutor.java:401)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.execute(DefaultStellarShellExecutor.java:257)
> at
> org.apache.metron.stellar.common.shell.cli.StellarShell.execute(StellarShell.java:357)
> at org.jboss.aesh.console.AeshProcess.run(AeshProcess.java:53)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:748){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (METRON-1877) Nested IF ELSE statements can cause parse errors in Stellar
[
https://issues.apache.org/jira/browse/METRON-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689808#comment-16689808
]
ASF GitHub Bot commented on METRON-1877:
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/1268#discussion_r234303547
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/BasicStellarTest.java
---
@@ -916,6 +916,53 @@ public void testShortCircuit_conditional() throws
Exception {
Assert.assertEquals("foo", run("if NOT('metron' in [ 'metron',
'metronicus'] ) then THROW('expression') else 'foo'", new HashMap<>()));
}
--- End diff --
Added test cases for statement following the pattern
```
// IF TO_UPPER('foo') == 'FOO'
// THEN IF GET_FIRST(MAP(['test_true'], x -> TO_UPPER(x))) ==
'TEST_TRUE'
// THEN match{ var1 < 12 => 'less', var1 >= 10 => 'more', default
=> 'default'}
// ELSE 'b'
// ELSE 'c'
```
Does this meet what you're looking for? I'm not sure how deep you want to
go down the rabbit hole, but this seems like it's hitting a pretty good amount
of stuff on the inner IF (multiple functions, list syntax, lambda, ==, along
with a match in the then.
> Nested IF ELSE statements can cause parse errors in Stellar
> ---
>
> Key: METRON-1877
> URL: https://issues.apache.org/jira/browse/METRON-1877
> Project: Metron
> Issue Type: Improvement
>Reporter: Justin Leet
>Assignee: Justin Leet
>Priority: Major
>
> IF ELSE statements nested inside IF ELSEstatements can cause problems with
> short-circuiting. See the following example.
> {code:java}
> Stellar>>> IF true THEN IF false THEN true ELSE false ELSE is_alert
> false
> Stellar>>> IF true THEN IF true THEN true ELSE false ELSE is_alert
> ! Invalid parse, found null
> org.apache.metron.stellar.dsl.ParseException: Invalid parse, found null
> at
> org.apache.metron.stellar.common.StellarCompiler$Expression.apply(StellarCompiler.java:211)
> at
> org.apache.metron.stellar.common.BaseStellarProcessor.parse(BaseStellarProcessor.java:145)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.executeStellar(DefaultStellarShellExecutor.java:401)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.execute(DefaultStellarShellExecutor.java:257)
> at
> org.apache.metron.stellar.common.shell.cli.StellarShell.execute(StellarShell.java:357)
> at org.jboss.aesh.console.AeshProcess.run(AeshProcess.java:53)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:748){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (METRON-1877) Nested IF ELSE statements can cause parse errors in Stellar
[
https://issues.apache.org/jira/browse/METRON-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689826#comment-16689826
]
ASF GitHub Bot commented on METRON-1877:
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1268#discussion_r234305980
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/BasicStellarTest.java
---
@@ -916,6 +916,53 @@ public void testShortCircuit_conditional() throws
Exception {
Assert.assertEquals("foo", run("if NOT('metron' in [ 'metron',
'metronicus'] ) then THROW('expression') else 'foo'", new HashMap<>()));
}
--- End diff --
yeah, that is the idea. I had to add more and more permutations ( I added
tests for issues as @jjmeyer0 found them, or as @cestella found them )
If you have one mega case that works that is fine. I started out
differently, because I had things that did not work at the beginning and I
added later ( MAP support etc )
> Nested IF ELSE statements can cause parse errors in Stellar
> ---
>
> Key: METRON-1877
> URL: https://issues.apache.org/jira/browse/METRON-1877
> Project: Metron
> Issue Type: Improvement
>Reporter: Justin Leet
>Assignee: Justin Leet
>Priority: Major
>
> IF ELSE statements nested inside IF ELSEstatements can cause problems with
> short-circuiting. See the following example.
> {code:java}
> Stellar>>> IF true THEN IF false THEN true ELSE false ELSE is_alert
> false
> Stellar>>> IF true THEN IF true THEN true ELSE false ELSE is_alert
> ! Invalid parse, found null
> org.apache.metron.stellar.dsl.ParseException: Invalid parse, found null
> at
> org.apache.metron.stellar.common.StellarCompiler$Expression.apply(StellarCompiler.java:211)
> at
> org.apache.metron.stellar.common.BaseStellarProcessor.parse(BaseStellarProcessor.java:145)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.executeStellar(DefaultStellarShellExecutor.java:401)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.execute(DefaultStellarShellExecutor.java:257)
> at
> org.apache.metron.stellar.common.shell.cli.StellarShell.execute(StellarShell.java:357)
> at org.jboss.aesh.console.AeshProcess.run(AeshProcess.java:53)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:748){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (METRON-1877) Nested IF ELSE statements can cause parse errors in Stellar
[
https://issues.apache.org/jira/browse/METRON-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689801#comment-16689801
]
ASF GitHub Bot commented on METRON-1877:
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/1268#discussion_r234302996
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/StellarCompiler.java
---
@@ -219,14 +220,23 @@ public Object apply(ExpressionState state) {
//short circuit the if/then/else
instanceDeque.pop();
if((Boolean)curr.getValue()) {
-//choose then
-skipElse = true;
+//choose then. Need to make sure we're keeping track of
nesting.
+skipElseCount++;
} else {
//choose else
+// Need to count in case we see another if-else, to avoid
breaking on wrong else.
+int innerIfCount = 0;
while (it.hasNext()) {
Token t = it.next();
+ if (t.getUnderlyingType() == IfExpr.class) {
+innerIfCount++;
+ }
--- End diff --
I might have addressed this? If the current change isn't what you wanted,
let me know.
> Nested IF ELSE statements can cause parse errors in Stellar
> ---
>
> Key: METRON-1877
> URL: https://issues.apache.org/jira/browse/METRON-1877
> Project: Metron
> Issue Type: Improvement
>Reporter: Justin Leet
>Assignee: Justin Leet
>Priority: Major
>
> IF ELSE statements nested inside IF ELSEstatements can cause problems with
> short-circuiting. See the following example.
> {code:java}
> Stellar>>> IF true THEN IF false THEN true ELSE false ELSE is_alert
> false
> Stellar>>> IF true THEN IF true THEN true ELSE false ELSE is_alert
> ! Invalid parse, found null
> org.apache.metron.stellar.dsl.ParseException: Invalid parse, found null
> at
> org.apache.metron.stellar.common.StellarCompiler$Expression.apply(StellarCompiler.java:211)
> at
> org.apache.metron.stellar.common.BaseStellarProcessor.parse(BaseStellarProcessor.java:145)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.executeStellar(DefaultStellarShellExecutor.java:401)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.execute(DefaultStellarShellExecutor.java:257)
> at
> org.apache.metron.stellar.common.shell.cli.StellarShell.execute(StellarShell.java:357)
> at org.jboss.aesh.console.AeshProcess.run(AeshProcess.java:53)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:748){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (METRON-1877) Nested IF ELSE statements can cause parse errors in Stellar
[
https://issues.apache.org/jira/browse/METRON-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689756#comment-16689756
]
ASF GitHub Bot commented on METRON-1877:
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1268#discussion_r234293803
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/BasicStellarTest.java
---
@@ -916,6 +916,53 @@ public void testShortCircuit_conditional() throws
Exception {
Assert.assertEquals("foo", run("if NOT('metron' in [ 'metron',
'metronicus'] ) then THROW('expression') else 'foo'", new HashMap<>()));
}
--- End diff --
if you look at https://github.com/apache/metron/pull/814, which was when I
did checkpoint work for match, I had a lot of fallout to account for. Maybe
you can take a peak at the match tests.
> Nested IF ELSE statements can cause parse errors in Stellar
> ---
>
> Key: METRON-1877
> URL: https://issues.apache.org/jira/browse/METRON-1877
> Project: Metron
> Issue Type: Improvement
>Reporter: Justin Leet
>Assignee: Justin Leet
>Priority: Major
>
> IF ELSE statements nested inside IF ELSEstatements can cause problems with
> short-circuiting. See the following example.
> {code:java}
> Stellar>>> IF true THEN IF false THEN true ELSE false ELSE is_alert
> false
> Stellar>>> IF true THEN IF true THEN true ELSE false ELSE is_alert
> ! Invalid parse, found null
> org.apache.metron.stellar.dsl.ParseException: Invalid parse, found null
> at
> org.apache.metron.stellar.common.StellarCompiler$Expression.apply(StellarCompiler.java:211)
> at
> org.apache.metron.stellar.common.BaseStellarProcessor.parse(BaseStellarProcessor.java:145)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.executeStellar(DefaultStellarShellExecutor.java:401)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.execute(DefaultStellarShellExecutor.java:257)
> at
> org.apache.metron.stellar.common.shell.cli.StellarShell.execute(StellarShell.java:357)
> at org.jboss.aesh.console.AeshProcess.run(AeshProcess.java:53)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:748){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (METRON-1877) Nested IF ELSE statements can cause parse errors in Stellar
[
https://issues.apache.org/jira/browse/METRON-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689733#comment-16689733
]
ASF GitHub Bot commented on METRON-1877:
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1268#discussion_r234290697
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/BasicStellarTest.java
---
@@ -916,6 +916,53 @@ public void testShortCircuit_conditional() throws
Exception {
Assert.assertEquals("foo", run("if NOT('metron' in [ 'metron',
'metronicus'] ) then THROW('expression') else 'foo'", new HashMap<>()));
}
--- End diff --
These tests are good, but these evaluations should be tested with other
things in the things in the if s
IF SOME_MORE_COMPLEX_FUNCTION THEN IF LAMBDA THEN MATCH ELSE B ELSE C
To make sure we are not messing the stack up.
> Nested IF ELSE statements can cause parse errors in Stellar
> ---
>
> Key: METRON-1877
> URL: https://issues.apache.org/jira/browse/METRON-1877
> Project: Metron
> Issue Type: Improvement
>Reporter: Justin Leet
>Assignee: Justin Leet
>Priority: Major
>
> IF ELSE statements nested inside IF ELSEstatements can cause problems with
> short-circuiting. See the following example.
> {code:java}
> Stellar>>> IF true THEN IF false THEN true ELSE false ELSE is_alert
> false
> Stellar>>> IF true THEN IF true THEN true ELSE false ELSE is_alert
> ! Invalid parse, found null
> org.apache.metron.stellar.dsl.ParseException: Invalid parse, found null
> at
> org.apache.metron.stellar.common.StellarCompiler$Expression.apply(StellarCompiler.java:211)
> at
> org.apache.metron.stellar.common.BaseStellarProcessor.parse(BaseStellarProcessor.java:145)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.executeStellar(DefaultStellarShellExecutor.java:401)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.execute(DefaultStellarShellExecutor.java:257)
> at
> org.apache.metron.stellar.common.shell.cli.StellarShell.execute(StellarShell.java:357)
> at org.jboss.aesh.console.AeshProcess.run(AeshProcess.java:53)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:748){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (METRON-1877) Nested IF ELSE statements can cause parse errors in Stellar
[
https://issues.apache.org/jira/browse/METRON-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689732#comment-16689732
]
ASF GitHub Bot commented on METRON-1877:
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1268#discussion_r234289745
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/StellarCompiler.java
---
@@ -219,14 +220,23 @@ public Object apply(ExpressionState state) {
//short circuit the if/then/else
instanceDeque.pop();
if((Boolean)curr.getValue()) {
-//choose then
-skipElse = true;
+//choose then. Need to make sure we're keeping track of
nesting.
+skipElseCount++;
} else {
//choose else
+// Need to count in case we see another if-else, to avoid
breaking on wrong else.
+int innerIfCount = 0;
while (it.hasNext()) {
Token t = it.next();
+ if (t.getUnderlyingType() == IfExpr.class) {
+innerIfCount++;
+ }
--- End diff --
wouldn't if, else if be more clear here?
> Nested IF ELSE statements can cause parse errors in Stellar
> ---
>
> Key: METRON-1877
> URL: https://issues.apache.org/jira/browse/METRON-1877
> Project: Metron
> Issue Type: Improvement
>Reporter: Justin Leet
>Assignee: Justin Leet
>Priority: Major
>
> IF ELSE statements nested inside IF ELSEstatements can cause problems with
> short-circuiting. See the following example.
> {code:java}
> Stellar>>> IF true THEN IF false THEN true ELSE false ELSE is_alert
> false
> Stellar>>> IF true THEN IF true THEN true ELSE false ELSE is_alert
> ! Invalid parse, found null
> org.apache.metron.stellar.dsl.ParseException: Invalid parse, found null
> at
> org.apache.metron.stellar.common.StellarCompiler$Expression.apply(StellarCompiler.java:211)
> at
> org.apache.metron.stellar.common.BaseStellarProcessor.parse(BaseStellarProcessor.java:145)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.executeStellar(DefaultStellarShellExecutor.java:401)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.execute(DefaultStellarShellExecutor.java:257)
> at
> org.apache.metron.stellar.common.shell.cli.StellarShell.execute(StellarShell.java:357)
> at org.jboss.aesh.console.AeshProcess.run(AeshProcess.java:53)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:748){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (METRON-1877) Nested IF ELSE statements can cause parse errors in Stellar
[
https://issues.apache.org/jira/browse/METRON-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689635#comment-16689635
]
ASF GitHub Bot commented on METRON-1877:
GitHub user justinleet opened a pull request:
https://github.com/apache/metron/pull/1268
METRON-1877: Nested IF ELSE statements can cause parse errors in Stellar
## Contributor Comments
When we're dealing with if-else, the existing code would simply say we need
to skip an else. In the case of nested if-else, the outer else would say to
skip the inner else and cause issues. By tracking the number of else's to
skip, we can manage the nesting properly.
Short-circuiting also needed updating, because it was also experiencing a
similar issue.
A variety of unit tests has been added to address both of these, and ensure
slightly more complicated nestings are tested.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON- where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/justinleet/metron nestedStellar
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1268.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1268
commit cb5911b149c111eb618593503083d26d09f17139
Author: justinjleet
Date: 2018-11-16T16:26:14Z
Expanding handling of Stellar if-else to avoid mismatching if to an else
> Nested IF ELSE statements can cause parse errors in Stellar
> ---
>
> Key: METRON-1877
> URL: https://issues.apache.org/jira/browse/METRON-1877
> Project: Metron
> Issue Type: Improvement
>Reporter: Justin Leet
>Assignee: Justin Leet
>Priority: Major
>
> IF ELSE statements nested inside IF ELSEstatements can cause problems with
> short-circuiting. See the following example.
> {code:java}
> Stellar>>> IF true THEN IF false THEN true ELSE false ELSE is_alert
> false
> Stellar>>> IF true THEN IF true THEN true ELSE false ELSE is_alert
>
[jira] [Commented] (METRON-1877) Nested IF ELSE statements can cause parse errors in Stellar
[
https://issues.apache.org/jira/browse/METRON-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689654#comment-16689654
]
ASF GitHub Bot commented on METRON-1877:
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1268
This looks good to me. Good catch, +1 by inspection.
> Nested IF ELSE statements can cause parse errors in Stellar
> ---
>
> Key: METRON-1877
> URL: https://issues.apache.org/jira/browse/METRON-1877
> Project: Metron
> Issue Type: Improvement
>Reporter: Justin Leet
>Assignee: Justin Leet
>Priority: Major
>
> IF ELSE statements nested inside IF ELSEstatements can cause problems with
> short-circuiting. See the following example.
> {code:java}
> Stellar>>> IF true THEN IF false THEN true ELSE false ELSE is_alert
> false
> Stellar>>> IF true THEN IF true THEN true ELSE false ELSE is_alert
> ! Invalid parse, found null
> org.apache.metron.stellar.dsl.ParseException: Invalid parse, found null
> at
> org.apache.metron.stellar.common.StellarCompiler$Expression.apply(StellarCompiler.java:211)
> at
> org.apache.metron.stellar.common.BaseStellarProcessor.parse(BaseStellarProcessor.java:145)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.executeStellar(DefaultStellarShellExecutor.java:401)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.execute(DefaultStellarShellExecutor.java:257)
> at
> org.apache.metron.stellar.common.shell.cli.StellarShell.execute(StellarShell.java:357)
> at org.jboss.aesh.console.AeshProcess.run(AeshProcess.java:53)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:748){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (METRON-1877) Nested IF ELSE statements can cause parse errors in Stellar
[
https://issues.apache.org/jira/browse/METRON-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689649#comment-16689649
]
ASF GitHub Bot commented on METRON-1877:
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1268
@cestella You're the mastermind of this, therefore you own it forever.
This look reasonable to you (both in cause and approach)?
> Nested IF ELSE statements can cause parse errors in Stellar
> ---
>
> Key: METRON-1877
> URL: https://issues.apache.org/jira/browse/METRON-1877
> Project: Metron
> Issue Type: Improvement
>Reporter: Justin Leet
>Assignee: Justin Leet
>Priority: Major
>
> IF ELSE statements nested inside IF ELSEstatements can cause problems with
> short-circuiting. See the following example.
> {code:java}
> Stellar>>> IF true THEN IF false THEN true ELSE false ELSE is_alert
> false
> Stellar>>> IF true THEN IF true THEN true ELSE false ELSE is_alert
> ! Invalid parse, found null
> org.apache.metron.stellar.dsl.ParseException: Invalid parse, found null
> at
> org.apache.metron.stellar.common.StellarCompiler$Expression.apply(StellarCompiler.java:211)
> at
> org.apache.metron.stellar.common.BaseStellarProcessor.parse(BaseStellarProcessor.java:145)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.executeStellar(DefaultStellarShellExecutor.java:401)
> at
> org.apache.metron.stellar.common.shell.DefaultStellarShellExecutor.execute(DefaultStellarShellExecutor.java:257)
> at
> org.apache.metron.stellar.common.shell.cli.StellarShell.execute(StellarShell.java:357)
> at org.jboss.aesh.console.AeshProcess.run(AeshProcess.java:53)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:748){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
