[jira] [Commented] (METRON-263) Configuration push should validate JSON prior to pushing to Zookeeper
[ https://issues.apache.org/jira/browse/METRON-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15629597#comment-15629597 ] Casey Stella commented on METRON-263: - This is currently done as an artifact of the work around the Stellar management functions. Invalid configs won't be pushed to zookeeper. > Configuration push should validate JSON prior to pushing to Zookeeper > - > > Key: METRON-263 > URL: https://issues.apache.org/jira/browse/METRON-263 > Project: Metron > Issue Type: Improvement >Reporter: David M. Lyle > Labels: platform > Fix For: 0.2.1BETA > > > Currently there is no validation that the configuration pushed to zookeeper > is valid. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (METRON-263) Configuration push should validate JSON prior to pushing to Zookeeper
[ https://issues.apache.org/jira/browse/METRON-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572054#comment-15572054 ] Otto Fowler commented on METRON-263: I found myself thinking that the public api surfaced to be reduced to one 'type' or format. > Configuration push should validate JSON prior to pushing to Zookeeper > - > > Key: METRON-263 > URL: https://issues.apache.org/jira/browse/METRON-263 > Project: Metron > Issue Type: Improvement >Reporter: David M. Lyle > Labels: platform > Fix For: 0.2.1BETA > > > Currently there is no validation that the configuration pushed to zookeeper > is valid. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (METRON-263) Configuration push should validate JSON prior to pushing to Zookeeper
[ https://issues.apache.org/jira/browse/METRON-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569873#comment-15569873 ] David M. Lyle commented on METRON-263: -- An FYI- when I entered this, users could push out invalid JSON. I opened this to address that. I think we're good on that score now, so afaic, we can close this. > Configuration push should validate JSON prior to pushing to Zookeeper > - > > Key: METRON-263 > URL: https://issues.apache.org/jira/browse/METRON-263 > Project: Metron > Issue Type: Improvement >Reporter: David M. Lyle > Labels: platform > Fix For: 0.2.1BETA > > > Currently there is no validation that the configuration pushed to zookeeper > is valid. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (METRON-263) Configuration push should validate JSON prior to pushing to Zookeeper
[ https://issues.apache.org/jira/browse/METRON-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569481#comment-15569481 ] Nick Allen commented on METRON-263: --- Agreed. It is is a bit of a layer cake. I have a hard time wrapping my head around that. Anything we can do to make that more intelligible, would be well worth the effort. > Configuration push should validate JSON prior to pushing to Zookeeper > - > > Key: METRON-263 > URL: https://issues.apache.org/jira/browse/METRON-263 > Project: Metron > Issue Type: Improvement >Reporter: David M. Lyle > Labels: platform > Fix For: 0.2.1BETA > > > Currently there is no validation that the configuration pushed to zookeeper > is valid. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (METRON-263) Configuration push should validate JSON prior to pushing to Zookeeper
[ https://issues.apache.org/jira/browse/METRON-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569496#comment-15569496 ] Nick Allen commented on METRON-263: --- It would make sense to add the validation at some central point, so that it occurs when a user pushes a new config, or if a bolt picks up a new config that happens to be bad. Honestly, I think we need Casey to chime in on this one. I don't know that part of the code off-hand. I would have to spend some time unwinding it. > Configuration push should validate JSON prior to pushing to Zookeeper > - > > Key: METRON-263 > URL: https://issues.apache.org/jira/browse/METRON-263 > Project: Metron > Issue Type: Improvement >Reporter: David M. Lyle > Labels: platform > Fix For: 0.2.1BETA > > > Currently there is no validation that the configuration pushed to zookeeper > is valid. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (METRON-263) Configuration push should validate JSON prior to pushing to Zookeeper
[ https://issues.apache.org/jira/browse/METRON-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569470#comment-15569470 ] Otto Fowler commented on METRON-263: But on the way in, they can be passed to the api as bytes or map<> objects it is a little bit of a layer cake in there. Isn't that were we want to validate? > Configuration push should validate JSON prior to pushing to Zookeeper > - > > Key: METRON-263 > URL: https://issues.apache.org/jira/browse/METRON-263 > Project: Metron > Issue Type: Improvement >Reporter: David M. Lyle > Labels: platform > Fix For: 0.2.1BETA > > > Currently there is no validation that the configuration pushed to zookeeper > is valid. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (METRON-263) Configuration push should validate JSON prior to pushing to Zookeeper
[ https://issues.apache.org/jira/browse/METRON-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569323#comment-15569323 ] Nick Allen commented on METRON-263: --- Maybe there is some way we can trigger the Jackson deserialization explicitly to perform this validation. I do not know off-hand how we would do that though. > Configuration push should validate JSON prior to pushing to Zookeeper > - > > Key: METRON-263 > URL: https://issues.apache.org/jira/browse/METRON-263 > Project: Metron > Issue Type: Improvement >Reporter: David M. Lyle > Labels: platform > Fix For: 0.2.1BETA > > > Currently there is no validation that the configuration pushed to zookeeper > is valid. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (METRON-263) Configuration push should validate JSON prior to pushing to Zookeeper
[ https://issues.apache.org/jira/browse/METRON-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569319#comment-15569319 ] Nick Allen commented on METRON-263: --- Jackson does it magically behind-the-scenes. I'm not a huge fan of its lack of explicitness either, but that's how it works. Try modifying/removing one of the fields in the configuration POJO and you will see it break as it deserializes the JSON. > Configuration push should validate JSON prior to pushing to Zookeeper > - > > Key: METRON-263 > URL: https://issues.apache.org/jira/browse/METRON-263 > Project: Metron > Issue Type: Improvement >Reporter: David M. Lyle > Labels: platform > Fix For: 0.2.1BETA > > > Currently there is no validation that the configuration pushed to zookeeper > is valid. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (METRON-263) Configuration push should validate JSON prior to pushing to Zookeeper
[ https://issues.apache.org/jira/browse/METRON-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568946#comment-15568946 ] Otto Fowler commented on METRON-263: [~nickallen] From what I can see it just subscribes to changes on the nodes, where is the loading and validation? > Configuration push should validate JSON prior to pushing to Zookeeper > - > > Key: METRON-263 > URL: https://issues.apache.org/jira/browse/METRON-263 > Project: Metron > Issue Type: Improvement >Reporter: David M. Lyle > Labels: platform > Fix For: 0.2.1BETA > > > Currently there is no validation that the configuration pushed to zookeeper > is valid. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (METRON-263) Configuration push should validate JSON prior to pushing to Zookeeper
[ https://issues.apache.org/jira/browse/METRON-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568446#comment-15568446 ] David M. Lyle commented on METRON-263: -- I think this was completed as a side effect of some work [~cestella] did with the repl. Casey, could you verify? > Configuration push should validate JSON prior to pushing to Zookeeper > - > > Key: METRON-263 > URL: https://issues.apache.org/jira/browse/METRON-263 > Project: Metron > Issue Type: Improvement >Reporter: David M. Lyle > Labels: platform > Fix For: 0.2.1BETA > > > Currently there is no validation that the configuration pushed to zookeeper > is valid. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (METRON-263) Configuration push should validate JSON prior to pushing to Zookeeper
[ https://issues.apache.org/jira/browse/METRON-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566687#comment-15566687 ] Nick Allen commented on METRON-263: --- I would think we would want to mimic what the org.apache.metron.common.bolt.ConfiguredBolt does in terms of loading the configuration. Beyond just valid JSON, it gets mapped (via Jackson) to a configuration type; example org.apache.metron.common.configuration.enrichment.SensorEnrichmentConfig. > Configuration push should validate JSON prior to pushing to Zookeeper > - > > Key: METRON-263 > URL: https://issues.apache.org/jira/browse/METRON-263 > Project: Metron > Issue Type: Improvement >Reporter: David M. Lyle > Labels: platform > Fix For: 0.2.1BETA > > > Currently there is no validation that the configuration pushed to zookeeper > is valid. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (METRON-263) Configuration push should validate JSON prior to pushing to Zookeeper
[ https://issues.apache.org/jira/browse/METRON-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566657#comment-15566657 ] Otto Fowler commented on METRON-263: So it is enough to verify that they are valid json? I will work on this > Configuration push should validate JSON prior to pushing to Zookeeper > - > > Key: METRON-263 > URL: https://issues.apache.org/jira/browse/METRON-263 > Project: Metron > Issue Type: Improvement >Reporter: David M. Lyle > Labels: platform > Fix For: 0.2.1BETA > > > Currently there is no validation that the configuration pushed to zookeeper > is valid. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
