[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-07-12 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r70519688 --- Diff: nifi-assembly/pom.xml --- @@ -425,7 +430,7 @@ language governing permissions and limitations under the License. -->

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-07-12 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r70520699 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/main/java/org/apache/nifi/processors/ignite/cache/AbstractIgniteCacheProcessor.java

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-07-12 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r70519994 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/pom.xml --- @@ -0,0 +1,83 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-07-12 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r70520296 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/main/java/org/apache/nifi/processors/ignite/AbstractIgniteProcessor.java

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-07-12 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r70526088 --- Diff: nifi-nar-bundles/pom.xml --- @@ -55,18 +55,19 @@ nifi-scripting-bundle nifi-elasticsearch-bundle nifi-amqp

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-07-12 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r70520573 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/main/java/org/apache/nifi/processors/ignite/AbstractIgniteProcessor.java

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-07-12 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r70523240 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/main/java/org/apache/nifi/processors/ignite/cache/AbstractIgniteCacheProcessor.java

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-07-12 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r70524850 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/main/java/org/apache/nifi/processors/ignite/cache/PutIgniteCache.java --- @@ -0,0

[GitHub] nifi issue #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-07-12 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/502 @mans2singh I added some minor comments. You also need to add a NOTICE file for licensing aspects in the nar project (you may want to have a look to other processors). I just tried to run

[GitHub] nifi pull request #496: NIFI-1965 - Implement QueryDNS Processor

2016-07-27 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/496#discussion_r72526887 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/AbstractEnrichProcessor.java

[GitHub] nifi pull request #496: NIFI-1965 - Implement QueryDNS Processor

2016-07-27 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/496#discussion_r72527914 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryDNS.java --- @@ -0,0 +1,269

[GitHub] nifi pull request #496: NIFI-1965 - Implement QueryDNS Processor

2016-07-27 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/496#discussion_r72528893 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryDNS.java --- @@ -0,0 +1,269

[GitHub] nifi pull request #496: NIFI-1965 - Implement QueryDNS Processor

2016-07-27 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/496#discussion_r72529729 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryDNS.java --- @@ -0,0 +1,269

[GitHub] nifi issue #496: NIFI-1965 - Implement QueryDNS Processor

2016-07-27 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/496 Hey @trixpan, thanks for your work! I've made some comments. Also, could you rebase against master? At the moment, I've not been able to test it because of the NPE I mentioned in comments. Once

[GitHub] nifi pull request #496: NIFI-1965 - Implement QueryDNS Processor

2016-07-27 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/496#discussion_r72526422 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/AbstractEnrichProcessor.java

[GitHub] nifi pull request #496: NIFI-1965 - Implement QueryDNS Processor

2016-07-27 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/496#discussion_r72527360 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/AbstractEnrichProcessor.java

[GitHub] nifi pull request #496: NIFI-1965 - Implement QueryDNS Processor

2016-07-27 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/496#discussion_r72526574 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/AbstractEnrichProcessor.java

[GitHub] nifi pull request #496: NIFI-1965 - Implement QueryDNS Processor

2016-07-27 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/496#discussion_r72529865 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryDNS.java --- @@ -0,0 +1,269

[GitHub] nifi pull request #496: NIFI-1965 - Implement QueryDNS Processor

2016-07-27 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/496#discussion_r72526705 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/AbstractEnrichProcessor.java

[GitHub] nifi pull request #496: NIFI-1965 - Implement QueryDNS Processor

2016-07-27 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/496#discussion_r72530345 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/test/java/org/apache/nifi/processors/enrich/TestQueryDNS.java --- @@ -0,0 +1,228

[GitHub] nifi pull request #496: NIFI-1965 - Implement QueryDNS Processor

2016-07-27 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/496#discussion_r72529488 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryDNS.java --- @@ -0,0 +1,269

[GitHub] nifi pull request #496: NIFI-1965 - Implement QueryDNS Processor

2016-07-27 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/496#discussion_r72530250 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryDNS.java --- @@ -0,0 +1,269

[GitHub] nifi pull request #496: NIFI-1965 - Implement QueryDNS Processor

2016-07-27 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/496#discussion_r72530181 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryDNS.java --- @@ -0,0 +1,269

[GitHub] nifi issue #476: NIFI-1942 Processor to validate CSV against user-supplied s...

2016-08-09 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/476 Hey @JPercivall, I think I've addressed most of your comments: - changed log level - fixed decrementation (was not related to header but rather to 'finally' in 'while' loop) - strategy

[GitHub] nifi issue #811: NIFI-2503 Backport PostHTTP SSL Protocol fix to 0.x branch

2016-08-10 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/811 @jskora it only works when merging to master branch ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #476: NIFI-1942 Processor to validate CSV against user-supplied s...

2016-07-13 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/476 Hey @JPercivall, that should be OK now, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #476: NIFI-1942 Processor to validate CSV against user-supplied s...

2016-07-17 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/476 Hey @JPercivall, thanks for the review! I believe I addressed all of your comments. I also added the new dependency in NOTICE files (let me know if it is OK). To validate the processor I used

[GitHub] nifi pull request #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-07-18 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/502#discussion_r71220449 --- Diff: nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/main/java/org/apache/nifi/processors/ignite/cache/PutIgniteCache.java --- @@ -0,0

[GitHub] nifi issue #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-07-18 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/502 Thanks @JPercivall ! @mans2singh. It LGTM, one last comment about wording and also could you confirm my old comment in ``AbstractIgniteCacheProcessor`` about ``IGNITE_CACHE_ENTRY_KEY

[GitHub] nifi issue #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-07-19 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/502 @mans2singh Thanks for your work, it LGTM! Would you mind rebasing your commits? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-07-19 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/502 Sorry I meant to rebase and squash them into one single commit ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi issue #502: Nifi-1972 Apache Ignite Put Cache Processor

2016-07-20 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/502 @mans2singh I was about to merge but there are checkstyle issues: [WARNING] src/test/java/org/apache/nifi/processors/ignite/cache/ITPutIgniteCache.java[41:1] (whitespace

[GitHub] nifi pull request #809: NIFI-2516 - Extract version info into parent pom, up...

2016-08-08 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/809#discussion_r73963178 --- Diff: pom.xml --- @@ -781,6 +786,16 @@ language governing permissions and limitations under the License. --> curator-reci

[GitHub] nifi pull request #809: NIFI-2516 - Extract version info into parent pom, up...

2016-08-08 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/809#discussion_r73962918 --- Diff: pom.xml --- @@ -781,6 +786,16 @@ language governing permissions and limitations under the License. --> curator-reci

[GitHub] nifi issue #774: Nifi 2440 - Add Last Modified Time attribute to ListSFTP

2016-08-08 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/774 Hi @kirkalicious, could you please rebase and squash your PR into one single commit to ease the review process? --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi issue #496: NIFI-1965 - Implement QueryDNS Processor

2016-08-07 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/496 @trixpan You've given the same .name() to multiple properties, this has to be unique. The consequence is that properties are not longer displayed in the UI. Besides, there is a checkstyle

[GitHub] nifi pull request #496: NIFI-1965 - Implement QueryDNS Processor

2016-08-01 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/496#discussion_r73060999 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryDNS.java --- @@ -0,0 +1,272

[GitHub] nifi pull request #496: NIFI-1965 - Implement QueryDNS Processor

2016-08-01 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/496#discussion_r73061305 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryDNS.java --- @@ -0,0 +1,272

[GitHub] nifi pull request #496: NIFI-1965 - Implement QueryDNS Processor

2016-08-01 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/496#discussion_r73061690 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryDNS.java --- @@ -0,0 +1,272

[GitHub] nifi pull request #496: NIFI-1965 - Implement QueryDNS Processor

2016-08-01 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/496#discussion_r73061861 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryDNS.java --- @@ -0,0 +1,272

[GitHub] nifi pull request #496: NIFI-1965 - Implement QueryDNS Processor

2016-08-02 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/496#discussion_r73098838 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryDNS.java --- @@ -0,0 +1,272

[GitHub] nifi pull request #496: NIFI-1965 - Implement QueryDNS Processor

2016-07-29 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/496#discussion_r72842053 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryDNS.java --- @@ -0,0 +1,272

[GitHub] nifi pull request #496: NIFI-1965 - Implement QueryDNS Processor

2016-07-29 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/496#discussion_r72842097 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryDNS.java --- @@ -0,0 +1,272

[GitHub] nifi issue #811: NIFI-2503 Backport PostHTTP SSL Protocol fix to 0.x branch

2016-08-09 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/811 @jskora I merged to 0.x, thanks. Could you close this PR manually? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi issue #844: NIFI-2397 merging patch for NIFI-2376 from master into 0.x ...

2016-08-16 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/844 Full build with contrib-check. Merged in 0.x, thanks @mosermw. Could you manually close the PR? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi issue #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-17 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/858 @trixpan Just made some tests with your template. I played with the parameters to check custom validation and the messages do not sound clear to me. For example: https

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-17 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r75143249 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryWhois.java --- @@ -0,0 +1,334

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-17 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r75144836 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryWhois.java --- @@ -0,0 +1,334

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-17 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r75146175 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryWhois.java --- @@ -0,0 +1,334

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-17 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r75146321 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryWhois.java --- @@ -0,0 +1,334

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-17 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r75141672 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/pom.xml --- @@ -63,5 +63,31 @@ nifi-mock test

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-17 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r75141817 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/pom.xml --- @@ -63,5 +63,31 @@ nifi-mock test

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-17 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r75143147 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryWhois.java --- @@ -0,0 +1,334

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-17 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r75147706 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/test/java/org/apache/nifi/processors/enrich/TestQueryWhois.java --- @@ -0,0 +1,187

[GitHub] nifi issue #1452: NIFI-3179 Added support for default UTF-8 char encoding

2017-01-31 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1452 Thanks @olegz, merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi issue #1449: NIFI-3223 added support for expression language

2017-01-31 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1449 Hey @olegz, it looks OK, I'll give it a try. Just wondering if there is an easy way to update unit tests to actually test the use of expression language. --- If your project is set up for it, you

[GitHub] nifi issue #1464: NIFI-3429 optionally quoting all table identifiers

2017-02-07 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1464 @nickcarenza one last thing and we are good to go (build failing because of checkstyle): [WARNING] src/main/java/org/apache/nifi/processors/standard/ConvertJSONToSQL.java[532

[GitHub] nifi pull request #1479: NIFI-3447 - PutSplunk - force connection close

2017-02-07 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1479 NIFI-3447 - PutSplunk - force connection close - when the channel sender fails to send data, closing it to force the creation of a new one next time. - replace deprecated

[GitHub] nifi issue #1480: NIFI-1657 - Configure travis-ci to run mvn verify in jp an...

2017-02-07 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1480 Thanks @trixpan, this will be useful! What do you think: should we get this merged now or wait to fix the tests known to fail with specific locales? (just to avoid a lot of build failures

[GitHub] nifi pull request #1480: NIFI-1657 - Configure travis-ci to run mvn verify i...

2017-02-07 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1480#discussion_r99832100 --- Diff: .travis.yml --- @@ -15,6 +15,11 @@ language: java +env: + - USER_LANGUAGE=en USER_COUNTRY=US + - USER_LANGUAGE=pt

[GitHub] nifi pull request #1369: NIFI-3114 Updated documentation of ListenHTTP

2017-02-07 Thread pvillard31
Github user pvillard31 closed the pull request at: https://github.com/apache/nifi/pull/1369 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #1369: NIFI-3114 Updated documentation of ListenHTTP

2017-02-07 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1369 Sure, thanks @mosermw! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] nifi issue #1449: NIFI-3223 added support for expression language

2017-02-07 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1449 LGTM, full build and tested a template with flow files containing both exchange and routing key as attributes. Merged to master, thanks @olegz! --- If your project is set up for it, you can reply

[GitHub] nifi issue #1432: NIFI-3372 Adding capability for PutSQL to handle BIT field...

2017-02-07 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1432 Yes perfect @ryanpersaud, thanks! It's merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1464: NIFI-3429 optionally quoting all table identifiers

2017-02-07 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1464 Never mind, took care of it and merged to master, thanks @nickcarenza! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi issue #1432: NIFI-3372 Adding capability for PutSQL to handle BIT field...

2017-02-07 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1432 Hey @ryanpersaud, it LGTM, could you just rebase against master and I'll merge into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi issue #1480: NIFI-1657 - Configure travis-ci to run mvn verify in jp an...

2017-02-07 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1480 I believe we need one more... I know what you are going to say: French people... what a pain ;) 123 456 fr_FR 345 987,246 fr_FR 123.456 pt_BR 345.987,246

[GitHub] nifi pull request #1464: NIFI-3429 automatically quoting all table identifie...

2017-02-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1464#discussion_r99665513 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ConvertJSONToSQL.java

[GitHub] nifi issue #1454: NIFI-3419: Routing flow files causing ZipException to fail...

2017-02-06 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1454 LGTM, merging. The same could apply to ``TarMerge`` but this can be done in another JIRA. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi pull request #1467: NIFI-3408 Add exception class when InvokeHTTP fails

2017-02-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1467#discussion_r99649060 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java --- @@ -753,6

[GitHub] nifi pull request #1467: NIFI-3408 Add exception class when InvokeHTTP fails

2017-02-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1467#discussion_r99649592 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java --- @@ -118,6

[GitHub] nifi issue #1470: NIFI-3055 StandardRecordWriter Can Throw UTFDataFormatExce...

2017-02-06 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1470 Even if I know there will be additional changes for this JIRA in a new PR, can you close this PR @jskora ? (not closed automatically in 0.x) --- If your project is set up for it, you can reply

[GitHub] nifi issue #1472: NIFI-3434 - Introduce the ability to skip the packaging of...

2017-02-06 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1472 LGTM, will allow faster build when developing ;) @trixpan @apiri Could we use this new profile in the travis builds to reduce the risk of timeout? --- If your project is set up for it, you

[GitHub] nifi issue #1468: NIFI-3430 adds support for date format property to parse i...

2017-02-06 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1468 LGTM, I'll take care of merging @trixpan ;) Thanks @nickcarenza --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi issue #1465: NIFI-3427 Fix Provenance DateTime Sorting

2017-02-06 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1465 LGTM, merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #1464: NIFI-3429 optionally quoting all table identifiers

2017-02-06 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1464#discussion_r99680121 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ConvertJSONToSQL.java

[GitHub] nifi issue #1480: NIFI-1657 - Configure travis-ci to run mvn verify in jp an...

2017-02-08 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1480 @trixpan I just wanted to check before getting this merged but I believe setting the properties like you did does not change the locale settings for surefire plugin (unit tests). The fact is I

[GitHub] nifi pull request #1441: NIFI-3390 Added support for LDAP HA

2017-01-24 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1441 NIFI-3390 Added support for LDAP HA Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] nifi pull request #1452: NIFI-3179 Added support for default UTF-8 char enco...

2017-01-30 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1452#discussion_r98545128 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/MergeContent.java --- @@ -780,7

[GitHub] nifi issue #1451: NIFI-3180 Fixed NPE in TemplateUtils

2017-01-30 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1451 LGTM, build with contrib-check OK, merged to master, thanks @olegz. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi issue #1453: NIFI-3161 added ASM exclusion

2017-01-30 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1453 LGTM, fixed style (to avoid changes on all the file) and merged to master. Thanks @olegz. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi pull request #1400: NIFI-957 Added the possibility to use DefaultSchedu...

2017-01-29 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1400#discussion_r98362729 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/reporting

[GitHub] nifi pull request #1400: NIFI-957 Added the possibility to use DefaultSchedu...

2017-01-29 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1400#discussion_r98362714 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/reporting

[GitHub] nifi pull request #1401: NIFI-3290 Reporting task to send bulletins with S2S

2017-01-29 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1401#discussion_r98363650 --- Diff: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting

[GitHub] nifi issue #1400: NIFI-957 Added the possibility to use DefaultSchedule anno...

2017-01-29 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1400 Hey @olegz, thanks for reviewing this PR. I addressed your comments, let me know if there is something else. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] nifi pull request #1401: NIFI-3290 Reporting task to send bulletins with S2S

2017-01-29 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1401#discussion_r98363608 --- Diff: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting

[GitHub] nifi pull request #1401: NIFI-3290 Reporting task to send bulletins with S2S

2017-01-29 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1401#discussion_r98363576 --- Diff: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting

[GitHub] nifi pull request #1401: NIFI-3290 Reporting task to send bulletins with S2S

2017-01-29 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1401#discussion_r98363588 --- Diff: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting

[GitHub] nifi pull request #1443: NIFI-3393 - replicates cluster/nodes/{id} to cluste...

2017-01-25 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1443 NIFI-3393 - replicates cluster/nodes/{id} to cluster coordinator Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi pull request #1441: NIFI-3390 Added support for LDAP HA

2017-01-25 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1441#discussion_r97817107 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/conf/login-identity-providers.xml --- @@ -50,7 +50,7

[GitHub] nifi pull request #1444: NIFI-3295 - ensures node is disconnected before try...

2017-01-25 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1444 NIFI-3295 - ensures node is disconnected before trying to remove it Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask

[GitHub] nifi issue #1441: NIFI-3390 Added support for LDAP HA

2017-01-25 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1441 Updated the PR to use a space-separated list of URLs as it seems to be the standard according to http://docs.oracle.com/javase/jndi/tutorial/ldap/misc/url.html --- If your project is set up

[GitHub] nifi issue #1382: NIFI-2860 Use different properties for JVM Heap Max and Mi...

2017-02-15 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1382 Thanks, I updated the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi pull request #1387: NIFI-1797 - Added compression codec property to Cre...

2017-02-20 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1387#discussion_r102093327 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/CreateHadoopSequenceFile.java

[GitHub] nifi issue #1378: NIFI-2952 Fixed search value validation in ReplaceText

2017-02-20 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1378 @trixpan, are you talking about another PR I opened? Because, if not, I really don't see the link between this one and the one from Andrew (which is really great btw!). Maybe the one regarding

[GitHub] nifi pull request #1530: NIFI-3490 added SAN option for TLS toolkit in stand...

2017-02-22 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/1530 NIFI-3490 added SAN option for TLS toolkit in standalone mode Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi issue #1530: NIFI-3490 added SAN option for TLS toolkit in standalone m...

2017-02-22 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1530 Test example: ./tls-toolkit.sh standalone -s "nifi.vip.org,localhost,nifi-01" -n nifi-01 $ keytool -list -keystore keystore.jks -v Keystore

[GitHub] nifi issue #1528: NIFI-385 Add Kerberos support in nifi-kite-nar

2017-02-24 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/1528 @trixpan I believe there is indeed an effort to support Kerberos in Kite processors. I believe the two features (Kerberos and Morphlines) have been in both PRs. I know there is a real interest

[GitHub] nifi pull request #1387: NIFI-1797 - Added compression codec property to Cre...

2017-02-19 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1387#discussion_r101932507 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/CreateHadoopSequenceFile.java

[GitHub] nifi issue #379: NIFI-1022 Added Tachyon/Alluxio processors

2017-02-21 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/379 Hey @trixpan, I didn't try but maybe that would work, I honestly don't know. However, Alluxio can run on top of a lot of storage solutions, so it makes sense to have a dedicated processor. Anyway

  1   2   3   4   5   6   7   >