[GitHub] [nifi-minifi-cpp] szaszm closed pull request #910: MINIFICPP-1375 Windows: Redistribute Universal CRT DLLs with our MSI

2020-09-18 Thread GitBox
szaszm closed pull request #910: URL: https://github.com/apache/nifi-minifi-cpp/pull/910 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #910: MINIFICPP-1375 Windows: Redistribute Universal CRT DLLs with our MSI

2020-09-18 Thread GitBox
szaszm commented on pull request #910: URL: https://github.com/apache/nifi-minifi-cpp/pull/910#issuecomment-695014486 Closed because the license is category X This is an automated message from the Apache Git Service. To

[GitHub] [nifi] thenatog commented on pull request #4250: NIFI-7401 Add ZooKeeper client TLS to CuratorLeaderElectionManager

2020-09-18 Thread GitBox
thenatog commented on pull request #4250: URL: https://github.com/apache/nifi/pull/4250#issuecomment-695016708 Right now for this PR I'm thinking we need some consolidation across the TLS + Zookeeper work. It seems like the embedded zookeeper + external zookeeper configuration isn't

[GitHub] [nifi] thenatog edited a comment on pull request #4250: NIFI-7401 Add ZooKeeper client TLS to CuratorLeaderElectionManager

2020-09-18 Thread GitBox
thenatog edited a comment on pull request #4250: URL: https://github.com/apache/nifi/pull/4250#issuecomment-695016708 Right now for this PR I'm thinking we need some consolidation across the TLS + Zookeeper work. It seems like the embedded zookeeper + external zookeeper configuration

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #886: MINIFICPP-1323 Encrypt sensitive properties

2020-09-18 Thread GitBox
szaszm commented on a change in pull request #886: URL: https://github.com/apache/nifi-minifi-cpp/pull/886#discussion_r491091131 ## File path: encrypt-config/ConfigFile.h ## @@ -0,0 +1,85 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[jira] [Resolved] (MINIFICPP-1375) Ship Universal C Runtime DLLs

2020-09-18 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-1375. - Resolution: Won't Fix Can not fix because the redistributable packages fall under

[GitHub] [nifi] denalex commented on pull request #4537: NIFI-7817: Fix ParquetReader instantiation error

2020-09-18 Thread GitBox
denalex commented on pull request #4537: URL: https://github.com/apache/nifi/pull/4537#issuecomment-695034540 @markap14 -- if you believe the provided patch is not optimal, then the fix indeed will need to happen in `ParquetReader` service component. We are not NiFi contributors (at least

[jira] [Created] (NIFI-7819) Add Zookeeper client TLS (external zookeeper) for cluster state management

2020-09-18 Thread Nathan Gough (Jira)
Nathan Gough created NIFI-7819: -- Summary: Add Zookeeper client TLS (external zookeeper) for cluster state management Key: NIFI-7819 URL: https://issues.apache.org/jira/browse/NIFI-7819 Project: Apache

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #886: MINIFICPP-1323 Encrypt sensitive properties

2020-09-18 Thread GitBox
fgerlits commented on a change in pull request #886: URL: https://github.com/apache/nifi-minifi-cpp/pull/886#discussion_r491086933 ## File path: encrypt-config/ConfigFile.h ## @@ -0,0 +1,85 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [nifi] thenatog commented on a change in pull request #4250: NIFI-7401 Add ZooKeeper client TLS to CuratorLeaderElectionManager

2020-09-18 Thread GitBox
thenatog commented on a change in pull request #4250: URL: https://github.com/apache/nifi/pull/4250#discussion_r490622374 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/conf/nifi.properties ## @@ -236,6 +236,11 @@

[GitHub] [nifi] jfrazee commented on a change in pull request #4250: NIFI-7401 Add ZooKeeper client TLS to CuratorLeaderElectionManager

2020-09-18 Thread GitBox
jfrazee commented on a change in pull request #4250: URL: https://github.com/apache/nifi/pull/4250#discussion_r491145537 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/conf/nifi.properties ## @@ -236,6 +236,11 @@

[GitHub] [nifi] jfrazee commented on pull request #4250: NIFI-7401 Add ZooKeeper client TLS to CuratorLeaderElectionManager

2020-09-18 Thread GitBox
jfrazee commented on pull request #4250: URL: https://github.com/apache/nifi/pull/4250#issuecomment-695048582 @thenatog I think for `SecureClientZooKeeperFactory` to be usable in the state provider, it'd need a small refactor to use Curator, which actually looks more straightforward than

[GitHub] [nifi-minifi-cpp] hunyadi-dev opened a new pull request #911: MINIFICPP-1373 - Add proper FlowFile::getAttribute getter [QoL][mini-PR]

2020-09-18 Thread GitBox
hunyadi-dev opened a new pull request #911: URL: https://github.com/apache/nifi-minifi-cpp/pull/911 Simple change extracted as separate commit, so that further changes will be easier to review. This is an automated message

[jira] [Updated] (MINIFICPP-1306) Replace header guards with #pragma once

2020-09-18 Thread Adam Hunyadi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Hunyadi updated MINIFICPP-1306: Description: *Background:* The team decided to replace header guards with

[jira] [Updated] (MINIFICPP-1355) Investigate and fix the initialization of ExecutePythonProcessor

2020-09-18 Thread Adam Hunyadi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Hunyadi updated MINIFICPP-1355: Description: *Acceptance criteria:* - GIVEN a flow set up as highlighted in blue

[jira] [Updated] (MINIFICPP-1331) Upgrade yaml-cpp to eliminate issues with "NULL" string in config

2020-09-18 Thread Adam Hunyadi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Hunyadi updated MINIFICPP-1331: Description: *Background:* Parsing the value "NULL" for a configuration node

[jira] [Updated] (MINIFICPP-1359) FollowRedirects feature is unavailable in InvokeHTTP

2020-09-18 Thread Arpad Boda (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpad Boda updated MINIFICPP-1359: -- Labels: easy-fix newbie (was: ) > FollowRedirects feature is unavailable in InvokeHTTP >

[jira] [Updated] (MINIFICPP-1358) SendBody property is unused in InvokeHTTP

2020-09-18 Thread Arpad Boda (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpad Boda updated MINIFICPP-1358: -- Labels: easy-fix newbie (was: ) > SendBody property is unused in InvokeHTTP >

[jira] [Commented] (NIFI-7816) Correct documentation example for urlEncode function in Expression Language Guide

2020-09-18 Thread Nadeem (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198320#comment-17198320 ] Nadeem commented on NIFI-7816: -- Sure [~alopresto], Thanks. I have replied to your comment on the PR. >

[GitHub] [nifi] naddym commented on pull request #4536: NIFI-7816: Correct documentation example for urlEncode function in Ex…

2020-09-18 Thread GitBox
naddym commented on pull request #4536: URL: https://github.com/apache/nifi/pull/4536#issuecomment-694677298 Yes @alopresto , The urlEncode() and urlDecode() EL functions uses `URLEncoder.encode()` and `URLDecoder.decode()` methods internally to evaluate the encoding/decodings. The guide

[jira] [Updated] (NIFI-7794) PutAzureBlobStorage doesn't work without permission to list containers

2020-09-18 Thread Paul Kelly (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Kelly updated NIFI-7794: - Status: Patch Available (was: In Progress) Went with [1] with a default value of "false" to preserve

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #911: MINIFICPP-1373 - Add proper FlowFile::getAttribute getter [QoL][mini-PR]

2020-09-18 Thread GitBox
szaszm commented on a change in pull request #911: URL: https://github.com/apache/nifi-minifi-cpp/pull/911#discussion_r490898307 ## File path: libminifi/include/core/FlowFile.h ## @@ -129,7 +130,9 @@ class FlowFile : public core::Connectable, public ReferenceContainer { *

[jira] [Updated] (MINIFICPP-57) Create multiple build profiles

2020-09-18 Thread Adam Hunyadi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-57?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Hunyadi updated MINIFICPP-57: -- Labels: easyfix newbie (was: easy-fix newbie) > Create multiple build profiles >

[jira] [Updated] (MINIFICPP-1286) Disable linter checks for long lines

2020-09-18 Thread Adam Hunyadi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Hunyadi updated MINIFICPP-1286: Labels: MiNiFi-CPP-Hygiene beginner starter (was: MiNiFi-CPP-Hygiene) > Disable

[jira] [Updated] (MINIFICPP-1306) Replace header guards with #pragma once

2020-09-18 Thread Adam Hunyadi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Hunyadi updated MINIFICPP-1306: Description: *Background:* The team decided to replace header guards with

[jira] [Updated] (MINIFICPP-1306) Replace header guards with #pragma once

2020-09-18 Thread Adam Hunyadi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Hunyadi updated MINIFICPP-1306: Labels: MiNiFi-CPP-Hygiene easyfix (was: MiNiFi-CPP-Hygiene) > Replace header guards

[jira] [Updated] (MINIFICPP-1375) Ship Universal C Runtime DLLs

2020-09-18 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz updated MINIFICPP-1375: Status: Open (was: Patch Available) > Ship Universal C Runtime DLLs >

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #910: MINIFICPP-1375 Windows: Redistribute Universal CRT DLLs with our MSI

2020-09-18 Thread GitBox
szaszm commented on pull request #910: URL: https://github.com/apache/nifi-minifi-cpp/pull/910#issuecomment-694818804 Waiting for [LEGAL-538](https://issues.apache.org/jira/browse/LEGAL-538) This is an automated message from

[jira] [Updated] (MINIFICPP-1311) Ensure that the integration test include dirs correspond to that of libminifi

2020-09-18 Thread Adam Hunyadi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Hunyadi updated MINIFICPP-1311: Labels: MiNiFi-CPP-Hygiene beginner starter (was: MiNiFi-CPP-Hygiene) > Ensure that

[jira] [Updated] (MINIFICPP-1306) Replace header guards with #pragma once

2020-09-18 Thread Adam Hunyadi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Hunyadi updated MINIFICPP-1306: Labels: MiNiFi-CPP-Hygiene easyfix starter (was: MiNiFi-CPP-Hygiene easyfix) >

[jira] [Updated] (MINIFICPP-1330) Simplify ValueParser::StringToTime and add option to convert from microseconds

2020-09-18 Thread Adam Hunyadi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Hunyadi updated MINIFICPP-1330: Labels: MiNiFi-CPP-Hygiene beginner starter (was: MiNiFi-CPP-Hygiene) > Simplify

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #905: MINIFICPP-1368 - Increment version number on main

2020-09-18 Thread GitBox
szaszm closed pull request #905: URL: https://github.com/apache/nifi-minifi-cpp/pull/905 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [nifi] simonbence commented on a change in pull request #4510: NIFI-7549 Adding Hazelcast based DistributedMapCacheClient support

2020-09-18 Thread GitBox
simonbence commented on a change in pull request #4510: URL: https://github.com/apache/nifi/pull/4510#discussion_r490974101 ## File path:

[GitHub] [nifi-registry] kevdoran commented on pull request #302: NIFIREG-415 Add Support for Unicode in X-ProxiedEntitiesChain

2020-09-18 Thread GitBox
kevdoran commented on pull request #302: URL: https://github.com/apache/nifi-registry/pull/302#issuecomment-694903957 Thanks for the review, @alopresto. I've updated my PR to incorporate your feedback. Turns out the weird handling of leading/trailing `<`/`>` was to properly tokenize the

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #886: MINIFICPP-1323 Encrypt sensitive properties

2020-09-18 Thread GitBox
szaszm commented on a change in pull request #886: URL: https://github.com/apache/nifi-minifi-cpp/pull/886#discussion_r490904072 ## File path: encrypt-config/CMakeLists.txt ## @@ -0,0 +1,30 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [nifi] jfrazee commented on pull request #4250: NIFI-7401 Add ZooKeeper client TLS to CuratorLeaderElectionManager

2020-09-18 Thread GitBox
jfrazee commented on pull request #4250: URL: https://github.com/apache/nifi/pull/4250#issuecomment-694981735 @thenatog No, I don't think anyone has worked on the state management/I don't have any code for that in progress either, so yeah, I think it'd make sense for you to do if you

[jira] [Created] (NIFI-7818) PutHDFS results in EOF due to HDFS-15191

2020-09-18 Thread Jason Iannone (Jira)
Jason Iannone created NIFI-7818: --- Summary: PutHDFS results in EOF due to HDFS-15191 Key: NIFI-7818 URL: https://issues.apache.org/jira/browse/NIFI-7818 Project: Apache NiFi Issue Type: Bug

[GitHub] [nifi] markap14 commented on pull request #4537: NIFI-7817: Fix ParquetReader instantiation error

2020-09-18 Thread GitBox
markap14 commented on pull request #4537: URL: https://github.com/apache/nifi/pull/4537#issuecomment-694966410 Thanks for the PR @frankgh. It definitely looks like you've done a good bit of work diving in here to understand the flow of all of this logic. But I think the existing

[jira] [Updated] (NIFI-7811) PrometheusReportingTask starts even if there's a port clash and it cannot possibly work (and the logs are unhelpful)

2020-09-18 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-7811: - Fix Version/s: 1.13.0 Resolution: Fixed Status: Resolved (was: Patch Available)

[jira] [Commented] (NIFI-7811) PrometheusReportingTask starts even if there's a port clash and it cannot possibly work (and the logs are unhelpful)

2020-09-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198365#comment-17198365 ] ASF subversion and git services commented on NIFI-7811: --- Commit

[GitHub] [nifi] asfgit closed pull request #4531: NIFI-7811: Prevent NPE and bad behavior when PrometheusReportingTask can't start

2020-09-18 Thread GitBox
asfgit closed pull request #4531: URL: https://github.com/apache/nifi/pull/4531 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nifi] pvillard31 commented on pull request #4531: NIFI-7811: Prevent NPE and bad behavior when PrometheusReportingTask can't start

2020-09-18 Thread GitBox
pvillard31 commented on pull request #4531: URL: https://github.com/apache/nifi/pull/4531#issuecomment-694893797 Merged to main, thanks @mattyb149. Probably worth being included in 1.12.1 @joewitt. This is an automated

[GitHub] [nifi] pvillard31 commented on a change in pull request #4534: NIFI-7815: Enhance the logging in MergeContent processor

2020-09-18 Thread GitBox
pvillard31 commented on a change in pull request #4534: URL: https://github.com/apache/nifi/pull/4534#discussion_r490984606 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/MergeContent.java ## @@

[GitHub] [nifi] markap14 commented on a change in pull request #4537: NIFI-7817: Fix ParquetReader instantiation error

2020-09-18 Thread GitBox
markap14 commented on a change in pull request #4537: URL: https://github.com/apache/nifi/pull/4537#discussion_r491063326 ## File path: