VedaKadam commented on a change in pull request #4670:
URL: https://github.com/apache/nifi/pull/4670#discussion_r527030717
##
File path:
nifi-toolkit/nifi-toolkit-tls/src/test/groovy/org/apache/nifi/toolkit/tls/diagnosis/TlsToolkitGetDiagnosisStandaloneTest.groovy
##
@@ -0,0
adenes opened a new pull request #4675:
URL: https://github.com/apache/nifi/pull/4675
…toryManager:486
Added an extra null-check to avoid NullPointerException
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
mattyb149 edited a comment on pull request #4601:
URL: https://github.com/apache/nifi/pull/4601#issuecomment-730526414
Also two files refer to `org.codehaus.jackson.JsonNode` and should be
changed to `com.fasterxml.jackson.databind.JsonNode`:
ConvertJSONToSQL
TestConvertJSONToSQL
humpfhumpf commented on pull request #4156:
URL: https://github.com/apache/nifi/pull/4156#issuecomment-730537868
@nmelche , @keithfenechgig :
http://localhost:8080/nifi-api/flow/metrics/prometheus
This is an automated
bbende commented on a change in pull request #4669:
URL: https://github.com/apache/nifi/pull/4669#discussion_r527089323
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-stateless-bundle/README.md
##
@@ -0,0 +1,405 @@
+
+
+# Introduction
+
+The Apache NiFi application
ChrisSamo632 commented on pull request #4667:
URL: https://github.com/apache/nifi/pull/4667#issuecomment-730563161
> I just had a look over the code and it LGTM.
> @ijokarumawak, I'm pinging you in case you want to have a look as well on
your side?
Noticed that while the
[
https://issues.apache.org/jira/browse/NIFI-8023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235725#comment-17235725
]
David Handermann commented on NIFI-8023:
The TestJdbcCommon class has two references to
[
https://issues.apache.org/jira/browse/NIFI-8016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess updated NIFI-8016:
---
Status: Patch Available (was: In Progress)
> Hive connection pool dynamic properties cannot be used
thenatog commented on pull request #4670:
URL: https://github.com/apache/nifi/pull/4670#issuecomment-730635492
I've tested out using the diagnosis tool and had some feedback on its usage.
I've compiled my comments alongside the logs I saw for different tests I tried.
Let me know if you
[
https://issues.apache.org/jira/browse/NIFI-8017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne resolved NIFI-8017.
--
Resolution: Fixed
> NPEx at org.apache.nifi.provenance.index.lucene. IndexDirectoryManager:486
>
VedaKadam commented on a change in pull request #4670:
URL: https://github.com/apache/nifi/pull/4670#discussion_r527037153
##
File path:
nifi-toolkit/nifi-toolkit-tls/src/test/groovy/org/apache/nifi/toolkit/tls/diagnosis/TlsToolkitGetDiagnosisStandaloneTest.groovy
##
@@ -0,0
mattyb149 opened a new pull request #4678:
URL: https://github.com/apache/nifi/pull/4678
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
This PR adds support to the MySQL DatabaseAdapter
thenatog edited a comment on pull request #4670:
URL: https://github.com/apache/nifi/pull/4670#issuecomment-730635492
I've tested out using the diagnosis tool and had some feedback on its usage.
I've compiled my comments alongside the logs I saw for different tests I tried.
Let me know if
mattyb149 commented on pull request #4601:
URL: https://github.com/apache/nifi/pull/4601#issuecomment-730520211
The build fails due to some remaining references to
`org.codehaus.jackson.map.ObjectMapper` which should be replaced with
`com.fasterxml.jackson.databind.ObjectMapper`:
[
https://issues.apache.org/jira/browse/NIFI-8031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess reassigned NIFI-8031:
--
Assignee: Matt Burgess
> Support MySQL Upsert in PutDatabaseRecord
>
Matt Burgess created NIFI-8031:
--
Summary: Support MySQL Upsert in PutDatabaseRecord
Key: NIFI-8031
URL: https://issues.apache.org/jira/browse/NIFI-8031
Project: Apache NiFi
Issue Type:
mattyb149 commented on pull request #4601:
URL: https://github.com/apache/nifi/pull/4601#issuecomment-730526414
Also two files refer to `org.codehaus.jackson.JsonNode` and should be
changed to `com.fasterxml.jackson.databind.JsonNode`:
ConvertJSONToSQL
TestConvertJSONToSQL
mattyb149 commented on pull request #4601:
URL: https://github.com/apache/nifi/pull/4601#issuecomment-730550766
I took the liberty of making the changes and putting up a
[commit](https://github.com/mattyb149/nifi/commit/5b58e082f632db5adbb67feca678b414edd2550f),
feel free to cherry-pick
[
https://issues.apache.org/jira/browse/NIFI-8017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235742#comment-17235742
]
ASF subversion and git services commented on NIFI-8017:
---
Commit
[
https://issues.apache.org/jira/browse/NIFI-8017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne updated NIFI-8017:
-
Fix Version/s: 1.13.0
> NPEx at org.apache.nifi.provenance.index.lucene. IndexDirectoryManager:486
>
mattyb149 commented on a change in pull request #4588:
URL: https://github.com/apache/nifi/pull/4588#discussion_r527046529
##
File path:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/dbcp/hive/HiveConnectionPool.java
##
@@ -71,6 +72,9 @@
mattyb149 opened a new pull request #4676:
URL: https://github.com/apache/nifi/pull/4676
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Fix the use of dynamic properties in Hive
mattyb149 edited a comment on pull request #4601:
URL: https://github.com/apache/nifi/pull/4601#issuecomment-730526414
Also two files refer to `org.codehaus.jackson.JsonNode` and should be
changed to `com.fasterxml.jackson.databind.JsonNode`:
ConvertJSONToSQL
TestConvertJSONToSQL
adenes opened a new pull request #4677:
URL: https://github.com/apache/nifi/pull/4677
… CET
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
_Enables X functionality; fixes bug
exceptionfactory commented on a change in pull request #4669:
URL: https://github.com/apache/nifi/pull/4669#discussion_r527081617
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-stateless-bundle/README.md
##
@@ -0,0 +1,405 @@
+
+
+# Introduction
+
+The Apache NiFi
mattyb149 commented on pull request #4601:
URL: https://github.com/apache/nifi/pull/4601#issuecomment-730540878
`AtlasAPIV2ServerEmulator` refers to `DeserializationConfig.Feature` which
needs to be replaced with `DeserializationFeature`
markap14 merged pull request #4675:
URL: https://github.com/apache/nifi/pull/4675
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
markap14 commented on pull request #4675:
URL: https://github.com/apache/nifi/pull/4675#issuecomment-730634825
Thanks @adenes, good catch. All looks good to me. +1 merged to main.
This is an automated message from the Apache
levilentz commented on a change in pull request #4638:
URL: https://github.com/apache/nifi/pull/4638#discussion_r527226152
##
File path:
nifi-nar-bundles/nifi-graph-bundle/nifi-graph-processors/src/main/java/org/apache/nifi/processors/graph/ExecuteGraphQueryRecord.java
##
@@
levilentz commented on a change in pull request #4638:
URL: https://github.com/apache/nifi/pull/4638#discussion_r527230022
##
File path:
nifi-nar-bundles/nifi-graph-bundle/nifi-graph-processors/src/main/java/org/apache/nifi/processors/graph/ExecuteGraphQueryRecord.java
##
@@
levilentz commented on a change in pull request #4638:
URL: https://github.com/apache/nifi/pull/4638#discussion_r527229886
##
File path:
nifi-nar-bundles/nifi-graph-bundle/nifi-graph-processors/src/main/java/org/apache/nifi/processors/graph/ExecuteGraphQueryRecord.java
##
@@
levilentz commented on a change in pull request #4638:
URL: https://github.com/apache/nifi/pull/4638#discussion_r527227527
##
File path:
nifi-nar-bundles/nifi-graph-bundle/nifi-graph-processors/src/main/java/org/apache/nifi/processors/graph/ExecuteGraphQueryRecord.java
##
@@
levilentz commented on a change in pull request #4638:
URL: https://github.com/apache/nifi/pull/4638#discussion_r527227213
##
File path:
nifi-nar-bundles/nifi-graph-bundle/nifi-graph-processors/src/main/java/org/apache/nifi/processors/graph/ExecuteGraphQueryRecord.java
##
@@
levilentz commented on a change in pull request #4638:
URL: https://github.com/apache/nifi/pull/4638#discussion_r527227687
##
File path: nifi-nar-bundles/nifi-graph-bundle/nifi-graph-processors/pom.xml
##
@@ -78,5 +78,59 @@
1.13.0-SNAPSHOT
test
NissimShiman commented on a change in pull request #4627:
URL: https://github.com/apache/nifi/pull/4627#discussion_r527270967
##
File path:
nifi-commons/nifi-utils/src/main/java/org/apache/nifi/processor/util/StandardValidators.java
##
@@ -848,8 +849,8 @@ public
levilentz commented on a change in pull request #4638:
URL: https://github.com/apache/nifi/pull/4638#discussion_r527228060
##
File path:
nifi-nar-bundles/nifi-graph-bundle/nifi-graph-processors/src/main/java/org/apache/nifi/processors/graph/ExecuteGraphQueryRecord.java
##
@@
levilentz commented on a change in pull request #4638:
URL: https://github.com/apache/nifi/pull/4638#discussion_r527230592
##
File path:
nifi-nar-bundles/nifi-graph-bundle/nifi-graph-processors/src/main/java/org/apache/nifi/processors/graph/ExecuteGraphQueryRecord.java
##
@@
levilentz commented on a change in pull request #4638:
URL: https://github.com/apache/nifi/pull/4638#discussion_r527230291
##
File path:
nifi-nar-bundles/nifi-graph-bundle/nifi-graph-processors/src/main/java/org/apache/nifi/processors/graph/ExecuteGraphQueryRecord.java
##
@@
ijokarumawak commented on pull request #4667:
URL: https://github.com/apache/nifi/pull/4667#issuecomment-730929288
Thanks @ChrisSamo632 for the changes and @pvillard31 for pinging me. I took
a look briefly, the changes look good to me. I will have some time in the next
few days to look at
ZhangCheng created NIFI-8032:
Summary: fix RecordPath Guide doc
Key: NIFI-8032
URL: https://issues.apache.org/jira/browse/NIFI-8032
Project: Apache NiFi
Issue Type: Bug
Reporter:
adamdebreceni commented on a change in pull request #937:
URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r526678496
##
File path: libminifi/src/c2/C2Agent.cpp
##
@@ -873,6 +664,161 @@ void C2Agent::update_agent() {
}
}
+utils::TaskRescheduleInfo
adamdebreceni commented on a change in pull request #937:
URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r526772202
##
File path: libminifi/src/FlowController.cpp
##
@@ -70,60 +71,33 @@ namespace apache {
namespace nifi {
namespace minifi {
-#define
fgerlits commented on a change in pull request #937:
URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r526759292
##
File path: libminifi/src/c2/C2Client.cpp
##
@@ -0,0 +1,335 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
fgerlits commented on a change in pull request #937:
URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r526750750
##
File path: libminifi/src/FlowController.cpp
##
@@ -70,60 +71,33 @@ namespace apache {
namespace nifi {
namespace minifi {
-#define
lordgamez opened a new pull request #939:
URL: https://github.com/apache/nifi-minifi-cpp/pull/939
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
humpfhumpf created NIFI-8028:
Summary: Cannot compile "SNAPSHOT" extention
Key: NIFI-8028
URL: https://issues.apache.org/jira/browse/NIFI-8028
Project: Apache NiFi
Issue Type: Bug
adamdebreceni commented on a change in pull request #937:
URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r526858625
##
File path: libminifi/src/c2/C2Client.cpp
##
@@ -0,0 +1,335 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or
adamdebreceni commented on a change in pull request #937:
URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r526858104
##
File path: libminifi/src/c2/C2Client.cpp
##
@@ -0,0 +1,335 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or
adamdebreceni commented on a change in pull request #937:
URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r526895238
##
File path: libminifi/test/unit/FileSystemTests.cpp
##
@@ -0,0 +1,90 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under
adamdebreceni commented on a change in pull request #937:
URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r526860105
##
File path: libminifi/src/utils/EncryptionProvider.cpp
##
@@ -15,40 +14,45 @@
* See the License for the specific language governing
adamdebreceni commented on a change in pull request #937:
URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r526867132
##
File path: libminifi/src/c2/C2Client.cpp
##
@@ -0,0 +1,335 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/NIFI-8024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne updated NIFI-8024:
-
Fix Version/s: 1.13.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
>
[
https://issues.apache.org/jira/browse/NIFI-8024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235496#comment-17235496
]
ASF subversion and git services commented on NIFI-8024:
---
Commit
markap14 commented on pull request #4674:
URL: https://github.com/apache/nifi/pull/4674#issuecomment-730401669
Thanks for fixing that @exceptionfactory! Code change makes sense to me.
Looks good. Unit tests verify behavior. +1 merged to main.
markap14 merged pull request #4674:
URL: https://github.com/apache/nifi/pull/4674
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
adamdebreceni commented on a change in pull request #937:
URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r526858104
##
File path: libminifi/src/c2/C2Client.cpp
##
@@ -0,0 +1,335 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or
adamdebreceni commented on a change in pull request #937:
URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r526860105
##
File path: libminifi/src/utils/EncryptionProvider.cpp
##
@@ -15,40 +14,45 @@
* See the License for the specific language governing
adamdebreceni commented on a change in pull request #937:
URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r526864912
##
File path: libminifi/include/utils/file/FileSystem.h
##
@@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
adamdebreceni commented on a change in pull request #937:
URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r526895679
##
File path: libminifi/src/utils/file/FileSystem.cpp
##
@@ -0,0 +1,80 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
André Luiz Fernandes do Prado created NIFI-8029:
---
Summary: InvokeHTTP throwing illegalArgumentException when dynamic
property has accent
Key: NIFI-8029
URL:
VedaKadam commented on a change in pull request #4670:
URL: https://github.com/apache/nifi/pull/4670#discussion_r526965016
##
File path:
nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/toolkit/tls/diagnosis/TlsToolkitGetDiagnosisStandalone.java
##
@@ -0,0 +1,664
[
https://issues.apache.org/jira/browse/NIFI-8029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
André Luiz Fernandes do Prado updated NIFI-8029:
Description:
!Seleção_047.png|width=932,height=671!
[
https://issues.apache.org/jira/browse/NIFI-8029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
André Luiz Fernandes do Prado updated NIFI-8029:
Description:
!Seleção_047.png|width=932,height=671!
[
https://issues.apache.org/jira/browse/NIFI-8029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
André Luiz Fernandes do Prado updated NIFI-8029:
Description:
!Seleção_047.png|width=932,height=671!
VedaKadam commented on a change in pull request #4670:
URL: https://github.com/apache/nifi/pull/4670#discussion_r526979642
##
File path:
nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/toolkit/tls/diagnosis/TlsToolkitGetDiagnosisStandalone.java
##
@@ -0,0 +1,664
Pierre Villard created NIFI-8030:
Summary: Improve Atlas lineage when using PutHDFS to push data
accessed through Hive
Key: NIFI-8030
URL: https://issues.apache.org/jira/browse/NIFI-8030
Project:
VedaKadam commented on a change in pull request #4670:
URL: https://github.com/apache/nifi/pull/4670#discussion_r526989534
##
File path:
nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/toolkit/tls/diagnosis/TlsToolkitGetDiagnosisStandalone.java
##
@@ -0,0 +1,664
VedaKadam commented on a change in pull request #4670:
URL: https://github.com/apache/nifi/pull/4670#discussion_r526990641
##
File path:
nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/toolkit/tls/diagnosis/TlsToolkitGetDiagnosisStandalone.java
##
@@ -0,0 +1,664
fgerlits commented on a change in pull request #937:
URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r526994756
##
File path: libminifi/src/c2/C2Client.cpp
##
@@ -0,0 +1,335 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
[
https://issues.apache.org/jira/browse/NIFI-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235556#comment-17235556
]
David Handermann commented on NIFI-7962:
Is this still a problem when the
VedaKadam commented on a change in pull request #4670:
URL: https://github.com/apache/nifi/pull/4670#discussion_r526998832
##
File path:
nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/toolkit/tls/diagnosis/TlsToolkitGetDiagnosisStandalone.java
##
@@ -0,0 +1,664
tlsmith109 commented on a change in pull request #4627:
URL: https://github.com/apache/nifi/pull/4627#discussion_r527000620
##
File path:
nifi-commons/nifi-utils/src/main/java/org/apache/nifi/processor/util/StandardValidators.java
##
@@ -503,6 +503,7 @@ public
VedaKadam commented on a change in pull request #4670:
URL: https://github.com/apache/nifi/pull/4670#discussion_r527001402
##
File path:
nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/toolkit/tls/diagnosis/TlsToolkitGetDiagnosisStandalone.java
##
@@ -0,0 +1,664
VedaKadam commented on a change in pull request #4670:
URL: https://github.com/apache/nifi/pull/4670#discussion_r527001300
##
File path:
nifi-toolkit/nifi-toolkit-tls/src/main/java/org/apache/nifi/toolkit/tls/diagnosis/TlsToolkitGetDiagnosisStandalone.java
##
@@ -0,0 +1,664
VedaKadam commented on a change in pull request #4670:
URL: https://github.com/apache/nifi/pull/4670#discussion_r527002762
##
File path:
nifi-toolkit/nifi-toolkit-tls/src/test/groovy/org/apache/nifi/toolkit/tls/diagnosis/TlsToolkitGetDiagnosisStandaloneTest.groovy
##
@@ -0,0
VedaKadam commented on a change in pull request #4670:
URL: https://github.com/apache/nifi/pull/4670#discussion_r527004277
##
File path:
nifi-toolkit/nifi-toolkit-tls/src/test/groovy/org/apache/nifi/toolkit/tls/diagnosis/TlsToolkitGetDiagnosisCommandLineTest.groovy
##
@@ -0,0
fgerlits commented on a change in pull request #937:
URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r527005657
##
File path: libminifi/src/c2/C2Client.cpp
##
@@ -0,0 +1,335 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
tlsmith109 commented on a change in pull request #4627:
URL: https://github.com/apache/nifi/pull/4627#discussion_r527008993
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TailFile.java
##
@@
szaszm commented on a change in pull request #937:
URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r527014281
##
File path: libminifi/src/c2/C2Client.cpp
##
@@ -0,0 +1,335 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
79 matches
Mail list logo
