Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/571#discussion_r72162790
--- Diff:
nifi-api/src/main/java/org/apache/nifi/registry/VariableRegistryUtils.java ---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/571#discussion_r72169945
--- Diff:
nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/StandardPropertyValue.java
---
@@ -134,9
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/563#discussion_r72325932
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/678
+1
Visually verified code and did a contrib check build. In a 3 node secure
cluster, I did a lot of restarting, starting/stopping processors, disconnecting
nodes and trying to hit corner
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/563#discussion_r72330212
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-pubsub-processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/ConsumeKafka.java
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/563#discussion_r72325489
--- Diff:
nifi-api/src/main/java/org/apache/nifi/components/state/ExternalStateManager.java
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/695#discussion_r72313026
--- Diff: nifi-assembly/pom.xml ---
@@ -363,147 +363,6 @@ language governing permissions and limitations under
the License
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/563#discussion_r72326199
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http/endpoints
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/571#discussion_r72174228
--- Diff:
nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-processor/src/test/java/org/apache/nifi/update/attributes/TestUpdateAttribute.java
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/571#discussion_r72173534
--- Diff:
nifi-mock/src/main/java/org/apache/nifi/util/MockControllerServiceLookup.java
---
@@ -97,4 +97,5 @@ public String getControllerServiceName(final
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/571#discussion_r72173226
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/571#discussion_r72174604
--- Diff:
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/NotificationServiceManager.java
---
@@ -247,7 +247,7 @@ public PropertyValue getProperty
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/717
+1
Visually verified code and did a contrib check build. In a 3 node secure
cluster I did all manner of disconnecting/reconnecting, restarting, and
checking the bulletins I could think
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/571#discussion_r72173525
--- Diff:
nifi-mock/src/main/java/org/apache/nifi/util/MockControllerServiceInitializationContext.java
---
@@ -68,4 +68,6 @@ public ComponentLog getLogger
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/655#discussion_r72340096
--- Diff: nifi-assembly/NOTICE ---
@@ -1,4 +1,4 @@
-Apache NiFi
+wApache NiFi
--- End diff --
typo
---
If your project is set up
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/655#discussion_r72343405
--- Diff:
nifi-nar-bundles/nifi-datadog-bundle/nifi-datadog-reporting-task/src/main/java/org/apache/nifi/reporting/datadog/DataDogReportingTask.java
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/655#discussion_r72344471
--- Diff:
nifi-nar-bundles/nifi-datadog-bundle/nifi-datadog-reporting-task/src/main/java/org/apache/nifi/reporting/datadog/DataDogReportingTask.java
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/655#discussion_r72342175
--- Diff:
nifi-nar-bundles/nifi-datadog-bundle/nifi-datadog-reporting-task/src/main/java/org/apache/nifi/reporting/datadog/DataDogReportingTask.java
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/655#discussion_r72347152
--- Diff: nifi-assembly/LICENSE ---
@@ -1487,3 +1487,56 @@ This project bundles 'Jython' which is available
under a Python Software Foundat
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/655#discussion_r72341497
--- Diff:
nifi-nar-bundles/nifi-datadog-bundle/nifi-datadog-reporting-task/src/main/java/org/apache/nifi/reporting/datadog/DDMetricRegistryBuilder.java
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/655#discussion_r72342292
--- Diff:
nifi-nar-bundles/nifi-datadog-bundle/nifi-datadog-reporting-task/src/main/java/org/apache/nifi/reporting/datadog/DataDogReportingTask.java
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/655#discussion_r72340427
--- Diff:
nifi-nar-bundles/nifi-datadog-bundle/nifi-datadog-nar/src/main/resources/META-INF/LICENSE
---
@@ -0,0 +1,585
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/655#discussion_r72342803
--- Diff:
nifi-nar-bundles/nifi-datadog-bundle/nifi-datadog-reporting-task/src/main/java/org/apache/nifi/reporting/datadog/DataDogReportingTask.java
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/563#discussion_r72334765
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-pubsub-processors/pom.xml ---
@@ -35,6 +35,10 @@
nifi-utils
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/655#discussion_r72345217
--- Diff:
nifi-nar-bundles/nifi-datadog-bundle/nifi-datadog-reporting-task/src/main/java/org/apache/nifi/reporting/datadog/metrics/MetricsService.java
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/609
Hey @jfrazee, looks like you have contrib check issues that cause the build
to fail:
[WARNING]
src/main/java/org/apache/nifi/processors/standard/TransformXml.java[24:8]
(imports
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/529
Hey @ijokarumawak, looks like this has merge conflicts. Could you address
them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/614
Hey @ijokarumawak, looks like this now has merge conflicts. Could you
address them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/476
Hey @pvillard31, looks like this has merge conflicts. Could you address
them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/388
Hey @ToivoAdams, looks like this has merge conflicts. Could you address
them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/652
Reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/571
Hey @YolandaMDavis, looks like this has merge conflicts. Could you update
the PR to the latest master?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/652
I see this change only taking effect when the repo is initialized. Is there
really no other place that should be updated?
---
If your project is set up for it, you can reply to this email and have
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/514
+1
Removed the offending package from m2 repo, rebuilt and saw that it
properly didn't exist. Ran a template using MQTT processors to verified
functionality. Thanks @PuspenduBanerjee, I
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/514
Haha, glad it helped
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/701
Ocasionally see error:
3 node secure cluster
have non-coordinator node disconnect itself
from the other non-node, refresh cluster panel
See "An unexpected error has occurred"
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/701
I think that error is reproducible when I disconnect the primary node.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/701
2 reproducible errors:
3 node secure cluster
node 1 is primary and coordinator
view bulletin board from node 2
using node 1 disconnect node 3
first error: see multiple
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/571#discussion_r72112140
--- Diff: nifi-api/src/main/java/org/apache/nifi/registry/MultiMap.java ---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/571#discussion_r72111965
--- Diff:
nifi-api/src/main/java/org/apache/nifi/registry/VariableRegistryUtils.java ---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/695#discussion_r72461496
--- Diff: nifi-toolkit/nifi-toolkit-assembly/pom.xml ---
@@ -0,0 +1,89 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/695
Hey @brosander, just went through the license/notice and deps, most of it
looks good for the new assembly but I had a few comments. I really like this
new functionality hopefully it will help make
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/695#discussion_r72460515
--- Diff: nifi-assembly/pom.xml ---
@@ -363,147 +363,6 @@ language governing permissions and limitations under
the License
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/695#discussion_r72462162
--- Diff: nifi-toolkit/nifi-toolkit-assembly/NOTICE ---
@@ -0,0 +1,112 @@
+Apache NiFi Toolkit
+Copyright 2014-2016 The Apache Software Foundation
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/695#discussion_r72464516
--- Diff: nifi-toolkit/nifi-toolkit-assembly/NOTICE ---
@@ -0,0 +1,112 @@
+Apache NiFi Toolkit
+Copyright 2014-2016 The Apache Software Foundation
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/695#discussion_r72455337
--- Diff: nifi-assembly/pom.xml ---
@@ -363,147 +363,6 @@ language governing permissions and limitations under
the License
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/695#discussion_r72460359
--- Diff: nifi-toolkit/nifi-toolkit-tls/pom.xml ---
@@ -0,0 +1,115 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/695#discussion_r72478934
--- Diff: nifi-toolkit/nifi-toolkit-assembly/NOTICE ---
@@ -0,0 +1,112 @@
+Apache NiFi Toolkit
+Copyright 2014-2016 The Apache Software Foundation
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/695#discussion_r72487873
--- Diff: nifi-assembly/pom.xml ---
@@ -363,147 +363,6 @@ language governing permissions and limitations under
the License
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/695#discussion_r72478817
--- Diff: nifi-toolkit/nifi-toolkit-assembly/NOTICE ---
@@ -0,0 +1,112 @@
+Apache NiFi Toolkit
+Copyright 2014-2016 The Apache Software Foundation
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/695#discussion_r72478228
--- Diff: nifi-toolkit/nifi-toolkit-assembly/NOTICE ---
@@ -0,0 +1,112 @@
+Apache NiFi Toolkit
+Copyright 2014-2016 The Apache Software Foundation
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/695#discussion_r72488748
--- Diff: nifi-toolkit/nifi-toolkit-assembly/NOTICE ---
@@ -0,0 +1,112 @@
+Apache NiFi Toolkit
+Copyright 2014-2016 The Apache Software Foundation
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/725
3 node secure cluster testing NIFI-2223, I see "conflict" and not "A
template named 'XYZ' already exists."
![screen shot 2016-07-27 at 2 17 59
pm](https://cloud.g
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/730
+1
Visually verified code, and did a contrib check. In a 3 node cluster and
standalone did various tests with copying and pasting different components and
all worked as expected. Thanks
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/725
Empty name template checking appears to only occur as a server side check.
This would be a simple client side check to add and would be a nice UX addition.
---
If your project is set up
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/725
+1
Visually verified code and did a contrib check build. In both standalone
and 3 node secure cluster, I tested all 5 situations and various other checks
relating to templates. Thanks
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/698
Similar logic is possible when going from the sub group to root group.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/698
I don't think NIFI-2235 was addressed. I am still able to reproduce
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/698
NIFI-2235 offending logic path:
copy processor in root PG
go into PG I do not have modify access
Context menu does not have paste, palette menu allows it to be clicked
after i click
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/698
As part of NIFI-1800, when viewing the config for a process group it should
have the UUID at the top. This way at the very least I can tell which
controller services belong to this ProcessGroup
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/698#discussion_r71795919
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/authorization/ConnectionAuthorizable.java
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/705
Reproducible error:
3 node cluster
stop 2 of the nodes
restart all three nodes cluster
None of them can start up, hit "Unexpected Error".
In the nifi.app logs
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/704
+1
Visually verified code, did a contrib check build. In 3 node secure
cluster, I added spaces to various parts of each nifi.properties and then ran
the cluster. Performed as expected
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/705
+1
Visually verified code, and did a contrib check. Ran a 3 node secure
cluster and tested various combinations of disconnecting and reconnecting nodes
and restarting in order to find
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/701
@markap14, this branch has conflicts with the current master, can you
resolve them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/698
Github is taking a long time to replicate but here is a link to the commit
in apache (I pushed it, I swear, lol):
https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/698
+1
Visually verified code and comments were addressed. Did a contrib check
build and on a 3 node secure cluster ran through each ticket and did many
different iterations of various paths
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/736
+1
Visually verified code and did a contrib check build. In a standalone
instance and 3 node secure cluster verified that the policies didn't/did show
up as expected. Thanks @mcgilman, I
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/740
Sorry more specifically, I have a 3 node cluster and made one change on
each (while all were connected), I didn't expect to see all three of the
changes in the history of each node.
---
If your
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/740
Yup, that was my confusion and I think the target user of this message
(people not really familiar with the in's/out's of clustering) will get hung up
on that as well.
---
If your project is set
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/694#discussion_r72731831
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/dto/EntityFactory.java
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/694#discussion_r72728226
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/dto/EntityFactory.java
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/740
I was a bit confused by the message at first, I took it to mean "this
history only shows changes that were made on this node" and was confused when I
saw changes from every node on t
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/571
Yup let's make another ticket for the documentation and just address what
was already merged into 0.x
+1
Visually verified code and did a contrib check build. In standalone
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/740
After sleeping on it, I agree with you.
+1
Visually verified code, and did a contrib check build. In 3 node secure
cluster and standalone verified that the message appeared when
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/694
@jtstorck, testing using one node that acts normally and 2 that always
allow.
Labels don't seem to get their permissions merged properly. I verified on
master that they work as expected
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/571
Whops accidentally mistyped the close statement but I merged it in[1].
@YolandaMDavis could you close this?
[1]
https://github.com/apache/nifi/commit
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/529
Sorry, @ijokarumawak I accidentally mistyped the "close" statement on a PR
I merged. Please re-open this.
---
If your project is set up for it, you can reply to this email and have
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/694
Hey @jtstorck, the "View the data" and "Modify the data" policies are not
being merged/properly taken into account when querying/working with provenance
events. (In bot
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/745
+1
Visually verified code, and ran a contrib check build. In 3 node secure
cluster and standalone instance tested various combinations of valid, invalid
and disabled components to see
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/571#discussion_r72144814
--- Diff:
nifi-api/src/main/java/org/apache/nifi/registry/VariableRegistryUtils.java ---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/695#discussion_r72462023
--- Diff: nifi-toolkit/nifi-toolkit-assembly/NOTICE ---
@@ -0,0 +1,112 @@
+Apache NiFi Toolkit
+Copyright 2014-2016 The Apache Software Foundation
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/476#discussion_r72539247
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateCsv.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/476#discussion_r72541263
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateCsv.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/476#discussion_r72542364
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateCsv.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/476#discussion_r72538224
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateCsv.java
---
@@ -0,0
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/563
When attempting to view state for ConsumeKafka when Kafka is not running,
it does not handle it well. In the UI I see "An unexpected error has occurred
An error occurred communic
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/655
Hey @Ramizjon, it looks like your squash didn't quite go right. I think you
somehow squashed all the commits ever. That commit says it has "4,279 changed
files with 19,598 additions
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/609
Sorry for taking so long @jfrazee, I got caught up with something I thought
was an issue but turned out it was just me messing up.
+1
Visually verified code, and did a contrib
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/655
No problem, happy to help get it right and learn.
When you do "git status" on the master branch it will tel you "you are X
number of commits ahead of origin/master and Y nu
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/655
@Ramizjon don't need to create a whole repo. You can probably achieve it
this way (first do "git fetch --all" to make sure you're up to date):
1: branch off of your master branc
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/655
@Ramizjon, another great resource for learning Git is this "Explain Git
with D3" page[1]. It visually and interactively explains the different commands.
[1] https://onlywei
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/837
Reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/655
@Ramizjon, I am attempting to test but I think there is something wrong
with my Datadog account itself because I tried connecting to it with both NiFi
and the OSX Agent and it doesn't get past
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/757
Sorry for not noticing this earlier but it appears that encapsulated
components (processors, controller services, etc.) inside a process group that
gets deleted do not have their associated
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/757
@mcgilman I don't think the UI button to delete the CS/RT works properly.
When I tried to use it when I had "write" but not "view" I saw a 405.
![screen shot 2016-
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/837
+1
Visually verified code and did a contrib check build. In a standalone
cluster tested many different levels of transitive dependencies using
DetectDuplicate
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/655
@Ramizjon Hmmm, that is unexpected. When you do `git log` do you see
"commit fa639e2596cc125af80615066f500cc908d4db6a" as the first (Matt Gilman's
commit for NIFI-2542)? Sorry I thou
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/655
It looks like your "origin" is not the apache or github repo so your not
comparing to the correct master commit. Could you run this "git remote -v"?
That will list all
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/655
@Ramizjon so it looks like you have the github repo added with the name
"upstream" but the current upstream repo is your "origin" repo (given that when
you do "git stat
1 - 100 of 613 matches
Mail list logo