GitHub user benqiu2016 opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/5
Minifi 69
Add GetFile and TailFile processor.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benqiu2016/nifi-minifi-cpp MINIFI-69
Github user benqiu2016 closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/41#discussion_r99379332
--- Diff: cmake/FindOpenSSL.cmake ---
@@ -0,0 +1,28 @@
+# OPENSSL_ROOT_DIR - Set this variable to the root installation of OpenSSL
--- End
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/41#discussion_r99884121
--- Diff: libminifi/include/FlowController.h ---
@@ -90,6 +93,25 @@ class FlowController
}
return _flowController
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/41
@phrocker @apiri remove the FindOpenSSL cmake by setting the
OPENSSL_ROOT_DIR. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/41
@apiri new code commit to address your review comment, back out the IOS
port.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user benqiu2016 closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/53
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/53
i rebase the benqiu2016/nifi-minifi-cpp to nifi-minifi-cpp and create
branch MINIFI-215 under benqiu2016 to track the change.
---
If your project is set up for it, you can reply
GitHub user benqiu2016 opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/53
Minifi 215
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benqiu2016/nifi-minifi-cpp MINIFI-215
Alternatively you can review
GitHub user benqiu2016 opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/51
MINIFI-215: IOS port
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benqiu2016/nifi-minifi-cpp master
Alternatively you can review
GitHub user benqiu2016 opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/41
MINIFI-184: Add Security Support
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benqiu2016/nifi-minifi-cpp master
Alternatively
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/40
@achristianson looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user benqiu2016 opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/6
MINFI-85: Add ListenSyslog processor
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benqiu2016/nifi-minifi-cpp MINFI-85
GitHub user benqiu2016 opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/62
MINIFI-231: Add Flow Persistent, Using id instead of name to load theâ¦
⦠flow from YAML
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user benqiu2016 opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/9
Minifi 87
add MiNiFi start/stop script
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benqiu2016/nifi-minifi-cpp MINIFI-87
GitHub user benqiu2016 opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/13
MINIFI-109: Add ExecuteProcess
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benqiu2016/nifi-minifi-cpp
excecute_process_merge
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/12
@apiri, will do. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/12
Close as Aldrin suggested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user benqiu2016 closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/12
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user benqiu2016 opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/12
Minifi 109
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benqiu2016/nifi-minifi-cpp MINIFI-109
Alternatively you can review
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/13
@apiri Address the above review comments. Thanks for the review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user benqiu2016 opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/23
MINIFI-131: Provenance Support
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benqiu2016/nifi-minifi-cpp master
Alternatively you
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/23
@apiri
address above review comments
Fix the GetFile regex bug with this PR also.
https://issues.apache.org/jira/browse/MINIFI-113
---
If your project is set up for it, you can
GitHub user benqiu2016 opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/24
MINIFI-114: Set default stateFile for TailFile
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benqiu2016/nifi-minifi-cpp master
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/68
looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user benqiu2016 closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/66
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/66
i think we may need to revisit the way to do MARCO in the later stage.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user benqiu2016 opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/67
Ios
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109757748
--- Diff: libminifi/src/provenance/ProvenanceTaskReport.cpp ---
@@ -0,0 +1,221 @@
+/**
+ * @file ProvenanceTaskReport.cpp
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109758846
--- Diff: libminifi/src/provenance/ProvenanceRepository.cpp ---
@@ -36,6 +36,7 @@ void ProvenanceRepository::run() {
uint64_t curTime
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109759205
--- Diff: thirdparty/jsoncpp/devtools/batchbuild.py ---
@@ -0,0 +1,278 @@
+from __future__ import print_function
--- End diff
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109758278
--- Diff: libminifi/src/provenance/ProvenanceTaskReport.cpp ---
@@ -0,0 +1,221 @@
+/**
+ * @file ProvenanceTaskReport.cpp
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109760197
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -1240,6 +1257,88 @@ void Site2SiteClientProtocol::transferFlowFiles(
return
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109761443
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -682,6 +682,7 @@ bool Site2SiteClientProtocol::receive(std::string
transactionID
GitHub user benqiu2016 opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74
Minifi 227
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109954861
--- Diff: thirdparty/jsoncpp/devtools/batchbuild.py ---
@@ -0,0 +1,278 @@
+from __future__ import print_function
--- End diff
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109958322
--- Diff: libminifi/src/provenance/ProvenanceRepository.cpp ---
@@ -36,6 +36,7 @@ void ProvenanceRepository::run() {
uint64_t curTime
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109954528
--- Diff: libminifi/src/provenance/ProvenanceTaskReport.cpp ---
@@ -0,0 +1,221 @@
+/**
+ * @file ProvenanceTaskReport.cpp
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109954793
--- Diff: libminifi/src/provenance/ProvenanceTaskReport.cpp ---
@@ -0,0 +1,221 @@
+/**
+ * @file ProvenanceTaskReport.cpp
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109956092
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -1240,6 +1257,88 @@ void Site2SiteClientProtocol::transferFlowFiles(
return
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r109955536
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -682,6 +682,7 @@ bool Site2SiteClientProtocol::receive(std::string
transactionID
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r110004694
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -1240,6 +1257,88 @@ void Site2SiteClientProtocol::transferFlowFiles(
return
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r110004494
--- Diff: libminifi/src/provenance/ProvenanceTaskReport.cpp ---
@@ -0,0 +1,221 @@
+/**
+ * @file ProvenanceTaskReport.cpp
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r110006513
--- Diff: libminifi/src/Site2SiteClientProtocol.cpp ---
@@ -1240,6 +1257,88 @@ void Site2SiteClientProtocol::transferFlowFiles(
return
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/74
@apiri i addressed your above review comments. Adding the new test case to
support full site2site is not as easy as we thought, we need to support hand
shake/CRC/two phase commit to make
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/77
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/75
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/56
create a different PR to track that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user benqiu2016 closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/56
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user benqiu2016 opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/66
Ios
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/66#discussion_r105460203
--- Diff: libminifi/src/io/TLSSocket.cpp ---
@@ -20,23 +20,29 @@
#include "Configure.h"
--- End diff --
sam
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/66#discussion_r105460135
--- Diff: libminifi/include/io/TLSSocket.h ---
@@ -24,8 +24,10 @@
#include
--- End diff --
it is difficult because we need
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/66
Instead of commenting on every macro, perhaps an alternative is to, at
build time, include files that are appropriate to your unit. If you want YAML,
have a configuration class that's
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/62
@phrocker Add unitest, please review and approve. I would like to get it
merge before your big name space change. Thanks a lot.
---
If your project is set up for it, you can reply
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/62#discussion_r104301097
--- Diff: libminifi/include/FlowFileRepository.h ---
@@ -0,0 +1,208 @@
+/**
+ * @file FlowFileRepository
+ * Flow file repository
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/62#discussion_r104301956
--- Diff: libminifi/include/FlowFileRepository.h ---
@@ -0,0 +1,208 @@
+/**
+ * @file FlowFileRepository
+ * Flow file repository
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/62#discussion_r104301877
--- Diff: libminifi/include/FlowFileRepository.h ---
@@ -0,0 +1,208 @@
+/**
+ * @file FlowFileRepository
+ * Flow file repository
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/62#discussion_r104300897
--- Diff: libminifi/include/FlowFileRecord.h ---
@@ -108,6 +109,10 @@ class FlowFileRecord
* Create a new flow record
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/62#discussion_r104300837
--- Diff: libminifi/include/Connection.h ---
@@ -180,7 +184,8 @@ class Connection
std::atomic _maxQueueDataSize;
//! Flow File
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/62#discussion_r104301034
--- Diff: libminifi/include/FlowFileRecord.h ---
@@ -202,6 +216,8 @@ class FlowFileRecord
std::string _uuidStr;
//! UUID string
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/62#discussion_r104301026
--- Diff: libminifi/include/FlowFileRecord.h ---
@@ -108,6 +109,10 @@ class FlowFileRecord
* Create a new flow record
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/62#discussion_r104319949
--- Diff: libminifi/include/Repository.h ---
@@ -0,0 +1,294 @@
+/**
+ * @file Repository
+ * Repository class declaration
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/62#discussion_r104318207
--- Diff: libminifi/include/Repository.h ---
@@ -0,0 +1,294 @@
+/**
+ * @file Repository
+ * Repository class declaration
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/62#discussion_r104319998
--- Diff: libminifi/include/Repository.h ---
@@ -0,0 +1,294 @@
+/**
+ * @file Repository
+ * Repository class declaration
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/62#discussion_r104320252
--- Diff: libminifi/src/Repository.cpp ---
@@ -0,0 +1,140 @@
+/**
+ * @file Repository.cpp
+ * Repository implemenatation
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/62#discussion_r104318102
--- Diff: libminifi/include/Repository.h ---
@@ -0,0 +1,294 @@
+/**
+ * @file Repository
+ * Repository class declaration
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/62#discussion_r104318122
--- Diff: libminifi/include/Repository.h ---
@@ -0,0 +1,294 @@
+/**
+ * @file Repository
+ * Repository class declaration
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/62#discussion_r104318245
--- Diff: libminifi/include/Repository.h ---
@@ -0,0 +1,294 @@
+/**
+ * @file Repository
+ * Repository class declaration
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/62#discussion_r104320062
--- Diff: libminifi/include/Repository.h ---
@@ -0,0 +1,294 @@
+/**
+ * @file Repository
+ * Repository class declaration
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/62#discussion_r104320103
--- Diff: libminifi/src/FlowFileRecord.cpp ---
@@ -74,6 +76,43 @@ FlowFileRecord::FlowFileRecord(std::map<std::string,
std::string> attr
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/62#discussion_r104320291
--- Diff: libminifi/src/Repository.cpp ---
@@ -0,0 +1,140 @@
+/**
+ * @file Repository.cpp
+ * Repository implemenatation
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/62#discussion_r104827593
--- Diff: libminifi/test/unit/ProvenanceTestHelper.h ---
@@ -20,6 +20,62 @@
#include "Provenance.h"
#include "F
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/62#discussion_r104827822
--- Diff: libminifi/test/unit/ProcessorTests.cpp ---
@@ -33,10 +35,18 @@ TEST_CASE("Test Find file", "
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/62
@apiri could you please merge the PR once you have free time. No rush. But
it would be good if it can get in before Marc name space change.
---
If your project is set up for it, you can
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/74
@phrocker
97%] Building C object
thirdparty/civetweb-1.9.1/src/CMakeFiles/c-executable.dir/main.c.o
Linking C executable civetweb
/usr/include/x86_64-linux-gnu/bits/stdio2.h
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/74
my MAC build linter is OKW12612:build binqiu$ make linter
/Users/binqiu/report/nifi-minifi-cpp/libminifi/include//Connection.h,/Users/binqiu/report/nifi-minifi-cpp/libminifi/include
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/74
@phrocker it looks like the travis for MAC is OK.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/74#discussion_r111843708
--- Diff: libminifi/include/core/Processor.h ---
@@ -239,12 +242,21 @@ class Processor : public Connectable, public
ConfigurableComponent
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/74
@apiri Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user benqiu2016 opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/81
MINIFI-269: Add Site2Site Test case
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126211327
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -150,6 +194,87 @@ void
RemoteProcessorGroupPort::onTrigger(core::ProcessContext
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126208386
--- Diff: libminifi/include/utils/HTTPUtils.h ---
@@ -88,6 +90,40 @@ struct HTTPRequestResponse {
};
+static void parse_url
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126210180
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -150,6 +194,87 @@ void
RemoteProcessorGroupPort::onTrigger(core::ProcessContext
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126209183
--- Diff: libminifi/include/Site2SiteClientProtocol.h ---
@@ -387,6 +387,15 @@ class DataPacket {
};
+/**
+ * Site2Site
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/114
Thanks for the review. Can we merge the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126240211
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -20,6 +20,9 @@
#include "../include/RemoteProcessorGroupP
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/114#discussion_r126239506
--- Diff: libminifi/include/utils/HTTPUtils.h ---
@@ -88,6 +90,40 @@ struct HTTPRequestResponse {
};
+static void parse_url
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/114
@phrocker if we use a stack based lock guard, in order to control the
period of lock, i need to add scope for the lock guard inside {}. it make code
less readable.
Anyway. i can
GitHub user benqiu2016 opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/119
MINIFI-70: enhance site2site port negotiation
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/114
@phrocker used https://github.com/apache/nifi-minifi-cpp/pull/119 which has
a single merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user benqiu2016 closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/114
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/119
@phrocker it is run OK in my MAC. run OK in Xcode 7.3 and fail in 8.3 in
travis.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/114
@phrocker @kevdoran use lock, extract token code, set default port. we need
to support /nifi-api/controller which is common to 1.x and 0.x.
---
If your project is set up for it, you
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/117#discussion_r128773288
--- Diff: libminifi/include/utils/ThreadPool.h ---
@@ -246,15 +349,67 @@ void ThreadPool::startWorkers() {
template
void ThreadPool
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/117
overall looks good. may be some optimization for the queue.
Please some tests in long duration to make sure it is not breaking the
master because it is big change.
---
If your
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/119
@phrocker it is passed now after i retrigger the same.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/110
@phrocker looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/117#discussion_r128620813
--- Diff: libminifi/include/utils/ThreadPool.h ---
@@ -246,15 +349,67 @@ void ThreadPool::startWorkers() {
template
void ThreadPool
Github user benqiu2016 commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/117#discussion_r128621371
--- Diff: libminifi/include/utils/ThreadPool.h ---
@@ -246,15 +349,67 @@ void ThreadPool::startWorkers() {
template
void ThreadPool
Github user benqiu2016 commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/117
[config.txt](https://github.com/apache/nifi-minifi-cpp/files/1166193/config.txt)
---
If your project is set up for it, you can reply to this email and have your
reply appear
1 - 100 of 155 matches
Mail list logo
