Github user devriesb commented on the issue:
https://github.com/apache/nifi/pull/2416
while i in no way object to a new implementation, I'm not sure that is the
correct solution to the bug described in NIFI-4774[1]. A new implementation
would need to be tested to a degree
Github user devriesb commented on the issue:
https://github.com/apache/nifi/pull/2461
Agreed on specifying a char set, but other than that I think it looks good!
---
Github user devriesb commented on the issue:
https://github.com/apache/nifi/pull/2416
So, I was under the impression this was still a WIP. I am a HUGE -1 on
this change. As @markap14 stated above, this is a critical section of code.
And while the previous version has serious flaws
Github user devriesb commented on the issue:
https://github.com/apache/nifi/pull/2416
I'll grant NIFI-4775 may raise issues with my proposed solution. However,
there is a problem right now. My proposed solution addresses the problem right
now. Future modification may require
Github user devriesb commented on the issue:
https://github.com/apache/nifi/pull/2416
I'm glad there's support for making this opt in. One point on @joewitt 's
comment : "The claim of a simple fix being available to close the previous gaps
doesn't appear to be b
Github user devriesb commented on the issue:
https://github.com/apache/nifi/pull/2416
Again, I would submit that it isn't violating the data loss guarantees of
the original implementation. Yes, some data could potentially be lost, but
none that it guaranteed to keep, and in doing so
Github user devriesb commented on the issue:
https://github.com/apache/nifi/pull/2416
@markap14 yes... under this somewhat unusual circumstance, my proposed
solution would sacrifice data for consistency. However, if alwaysSync is set
false, there isn't a guarantee of no loss anyway
Github user devriesb commented on the issue:
https://github.com/apache/nifi/pull/2284
Koji,
"Are all of these three methods, removeAndGet, removeByPatternAndGet and
keySet required by the folks you know of?" - Yes.
"atomicity is not that important
Github user devriesb commented on the issue:
https://github.com/apache/nifi/pull/2796
+1. Looks good, and we've been running the new version successfully for
weeks.
---
