[GitHub] nifi pull request #704: NIFI-2253 flexibly cleaning zookeeper connect string

2016-07-22 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/704#discussion_r71884405 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/cluster/ZooKeeperClientConfig.java

[GitHub] nifi issue #720: Introduce data resource for authorizing Provenance and Queu...

2016-07-26 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/720 Code looks good now. Unit tests are good. Tested functionality and all appears to work as expected. +1 merged to master. Thanks! --- If your project is set up for it, you can reply to this email

[GitHub] nifi pull request #633: NIFI-2234: Fixed but that was overwriting the cluste...

2016-07-12 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/633 NIFI-2234: Fixed but that was overwriting the cluster node identifier… … in provenance events You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] nifi issue #631: NIFI-2095: Introduce User/Group/Policy UI

2016-07-12 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/631 @mcgilman looks great! A whole lot of work has gone into this, and it looks fantastic. Was able to verify functionality of the different access policies. I create a handful of additional JIRA's

[GitHub] nifi pull request #649: Nifi 1413

2016-07-14 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/649 Nifi 1413 You can merge this pull request into a Git repository by running: $ git pull https://github.com/markap14/nifi NIFI-1413 Alternatively you can review and apply these changes

[GitHub] nifi issue #651: UI - Cluster Awareness

2016-07-14 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/651 @mcgilman looks great - i was able to verify the behavior and merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #614: NIFI-2145: Auto flow.xml archive

2016-07-14 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/614 Oh no! As always, I forgot to add the magical words to close the PR. Can you close this PR manually? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi issue #614: NIFI-2145: Auto flow.xml archive

2016-07-14 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/614 @ijokarumawak looked over the code, and all looks good. I updated the docs to fix a few misspellings / typos. Tested and verified behavior, including turning archive on & off, aging off based on

[GitHub] nifi issue #647: NIFI-1157 NIFI-1307 Resolve deprecated classes and methods

2016-07-14 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/647 @joewitt the code changes look good. Was able to build and verify that all still compiles and that all unit tests still pass. Tested a lot of different scenarios that I could think of to ensure

[GitHub] nifi pull request #652: NIFI-2087: Do not update the lucene index to delete ...

2016-07-14 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/652 NIFI-2087: Do not update the lucene index to delete expired events... Instead, just wait for the entire index to expire and remove the files for that index. This is much more efficient. You can

[GitHub] nifi issue #654: Addressing issue with enabling/disabling Controller Service...

2016-07-14 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/654 These changes all look good, and they do address the issues seen. Thanks! Will merge to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi issue #652: NIFI-2087: Do not update the lucene index to delete expired...

2016-07-14 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/652 @JPercivall no, that should be it. We have one other place where we use the DeleteFileAction but it still needs to stay there. This should take care of it. --- If your project is set up for it, you

[GitHub] nifi pull request #701: NIFI-2292: Funnel all cluster node status changes th...

2016-07-21 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/701 NIFI-2292: Funnel all cluster node status changes through the cluster coordinator… … instead of having each node broadcast changes to the whole cluster. This gives us the ability to increment

[GitHub] nifi pull request #717: NIFI-2292: Funnel all cluster node status changes th...

2016-07-25 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/717 NIFI-2292: Funnel all cluster node status changes through the cluster coordinator… You can merge this pull request into a Git repository by running: $ git pull https://github.com/markap14

[GitHub] nifi pull request #701: NIFI-2292: Funnel all cluster node status changes th...

2016-07-25 Thread markap14
Github user markap14 closed the pull request at: https://github.com/apache/nifi/pull/701 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request #729: NIFI-2406: Ensure that hearbeat monitor continues to...

2016-07-27 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/729 NIFI-2406: Ensure that hearbeat monitor continues to run while instance … …is running. This way if a node sends heartbeat to this node as elected coordinator changes, we notify the node

[GitHub] nifi pull request #728: NIFI-2388: Use null for group id if no group specifi...

2016-07-27 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/728 NIFI-2388: Use null for group id if no group specified instead of throwing NPE You can merge this pull request into a Git repository by running: $ git pull https://github.com/markap14/nifi

[GitHub] nifi pull request #529: NIFI-2028: Fixed Site-to-Site Transit URI

2016-07-28 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/529#discussion_r72617680 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/main/java/org/apache/nifi/remote/StandardRemoteGroupPort.java

[GitHub] nifi pull request #688: NIFI-2304: If node address is not set, default to lo...

2016-07-28 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/688#discussion_r72613879 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat

[GitHub] nifi pull request #688: NIFI-2304: If node address is not set, default to lo...

2016-07-28 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/688#discussion_r72614705 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat

[GitHub] nifi pull request #688: NIFI-2304: If node address is not set, default to lo...

2016-07-28 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/688#discussion_r72614233 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat

[GitHub] nifi issue #688: NIFI-2304: If node address is not set, default to localhost...

2016-07-28 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/688 @ijokarumawak thanks for reviewing! Updated PR to address the 'port' and left comments re: hostname. Let me know if you have any other thoughts. Thanks! --- If your project is set up for it, you can

[GitHub] nifi pull request #734: NIFI-2395: Ensure that if we fail to index provenanc...

2016-07-28 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/734#discussion_r72636644 --- Diff: nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance

[GitHub] nifi pull request #731: NIFI-2337: Turn off logging for org.apache.curator.f...

2016-07-27 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/731 NIFI-2337: Turn off logging for org.apache.curator.framework.recipes.… …leader.LeaderSelector since it logs only a single error, and that error is a but in Curator You can merge this pull

[GitHub] nifi pull request #739: NIFI-2419: Ensure that if a node is disconnected tha...

2016-07-28 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/739 NIFI-2419: Ensure that if a node is disconnected that we unregister f… …or 'cluster coordinator' and 'primary node' roles by updating FlowController to know that it is disconnected. Also removed

[GitHub] nifi issue #705: NIFI-2360: Leave ZooKeeper running when a node is disconnec...

2016-07-22 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/705 @JPercivall - interestingly enough i didn't see this in any of my testing but when i switched back to the branch i saw it immediately when i started up the cluster. A restart fixed it, but then after

[GitHub] nifi pull request #742: NIFI-2431: Before registering for the Cluster Coordi...

2016-07-29 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/742 NIFI-2431: Before registering for the Cluster Coordinator role, check… … if another node already has this role. If so, do not register for this role until after the node has joined the cluster

[GitHub] nifi pull request #734: NIFI-2395: Ensure that if we fail to index provenanc...

2016-07-29 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/734#discussion_r72788219 --- Diff: nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance

[GitHub] nifi pull request #718: NIFI-2366 - Fixed ID generation semantics in cluster...

2016-07-29 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/718#discussion_r72813537 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/java/org/apache/nifi/web/util/SnippetUtilsTest.java

[GitHub] nifi pull request #746: NIFI-2388: Addressed a spot that assumes that Proces...

2016-07-29 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/746 NIFI-2388: Addressed a spot that assumes that Process Group is always… … set on StandardControllerServiceNode You can merge this pull request into a Git repository by running: $ git pull

[GitHub] nifi pull request #746: NIFI-2388: Addressed a spot that assumes that Proces...

2016-07-29 Thread markap14
Github user markap14 closed the pull request at: https://github.com/apache/nifi/pull/746 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request #752: NIFI-2291: Correct the Content URI for 1.0.0 REST AP...

2016-07-29 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/752 NIFI-2291: Correct the Content URI for 1.0.0 REST API; added cluster … …node identifier & whether or not clustered to ReportingContext so that the Reporting Task could make use of it You

[GitHub] nifi issue #758: NIFI-2444 NIFI-2445 fixed PublishKafka

2016-08-01 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/758 @olegz the KafkaPublisher class is now logging everything twice. I think we need to get rid of the internal logger and use only the Processor Logger. --- If your project is set up for it, you can

[GitHub] nifi issue #702: NIFI-1950 Updating FileAuthorizer to convert access control...

2016-07-25 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/702 @bbende I was able to verify functionality and code review looks good. Thanks for updating this! +1 pushed to master. --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi issue #701: NIFI-2292: Funnel all cluster node status changes through t...

2016-07-25 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/701 @JPercivall that's a good catch! I updated the PR to address this. The issue was that whenever there is only 1 node in the cluster, it is complaining if we attempt to disconnect ANY node (even one

[GitHub] nifi issue #720: Introduce data resource for authorizing Provenance and Queu...

2016-07-26 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/720 Things look good on here, but I noticed that the seeding of the authorizations.xml file does not include the DN's of the hosts in my authorizers.xml file, but it did include my 'admin dn' from

[GitHub] nifi issue #718: NIFI-2366 - Fixed ID generation semantics in clustered envi...

2016-07-31 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/718 @olegz looks good! Did a full build and created several process groups, processors, input & output ports, funnels, remote process groups, and labels. Copied & pasted them all over the place,

[GitHub] nifi pull request #529: NIFI-2028: Fixed Site-to-Site Transit URI

2016-07-25 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/529#discussion_r72096781 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-site-to-site/src/main/java/org/apache/nifi/remote/StandardRemoteGroupPort.java

[GitHub] nifi pull request #828: NIFI-2540: Exclude from templates the parts of prope...

2016-08-10 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/828 NIFI-2540: Exclude from templates the parts of property descriptors t… …hat are not necessary. Also ensure that Property Descriptors are not completely removed from Controller Services. You can

[GitHub] nifi pull request #771: NIFI-2452

2016-08-02 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/771 NIFI-2452 Ensure that we keep track of how many references we have to each lucene searcher and only close the underlying index reader if there are no references to the searcher. Also updated

[GitHub] nifi issue #758: NIFI-2444 NIFI-2445 fixed PublishKafka

2016-08-02 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/758 All looks good now. I was able to verify that contrib-check passes. All unit tests pass and all compiles. Was able to deploy to same system that was having problems before and see that all FlowFiles

[GitHub] nifi issue #761: NIFI-2444 NIFI-2445 fixed PublishKafka

2016-08-02 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/761 Thanks @olegz. All looks good. +1 merged to 0.x --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #836: NIFI-2545: Ensure that when @OnUnscheduled and @OnSt...

2016-08-11 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/836 NIFI-2545: Ensure that when @OnUnscheduled and @OnStopped methods are… … called that the active thread count takes that thread into account You can merge this pull request into a Git repository

[GitHub] nifi pull request #829: NIFI-2535: Do not include properties that are unset ...

2016-08-10 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/829 NIFI-2535: Do not include properties that are unset in flow fingerpri… …nt. This allows a new property to be added to a processor without affecting the fingerprint, if the value is never set

[GitHub] nifi pull request #832: NIFI-2544: Created integration tests for clustering ...

2016-08-10 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/832 NIFI-2544: Created integration tests for clustering and addressed a f… …ew minor bugs that were found in doing so You can merge this pull request into a Git repository by running: $ git

[GitHub] nifi pull request #776: NIFI-2446: Add option to specify key password when d...

2016-08-03 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/776 NIFI-2446: Add option to specify key password when different than keystore password NIFI-2446: Add option to specify key password when different than keystore password You can merge this pull

[GitHub] nifi pull request #782: NIFI-2474: Remove VariableRegistry from outward faci...

2016-08-03 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/782 NIFI-2474: Remove VariableRegistry from outward facing API so that th… …e it is more flexible to evolve You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi issue #776: NIFI-2466: Add option to specify key password when differen...

2016-08-03 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/776 @alopresto wow i really messed up my testing. Sorry about that, and great catch. I replicated your steps above and added the keystore to src/test/resources for the StandardSSLContextService

[GitHub] nifi issue #760: Reporting appropriate error message when not authorized to ...

2016-08-03 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/760 Verified behavior before & after patch. Change looks good. +1, merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] nifi pull request #778: NIFI-2407 Implements EL support on some properties o...

2016-08-03 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/778#discussion_r73411049 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/test/java/org/apache/nifi/processors/hadoop/PutHDFSTest.java --- @@ -199,7 +202,39

[GitHub] nifi pull request #778: NIFI-2407 Implements EL support on some properties o...

2016-08-03 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/778#discussion_r73416186 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/test/java/org/apache/nifi/dbcp/DBCPServiceTest.java

[GitHub] nifi issue #752: NIFI-2291: Correct the Content URI for 1.0.0 REST API; adde...

2016-08-03 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/752 Excellent, thanks, @YolandaMDavis ! Congratulations of your first merge :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi pull request #778: NIFI-2407 Implements EL support on some properties o...

2016-08-03 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/778#discussion_r73406263 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/AbstractHadoopProcessor.java --- @@ -191,9

[GitHub] nifi issue #776: NIFI-2466: Add option to specify key password when differen...

2016-08-03 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/776 @alopresto sorry about that NPE - i had a typo where i referenced the configContext instead of validation context. The config context isn't guaranteed to be set when customValidate is called. Pushed

[GitHub] nifi pull request #741: NIFI-2322, NIFI-2423, NIFI-2412 Kafka improvements

2016-08-04 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/741#discussion_r73512333 --- Diff: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-pubsub-processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/AbstractKafkaProcessor.java

[GitHub] nifi issue #690: NIFI-2035: Verify existence of source and destination when ...

2016-08-04 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/690 Hey @YolandaMDavis - the changes that were made in the later commit will not completely prevent the IllegalArgumentException from being thrown in verifyCreate... it's still possible because after

[GitHub] nifi issue #783: NIFI-2478 Fixed Zk leaders path to include root.

2016-08-04 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/783 @ijokarumawak I verified the fix works & contrib-check looks good. +1 merged to master. Thanks for catching that! --- If your project is set up for it, you can reply to this email and have

[GitHub] nifi pull request #789: NIFI-2483: Removed 'passthrough' relationship

2016-08-04 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/789 NIFI-2483: Removed 'passthrough' relationship You can merge this pull request into a Git repository by running: $ git pull https://github.com/markap14/nifi NIFI-2483 Alternatively you can

[GitHub] nifi issue #729: NIFI-2406: Ensure that hearbeat monitor continues to run wh...

2016-08-04 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/729 @YolandaMDavis thanks - PR i was rebased & pushed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] nifi pull request #786: NIFI-2472: Normalize coordinates for all components ...

2016-08-04 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/786 NIFI-2472: Normalize coordinates for all components in a snippet, not… … just processors You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] nifi pull request #779: NIFI-2471 fix Hadoop configuration resources when ta...

2016-08-04 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/779#discussion_r73546113 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/AbstractHadoopProcessor.java --- @@ -177,9

[GitHub] nifi issue #690: NIFI-2035: Verify existence of source and destination when ...

2016-08-03 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/690 @YolandaMDavis after reviewing the NPE I changed my mind - you do appear to be causing the issue manually :) The NPE was another place where we needed to verify that the source and destination

[GitHub] nifi pull request #848: NIFI-2551: Addressed a threading issue in the Standa...

2016-08-12 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/848 NIFI-2551: Addressed a threading issue in the StandardResourceClaimManager… … and performed some refactoring so that we can ensure thread-safety across different components of the application

[GitHub] nifi pull request #847: NIFI-2551: Addressed a threading issue in the Standa...

2016-08-12 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/847 NIFI-2551: Addressed a threading issue in the StandardResourceClaimManager… … and performed some refactoring so that we can ensure thread-safety across different components of the application

[GitHub] nifi pull request #693: NIFI-2333: Consider reporting tasks and controller s...

2016-07-20 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/693 NIFI-2333: Consider reporting tasks and controller services when determining whether or not flow is empty You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi pull request #696: NIFI-2336: Ensure that we save changes to the flow w...

2016-07-20 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/696 NIFI-2336: Ensure that we save changes to the flow when we start or stop the current process group NIFI-2336: Ensure that we save changes to the flow when we start or stop the current process group

[GitHub] nifi pull request #696: NIFI-2336: Ensure that we save changes to the flow w...

2016-07-20 Thread markap14
Github user markap14 closed the pull request at: https://github.com/apache/nifi/pull/696 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request #697: NIFI-2334: Delegate requests for cluster info to the...

2016-07-20 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/697 NIFI-2334: Delegate requests for cluster info to the cluster coordinator You can merge this pull request into a Git repository by running: $ git pull https://github.com/markap14/nifi NIFI-2334

[GitHub] nifi issue #678: NIFI-2316, NIFI-2318: Ensure that we do not save the flow b...

2016-07-21 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/678 @JPercivall I think the issue that you are seeing now is related to NIFI-2292. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi pull request #667: NIFI-2305: Do not run processors that are marked as ...

2016-07-18 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/667 NIFI-2305: Do not run processors that are marked as Primary Node Only… … if disconnected from cluster You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi pull request #671: NIFI-826 (part deux)

2016-07-18 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/671#discussion_r71214452 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/util/SnippetUtils.java --- @@ -565,13

[GitHub] nifi issue #666: Fixing issues loading the Policy Management UI

2016-07-18 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/666 LGTM. The verbage for the access policies is definitely better imho. +1. Merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi issue #671: NIFI-826 (part deux)

2016-07-18 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/671 +1 all looks good. I've pushed to master. Thanks for knocking this out! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi pull request #665: NIFI-2289: Directly ask ZooKeeper which node is clus...

2016-07-16 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/665 NIFI-2289: Directly ask ZooKeeper which node is cluster coordinator a… …nd add watches on the ZNode rather than relying on Node Status Updates over the cluster protocol because cluster protocol

[GitHub] nifi pull request #678: NIFI-2316, NIFI-2318: Ensure that we do not save the...

2016-07-19 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/678 NIFI-2316, NIFI-2318: Ensure that we do not save the flow before init… …ializing the Run Status of components. Clarify the Node Event messages You can merge this pull request into a Git

[GitHub] nifi pull request #682: NiFi 2324 - Log number of requests per URI if we hav...

2016-07-19 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/682 NiFi 2324 - Log number of requests per URI if we have too many outstanding requests to replicate You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi pull request #683: NIFI-2324: Log number of requests per URI if we have...

2016-07-19 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/683 NIFI-2324: Log number of requests per URI if we have too many outstan… …ding requests to replicate You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi pull request #682: NiFi 2324 - Log number of requests per URI if we hav...

2016-07-19 Thread markap14
Github user markap14 closed the pull request at: https://github.com/apache/nifi/pull/682 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request #680: NIFI-2319: Ensure that when we set cluster node id's...

2016-07-19 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/680 NIFI-2319: Ensure that when we set cluster node id's and node address… …es, that we do so only if they are not already populated You can merge this pull request into a Git repository by running

[GitHub] nifi issue #679: NIFI-826 (part 3)

2016-07-19 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/679 @olegz looks good. Addresses the issue that I was seeing. +1. Merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi pull request #681: NIFI-2289: Ensure that we include Node ID's of all n...

2016-07-19 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/681 NIFI-2289: Ensure that we include Node ID's of all nodes when finding… … cluster coordinator, even if the node is currently still connecting or has not yet joined the cluster, which ccan

[GitHub] nifi pull request #690: NIFI-2035: Verify existence of source and destinatio...

2016-07-20 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/690 NIFI-2035: Verify existence of source and destination when creating a… … connection You can merge this pull request into a Git repository by running: $ git pull https://github.com/markap14

[GitHub] nifi pull request #686: NIFI-2330: Ensure that we set ProcessGroupDTO's cont...

2016-07-20 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/686 NIFI-2330: Ensure that we set ProcessGroupDTO's contents after popula… …ting sets of components, as the contents dto now copies the sets You can merge this pull request into a Git repository

[GitHub] nifi pull request #688: NIFI-2304: If node address is not set, default to lo...

2016-07-20 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/688 NIFI-2304: If node address is not set, default to localhost, as the a… …dmin guide says it should You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi pull request #689: NIFI-2305: Do not run processors that are marked as ...

2016-07-20 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/689 NIFI-2305: Do not run processors that are marked as Primary Node Only… … if disconnected from cluster You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi issue #658: Addressing issue searching Provenance while clustered and R...

2016-07-15 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/658 Merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #658: Addressing issue searching Provenance while clustered and R...

2016-07-15 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/658 Looks good, Matt! Thanks for fixing this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request #630: NIFI-2228: Change FlowFileHandlingException to exten...

2016-07-12 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/630 NIFI-2228: Change FlowFileHandlingException to extend from RuntimeExc… …eption instead of ProcessException You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi issue #636: NIFI-2249: Move URI out of component so it is accessible wi...

2016-07-13 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/636 @mcgilman looks good - merged to master. Thanks for knocking this one out! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi pull request #641: NIFI-2252: Fixed issue where POST to Controller Reso...

2016-07-13 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/641 NIFI-2252: Fixed issue where POST to Controller Resource createContro… …llerService and also ensure that URI is set on the entity You can merge this pull request into a Git repository by running

[GitHub] nifi issue #625: NIFI-2214 updated both of the Azure Event Hub processors to...

2016-07-13 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/625 @apsaltis great, thanks! The MIT licenses are handled a little differently and are placed in the LICENSE file instead of the NOTICE file. I updated accordingly and pushed to master. Thanks

[GitHub] nifi issue #663: NIFI-1157 removed method that is no longer necessary post d...

2016-07-16 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/663 @joewitt I do agree that these methods are now superfluous and should be removed. Verified that all builds and all still looks okay. Contrib-check is good, as well. +1 Merged to master --- If your

[GitHub] nifi pull request #621: NIFI-2185: Proxy requests through the cluster coordi...

2016-07-08 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/621 NIFI-2185: Proxy requests through the cluster coordinator rather than… … making use of distributed read/write locks You can merge this pull request into a Git repository by running: $ git

[GitHub] nifi issue #625: NIFI-2214 updated both of the Azure Event Hub processors to...

2016-07-11 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/625 @apsaltis very cool that you were able to jump in and knock this out! The community very much appreciates it! Looking through the code, it all looks good. I did notice though that the client library

[GitHub] nifi pull request #791: NIFI-2484: Ensure that if a Processor throws an Exce...

2016-08-04 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/791 NIFI-2484: Ensure that if a Processor throws an Exception from an @On… …Scheduled method that @OnStopped methods get called You can merge this pull request into a Git repository by running

[GitHub] nifi issue #778: NIFI-2407 Implements EL support on some properties of proce...

2016-08-04 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/778 @jtstorck all looks good now. Thanks for updating those! +1, merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi issue #779: NIFI-2471 fix Hadoop configuration resources when talking t...

2016-08-04 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/779 OK thanks @mosermw. Looks good. Merged to master & 0.x branches. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi issue #729: NIFI-2406: Ensure that hearbeat monitor continues to run wh...

2016-08-04 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/729 @YolandaMDavis is this cluster running an embedded zookeeper? If so, which node(s)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi pull request #808: NIFI-2495: Ensure that we always close Index Searche...

2016-08-08 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/808 NIFI-2495: Ensure that we always close Index Searchers when we're fin… …ished with them You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] nifi pull request #820: NIFI-2406: Addressed regression introduced in NIFI-2...

2016-08-09 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/820 NIFI-2406: Addressed regression introduced in NIFI-2406 where the clu… …ster does not recognize a new Cluster Coordinator when the coordinator is shutdown You can merge this pull request

  1   2   3   4   5   6   7   8   9   10   >