GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1429
NIFI-3291: Address additional issues from jQuery upgrade
NIFI-3291:
- Fixing styles from our usage of jquery ui autocomplete.
- Fixing horizontal scroll bars.
- Fixing border around
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1430
NIFI-3301: Fix cursor style over event type text in lineage graph
NIFI-3301:
- Removing incorrect cursor style when hovering over event type text in a
linage graph.
You can merge this pull
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1428
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1430
@jvwing Thanks for the prompt review!
I certainly don't mind having a more comprehensive review of the current
behavior. The initial stab at the PR was simply trying to address the conf
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1428
Thanks for starting all this modularization @scottyaslan! This looks mostly
good but I have a couple comments.
In nf-canvas.js, the loading of the cluster summary has been moved to
before
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1430
Sounds good. I've made the changes. However, I'm going to hold off on
pushing the update since it'll conflict with some changes that I'm reviewing in
another PR (#1428) with som
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1428
Thanks @scottyaslan! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1430
I just pushed an update making the suggested changes. Thanks again!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1430
Good call. I had my setup to ignore whitespace following my rebase and I
overlooked it. I'm pretty sure it's correct now but it still looks like some
things are shifted because I moved a
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1437
Hey @jvwing. I actually updated these in a separate PR that's been awaiting
review for awhile now. Specifically, they were regenerated in #1399.
---
If your project is set up for it, you can
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1438
NIFI-3291: Continue addressing issues from jQuery upgrade
NIFI-3291:
- Fixing overflow calculation to determine if scrollbars are necessary.
- Fixing styles with jquery ui slider usage.
You
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi-maven/pull/1
NIFI-1450: Fixed issue preventing provided nar dependencies from running
NIFI-1450:
- Ensuring that system properties are relayed so that the disable doclint
profile is not activated.
You
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1437
No worries. Sounds like a plan. I could have opened a new JIRA but decided
to just address in that PR since I was updating the integration tests. Thanks
for opening the 0.x PR!
---
If your project
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1399#discussion_r97633156
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-controller-services.js
---
@@ -497,6
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1399
Yep, I'm tracking. Looks like that will provide more consistent coverage
when checking if that behavior should be available.
---
If your project is set up for it, you can reply to this emai
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1399
I've updated the PR with the changes suggested thus far. Thanks again
@jvwing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1443
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1443
Looks good @pvillard31! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1441
Will review..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1441#discussion_r97814843
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/conf/login-identity-providers.xml
---
@@ -50,7 +50,7
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1444
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1444
Looks good @pvillard31. This has been merged to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1441
Thanks @pvillard31! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1438#discussion_r98240235
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/provenance/nf-provenance-table.js
---
@@ -617,7
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1476
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1476
@ijokarumawak Thanks! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1368
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1368
Thanks @pvillard31! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1483
NIFI-3251: Addressing JS error preventing CS table loading
NIFI-3251:
- Ensuring read permissions to the ControllerService before attempting to
check permissions to parent.
You can merge this
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1486
NIFI-3291: Addressing more issues following jQuery upgrade
NIFI-3291:
- Fixing slider issue when there is only one event in the lineage graph.
- Fixing scollbar issue when accessing the
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1487
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1488
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1488
@scottyaslan I think the inclusion of the processor-configuration.css needs
to happen in the pom and summary.properties which define the files being
included. The proposed solution does not work
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1489
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1487
Thanks @scottyaslan. This has been merged to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1488
Thanks @scottyaslan. This has been merged to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1489
Thanks @scottyaslan. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1495
Thanks @scottyaslan. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1498
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1498
Thanks @scottyaslan. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1506
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1506
Thanks @scottyaslan. This has been merged to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1516
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1516
Thanks @scottyaslan. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1519
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1519
@scottyaslan Can you update the existing license with the content from the
new version of D3? I think it's just updating the Copyright date.
---
If your project is set up for it, you can rep
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1519
Thanks @scottyaslan. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1533
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1533
Thanks @scottyaslan. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1540
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1540
Thanks @scottyaslan. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1538
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1538
Overall this looks good. One minor comment though.. can we move the the
click handler into a common place so the callback is replicated a number of
times?
---
If your project is set up for it, you
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1538
Yeah, but nf-common might be more appropriate considering all the places
this needs to be called.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1534
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1534
Couple quick comments...
- The cluster summary dialogs for the other types of components should
probably be updated as well.
- With the new layout, we can probably remove some of the
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1535
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1535
Thanks @scottyaslan. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1538
Thanks @scottyaslan. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1545
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1545
Thanks @scottyaslan. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1534
Looks good @scottyaslan. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1546
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1546
Hey @scottyaslan,
This is a great start, but I think there are a few fundamental issues with
how `PropertyDescriptors` relay what sort of editor should be used. There does
not appear to be
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1555
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1559
Will Review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1560
Will Review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1555
Thanks @markap14. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1560
Thanks @scottyaslan! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1572
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1574
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1572
Thanks @jvwing! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1574
Thanks @apiri! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1582
NIFI-3575: Prevent unintended move events
- Verify that when moving a snippet, we do not attempt to move a process
group into itself.
- Update the UI to ensure a subsequent move event cannot be
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1582
I left this guidance on the JIRA for anyone testing/reviewing...
> Feel free to apply the server side changes first. This should prevent
NiFi from getting into this state. You should see
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1590
NIFI-3244: Updating rendering of parent of Controller Service
NIFI-3244:
- Updating Controller Service scope header.
- Rendering the name of the parent when possible.
- Fixing the check
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1591
NIFI-3243: Rendering the selected Process Group in the header if possible
NIFI-3243:
- Rendering the selected Process Group in the header if possible.
You can merge this pull request into a Git
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1593
NIFI-3245: Controller Service availability note
NIFI-3245:
- Adding notes to the controller service tables to better define their
availability.
- Clarifying support of Safari.
You can
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1585#discussion_r105758869
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/pom.xml
---
@@ -440,6 +440,7
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1585#discussion_r105759544
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-actions.js
---
@@ -1214,6 +1217,23
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1594
NIFI-3246: Prevent editing of inherited Controller Services
NIFI-3246:
- Preventing the editing of controller services that are defined in an
ancestor process group.
- Adding a go to link
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1585#discussion_r105980032
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/resources/filters/canvas.properties
---
@@ -28,6 +28,7
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1585#discussion_r105980001
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/jquery/propertytable/jquery.propertytable.js
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1599
NIFI-3615: Removing hidden control characters
NIFI-3615:
- Removing hidden control characters.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1601
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1600
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1601
Thanks @alopresto. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1600
Thanks @scottyaslan. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1559
Thanks @scottyaslan. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1616
NIFI-3272: GC stats in Cluster view
NIFI-3272:
- Adding explicit support for the default and G1 garbage collector in the
JVM tab of the cluster table.
You can merge this pull request into a
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1620
NIFI-3421: Preventing successive attempts to create a FlowController
NIFI-3421:
- On contextDestroyed, referencing beans created during contextInitialized
to prevent successive attempts to
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1626
NIFI-3643: Fixing capitalization in Java Property
NIFI-3643:
- Addressing incorrect capitalization in VersionInfoDTO in NiFiVersion.
You can merge this pull request into a Git repository by
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1627
NIFI-3380: Fixing paths in generated documentation
NIFI-3380:
- Addressing issues with paths in generated documentation.
You can merge this pull request into a Git repository by running
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1616
Thanks @joewitt! Will update accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1616
@joewitt I took a different approach. Please pull down the latest and
re-review. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1616
Rebased, squashed, and pushed. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1622
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1622
@trixpan Thanks for the PR. Everything functions correctly but behind the
scenes we were recording observers for the NONE log level because the observers
are registered according to the severity
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1635
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1622
Thanks @trixpan! This has been merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
1 - 100 of 1205 matches
Mail list logo
