[GitHub] nifi issue #239: Nifi 1540 - AWS Kinesis Get and Put Processors

2016-09-25 Thread simplesteph
Github user simplesteph commented on the issue: https://github.com/apache/nifi/pull/239 +1 on separate nar for now. In the short term that's how users (like me) may benefit from it! Should be a quick win as well --- If your project is set up for it, you can reply to this email

[GitHub] nifi issue #1136: [NIFI-2900] fixes timestamps to be ISO 8601 compliant, as ...

2016-10-29 Thread simplesteph
Github user simplesteph commented on the issue: https://github.com/apache/nifi/pull/1136 Sorry I haven't had the time to work on it just yet... Agree with all the above --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #1136: [NIFI-2900] fixes timestamps to be ISO 8601 compliant, as ...

2016-10-14 Thread simplesteph
Github user simplesteph commented on the issue: https://github.com/apache/nifi/pull/1136 That could be a solution, but I believe it's a more complicated one than just keeping the date-time annotation and make the API compliant with the OpenAPI specs. If you create a "Time&q

[GitHub] nifi issue #1136: [NIFI-2900] fixes timestamps to be ISO 8601 compliant, as ...

2016-10-14 Thread simplesteph
Github user simplesteph commented on the issue: https://github.com/apache/nifi/pull/1136 Hi, I understand the concern. The tests were passing on my end, but maybe something has been broken. Let me explain the rationale: 1) Your API should comply with the OpenAPI

[GitHub] nifi issue #1136: [NIFI-2900] fixes timestamps to be ISO 8601 compliant, as ...

2016-11-02 Thread simplesteph
Github user simplesteph commented on the issue: https://github.com/apache/nifi/pull/1136 hi @mcgilman , pain commit but it should be good. the resulting `swagger.json` doesn't have any datetime, which makes the api compliant in that regard. Not sure when 2.0 is planned, and not sure

[GitHub] nifi issue #239: Nifi 1540 - AWS Kinesis Put Processor

2016-10-11 Thread simplesteph
Github user simplesteph commented on the issue: https://github.com/apache/nifi/pull/239 Amazing guys congrats! Quick question, are there plans to have a GetKinesis processor too? or should we open another JIRA for that? Kind regards, Stephane [image: Simple

[GitHub] nifi issue #1135: [NIFI-2899] Updated swagger-maven-plugin to 3.0.1

2016-10-13 Thread simplesteph
Github user simplesteph commented on the issue: https://github.com/apache/nifi/pull/1135 good stuff. Quick question, what do you think of NiFi automating the build and release of API clients in various language, vs me just maintaining it in my own repos? --- If your project is set

[GitHub] nifi issue #1135: [NIFI-2899] Updated swagger-maven-plugin to 3.0.1

2016-10-13 Thread simplesteph
Github user simplesteph commented on the issue: https://github.com/apache/nifi/pull/1135 No worries, I’ll build it on my own in my separate repos, see if people have any usage for it, and based on adoption thinking of merging this into the base. What I really like though

[GitHub] nifi pull request #1135: [NIFI-2899] Updated swagger-maven-plugin to 3.0.1

2016-10-13 Thread simplesteph
GitHub user simplesteph opened a pull request: https://github.com/apache/nifi/pull/1135 [NIFI-2899] Updated swagger-maven-plugin to 3.0.1 Incorporates the fix from https://github.com/kongchen/swagger-maven-plugin/issues/141 Ensures the new swagger.json is spec 2.0 compliant

[GitHub] nifi pull request #1136: [NIFI-2900] fixes timestamps to be ISO 8601 complia...

2016-10-14 Thread simplesteph
GitHub user simplesteph opened a pull request: https://github.com/apache/nifi/pull/1136 [NIFI-2900] fixes timestamps to be ISO 8601 compliant, as it should b… …e because of OpenAPI specs You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi pull request #239: Nifi 1540 - AWS Kinesis Put Processor

2016-10-10 Thread simplesteph
Github user simplesteph commented on a diff in the pull request: https://github.com/apache/nifi/pull/239#discussion_r82724343 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/kinesis/stream/PutKinesis.java --- @@ -0,0

[GitHub] nifi issue #1136: [NIFI-2900] fixes timestamps to be ISO 8601 compliant, as ...

2016-10-16 Thread simplesteph
Github user simplesteph commented on the issue: https://github.com/apache/nifi/pull/1136 I think then we need to add `dataType = "string"` in the annotation to every field `DateTime` that uses any `TimeAdapter` or `DateTimeAdapter`. Hopefully this way the format won'