[GitHub] nifi issue #2082: NIFI-2829: Fixed PutSQL time unit test.

2017-08-14 Thread yjhyjhyjh0
Github user yjhyjhyjh0 commented on the issue: https://github.com/apache/nifi/pull/2082 Thanks for the detail explanation. Indeed using local time zone is more reasonable. Didn’t notice the date will be transform into local time zone once with value format. Just

[GitHub] nifi issue #1983: NiFi-2829: Add Date and Time Format Support for PutSQL

2017-07-12 Thread yjhyjhyjh0
Github user yjhyjhyjh0 commented on the issue: https://github.com/apache/nifi/pull/1983 Thanks for the reply and detail review. Just update the commit title, document part and remove unnecessary if condition. Seems AppVevor fail at same part. Travis CI only fail

[GitHub] nifi issue #1983: NiFi-2829: Add Date and Time Format Support for PutSQL

2017-07-15 Thread yjhyjhyjh0
Github user yjhyjhyjh0 commented on the issue: https://github.com/apache/nifi/pull/1983 Thanks for the review and feedback. I’ve add your enhancement of handing time precision at milliseconds in PutSQL. Also I'm very willing to add a unit test for it. However after

[GitHub] nifi issue #1983: NiFi-2829: Add Date and Time Format Support for PutSQL

2017-07-06 Thread yjhyjhyjh0
Github user yjhyjhyjh0 commented on the issue: https://github.com/apache/nifi/pull/1983 Well, lesson learned. Last build fail with Travis-CI is trailing whitespace problem. Just fix that and retry the PR. --- If your project is set up for it, you can reply to this email

[GitHub] nifi pull request #1983: NiFi-2829: Add Date and Time Format Support for Put...

2017-07-06 Thread yjhyjhyjh0
GitHub user yjhyjhyjh0 reopened a pull request: https://github.com/apache/nifi/pull/1983 NiFi-2829: Add Date and Time Format Support for PutSQL Fix unit test for Date and Time type time zone problem while testing PutSQL processor @paulgibeault made the original PR #1073

[GitHub] nifi pull request #1983: NiFi-2829: Add Date and Time Format Support for Put...

2017-07-06 Thread yjhyjhyjh0
Github user yjhyjhyjh0 closed the pull request at: https://github.com/apache/nifi/pull/1983 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request #1983: NiFi-2829: Add Date and Time Format Support for Put...

2017-07-05 Thread yjhyjhyjh0
GitHub user yjhyjhyjh0 opened a pull request: https://github.com/apache/nifi/pull/1983 NiFi-2829: Add Date and Time Format Support for PutSQL Fix unit test for Date and Time type time zone problem while testing PutSQL processor @paulgibeault made the original PR #1073

[GitHub] nifi issue #2166: NIFI-4395 - GenerateTableFetch can't fetch column type by ...

2017-09-21 Thread yjhyjhyjh0
Github user yjhyjhyjh0 commented on the issue: https://github.com/apache/nifi/pull/2166 Thanks for the detail comment and suggestion. That helps me a lot. Some fix by suggestion like. 1 - put back StringmaxValueColumnNames to GenerateTableFetch to avoid NPE unit test

[GitHub] nifi issue #2166: NIFI-4395 - GenerateTableFetch can't fetch column type by ...

2017-09-21 Thread yjhyjhyjh0
Github user yjhyjhyjh0 commented on the issue: https://github.com/apache/nifi/pull/2166 Not quite understand result from travis-ci. Seems it stuck at ANTLR Parser AttributeExpressionParser every time? ---

[GitHub] nifi pull request #2166: NIFI-4395 - GenerateTableFetch can't fetch column t...

2017-09-21 Thread yjhyjhyjh0
GitHub user yjhyjhyjh0 opened a pull request: https://github.com/apache/nifi/pull/2166 NIFI-4395 - GenerateTableFetch can't fetch column type by state after… … instance reboot Thank you for submitting a contribution to Apache NiFi. In order to streamline

[GitHub] nifi issue #2166: NIFI-4395 - GenerateTableFetch can't fetch column type by ...

2017-09-21 Thread yjhyjhyjh0
Github user yjhyjhyjh0 commented on the issue: https://github.com/apache/nifi/pull/2166 I've solved this issue by re-cache column type if needed and pass local unit and instance test. The root cause of this issue is that originally disign didn't recognize that column type

[GitHub] nifi pull request #2442: NIFI-4395 GenerateTableFetch can't fetch column typ...

2018-01-29 Thread yjhyjhyjh0
GitHub user yjhyjhyjh0 opened a pull request: https://github.com/apache/nifi/pull/2442 NIFI-4395 GenerateTableFetch can't fetch column type by state after i… …nstance reboot Add multiple states recover Add support for multiple state cache recover after instance

[GitHub] nifi pull request #2530: NIFI-4800 Expose the flattenMode as property in Fla...

2018-03-11 Thread yjhyjhyjh0
GitHub user yjhyjhyjh0 opened a pull request: https://github.com/apache/nifi/pull/2530 NIFI-4800 Expose the flattenMode as property in FlattenJSON processor Expose all 3 kinds of flatten mode. Documentation along with unit tests. Finish local nifi instance integration test

[GitHub] nifi issue #2530: NIFI-4800 Expose the flattenMode as property in FlattenJSO...

2018-03-12 Thread yjhyjhyjh0
Github user yjhyjhyjh0 commented on the issue: https://github.com/apache/nifi/pull/2530 Thanks for the review. I've added display name as most processor does and removed unnecessary line at unit tests. ---

[GitHub] nifi pull request #2538: NIFI-4962 FlattenJson processor add unexpected back...

2018-03-13 Thread yjhyjhyjh0
GitHub user yjhyjhyjh0 opened a pull request: https://github.com/apache/nifi/pull/2538 NIFI-4962 FlattenJson processor add unexpected backslash after flatten Upgrade json flatten library version to newest one to deal with StringEscapePolicy. Add unit test code to verify

[GitHub] nifi pull request #3107: NIFI-5744: Put exception message to attribute while...

2018-10-24 Thread yjhyjhyjh0
GitHub user yjhyjhyjh0 opened a pull request: https://github.com/apache/nifi/pull/3107 NIFI-5744: Put exception message to attribute while ExecuteSQL fail Put exception message to flowfile attribute if exception occur. Add unit test to ExecuteSQL, ExecuteSQLRecord. Update

[GitHub] nifi pull request #3107: NIFI-5744: Put exception message to attribute while...

2018-11-01 Thread yjhyjhyjh0
Github user yjhyjhyjh0 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3107#discussion_r230031051 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteSQL.java --- @@ -83,6

[GitHub] nifi issue #3107: NIFI-5744: Put exception message to attribute while Execut...

2018-10-27 Thread yjhyjhyjh0
Github user yjhyjhyjh0 commented on the issue: https://github.com/apache/nifi/pull/3107 Thanks for the remind, there are some nice discussions in the mailing list. I'll fix capitalization after we have consensus. ---

[GitHub] nifi pull request #3156: NIFI-5780 Add pre and post statements to ExecuteSQL...

2018-11-07 Thread yjhyjhyjh0
Github user yjhyjhyjh0 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3156#discussion_r231754034 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestExecuteSQLRecord.java

[GitHub] nifi pull request #3156: NIFI-5780 Add pre and post statements to ExecuteSQL...

2018-11-07 Thread yjhyjhyjh0
Github user yjhyjhyjh0 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3156#discussion_r231753838 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractExecuteSQL.java

[GitHub] nifi pull request #3156: NIFI-5780 Add pre and post statements to ExecuteSQL...

2018-11-09 Thread yjhyjhyjh0
Github user yjhyjhyjh0 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3156#discussion_r232293044 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractExecuteSQL.java

[GitHub] nifi pull request #3156: NIFI-5780 Add pre and post statements to ExecuteSQL...

2018-11-09 Thread yjhyjhyjh0
Github user yjhyjhyjh0 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3156#discussion_r232292846 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractExecuteSQL.java

[GitHub] nifi issue #3156: NIFI-5780 Add pre and post statements to ExecuteSQL and Ex...

2018-11-09 Thread yjhyjhyjh0
Github user yjhyjhyjh0 commented on the issue: https://github.com/apache/nifi/pull/3156 Thanks for the suggestion. Update description to be more precise in ExecuteSQL, ExecuteSQLRecord, SelectHiveQL. Squash the this commit. ---

[GitHub] nifi pull request #3156: NIFI-5780 Add pre and post statements to ExecuteSQL...

2018-11-07 Thread yjhyjhyjh0
GitHub user yjhyjhyjh0 opened a pull request: https://github.com/apache/nifi/pull/3156 NIFI-5780 Add pre and post statements to ExecuteSQL and ExecuteSQLRecord Add pre, post query property to AbstractExecuteSQL. Most of implementation comes from SelectHiveQL. Add unit test

[GitHub] nifi issue #3107: NIFI-5744: Put exception message to attribute while Execut...

2018-11-16 Thread yjhyjhyjh0
Github user yjhyjhyjh0 commented on the issue: https://github.com/apache/nifi/pull/3107 Thanks for the suggestion. Rebase against master, solve conflicts and squash into single commit. ---

[GitHub] nifi pull request #3107: NIFI-5744: Put exception message to attribute while...

2018-11-17 Thread yjhyjhyjh0
Github user yjhyjhyjh0 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3107#discussion_r234407245 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestExecuteSQLRecord.java