[GitHub] [nifi] NissimShiman commented on a change in pull request #4130: NIFI-6235 - Prioritizing standard content war loading order

2020-10-15 Thread GitBox 


NissimShiman commented on a change in pull request #4130:
URL: https://github.com/apache/nifi/pull/4130#discussion_r505770555



##
File path: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/web/server/JettyServer.java
##
@@ -237,26 +236,25 @@ private Handler loadInitialWars(final Set 
bundles) {
 webContentViewerWar = war;
 } else if (war.getName().toLowerCase().startsWith("nifi-web")) {
 webUiWar = war;
+} else if 
(war.getName().toLowerCase().startsWith("nifi-standard-content")) {

Review comment:
   @mcgilman At this time, there is no media nar in the nifi distribution 
so I think that is the cause for the disconnect here...
   The last version it existed was 1.9.2. 
   
   @anaylor See https://issues.apache.org/jira/browse/NIFI-6604 Reduce the size 
of the generated assemblies (and 
https://issues.apache.org/jira/browse/NIFI-7931).
   
   But, yes, this will need to be accounted for as well... 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [nifi] NissimShiman commented on a change in pull request #4130: NIFI-6235 - Prioritizing standard content war loading order

2020-10-15 Thread GitBox 


NissimShiman commented on a change in pull request #4130:
URL: https://github.com/apache/nifi/pull/4130#discussion_r505770555



##
File path: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/web/server/JettyServer.java
##
@@ -237,26 +236,25 @@ private Handler loadInitialWars(final Set 
bundles) {
 webContentViewerWar = war;
 } else if (war.getName().toLowerCase().startsWith("nifi-web")) {
 webUiWar = war;
+} else if 
(war.getName().toLowerCase().startsWith("nifi-standard-content")) {

Review comment:
   @mcgilman At this time, there is no media nar in the nifi distribution 
so I think that is the cause for the disconnect here...
   The last version it existed was 1.9.2. 
   
   This is likely a bug so I opened 
https://issues.apache.org/jira/browse/NIFI-7931 for it.
   
   But, yes, this will need to be accounted for as well... 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org