[GitHub] [nifi] alopresto commented on pull request #4289: NIFI-7467 Refactored S2S peer selection logic

2020-06-04 Thread GitBox


alopresto commented on pull request #4289:
URL: https://github.com/apache/nifi/pull/4289#issuecomment-639223794


   Thanks Mark. I replied to the comments and integrated most of what you had 
suggested (the exception being the complete removal of the marker interface). 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] alopresto commented on pull request #4289: NIFI-7467 Refactored S2S peer selection logic

2020-05-21 Thread GitBox


alopresto commented on pull request #4289:
URL: https://github.com/apache/nifi/pull/4289#issuecomment-632366081


   I ran the GitHub Actions checks twice. The problem is with downloading a 
dependency for another module from a remote repository. Running the build on my 
local machine completes successfully. 
   
   ```
   [ERROR] Exception calling reference $projectsSortedByOrganization at 
META-INF/DEPENDENCIES.vm[line 34, column 33]
   [ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-remote-resources-plugin:1.7.0:process 
(process-resource-bundles) on project nifi-hive_1_1-processors: Execution 
process-resource-bundles of goal 
org.apache.maven.plugins:maven-remote-resources-plugin:1.7.0:process failed: 
Error resolving project artifact: Failure to transfer 
eigenbase:eigenbase-properties:pom:1.1.4 from 
https://repository.apache.org/content/repositories/releases was cached in the 
local repository, resolution will not be reattempted until the update interval 
of apache-repo has elapsed or updates are forced. Original error: Could not 
transfer artifact eigenbase:eigenbase-properties:pom:1.1.4 from/to apache-repo 
(https://repository.apache.org/content/repositories/releases): Transfer failed 
for 
https://repository.apache.org/content/repositories/releases/eigenbase/eigenbase-properties/1.1.4/eigenbase-properties-1.1.4.pom
 503 Service Unavailable for project eigenbase:eigenbase-properties:jar:1.1.4 
-> [Help 1]
   [ERROR] 
   [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
   [ERROR] Re-run Maven using the -X switch to enable full debug logging.
   [ERROR] 
   [ERROR] For more information about the errors and possible solutions, please 
read the following articles:
   [ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
   [ERROR] 
   [ERROR] After correcting the problems, you can resume the build with the 
command
   [ERROR]   mvn  -rf :nifi-hive_1_1-processors
   ##[error]Process completed with exit code 1.
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [nifi] alopresto commented on pull request #4289: NIFI-7467 Refactored S2S peer selection logic

2020-05-21 Thread GitBox


alopresto commented on pull request #4289:
URL: https://github.com/apache/nifi/pull/4289#issuecomment-632311149


   @thenatog I believe this PR resolves the error you and I both got during 
testing of PR 4263 where if a secure cluster had multiple nodes running on the 
same physical/virtual server using different ports, Site-to-site would fail to 
retrieve the peers because the certificate SAN did not match. What was 
happening was the request for S2S details was being replicated to all nodes, 
and whichever answered first used its ports, but often did not match the 
specific node which was queried. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org