joewitt commented on a change in pull request #3971: NIFI-6997: consumeAMQP closing connection when queue not found URL: https://github.com/apache/nifi/pull/3971#discussion_r365281042
########## File path: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/ConsumeAMQP.java ########## @@ -194,6 +194,13 @@ protected synchronized AMQPConsumer createAMQPWorker(final ProcessContext contex return amqpConsumer; } catch (final IOException ioe) { + try { + connection.close(); + getLogger().warn("Closed connection at port " + connection.getPort()); + } catch (final IOException ioeClose) { + throw new ProcessException("Failed to close connection at port " + connection.getPort()); Review comment: You're at this point because of an io exception that already occurred. Here you're closing a connection as good practice but the fact that it too might not go well isn't useful/not something you could do anything about. As such I'd closeQuietly meaning do not rethrow the exception and do not log even at a warn level. If you want you could keep the logging part and only as a debug thing. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services