[GitHub] [nifi] kotarot commented on pull request #4589: NIFI-7728: FetchS3Object sends a flowfile to failure relationship if the given bucket or object key is empty

2020-10-09 Thread GitBox
kotarot commented on pull request #4589: URL: https://github.com/apache/nifi/pull/4589#issuecomment-706068741 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [nifi] kotarot commented on pull request #4589: NIFI-7728: FetchS3Object sends a flowfile to failure relationship if the given bucket or object key is empty

2020-10-09 Thread GitBox
kotarot commented on pull request #4589: URL: https://github.com/apache/nifi/pull/4589#issuecomment-706092966 Yes I definitely agree with using flow files attributes is typical cases. I'll try to think over and fix the code based on the ideas.

[GitHub] [nifi] kotarot commented on pull request #4589: NIFI-7728: FetchS3Object sends a flowfile to failure relationship if the given bucket or object key is empty

2020-10-09 Thread GitBox
kotarot commented on pull request #4589: URL: https://github.com/apache/nifi/pull/4589#issuecomment-706073724 In case of the variable in the incoming flowfile attributes, yes, penalizing has no meanings. So like `failure.reason` idea makes sense to me.

[GitHub] [nifi] kotarot commented on pull request #4589: NIFI-7728: FetchS3Object sends a flowfile to failure relationship if the given bucket or object key is empty

2020-10-09 Thread GitBox
kotarot commented on pull request #4589: URL: https://github.com/apache/nifi/pull/4589#issuecomment-706068741 Thank you for looking at this change. Assume that the "Bucket" property of FetchS3Object is set to "${bucket}" and "Object Key" property is set to "${key}". If we set