[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-21 Thread GitBox
adamdebreceni commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r509320738 ## File path: libminifi/include/utils/Id.h ## @@ -65,10 +67,11 @@ class Identifier { bool operator!=(const Identifier& other) const;

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-21 Thread GitBox
adamdebreceni commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r509166507 ## File path: libminifi/include/utils/Id.h ## @@ -65,10 +67,11 @@ class Identifier { bool operator!=(const Identifier& other) const;

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-21 Thread GitBox
adamdebreceni commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r509027132 ## File path: libminifi/include/utils/Id.h ## @@ -65,10 +67,11 @@ class Identifier { bool operator!=(const Identifier& other) const;

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-20 Thread GitBox
adamdebreceni commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r508274717 ## File path: libminifi/include/utils/Id.h ## @@ -65,10 +67,11 @@ class Identifier { bool operator!=(const Identifier& other) const;

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-20 Thread GitBox
adamdebreceni commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r508247054 ## File path: libminifi/src/core/ProcessSession.cpp ## @@ -66,10 +66,12 @@ ProcessSession::~ProcessSession() { } void

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-19 Thread GitBox
adamdebreceni commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507761664 ## File path: libminifi/include/utils/Id.h ## @@ -65,10 +67,11 @@ class Identifier { bool operator!=(const Identifier& other) const;

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-19 Thread GitBox
adamdebreceni commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507766370 ## File path: libminifi/src/core/ProcessSession.cpp ## @@ -66,10 +66,12 @@ ProcessSession::~ProcessSession() { } void

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-19 Thread GitBox
adamdebreceni commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507760547 ## File path: libminifi/include/utils/SmallString.h ## @@ -0,0 +1,86 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-19 Thread GitBox
adamdebreceni commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507761664 ## File path: libminifi/include/utils/Id.h ## @@ -65,10 +67,11 @@ class Identifier { bool operator!=(const Identifier& other) const;

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-19 Thread GitBox
adamdebreceni commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507760547 ## File path: libminifi/include/utils/SmallString.h ## @@ -0,0 +1,86 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-19 Thread GitBox
adamdebreceni commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507758324 ## File path: libminifi/include/utils/Id.h ## @@ -65,10 +67,11 @@ class Identifier { bool operator!=(const Identifier& other) const;

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-19 Thread GitBox
adamdebreceni commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507752703 ## File path: libminifi/include/utils/SmallString.h ## @@ -0,0 +1,86 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-19 Thread GitBox
adamdebreceni commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507746211 ## File path: libminifi/include/utils/SmallString.h ## @@ -0,0 +1,86 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-19 Thread GitBox
adamdebreceni commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507746211 ## File path: libminifi/include/utils/SmallString.h ## @@ -0,0 +1,86 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #926: MINIFICPP-1387 - Speed up Identifier to string conversion

2020-10-19 Thread GitBox
adamdebreceni commented on a change in pull request #926: URL: https://github.com/apache/nifi-minifi-cpp/pull/926#discussion_r507745780 ## File path: libminifi/include/utils/Id.h ## @@ -65,10 +67,11 @@ class Identifier { bool operator!=(const Identifier& other) const;