[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #826: MINIFICPP-1274 - Commit delete operation before shutdown

2020-06-29 Thread GitBox
arpadboda commented on a change in pull request #826: URL: https://github.com/apache/nifi-minifi-cpp/pull/826#discussion_r447271999 ## File path: libminifi/test/rocksdb-tests/RepoTests.cpp ## @@ -326,3 +326,82 @@ TEST_CASE("Test FlowFile Restore", "[TestFFR6]") {

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #826: MINIFICPP-1274 - Commit delete operation before shutdown

2020-06-29 Thread GitBox
arpadboda commented on a change in pull request #826: URL: https://github.com/apache/nifi-minifi-cpp/pull/826#discussion_r447271999 ## File path: libminifi/test/rocksdb-tests/RepoTests.cpp ## @@ -326,3 +326,82 @@ TEST_CASE("Test FlowFile Restore", "[TestFFR6]") {

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #826: MINIFICPP-1274 - Commit delete operation before shutdown

2020-06-29 Thread GitBox
arpadboda commented on a change in pull request #826: URL: https://github.com/apache/nifi-minifi-cpp/pull/826#discussion_r447269648 ## File path: libminifi/test/rocksdb-tests/RepoTests.cpp ## @@ -326,3 +326,82 @@ TEST_CASE("Test FlowFile Restore", "[TestFFR6]") {

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #826: MINIFICPP-1274 - Commit delete operation before shutdown

2020-06-29 Thread GitBox
arpadboda commented on a change in pull request #826: URL: https://github.com/apache/nifi-minifi-cpp/pull/826#discussion_r447269150 ## File path: libminifi/src/FlowFileRecord.cpp ## @@ -366,7 +366,7 @@ bool FlowFileRecord::DeSerialize(const uint8_t *buffer, const int