[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #820: MINIFICPP-1183 - Cleanup C2 Update tests

2020-07-10 Thread GitBox
fgerlits commented on a change in pull request #820: URL: https://github.com/apache/nifi-minifi-cpp/pull/820#discussion_r452679078 ## File path: extensions/http-curl/tests/HttpGetIntegrationTest.cpp ## @@ -17,46 +17,31 @@ */ #define CURLOPT_SSL_VERIFYPEER_DISABLE 1 -#inclu

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #820: MINIFICPP-1183 - Cleanup C2 Update tests

2020-06-29 Thread GitBox
fgerlits commented on a change in pull request #820: URL: https://github.com/apache/nifi-minifi-cpp/pull/820#discussion_r446859252 ## File path: extensions/http-curl/tests/C2UpdateTest.cpp ## @@ -16,174 +16,24 @@ * limitations under the License. */ -#include #undef NDEB

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #820: MINIFICPP-1183 - Cleanup C2 Update tests

2020-06-23 Thread GitBox
fgerlits commented on a change in pull request #820: URL: https://github.com/apache/nifi-minifi-cpp/pull/820#discussion_r444037795 ## File path: extensions/http-curl/tests/C2DescribeCoreComponentStateTest.cpp ## @@ -58,16 +57,11 @@ class VerifyC2DescribeCoreComponentState : pub