[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

szaszm commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r439450357 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -335,170 +563,210 @@ bool TailFile::storeState(const std::shared_ptr&

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

szaszm commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r439449272 ## File path: libminifi/test/unit/StringUtilsTests.cpp ## @@ -338,3 +338,30 @@ TEST_CASE("TestStringUtils::testJoinPackNegative", "[test join_pack

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

szaszm commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r439449272 ## File path: libminifi/test/unit/StringUtilsTests.cpp ## @@ -338,3 +338,30 @@ TEST_CASE("TestStringUtils::testJoinPackNegative", "[test join_pack

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

szaszm commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r439020454 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -40,60 +35,283 @@ #include #include +#include "io/CRCStream.h"

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

szaszm commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r438997857 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -204,52 +418,78 @@ void TailFile::parseStateFileLine(char *buf) { }

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

szaszm commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r438223344 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -403,102 +435,136 @@ void TailFile::onTrigger(const std::shared_ptr , c

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

szaszm commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r436792573 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -403,102 +435,136 @@ void TailFile::onTrigger(const std::shared_ptr , c

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

szaszm commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r436606464 ## File path: libminifi/src/core/ProcessSession.cpp ## @@ -469,6 +470,14 @@ void ProcessSession::import(std::string source, const std::shared_ptr>

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

szaszm commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r436597137 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -403,102 +435,136 @@ void TailFile::onTrigger(const std::shared_ptr , c

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

szaszm commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r433821309 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -204,52 +230,65 @@ void TailFile::parseStateFileLine(char *buf) { }

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

szaszm commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r432671663 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -58,42 +47,108 @@ #define S_ISDIR(mode) (((mode) & S_IFMT) == S_IFDIR)