[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #816: MINIFICPP-1261 - Refactor non-trivial usages of ScopeGuard class

szaszm commented on a change in pull request #816: URL: https://github.com/apache/nifi-minifi-cpp/pull/816#discussion_r446966421 ## File path: libminifi/include/utils/ScopeGuard.h ## @@ -33,10 +33,6 @@ namespace utils { struct ScopeGuard : ::gsl::final_action> { using

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #816: MINIFICPP-1261 - Refactor non-trivial usages of ScopeGuard class

szaszm commented on a change in pull request #816: URL: https://github.com/apache/nifi-minifi-cpp/pull/816#discussion_r446965308 ## File path: libminifi/include/io/tls/TLSSocket.h ## @@ -80,10 +77,13 @@ class TLSContext : public SocketContext { int16_t initialize(bool

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #816: MINIFICPP-1261 - Refactor non-trivial usages of ScopeGuard class

szaszm commented on a change in pull request #816: URL: https://github.com/apache/nifi-minifi-cpp/pull/816#discussion_r446315793 ## File path: libminifi/include/io/tls/TLSSocket.h ## @@ -80,10 +77,13 @@ class TLSContext : public SocketContext { int16_t initialize(bool