[GitHub] nifi-minifi-cpp issue #293: MINIFICPP-445 Added escape/unescape CSV expressi...

2018-04-09 Thread apiri 
Github user apiri commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/293
  
Code, tests, and build all look good. Thanks for adding these! Will merge.

@phrocker I adjusted those lines that were affected by autoformat with no 
functional changes


---

[GitHub] nifi-minifi-cpp issue #293: MINIFICPP-445 Added escape/unescape CSV expressi...

2018-04-05 Thread achristianson 
Github user achristianson commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/293
  
@apiri sorry about that. Fixed.


---

[GitHub] nifi-minifi-cpp issue #293: MINIFICPP-445 Added escape/unescape CSV expressi...

2018-04-04 Thread apiri 
Github user apiri commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/293
  
Looks like all envs in Travis are failing with:

```

---

Decode XML


---


/Users/travis/build/apache/nifi-minifi-cpp/libminifi/test/expression-language-tests/ExpressionLanguageTests.cpp:1052


...




/Users/travis/build/apache/nifi-minifi-cpp/libminifi/test/expression-language-tests/ExpressionLanguageTests.cpp:1057:
 FAILED:

  REQUIRE( "Zero > One < \"two!\" & 'true'" == 
expr({flow_file_a}).asString() )

with expansion:

  "Zero > One < "two!" & 'true'"

  ==

  "Zero > One < two! & 'true'"

```


---