[GitHub] nifi-minifi-cpp issue #43: MINIFI-183 Implemented ListenHTTP
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/43 @achristianson had some other things that interrupted, but looks good. will get these squashed and merged. appreciate you working through all the iterations with us! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #43: MINIFI-183 Implemented ListenHTTP
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/43 Great, thanks for all the resources. If you are not aware, the community also has the TLS Toolkit that is super helpful as well: http://nifi.apache.org/docs/nifi-docs/html/administration-guide.html#tls-generation-toolkit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #43: MINIFI-183 Implemented ListenHTTP
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/43 @apiri Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #43: MINIFI-183 Implemented ListenHTTP
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/43 @apiri Sure thing. These cmds might help for part of your testing: ```sh dd if=/dev/urandom of=./testdat bs=1M count=1 ``` ```sh curl -vvv -X POST --data-binary @./testdat http://127.0.0.1:/contentListener ``` Here's a link with info to create test TLS certs: http://stackoverflow.com/questions/14267010/how-to-create-self-signed-ssl-certificate-for-test-purposes Here's the flow I was testing with: ```markdown Flow Controller: name: MiNiFi Flow Processors: # - name: GetFile # class: org.apache.nifi.processors.standard.GetFile # max concurrent tasks: 1 # scheduling strategy: TIMER_DRIVEN # scheduling period: 1 sec # penalization period: 30 sec # yield period: 1 sec # run duration nanos: 0 # auto-terminated relationships list: # Properties: # Input Directory: /tmp/getfile # Keep Source File: false # File Filter: ".*" - name: ListenHTTP class: org.apache.nifi.processors.standard.ListenHTTP max concurrent tasks: 16 scheduling strategy: TIMER_DRIVEN scheduling period: 1 sec penalization period: 30 sec yield period: 1 sec run duration nanos: 0 auto-terminated relationships list: Properties: Listening Port: # Authorized DN Pattern: /C=AU/ST=Some-State/O=Internet Widgits Pty Ltd/CN=localhost|/C=US/ST=Maryland/O=Internet Widgits Pty Ltd/CN=localhost # SSL Certificate: /home/ubuntu/workspace/build/server.pem # SSL Certificate Authority: /home/ubuntu/workspace/build/server.pem # SSL Verify Peer: yes # SSL Minimum Version: TLS1.2 HTTP Headers to receive as Attributes (Regex): X-Test2.* - name: LogAttribute class: org.apache.nifi.processors.standard.LogAttribute max concurrent tasks: 1 scheduling strategy: EVENT_DRIVEN scheduling period: 1 sec penalization period: 30 sec yield period: 1 sec run duration nanos: 0 auto-terminated relationships list: - name: PutFile class: org.apache.nifi.processors.standard.PutFile max concurrent tasks: 1 scheduling strategy: EVENT_DRIVEN scheduling period: 1 sec penalization period: 30 sec yield period: 1 sec run duration nanos: 0 auto-terminated relationships list: ["success", "failure"] Properties: Output Directory: /tmp/putfile Connections: # - name: TransferFiles # source name: GetFile # source relationship name: success # destination name: PutFile # max work queue size: 0 # max work queue data size: 1 MB # flowfile expiration: 60 sec - name: TransferHttpToLogAttribute source name: ListenHTTP source relationship name: success destination name: LogAttribute max work queue size: 0 max work queue data size: 1 MB flowfile expiration: 60 sec - name: LogAttributeToPutFile source name: LogAttribute source relationship name: success destination name: PutFile max work queue size: 0 max work queue data size: 1 MB flowfile expiration: 60 sec Remote Processing Groups: [] ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #43: MINIFI-183 Implemented ListenHTTP
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/43 @achristianson great, thanks. still working through testing functionality --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #43: MINIFI-183 Implemented ListenHTTP
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/43 @apiri Will do. Expecting to get an updated PR out here in a couple minutes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #43: MINIFI-183 Implemented ListenHTTP
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/43 @achristianson feel free to update the LICENSE when you have the opportunity if you are going to adjust the libxml items --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #43: MINIFI-183 Implemented ListenHTTP
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/43 We will need to update the LICENSE for the civetweb source inclusion. That does not appear to be present currently. My understanding is that we are not using any of the optional items in the build, so the following portion should be sufficient: https://github.com/civetweb/civetweb/blob/master/LICENSE.md#included-with-all-features Please clarify if my understanding is incorrect. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #43: MINIFI-183 Implemented ListenHTTP
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/43 @apiri @phrocker Addressed the comments, updated the code, and rebased. The biggest thing is cleanly setting up an ExternalProject system, but I think that's best addressed under the ticket @phrocker created. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #43: MINIFI-183 Implemented ListenHTTP
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/43 @phrocker Sounds good. I'll take a look at the rest and also fix this new merge conflict. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #43: MINIFI-183 Implemented ListenHTTP
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/43 Created MINIFI-213 to have the CMake 3rd party discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #43: MINIFI-183 Implemented ListenHTTP
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/43 @achristianson I thought I created a ticket to break these out...or maybe it was an E-mail, but I think that's something we could discuss. When I sent a message to @apiri earlier I said that the ExternalProject comment was mostly a desire and that this PR followed precedent and as such it's not a deal breaker, it's just a direction I would like to see things go. With that said, the operative word is suggestion and we can thus have a ticket to discuss this further. I'll create that ticket and we can discuss it there. TL;DR on my thoughts: having people build offline isn't a big deal because that likely wouldn't happen very frequently. In cases where it is anticipated, you would likely need to move code to said device, and in this case we could codify the download so that it's easy to stage. In my opinion, worrying about those types of systems also brings the worry about those which don't have OpenSSL or boost readily available. Since we don't package those and those certainly aren't standard fare on many lightweight distros, are we really breaking the mold to have ExternalProjects? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #43: MINIFI-183 Implemented ListenHTTP
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/43 @phrocker @apiri Thanks for the feedback. All makes sense, but had one question re: civet as an ExternalProject. I did it as a thirdparty/ dir mainly to be consistent with how the current thirdparty dependencies are handled, e.g. yaml and leveldb. If we're OK with breaking that consistency, and perhaps adding future tickets to extract out the current thirdparty projects, then I'll move forward with that. The only other concern regarding the ExternalProject is that it does make it harder to build offline or if the remote host goes down. We would probably want to add some build instructions for how and where to place the external code manually to cover these build-time use cases. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #43: MINIFI-183 Implemented ListenHTTP
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/43 If you happen to update try -Os ( don't feel like you need to in this PR ) https://issues.apache.org/jira/browse/MINIFI-197 is a corresponding ticket for it. I was going to do this and prune out warnings that weren't important. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi-minifi-cpp issue #43: MINIFI-183 Implemented ListenHTTP
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/43 great, thanks. will scope out shortly --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
