[GitHub] nifi issue #1022: NIFI-2774 changed the default ACK mode to CLIENT

2016-09-20 Thread olegz
Github user olegz commented on the issue:

https://github.com/apache/nifi/pull/1022
  
Closing this PR because of the complexity with fixing merge conflicts due 
to changes that came in with #1027. Will submit new one shortly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1022: NIFI-2774 changed the default ACK mode to CLIENT

2016-09-19 Thread olegz
Github user olegz commented on the issue:

https://github.com/apache/nifi/pull/1022
  
@ckmcd PR comments addressed with few minor improvements.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1022: NIFI-2774 changed the default ACK mode to CLIENT

2016-09-15 Thread joewitt
Github user joewitt commented on the issue:

https://github.com/apache/nifi/pull/1022
  

Other.commit
Nifi.commit

This means at most once.  Loss is possible but dupes are not.


Nifi.commit
Other.commit

This means at least once.  Dupes are possible but loss is not.

Default mode should always be at least once.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---