[GitHub] nifi issue #1047: [NIFI-2812] Fix creating NiFi RPM
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/1047 @trixpan please make sure that commit log entries indicate/start with the JIRA. This would be in this case NIFI-2812 This closes #1047. Fixes rpm includes/excludes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1047: [NIFI-2812] Fix creating NiFi RPM
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1047 Notes: * created RPM. * did diff between RPM with RPM profile and TGZ without the RPM profile * installed from the RPM. started NiFi. Connected to it. LGTM, will merge later today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1047: [NIFI-2812] Fix creating NiFi RPM
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1047 @fidget83 - thanks for the contribution. @joaohf - muito obrigadopelo feedback. :wink: Notes: created RPM. did diff between LGTM, will merge later today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1047: [NIFI-2812] Fix creating NiFi RPM
Github user joaohf commented on the issue: https://github.com/apache/nifi/pull/1047 Hi, I've tested this and the output files from rpm package is the same of tar.gz. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1047: [NIFI-2812] Fix creating NiFi RPM
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1047 @fidget83 the JARs should not be unified, instead only the appropriate JARs should go into each directory. Would you mind amending your commit? Kind regards --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1047: [NIFI-2812] Fix creating NiFi RPM
Github user fidget83 commented on the issue: https://github.com/apache/nifi/pull/1047 @trixpan, I just unified the list of jars in rpm and in created .tar.gz.file. I didn't analyze necessary of each jar, but with this set nifi works :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1047: [NIFI-2812] Fix creating NiFi RPM
Github user fidget83 commented on the issue: https://github.com/apache/nifi/pull/1047 @trixpan, done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1047: [NIFI-2812] Fix creating NiFi RPM
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1047 @fidget83 would you mind amending the commit message and adding reference to the JIRA you mentioned above? You can do so by running `git commit --amend` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] nifi issue #1047: [NIFI-2812] Fix creating NiFi RPM
Github user fidget83 commented on the issue: https://github.com/apache/nifi/pull/1047 @bbende, Jira issue is https://issues.apache.org/jira/browse/NIFI-2812 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---