[GitHub] nifi issue #1288: NIFI-3140: Restored optional type handling in FetchElastic...

2016-12-02 Thread JPercivall
Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/1288
  
+1

Visually verified code and did a contrib-check build. In a standalone 
instance I ran FetchElasticsearchHTTP with and without a "type" hitting a 
secure 2.3 ES instance. Also used EL for the URL to verify NIFI-3095. 
Everything worked as expected. Thanks @mattyb149 I will merge it in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1288: NIFI-3140: Restored optional type handling in FetchElastic...

2016-12-01 Thread mattyb149
Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/1288
  
@gresockj Do you mind taking a look at this? I want to make sure I didn't 
miss something in the API or any potential differences between versions. For 
the Http processors I'd like to keep the least-common-denominator principle, 
since they are the alternative to the other Transport-based processors that 
require a particular (major) version.  Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---