[GitHub] nifi issue #1335: NIFI-3213: ListFile - Do not skip obviously old files.

[ijokarumawak]

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/1335
  
@trixpan Thank you for merging! closed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1335: NIFI-3213: ListFile - Do not skip obviously old files.

[trixpan]

Github user trixpan commented on the issue:

https://github.com/apache/nifi/pull/1335
  
@ijokarumawak merged. However I forgot to add reference to the PR in the 
commit message. Would you mind closing it manually ?

I thank you in advance


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1335: NIFI-3213: ListFile - Do not skip obviously old files.

[ijokarumawak]

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/1335
  
@trixpan Since the failing test has more Thread.sleep calls than before, 
the meaning of variables such as `age1` or `age2` became fragile at the later 
part of the test. I added another commit to fix the test case. Also, rebased it 
with the latest master just in case.

Thanks again for caching this test issue. Please review the test again, and 
let me know if you want me to squash commits.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1335: NIFI-3213: ListFile - Do not skip obviously old files.

[ijokarumawak]

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/1335
  
@trixpan Thanks for reviewing and catching the unit test failure. Yes, I'd 
like to look at it closer. I will update the PR accordingly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1335: NIFI-3213: ListFile - Do not skip obviously old files.

[trixpan]

Github user trixpan commented on the issue:

https://github.com/apache/nifi/pull/1335
  
@ijokarumawak my bad. I was just running a extra set of compilations and I 
noticed that under certain conditions there seems to be a race condition 
affecting 

```
Tests run: 12, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 5.66 sec 
<<< FAILURE! - in org.apache.nifi.processors.standard.TestListFile
testFilterAge(org.apache.nifi.processors.standard.TestListFile)  Time 
elapsed: 1.212 sec  <<< FAILURE!
org.junit.ComparisonFailure: expected: but was:
at org.junit.Assert.assertEquals(Assert.java:115)
at org.junit.Assert.assertEquals(Assert.java:144)
at 
org.apache.nifi.processors.standard.TestListFile.testFilterAge(TestListFile.java:223)

```

Do you want to have a look at it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1335: NIFI-3213: ListFile - Do not skip obviously old files.

[trixpan]

Github user trixpan commented on the issue:

https://github.com/apache/nifi/pull/1335
  
LGTM merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1335: NIFI-3213: ListFile - Do not skip obviously old files.

[trixpan]

Github user trixpan commented on the issue:

https://github.com/apache/nifi/pull/1335
  
@ijokarumawak reviewing it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---