[GitHub] nifi issue #1450: NIFI-3339b Add getDataSource() to DBCPService, second vers...

2017-03-08 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1450 Agreed, sounds good thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] nifi issue #1450: NIFI-3339b Add getDataSource() to DBCPService, second vers...

2017-03-08 Thread ToivoAdams
Github user ToivoAdams commented on the issue: https://github.com/apache/nifi/pull/1450 @ijokarumawak @mattyb149 We could add example how to use String JDBC to wiki. No need to be part of NiFi codebase. --- If your project is set up for it, you can reply to this email

[GitHub] nifi issue #1450: NIFI-3339b Add getDataSource() to DBCPService, second vers...

2017-02-06 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1450 My use case is a third-party library that takes the same information you might put into a DBCPControllerService, either in the URL and/or the username/password, etc. I was hoping to avoid trying to

[GitHub] nifi issue #1450: NIFI-3339b Add getDataSource() to DBCPService, second vers...

2017-02-06 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1450 @mattyb149 Thanks for sharing your use case. That's interesting. Why does your processor need DBCPService's URL? For provenance? If so, I'd prefer creating another interface looks like below:

[GitHub] nifi issue #1450: NIFI-3339b Add getDataSource() to DBCPService, second vers...

2017-02-06 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1450 Koji has a good point about managing the actual DataSource instance internally, if your use case can be accomplished without needing access to this object, then I would tend to agree that we

[GitHub] nifi issue #1450: NIFI-3339b Add getDataSource() to DBCPService, second vers...

2017-02-05 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1450 Hi @ToivoAdams I think we should think who should manage the DataSource instance. For me, that should be NiFi DBCPService, because it provides control via NiFi UI or REST API to users.

[GitHub] nifi issue #1450: NIFI-3339b Add getDataSource() to DBCPService, second vers...

2017-02-04 Thread ToivoAdams
Github user ToivoAdams commented on the issue: https://github.com/apache/nifi/pull/1450 Hi @ijokarumawak I have something like this already in use. This was meant to be temporary solution until “right” implementation is available. Now I am little bit confused.

[GitHub] nifi issue #1450: NIFI-3339b Add getDataSource() to DBCPService, second vers...

2017-01-31 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/1450 Hi @ToivoAdams , thank you for your contribution. I reviewed it and saw the sample code using Spring JDBC template. Then I felt that this can be done outside of DBCPService. Adding getDataSource