[GitHub] nifi issue #1649: NIFI-3318: Support for websocket multiplexing to all exist...

2017-04-20 Thread ijokarumawak
Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/1649
  
@jdye64 Thanks for updating the doc, all LGTM! Merged into master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1649: NIFI-3318: Support for websocket multiplexing to all exist...

2017-04-20 Thread ijokarumawak
Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/1649
  
@jdye64 Test with multiple WebSocket clients to receive messages sent from 
a NiFi at the same time. Works great, thanks for adding this! I'm +1 with the 
functional change, however, I'd like this feature to be documented so that 
users will be able to configure PutWebSocket as they want.

Would you update Processor websocket-session-id property docs something 
like this? "A NiFi Expression to retrieve the session id. If not specified, a 
message will be sent to all connected WebSocket peer for the WebSocket 
controller service endpoint."

Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1649: NIFI-3318: Support for websocket multiplexing to all exist...

2017-04-20 Thread ijokarumawak
Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/1649
  
Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---